[Okular-devel] [Bug 311601] Crash/Assert when paging down to end of document

2012-12-16 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=311601

Fabio D'Urso  changed:

   What|Removed |Added

 CC||j...@holodeck1.com

--- Comment #2 from Fabio D'Urso  ---
*** Bug 311803 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=311803

Fabio D'Urso  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #5 from Fabio D'Urso  ---
No problem. Thank you for reporting

*** This bug has been marked as a duplicate of bug 311601 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Jure Repinc
https://bugs.kde.org/show_bug.cgi?id=311803

--- Comment #4 from Jure Repinc  ---
Ah yes, all fine after a compile from git, looks like I was just a few commits
befor the fix. Sorry for the noise.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=311803

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Albert Astals Cid  ---
Waiting for info

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=311803

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #2 from Fabio D'Urso  ---
It works fine here. What is your git HEAD? Can you check if you have commit
5b8d51d66e877a33bb30ebb76322e678a81808b4?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Jure Repinc
https://bugs.kde.org/show_bug.cgi?id=311803

--- Comment #1 from Jure Repinc  ---
Created attachment 75873
  --> https://bugs.kde.org/attachment.cgi?id=75873&action=edit
crashy.pdf

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311803] New: Okular crashes when I scroll to third page of PDF document

2012-12-16 Thread Jure Repinc
https://bugs.kde.org/show_bug.cgi?id=311803

Bug ID: 311803
  Severity: crash
   Version: unspecified
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: Okular crashes when I scroll to third page of PDF
document
Classification: Unclassified
OS: Linux
  Reporter: j...@holodeck1.com
  Hardware: Compiled Sources
Status: CONFIRMED
 Component: general
   Product: okular

Application: okular (0.15.90)
KDE Platform Version: 4.9.90 (Compiled from sources)
Qt Version: 4.8.4
Operating System: Linux 3.7.0 x86_64
Distribution: "NAME=Gentoo"

-- Information about the crash:
- What I was doing when the application crashed:
I downloaded this PDF, opened it and started scrolling. When I get to the third
page Koular just crashes.

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[KCrash Handler]
#6  0x003d1dab0933 in isNull (this=0x64006e0065007f) at tools/qrect.h:232
#7  QRect::operator& (this=0x7fff34df00b0, r=...) at tools/qrect.cpp:1127
#8  0x7fee5da66c17 in intersect (r=..., this=0x7fff34df00b0) at
/usr/include/qt4/QtCore/qrect.h:478
#9  slotRequestPreloadPixmap (i=0x64006e0065006b, expandedViewportRect=...,
requestedPixmaps=requestedPixmaps@entry=0x7fff34df0060) at
/var/tmp/portage/kde-base/okular-/work/okular-/ui/pageview.cpp:4019
#10 0x7fee5da67ba8 in PageView::slotRequestVisiblePixmaps (this=, newValue=) at
/var/tmp/portage/kde-base/okular-/work/okular-/ui/pageview.cpp:4195
#11 0x7fee5da6e5f5 in qt_static_metacall (_a=,
_id=, _o=, _c=) at
/var/tmp/portage/kde-base/okular-/work/okular-_build/pageview.moc:172
#12 PageView::qt_static_metacall (_o=, _c=,
_id=, _a=) at
/var/tmp/portage/kde-base/okular-/work/okular-_build/pageview.moc:149
#13 0x003d1db9351f in QMetaObject::activate (sender=0x2071470, m=, local_signal_index=, argv=0x7fff34df0300) at
kernel/qobject.cpp:3539
#14 0x003d1fa3406e in QAbstractSlider::valueChanged (this=,
_t1=3490) at .moc/release-shared/moc_qabstractslider.cpp:196
#15 0x7fee5da5ddf0 in PageView::slotScrollDown (this=0x207cc20,
singleStep=singleStep@entry=false) at
/var/tmp/portage/kde-base/okular-/work/okular-/ui/pageview.cpp:4551
#16 0x7fee5da6e79d in qt_static_metacall (_a=,
_id=, _o=, _c=) at
/var/tmp/portage/kde-base/okular-/work/okular-_build/pageview.moc:199
#17 PageView::qt_static_metacall (_o=, _c=,
_id=, _a=) at
/var/tmp/portage/kde-base/okular-/work/okular-_build/pageview.moc:149
#18 0x003d1db9351f in QMetaObject::activate (sender=0x212c940, m=, local_signal_index=, argv=0x7fff34df04c0) at
kernel/qobject.cpp:3539
#19 0x003d1f3d5af2 in QAction::triggered (this=this@entry=0x212c940,
_t1=false) at .moc/release-shared/moc_qaction.cpp:277
#20 0x003d1f3d5cb8 in QAction::activate (this=0x212c940,
event=event@entry=QAction::Trigger) at kernel/qaction.cpp:1257
#21 0x003d1f3d5dff in QAction::event (this=, e=) at kernel/qaction.cpp:1183
#22 0x003fa6179a77 in KAction::event (this=,
event=0x7fff34df0a70) at
/var/tmp/portage/kde-base/kdelibs-/work/kdelibs-/kdeui/actions/kaction.cpp:131
#23 0x003d1f3dbe8c in QApplicationPrivate::notify_helper
(this=this@entry=0x1c74b60, receiver=receiver@entry=0x212c940,
e=e@entry=0x7fff34df0a70) at kernel/qapplication.cpp:4562
#24 0x003d1f3e02f6 in QApplication::notify (this=0x7fff34df2140,
receiver=0x212c940, e=0x7fff34df0a70) at kernel/qapplication.cpp:3944
#25 0x003fa6254628 in KApplication::notify (this=0x7fff34df2140,
receiver=0x212c940, event=0x7fff34df0a70) at
/var/tmp/portage/kde-base/kdelibs-/work/kdelibs-/kdeui/kernel/kapplication.cpp:311
#26 0x003d1db7dd4d in QCoreApplication::notifyInternal
(this=0x7fff34df2140, receiver=0x212c940, event=0x7fff34df0a70) at
kernel/qcoreapplication.cpp:946
#27 0x003d1f40ced0 in sendEvent (event=0x7fff34df0a70, receiver=) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:231
#28 QShortcutMap::dispatchEvent (this=this@entry=0x1c74c80,
e=e@entry=0x7fff34df1060) at kernel/qshortcutmap.cpp:884
#29 0x003d1f40e465 in QShortcutMap::tryShortcutEvent (this=0x1c74c80,
o=, e=0x7fff34df1060) at kernel/qshortcutmap.cpp:364
#30 0x003d1f3e1f37 in QApplication::notify (this=0x7fff34df2140,
receiver=0x207cc20, e=0x7fff34df1060) at kernel/qapplication.cpp:3986
#31 0x003fa6254628 in KApplication::notify (this=0x7fff34df2140,
receiver=0x207cc20, event=0x7fff34df1060) at
/var/tmp/portage/kde-base/kdelibs-/work/kdelibs-/kdeui/kernel/kapplication.cpp:311
#32 0x003d1db7dd4d in QCoreApplication::notifyInternal
(this=0x7fff34df2140, receiver=0x207cc20, event=0x7fff34df1060) at
kernel/qcoreapplication.cpp:946
#33 0x003d1f478cd3 in QKeyMapper::sendKeyEvent
(keyWidget=keyWidget@entry=0x207cc20, grab=

[Okular-devel] [Bug 310572] Inaccessible yellow highlighting annotation because of wrongly calculated boundary

2012-12-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=310572

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/okul |http://commits.kde.org/okul
   |ar/1ef6929344a423a837aa9fff |ar/55c413332e709750305e1eed
   |56524706220def56|e1ef3b81e433d225

--- Comment #3 from Albert Astals Cid  ---
Git commit 55c413332e709750305e1eede1ef3b81e433d225 by Albert Astals Cid.
Committed on 16/12/2012 at 20:48.
Pushed by aacid into branch 'KDE/4.10'.

Don't ignore mouse movements on the annotator when not on the locked item

REVIEW: 107726
(cherry picked from commit 1ef6929344a423a837aa9fff56524706220def56)

M  +13   -14   ui/pageviewannotator.cpp

http://commits.kde.org/okular/55c413332e709750305e1eede1ef3b81e433d225

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 310572] Inaccessible yellow highlighting annotation because of wrongly calculated boundary

2012-12-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=310572

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
   Version Fixed In||4.10.0

--- Comment #2 from Albert Astals Cid  ---
Fixed the creation, if you feel that the reparation of existing ones it's
important please open a new bug, but take into account that's qiute of a corner
case so it won't really be one of the topmost things we will be working since
there's lots of things to work on and limited manpower.

Thanks for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 310572] Inaccessible yellow highlighting annotation because of wrongly calculated boundary

2012-12-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=310572

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/1ef6929344a423a837aa9fff
   ||56524706220def56

--- Comment #1 from Albert Astals Cid  ---
Git commit 1ef6929344a423a837aa9fff56524706220def56 by Albert Astals Cid.
Committed on 16/12/2012 at 20:48.
Pushed by aacid into branch 'master'.

Don't ignore mouse movements on the annotator when not on the locked item

REVIEW: 107726

M  +13   -14   ui/pageviewannotator.cpp

http://commits.kde.org/okular/1ef6929344a423a837aa9fff56524706220def56

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request: Don't ignore mouse movements on the annotator when not on the locked item

2012-12-16 Thread Fabio D'Urso

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107726/#review23562
---

Ship it!


Ship It!

- Fabio D'Urso


On Dec. 14, 2012, 6:39 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107726/
> ---
> 
> (Updated Dec. 14, 2012, 6:39 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> Since we lock the item in the annotator there is no need to ignore the move 
> movements when we are out of the annotator. I've tested the annotations and
> they all work "fine" with the limitation of the annotation only affects the 
> page that the annotation was started (which is already a limitation) and the 
> problem of the "Note" that you can really put "outside" of the page.
> 
> If we agree this is fine i'll "fix" the "Note" so you can not drag it outside 
> the page.
> 
> And maybe we can "improve" the other annotations not to give the impression 
> that the annotation will go over the other pages too.
> 
> Comments?
> 
> 
> This addresses bug 310572.
> http://bugs.kde.org/show_bug.cgi?id=310572
> 
> 
> Diffs
> -
> 
>   ui/pageviewannotator.cpp 4488639 
> 
> Diff: http://git.reviewboard.kde.org/r/107726/diff/
> 
> 
> Testing
> ---
> 
> Run all the default annotations with the outcome above described
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 267588] It would great if you could add a feature where the user can customize annotation styles for the actual tool.

2012-12-16 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=267588

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #1 from Fabio D'Urso  ---


*** This bug has been marked as a duplicate of bug 159601 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 159601] configurable review tools

2012-12-16 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=159601

Fabio D'Urso  changed:

   What|Removed |Added

 CC||philipbellen...@gmail.com

--- Comment #17 from Fabio D'Urso  ---
*** Bug 267588 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311775] crash if I use button 'Previous' in finding words in pdf

2012-12-16 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=311775

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Can you attach the pdf file you are using? And tell us which word you searched
for?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [Bug 311775] New: crash if I use button 'Previous' in finding words in pdf

2012-12-16 Thread Yegor
https://bugs.kde.org/show_bug.cgi?id=311775

Bug ID: 311775
  Severity: normal
   Version: 0.15.3
  Priority: NOR
  Assignee: okular-devel@kde.org
   Summary: crash if I use button 'Previous' in finding words in
pdf
Classification: Unclassified
OS: Linux
  Reporter: yegorkle...@gmail.com
  Hardware: Archlinux Packages
Status: UNCONFIRMED
 Component: PDF backend
   Product: okular

Button 'Next' works well. When I missed my point and want to go back I cant.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel