[Okular-devel] [okular] [Bug 300992] Searching for a phrase does not find occurences split by a line break / newline in Pdf

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=300992

--- Comment #5 from Florian Moretz  ---
This is the screenshot I was referring to:
http://bugzilla-attachments.gnome.org/attachment.cgi?id=236718

Evince's behaviour is identical to that of Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 300992] Searching for a phrase does not find occurences split by a line break / newline in Pdf

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=300992

--- Comment #4 from Florian Moretz  ---
This bug is also present in evince. My comment in the bugreport there
(https://bugzilla.gnome.org/show_bug.cgi?id=622160) fully applies to Okular as
well:

The problem here, as
shown in the attached screenshot, seems to be twofold:

1.) sentences spanning across line breaks are not recognized as continuous and
aren't taken up by the inbuilt search (lower part of screenshot)

2.) single phrases spanning across line breaks aren't recognized as being
continuous, either. There does not seem to be any difference between hyphenated
and regular phrases in this. Searching for "main-tenance" in the example above
doesn't return any results, either.

Neither of these problems exist in proprietary solutions such as Adobe Reader
or Foxit. I think it can be argued that fixing this issue is quite important as
it greatly diminishes the inbuilt search capabilities.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 300992] Searching for a phrase does not find occurences split by a line break / newline in Pdf

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=300992

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 158313] pdf extract raster option

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=158313

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

--- Comment #3 from Florian Moretz  ---
Related bug: https://bugs.kde.org/show_bug.cgi?id=311043

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 246374] Use text of ToC entry when bookmark is created

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=246374

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 271487] okular search a section

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=271487

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 261791] Make searching through multiple documents possible

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=261791

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 163297] Faster repeat searching of large documents

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=163297

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 163294] Intelligent naming of bookmarks

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=163294

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311034] default search result and highlight colours are the same - usability problem

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=311034

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

--- Comment #3 from Florian Moretz  ---
This is a duplicate of this bug:

https://bugs.kde.org/show_bug.cgi?id=273968

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311043] Images should be extractable via right-click and/or drag-and-drop

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=311043

Florian Moretz  changed:

   What|Removed |Added

  Component|PDF backend |general

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311045] Search strings should be parsable from the command-line

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=311045

Florian Moretz  changed:

   What|Removed |Added

  Component|PDF backend |general

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 301302] Make Hand tool select text & images

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=301302

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 289614] New view mode: see upcoming slide when showing a presentation

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=289614

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 274933] Make search ignore diacritic marks

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=274933

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 273968] Usability: change highlight color for text search and/or annotation

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=273968

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 266680] Library, or list of bookmarked documents.

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=266680

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

--- Comment #1 from Florian Moretz  ---
Alternatively the currently empty home screen when starting Okular without a
specified file could be used to display the most recent / most commonly
accessed PDF documents. I am thinking of something akin to most web browser's
"new tab" page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 238123] Okular: Overview list of search results

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=238123

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 238123] Okular: Overview list of search results

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=238123

--- Comment #2 from Florian Moretz  ---
Created attachment 77421
  --> https://bugs.kde.org/attachment.cgi?id=77421&action=edit
Chrome's dynamic scrollbar

A simple alternative enhacement would be to implement a dynamic scrollbar
similar to the one found in Chrome's PDF viewer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 230077] bookmarks should show shorter paths

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=230077

--- Comment #2 from Florian Moretz  ---
I also concur. At the moment it is very difficult to locate the right bookmarks
in the pane as the first parts of the file path are identical in almost all
cases. It's the last few branches of the file tree and especially the filename
that's important for identifying a file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 230077] bookmarks should show shorter paths

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=230077

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 190203] Allow to create bookmarks from the "table of contents"

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=190203

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 186677] Better PDF text comments for okular

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=186677

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 159408] centre-point for zooming of pdf files (via +) should be in zone of the mouse-cursor

[Florian Moretz]

https://bugs.kde.org/show_bug.cgi?id=159408

Florian Moretz  changed:

   What|Removed |Added

 CC||comenius...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

[Jaydeep Solanki]

> On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2775
> > 
> >
> > Why did you decide that icon name?
> 
> Jaydeep Solanki wrote:
> I had two options for goto icon, "go_goto" & "go_goto_page" but none of 
> them shows an icon.
> I decided to keep, the later one because I have used it in one of my 
> apps, & at that time it worked.
> 
> Albert Astals Cid wrote:
> Use "kdialog --geticon foo", then select again the Actions combo (seems 
> that's a bug) and once you are there try to look for an icon that makes 
> sense, if not, i guess it's better to simply use no icon than one that 
> doesn't exist

Don't you think that the 'search for' option that appears when right clicked on 
selected text, should have 'edit-web-search' icon,
& go to 'link' should have 'preferences-web-browser-shortcuts'.
I just had a look at the icons & I think 'edit-web-search' describes the search 
action more appropriately.


- Jaydeep


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review26271
---


On Feb. 17, 2013, 7:04 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated Feb. 17, 2013, 7:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314693] Crash when printing A3 & A4 mixed PDF

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=314693

--- Comment #2 from Christoph Feck  ---
If you can provide the information requested in comment #1, please add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Txt backend for okular, for plain text files.

[Azat Khuzhin]

On Mon, Feb 18, 2013 at 3:36 AM, Albert Astals Cid  wrote:
> El Dilluns, 18 de febrer de 2013, a les 03:27:25, Azat Khuzhin va escriure:
>> On Feb 18, 2013 2:45 AM, "Albert Astals Cid"  wrote:
>> > El Divendres, 15 de febrer de 2013, a les 00:45:10, Azat Khuzhin va
>>
>> escriure:
>> > > Here is simple version of font selector for plain text formats.
>> > > (Formats based on TextDocumentGenerator.)
>> > >
>> > > It works only if you installing custom font before document loaded.
>> >
>> > Not sure what you mean with this sentence
>>
>> It was already fixed. You can see git history for more info.
>>
>>
>>
>>
>> https://github.com/azat/okular/compare/master...font-selector-for-plain-text
>> > > -formats
>> >
>> > Lol, you are closing and opening the document, seems a bit extreme :D
>>
>> I did this because we need do update all pages. So why not?
>> But it was is a _hack_. Can you suggest better decision?
>
> Sure, have a look at PDFGenerator::reparseConfig for example.

Thanks. I didn't see this.
Updated patch, according to ConfigInterface.
And upload to reviewboard - https://git.reviewboard.kde.org/r/109009/

>
> Cheers,
>   Albert
>
>>
>> But we need to reopen only text documents. I will fix this in the next few
>> days.
>>
>> > > I also can push this patch to git.reviewboard.kde.org if this will be
>> > > more comfortable.
>> >
>> > It's easier for us to review and keep track of the missing things to
>>
>> review.
>>
>> > Cheers,
>> >
>> >   Albert
>> >
>> > > On Thu, Feb 14, 2013 at 10:41 AM, Azat Khuzhin 
>> >
>> > wrote:
>> > > > Hi Albert,
>> > > >
>> > > > Thanks, I forgot about that places.
>> > > > Fixed.
>> > > >
>> > > > Maybe I need to push this patch to git.reviewboard.kde.org ?
>> > > >
>> > > > On Thu, Feb 14, 2013 at 3:08 AM, Albert Astals Cid 
>>
>> wrote:
>> > > >> El Dijous, 14 de febrer de 2013, a les 01:15:39, Azat Khuzhin va
>> >
>> > escriure:
>> > > >>> Hi all,
>> > > >>>
>> > > >>> I found Okular::TextDocumentGenerator, so I fully rewrite current
>>
>> txt
>>
>> > > >>> backend using Okular::TextDocumentGenerator
>> > > >>> And code become pretty clear now.
>> > > >>>
>> > > >>> Patch available here
>>
>> https://github.com/azat/okular/compare/master...add-txt-support.patch
>>
>> > > >>> Human view here
>> > > >>> https://github.com/azat/okular/compare/master...add-txt-support
>> > > >>
>> > > >> Document::toUnicode will crash if the prober doesn't give you enough
>> > > >> confidence and you return "" in detectEncoding
>> > > >>
>> > > >> Also i don't see why you need to cache m_detectedEncoding since
>>
>> toUnicode
>>
>> > > >> is only called from the document constructor.
>> > > >>
>> > > >> Cheers,
>> > > >>
>> > > >>   Albert
>> > > >>>
>> > > >>> New screenshot available here:
>> > > >>> http://i.imgur.com/YZEmlg0.png
>> > > >>>
>> > > >>> Any wishes?
>> > > >>>
>> > > >>> On Wed, Feb 13, 2013 at 8:48 AM, Azat Khuzhin > >
>> > wrote:
>> > > >>> > On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid 
>> >
>> > wrote:
>> > > >>> >> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat Khuzhin va
>> > > >>
>> > > >> escriure:
>> > > >>> >>> On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid <
>>
>> aa...@kde.org>
>>
>> > > >> wrote:
>> > > >>> >>> > El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat
>>
>> Khuzhin va
>>
>> > > >>> >> escriure:
>> > > >>> >>> >> Hi all,
>> > > >>> >>> >
>> > > >>> >>> > Hi
>> > > >>> >>> >
>> > > >>> >>> >> I write simple plain text backend for okular.
>> > > >>> >>> >> https://github.com/azat/okular/tree/add-txt-support
>> > > >>> >>> >
>> > > >>> >>> > To be honest i don't see what benefit a plain text backend for
>> > > >>> >>> > okular
>> > > >>> >>> > has,
>> > > >>> >>> > but I'm not going to try to stop you :-)
>> > > >>> >>>
>> > > >>> >>> I use okular to read books, and I have one book in plaintext
>>
>> format,
>>
>> > > >>> >>> but kate doesn't the best choice to read books, so I start
>> > > >>> >>> implementing this backend.
>> > > >>> >>
>> > > >>> >> Makes sense, do you have a screenshot we can see how it is
>>
>> looking
>>
>> > > >>> >> like?
>> > > >>> >
>> > > >>> > http://i.imgur.com/gX0DEJJ.png
>> > > >>> > Is this enough?
>> > > >>> >
>> > > >>> >> One of the things i think you'll need to implement is a font
>> > > >>> >> selector,
>> > > >>> >> no? So you can change font size, etc. That's one of the things
>>
>> we've
>>
>> > > >>> >> been needing for lots of other "text based" formats, so it'd be
>>
>> cool
>>
>> > > >>> >> to
>> > > >>> >> get globally :-)>
>> > > >>> >
>> > > >>> > Good idea.
>> > > >>> > I will do this in the next week. More likely after some
>> > > >>> > refactoring/improvements of new plain text backend.
>> > > >>> >
>> > > >>> >>> >> I will support this backend until bringing it to a normal
>>
>> state.
>>
>> > > >>> >>> >> It means I will resolv many TODO's in this code, that I
>>
>> left, and
>>
>> > > >>> >>> >> do
>> > > >>> >>> >> some refactoring.
>> > > >>> >>> >>
>> > > >>> >>> >> And aft

[Okular-devel] [okular] [Bug 261930] wish: plain text backend

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=261930

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.11.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/74420f1baac621f6822ed9c5
   ||212e6004711d695a

--- Comment #9 from Albert Astals Cid  ---
Git commit 74420f1baac621f6822ed9c5212e6004711d695a by Albert Astals Cid, on
behalf of Azat Khuzhin.
Committed on 19/02/2013 at 00:22.
Pushed by aacid into branch 'master'.

Txt backend
REVIEW: 109009
FIXED-IN: 4.11.0

M  +2-0generators/CMakeLists.txt
A  +25   -0generators/txt/CMakeLists.txt
A  +14   -0generators/txt/active-documentviewer_txt.desktop
A  +41   -0generators/txt/converter.cpp [License: GPL (v2+)]
A  +31   -0generators/txt/converter.h [License: GPL (v2+)]
A  +68   -0generators/txt/document.cpp [License: GPL (v2+)]
A  +26   -0generators/txt/document.h [License: GPL (v2+)]
A  +36   -0generators/txt/generator_txt.cpp [License: GPL (v2+)]
A  +24   -0generators/txt/generator_txt.h [License: GPL (v2+)]
A  +10   -0generators/txt/libokularGenerator_txt.desktop
A  +12   -0generators/txt/okularApplication_txt.desktop
A  +7-0generators/txt/okularTxt.desktop

http://commits.kde.org/okular/74420f1baac621f6822ed9c5212e6004711d695a

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Txt backend for okular, for plain text files.

[Azat Khuzhin]

On Mon, Feb 18, 2013 at 2:54 AM, Albert Astals Cid  wrote:
> El Diumenge, 17 de febrer de 2013, a les 15:33:01, Azat Khuzhin va escriure:
>> I improve font selector, now user don't need to reopen document
>> manually to change font, it will be done automatically.
>>
>> I noted that there is some tricky FontInfo class
>
> Why tricky?

It has many connect()/emit code, and at that time I don't have enough
time to look through this more closely

>
>> , should it used instead of QFont?
>
> No
>
>> And somehow the string "&Font" not parsed as "_F_ont" (ALT+F hotkey)
>> In
>> https://github.com/azat/okular/commit/0d3817ddcc1b0862072a2a74535edde89b6ad
>> 35d
>>
>> Can anybody tell, why this happened?
>
> Not that i can read XML diffs that well, but is &Font on a label? If so you
> need to give it a buddy (In the edit menu of designer).

Yes it is in label. Yes it helps. Thanks.
https://github.com/azat/okular/commit/26e6cd9aca408210e706f5a1b3b5d55c0ddea887

>
> Cheers,
>   Albert
>
>>
>> On Fri, Feb 15, 2013 at 12:45 AM, Azat Khuzhin 
> wrote:
>> > Here is simple version of font selector for plain text formats.
>> > (Formats based on TextDocumentGenerator.)
>> >
>> > It works only if you installing custom font before document loaded.
>> >
>> > https://github.com/azat/okular/compare/master...font-selector-for-plain-te
>> > xt-formats
>> >
>> > I also can push this patch to git.reviewboard.kde.org if this will be
>> > more comfortable.
>> >
>> > On Thu, Feb 14, 2013 at 10:41 AM, Azat Khuzhin 
> wrote:
>> >> Hi Albert,
>> >>
>> >> Thanks, I forgot about that places.
>> >> Fixed.
>> >>
>> >> Maybe I need to push this patch to git.reviewboard.kde.org ?
>> >>
>> >> On Thu, Feb 14, 2013 at 3:08 AM, Albert Astals Cid  wrote:
>> >>> El Dijous, 14 de febrer de 2013, a les 01:15:39, Azat Khuzhin va
> escriure:
>>  Hi all,
>> 
>>  I found Okular::TextDocumentGenerator, so I fully rewrite current txt
>>  backend using Okular::TextDocumentGenerator
>>  And code become pretty clear now.
>> 
>>  Patch available here
>>  https://github.com/azat/okular/compare/master...add-txt-support.patch
>> 
>>  Human view here
>>  https://github.com/azat/okular/compare/master...add-txt-support
>> >>>
>> >>> Document::toUnicode will crash if the prober doesn't give you enough
>> >>> confidence and you return "" in detectEncoding
>> >>>
>> >>> Also i don't see why you need to cache m_detectedEncoding since
>> >>> toUnicode is only called from the document constructor.
>> >>>
>> >>> Cheers,
>> >>>
>> >>>   Albert
>> 
>>  New screenshot available here:
>>  http://i.imgur.com/YZEmlg0.png
>> 
>>  Any wishes?
>> 
>>  On Wed, Feb 13, 2013 at 8:48 AM, Azat Khuzhin 
> wrote:
>>  > On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid 
> wrote:
>>  >> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat Khuzhin va
>> >>>
>> >>> escriure:
>>  >>> On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid 
>> >>>
>> >>> wrote:
>>  >>> > El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat Khuzhin
>>  >>> > va
>>  >>
>>  >> escriure:
>>  >>> >> Hi all,
>>  >>> >
>>  >>> > Hi
>>  >>> >
>>  >>> >> I write simple plain text backend for okular.
>>  >>> >> https://github.com/azat/okular/tree/add-txt-support
>>  >>> >
>>  >>> > To be honest i don't see what benefit a plain text backend for
>>  >>> > okular
>>  >>> > has,
>>  >>> > but I'm not going to try to stop you :-)
>>  >>>
>>  >>> I use okular to read books, and I have one book in plaintext
>>  >>> format,
>>  >>> but kate doesn't the best choice to read books, so I start
>>  >>> implementing this backend.
>>  >>
>>  >> Makes sense, do you have a screenshot we can see how it is looking
>>  >> like?
>>  >
>>  > http://i.imgur.com/gX0DEJJ.png
>>  > Is this enough?
>>  >
>>  >> One of the things i think you'll need to implement is a font
>>  >> selector,
>>  >> no? So you can change font size, etc. That's one of the things we've
>>  >> been needing for lots of other "text based" formats, so it'd be cool
>>  >> to
>>  >> get globally :-)>
>>  >
>>  > Good idea.
>>  > I will do this in the next week. More likely after some
>>  > refactoring/improvements of new plain text backend.
>>  >
>>  >>> >> I will support this backend until bringing it to a normal state.
>>  >>> >> It means I will resolv many TODO's in this code, that I left,
>>  >>> >> and do
>>  >>> >> some refactoring.
>>  >>> >>
>>  >>> >> And after some fixes, from time to time, to this backed will
>>  >>> >> write
>>  >>> >> email to this mail list that new version is available.
>>  >>> >>
>>  >>> >> It will be great if this backend can be merged to upstream, for
>>  >>> >> everybody.
>>  >>> >> So if anybody can tell what must be fixed before merging to
>>  >>> >> upstream,

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Azat Khuzhin]

> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/CMakeLists.txt, line 6
> > 
> >
> > This probably should go away?

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/active-documentviewer_txt.desktop, line 4
> > 
> >
> > Clean all the translations, that's for our translators and translation 
> > script to maintain.

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/converter.h, line 10
> > 
> >
> > bad define name

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/converter.h, line 27
> > 
> >
> > This red that reviewboard shows maybe means you're mixing tabs & spaces 
> > or something?

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/converter.cpp, line 16
> > 
> >
> > Do you need all these includes?

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/document.cpp, line 25
> > 
> >
> > This seems like it should be a debug not a warning

Fixed in patch r2.


> On Feb. 18, 2013, 10:31 p.m., Albert Astals Cid wrote:
> > generators/txt/document.cpp, line 55
> > 
> >
> > warning -> debug
> > empty space at the end of line

Fixed in patch r2.


- Azat


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27676
---


On Feb. 18, 2013, 11:07 p.m., Azat Khuzhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109009/
> ---
> 
> (Updated Feb. 18, 2013, 11:07 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Simple txt backend for okular.
> 
> Development history:
> https://github.com/azat/okular/compare/master...add-txt-support
> 
> From mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -
> 
>   generators/txt/document.cpp PRE-CREATION 
>   generators/txt/generator_txt.h PRE-CREATION 
>   generators/txt/generator_txt.cpp PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
>   generators/txt/okularApplication_txt.desktop PRE-CREATION 
>   generators/txt/okularTxt.desktop PRE-CREATION 
>   generators/CMakeLists.txt 5a101bf 
>   generators/txt/CMakeLists.txt PRE-CREATION 
>   generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
>   generators/txt/converter.h PRE-CREATION 
>   generators/txt/converter.cpp PRE-CREATION 
>   generators/txt/document.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109009/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Azat Khuzhin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/
---

(Updated Feb. 18, 2013, 11:07 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
---

Resolve all issues


Description
---

Simple txt backend for okular.

Development history:
https://github.com/azat/okular/compare/master...add-txt-support

>From mailing list:
http://comments.gmane.org/gmane.comp.kde.devel.okular/13279


Diffs (updated)
-

  generators/txt/document.cpp PRE-CREATION 
  generators/txt/generator_txt.h PRE-CREATION 
  generators/txt/generator_txt.cpp PRE-CREATION 
  generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
  generators/txt/okularApplication_txt.desktop PRE-CREATION 
  generators/txt/okularTxt.desktop PRE-CREATION 
  generators/CMakeLists.txt 5a101bf 
  generators/txt/CMakeLists.txt PRE-CREATION 
  generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
  generators/txt/converter.h PRE-CREATION 
  generators/txt/converter.cpp PRE-CREATION 
  generators/txt/document.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109009/diff/


Testing
---

Tested manually.


Thanks,

Azat Khuzhin

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Azat Khuzhin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27679
---



generators/txt/document.cpp


No, if encoding is empty is return "" - empty string, see above


- Azat Khuzhin


On Feb. 18, 2013, 5:03 p.m., Azat Khuzhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109009/
> ---
> 
> (Updated Feb. 18, 2013, 5:03 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Simple txt backend for okular.
> 
> Development history:
> https://github.com/azat/okular/compare/master...add-txt-support
> 
> From mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -
> 
>   generators/txt/generator_txt.cpp PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
>   generators/txt/okularApplication_txt.desktop PRE-CREATION 
>   generators/txt/okularTxt.desktop PRE-CREATION 
>   generators/CMakeLists.txt 5a101bf 
>   generators/txt/CMakeLists.txt PRE-CREATION 
>   generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
>   generators/txt/converter.h PRE-CREATION 
>   generators/txt/converter.cpp PRE-CREATION 
>   generators/txt/document.h PRE-CREATION 
>   generators/txt/document.cpp PRE-CREATION 
>   generators/txt/generator_txt.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109009/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27680
---



generators/txt/document.cpp


Please return QString(), returning "" calls an unnecessary number of 
constructors when QString() is as clear as "", same for the ::detectEncoding ""


- Albert Astals Cid


On Feb. 18, 2013, 5:03 p.m., Azat Khuzhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109009/
> ---
> 
> (Updated Feb. 18, 2013, 5:03 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Simple txt backend for okular.
> 
> Development history:
> https://github.com/azat/okular/compare/master...add-txt-support
> 
> From mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -
> 
>   generators/txt/generator_txt.cpp PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
>   generators/txt/okularApplication_txt.desktop PRE-CREATION 
>   generators/txt/okularTxt.desktop PRE-CREATION 
>   generators/CMakeLists.txt 5a101bf 
>   generators/txt/CMakeLists.txt PRE-CREATION 
>   generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
>   generators/txt/converter.h PRE-CREATION 
>   generators/txt/converter.cpp PRE-CREATION 
>   generators/txt/document.h PRE-CREATION 
>   generators/txt/document.cpp PRE-CREATION 
>   generators/txt/generator_txt.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109009/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/#review27676
---



generators/txt/CMakeLists.txt


This probably should go away?



generators/txt/active-documentviewer_txt.desktop


Clean all the translations, that's for our translators and translation 
script to maintain.



generators/txt/converter.h


bad define name



generators/txt/converter.h


This red that reviewboard shows maybe means you're mixing tabs & spaces or 
something?



generators/txt/converter.cpp


Do you need all these includes?



generators/txt/document.cpp


This seems like it should be a debug not a warning



generators/txt/document.cpp


warning -> debug
empty space at the end of line



generators/txt/document.cpp


if encoding is "" this will crash


- Albert Astals Cid


On Feb. 18, 2013, 5:03 p.m., Azat Khuzhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109009/
> ---
> 
> (Updated Feb. 18, 2013, 5:03 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Description
> ---
> 
> Simple txt backend for okular.
> 
> Development history:
> https://github.com/azat/okular/compare/master...add-txt-support
> 
> From mailing list:
> http://comments.gmane.org/gmane.comp.kde.devel.okular/13279
> 
> 
> Diffs
> -
> 
>   generators/txt/generator_txt.cpp PRE-CREATION 
>   generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
>   generators/txt/okularApplication_txt.desktop PRE-CREATION 
>   generators/txt/okularTxt.desktop PRE-CREATION 
>   generators/CMakeLists.txt 5a101bf 
>   generators/txt/CMakeLists.txt PRE-CREATION 
>   generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
>   generators/txt/converter.h PRE-CREATION 
>   generators/txt/converter.cpp PRE-CREATION 
>   generators/txt/document.h PRE-CREATION 
>   generators/txt/document.cpp PRE-CREATION 
>   generators/txt/generator_txt.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/109009/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

[Albert Astals Cid]

> On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2775
> > 
> >
> > Why did you decide that icon name?
> 
> Jaydeep Solanki wrote:
> I had two options for goto icon, "go_goto" & "go_goto_page" but none of 
> them shows an icon.
> I decided to keep, the later one because I have used it in one of my 
> apps, & at that time it worked.

Use "kdialog --geticon foo", then select again the Actions combo (seems that's 
a bug) and once you are there try to look for an icon that makes sense, if not, 
i guess it's better to simply use no icon than one that doesn't exist


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review26271
---


On Feb. 17, 2013, 7:04 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated Feb. 17, 2013, 7:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review27674
---



ui/pageview.cpp


Please do not return 0 as a QString, that's just evil



ui/pageview.cpp


isEmpty is "bigger" than isNull, so just check for empty is enough


- Albert Astals Cid


On Feb. 17, 2013, 7:04 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated Feb. 17, 2013, 7:04 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 109009: Txt backend for okular

[Azat Khuzhin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/
---

Review request for Okular and Albert Astals Cid.


Description
---

Simple txt backend for okular.

Development history
https://github.com/azat/okular/compare/master...add-txt-support


Diffs
-

  generators/txt/generator_txt.cpp PRE-CREATION 
  generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
  generators/txt/okularApplication_txt.desktop PRE-CREATION 
  generators/txt/okularTxt.desktop PRE-CREATION 
  generators/CMakeLists.txt 5a101bf 
  generators/txt/CMakeLists.txt PRE-CREATION 
  generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
  generators/txt/converter.h PRE-CREATION 
  generators/txt/converter.cpp PRE-CREATION 
  generators/txt/document.h PRE-CREATION 
  generators/txt/document.cpp PRE-CREATION 
  generators/txt/generator_txt.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109009/diff/


Testing
---

Tested manually.


Thanks,

Azat Khuzhin

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109009: Txt backend for okular

[Azat Khuzhin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109009/
---

(Updated Feb. 18, 2013, 5:03 p.m.)


Review request for Okular and Albert Astals Cid.


Changes
---

Add link to mailing list


Description (updated)
---

Simple txt backend for okular.

Development history:
https://github.com/azat/okular/compare/master...add-txt-support

>From mailing list:
http://comments.gmane.org/gmane.comp.kde.devel.okular/13279


Diffs
-

  generators/txt/generator_txt.cpp PRE-CREATION 
  generators/txt/libokularGenerator_txt.desktop PRE-CREATION 
  generators/txt/okularApplication_txt.desktop PRE-CREATION 
  generators/txt/okularTxt.desktop PRE-CREATION 
  generators/CMakeLists.txt 5a101bf 
  generators/txt/CMakeLists.txt PRE-CREATION 
  generators/txt/active-documentviewer_txt.desktop PRE-CREATION 
  generators/txt/converter.h PRE-CREATION 
  generators/txt/converter.cpp PRE-CREATION 
  generators/txt/document.h PRE-CREATION 
  generators/txt/document.cpp PRE-CREATION 
  generators/txt/generator_txt.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/109009/diff/


Testing
---

Tested manually.


Thanks,

Azat Khuzhin

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 315354] okular crashed when i opened a .mobi format file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=315354

Albert Astals Cid  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 CC||aa...@kde.org
 Resolution|DUPLICATE   |---

--- Comment #2 from Albert Astals Cid  ---
@Maarten: This is not a duplicate, check the backtraces
@Brian: Can you please attach a file that produces such a crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 315354] okular crashed when i opened a .mobi format file

[Maarten De Meyer]

https://bugs.kde.org/show_bug.cgi?id=315354

Maarten De Meyer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||de.meyer.maar...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Maarten De Meyer  ---


*** This bug has been marked as a duplicate of bug 272867 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel