[Okular-devel] Undo / Redo questions
Greetings, For the past several months I've been (slowly) working on adding undo/redo support to Okular. I believe I have everything working to undo/redo all actions related to annotations (See https://git.reviewboard.kde.org/r/107442/). My first question is whether this functionality is sufficient for inclusion in Okular or whether we should wait until I have time to add undo support for forms as well. I do hope I'll have time to work on adding form support in the not so distant future. Does anyone have a good sample PDF file that includes all of the form controls supported by Okular for me to test with? Thanks! -Jon ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109041: Change search highlight color
On Feb. 19, 2013, 11:15 p.m., Albert Astals Cid wrote: But annotation highlight color can be changed, so what's the point of this, if we are using colors it may conflict at some point, no? Jaydeep Solanki wrote: yes, you are absolutely correct, but suppose you have a pdf with a lot of annotations, in that case you'll have to change the color of all the annotations. Okular doesn't provide a convenient way of changing colors in bulk. So the other way of doing this would be providing an option like change default annotation color, that changes all the highlights to a specific color. I disagree, I think the proper fix is making the Search be somewhat different to annotations, by e.g. having a border or something around them so you can easily see what is a search and what is an annotation even if both have exactly the same color. Thoughts? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109041/#review27755 --- On Feb. 19, 2013, 12:45 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109041/ --- (Updated Feb. 19, 2013, 12:45 p.m.) Review request for Okular. Description --- change search highlight color, as the annotation highlight color is the same which makes it difficult to differentiate between them. This addresses bug 273968. http://bugs.kde.org/show_bug.cgi?id=273968 Diffs - ui/findbar.cpp f00f883 ui/presentationsearchbar.cpp 68c0128 Diff: http://git.reviewboard.kde.org/r/109041/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Participating in development
Hi, I have an assignment to join in some open-source project at school and I will be happy to cooperate on development in future. I would like to take part in developing Okular because I'm interested in Okular and I think it is a great program. I was looking into the bugtracking system and I have found some issue which I would like to do. I want to work on bugs 252462 and maybe 26. I have an idea to add a zoom slider into Page Bar (relating to 26), but I'm not sure whether it is OK. Can I work on these bugs? Next I want to ask how I send my changes. Would you like a patch or how it works? I have experience with developing Qt and KDE applications. I have developed KMiniDLNA http://sourceforge.net/projects/kminidlna/ Thank you for your response Tomas Poledny ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 2183 http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2183 Mere looks, please put the static on front oops! On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 2185 http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185 This regexp still needs some tweaking, right now if i pass holahttps://okular.org; it returns https://okular.org that in my opinion is not correct. You should enforce spaces (or newlines or tabs) around the regexp to make sure the url is a single word. Also it would be cool if you could write down all the urls you've used to positively and negatively test the regexp so we can put it in a testcase You mean holahttps://okular.org; should not be detected as an url, hola https://okular.org; should be. Am I right ?? - Jaydeep --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27846 --- On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated Feb. 20, 2013, 2:21 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 2185 http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185 This regexp still needs some tweaking, right now if i pass holahttps://okular.org; it returns https://okular.org that in my opinion is not correct. You should enforce spaces (or newlines or tabs) around the regexp to make sure the url is a single word. Also it would be cool if you could write down all the urls you've used to positively and negatively test the regexp so we can put it in a testcase Jaydeep Solanki wrote: You mean holahttps://okular.org; should not be detected as an url, hola https://okular.org; should be. Am I right ?? Exactly - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27846 --- On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated Feb. 20, 2013, 2:21 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Participating in development
El Dijous, 21 de febrer de 2013, a les 17:22:05, Tomas Poledny va escriure: Hi, Hi I have an assignment to join in some open-source project at school and I will be happy to cooperate on development in future. I would like to take part in developing Okular because I'm interested in Okular and I think it is a great program. Nice :-) I was looking into the bugtracking system and I have found some issue which I would like to do. I want to work on bugs 252462 and maybe 26. I have an idea to add a zoom slider into Page Bar (relating to 26), but I'm not sure whether it is OK. Can I work on these bugs? To be honest i don't think 26 is a good idea. 252462 seems ok'ish, maybe while doing it you can do 315538 too. Next I want to ask how I send my changes. Would you like a patch or how it works? You do a git diff and post it on https://git.reviewboard.kde.org/ using the okular group. Happy hacking! Cheers, Albert I have experience with developing Qt and KDE applications. I have developed KMiniDLNA http://sourceforge.net/projects/kminidlna/ Thank you for your response Tomas Poledny ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27875 --- - Mailson Menezes On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated Feb. 20, 2013, 2:21 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
On Feb. 21, 2013, 3:29 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 2185 http://git.reviewboard.kde.org/r/108614/diff/3/?file=114545#file114545line2185 This regexp still needs some tweaking, right now if i pass holahttps://okular.org; it returns https://okular.org that in my opinion is not correct. You should enforce spaces (or newlines or tabs) around the regexp to make sure the url is a single word. Also it would be cool if you could write down all the urls you've used to positively and negatively test the regexp so we can put it in a testcase Jaydeep Solanki wrote: You mean holahttps://okular.org; should not be detected as an url, hola https://okular.org; should be. Am I right ?? Albert Astals Cid wrote: Exactly Try to have a look on how konversation extracts url from strings. More precisely the function extractUrlData in common.cpp - Mailson --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27846 --- On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated Feb. 20, 2013, 2:21 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315611] New: Print to file with option 'multiple pages per sheet' doesn't produce the expected document
https://bugs.kde.org/show_bug.cgi?id=315611 Bug ID: 315611 Summary: Print to file with option 'multiple pages per sheet' doesn't produce the expected document Classification: Unclassified Product: okular Version: 0.16.0 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: rom1...@gmail.com Hi ! I found a couple of already reported bugs regarding an incorrect rendering when printing to a file. I'm not sure my problem isn't a dupe but I still open a new bug since it focuses on 'pages per sheet' printing option and not directly on border issues. Also, as a note, the vocabulary used here to describe the problem may differ slightly since I'm using a localized kde (not -en then), sorry about that… Reproducible: Always Steps to Reproduce: 1. Open some pdf file and chose to print it with option: Options → Pages → 6 pages 2. Printing to a file (pdf) 3. Select an output file press the print button Actual Results: The rendered document still contains one page per… page, and looks just the same as the original one. Expected Results: The rendered document is expected to contain 6 pages at once. As a comparison, evince reach producing this «compressed» document. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
