[Okular-devel] [okular] [Bug 315842] New: Okular crashes randomly when printing the second time

2013-02-27 Thread energie.mc2
https://bugs.kde.org/show_bug.cgi?id=315842

Bug ID: 315842
   Summary: Okular crashes randomly when printing the second time
Classification: Unclassified
   Product: okular
   Version: 0.14.3
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: energie@gmx.de

Application: okular (0.14.3)
KDE Platform Version: 4.8.5 (4.8.5)
Qt Version: 4.8.1
Operating System: Linux 3.2.0-38-generic x86_64
Distribution: Ubuntu 12.04.2 LTS

-- Information about the crash:
- What I was doing when the application crashed:
I wanted to print a certain pdf-document a second time. I pressed Ctrl-P for
that. The program did not hang, it just closed immediately.

The crash can be reproduced some of the time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library /lib/x86_64-linux-gnu/libthread_db.so.1.
[Current thread is 1 (Thread 0x7f6784121780 (LWP 30686))]

Thread 4 (Thread 0x7f676d57f700 (LWP 30689)):
#0  0x7f677e13b33e in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f677e13b599 in g_mutex_lock () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f677e10001b in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f677e100164 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f6781cf7426 in QEventDispatcherGlib::processEvents
(this=0x7f67600038c0, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#5  0x7f6781cc6c82 in QEventLoop::processEvents (this=optimized out,
flags=...) at kernel/qeventloop.cpp:149
#6  0x7f6781cc6ed7 in QEventLoop::exec (this=0x7f676d57edd0, flags=...) at
kernel/qeventloop.cpp:204
#7  0x7f6781bc5fa7 in QThread::exec (this=optimized out) at
thread/qthread.cpp:501
#8  0x7f6781ca69ff in QInotifyFileSystemWatcherEngine::run (this=0x19391d0)
at io/qfilesystemwatcher_inotify.cpp:248
#9  0x7f6781bc8fcb in QThreadPrivate::start (arg=0x19391d0) at
thread/qthread_unix.cpp:298
#10 0x7f677e5cce9a in start_thread (arg=0x7f676d57f700) at
pthread_create.c:308
#11 0x7f6781304cbd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#12 0x in ?? ()

Thread 3 (Thread 0x7f6767fff700 (LWP 30938)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at
../nptl/sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:162
#1  0x7f6781bc94db in wait (time=18446744073709551615, this=0x56dad20) at
thread/qwaitcondition_unix.cpp:86
#2  QWaitCondition::wait (this=optimized out, mutex=0x7027700,
time=18446744073709551615) at thread/qwaitcondition_unix.cpp:158
#3  0x7f6782bcb354 in QFileInfoGatherer::run (this=0x70276f0) at
dialogs/qfileinfogatherer.cpp:214
#4  0x7f6781bc8fcb in QThreadPrivate::start (arg=0x70276f0) at
thread/qthread_unix.cpp:298
#5  0x7f677e5cce9a in start_thread (arg=0x7f6767fff700) at
pthread_create.c:308
#6  0x7f6781304cbd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#7  0x in ?? ()

Thread 2 (Thread 0x7f676dd80700 (LWP 30939)):
#0  0x7f67812f9303 in __GI___poll (fds=optimized out, nfds=optimized
out, timeout=optimized out) at ../sysdeps/unix/sysv/linux/poll.c:87
#1  0x7f677e100036 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f677e100164 in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f6781cf7426 in QEventDispatcherGlib::processEvents
(this=0x7f675c093510, flags=...) at kernel/qeventdispatcher_glib.cpp:426
#4  0x7f6781cc6c82 in QEventLoop::processEvents (this=optimized out,
flags=...) at kernel/qeventloop.cpp:149
#5  0x7f6781cc6ed7 in QEventLoop::exec (this=0x7f676dd7fdd0, flags=...) at
kernel/qeventloop.cpp:204
#6  0x7f6781bc5fa7 in QThread::exec (this=optimized out) at
thread/qthread.cpp:501
#7  0x7f6781ca69ff in QInotifyFileSystemWatcherEngine::run (this=0x18a2e60)
at io/qfilesystemwatcher_inotify.cpp:248
#8  0x7f6781bc8fcb in QThreadPrivate::start (arg=0x18a2e60) at
thread/qthread_unix.cpp:298
#9  0x7f677e5cce9a in start_thread (arg=0x7f676dd80700) at
pthread_create.c:308
#10 0x7f6781304cbd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#11 0x in ?? ()

Thread 1 (Thread 0x7f6784121780 (LWP 30686)):
[KCrash Handler]
#6  0x7f67828dfb0e in QCUPSSupport::printerOption (this=0x5740990, key=...)
at painting/qcups.cpp:251
#7  0x7f6782b7bce5 in QUnixPrintWidgetPrivate::_q_printerChanged
(this=0x590ff20, index=0) at dialogs/qprintdialog_unix.cpp:804
#8  0x7f6782b7c8f2 in QUnixPrintWidgetPrivate::QUnixPrintWidgetPrivate
(this=0x590ff20, p=optimized out) at dialogs/qprintdialog_unix.cpp:711
#9  0x7f6782b7cbdb in QUnixPrintWidget::QUnixPrintWidget (this=0x56aa880,
printer=0x0, parent=optimized out) at dialogs/qprintdialog_unix.cpp:1036
#10 0x7f6782b7cc5e in 

[Okular-devel] [okular] [Bug 315818] http links do not work in PDF files

2013-02-27 Thread jaydeep
https://bugs.kde.org/show_bug.cgi?id=315818

jaydeep j.solank...@yahoo.com changed:

   What|Removed |Added

 CC||j.solank...@yahoo.com

--- Comment #3 from jaydeep j.solank...@yahoo.com ---
Actually it works only with internal links, no http links.
Will be fixed in a short period of time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315844] New: Highlighting pdfs doesn't work when using keyboard shortcuts

2013-02-27 Thread Luca Cerone
https://bugs.kde.org/show_bug.cgi?id=315844

Bug ID: 315844
   Summary: Highlighting pdfs doesn't work when using keyboard
shortcuts
Classification: Unclassified
   Product: okular
   Version: 0.14.3
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: luca_cer...@yahoo.it

The highlighting function can not be activated by using only the keyboard
shortcuts.
I use the default shortcuts, F6 to open the annotation window and then 4 to
select highlight.
After pressing 4 I would expect to be able to highlight the text,
but rather what I get is that I move the page using the hand browse tool

Reproducible: Always

Steps to Reproduce:
1. Open annotation window pressing F6
2. Select Highlight by pressing 4
3. Try to highlight some text
Actual Results:  
The page is moved as if the browse tool is selected rather than the highlight.

Expected Results:  
I can highlight text

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315844] Highlighting pdfs doesn't work when using keyboard shortcuts

2013-02-27 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=315844

Fabio D'Urso fabiodu...@hotmail.it changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #1 from Fabio D'Urso fabiodu...@hotmail.it ---
I'm failing to reproduce it, I've tried both 0.14.3 and 0.16.0 and it works
here.

The only thing that comes close to the behavior you described is trying
highlight documents in formats that do not provide text information (but in
such cases the highlight icon is grayed out). The only formats that allow text
highlighting are CHM, DJVU, DVI, PDF and XPS.
You said it's a PDF, so it should work. Do you confirm it works if you select
the highlight tool with the mouse?

Honestly I have no idea what the issue might be... maybe something qt-related?
I have qt 4.8.4. Let's see what others say.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315844] Highlighting pdfs doesn't work when using keyboard shortcuts

2013-02-27 Thread Luca Cerone
https://bugs.kde.org/show_bug.cgi?id=315844

--- Comment #2 from Luca Cerone luca_cer...@yahoo.it ---
You are right Fabio, it is not always reproducible.
after closing and opening Okular, now it is working as intended (my bad).
But definitively it is an issue with pdf.
Maybe it is because I had more than one Okular with the same document open?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Compile okular with qt5

2013-02-27 Thread Bogdan Cristea
Hi

I am wondering if there are plans to provide okular with qt5? I know that qt5 
is not source compatible with qt4, but I think that there are some speed 
improvements and new features from qt5 that might be worth trying.

regards
-- 
Bogdan
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Compile okular with qt5

2013-02-27 Thread Luigi Toscano
Bogdan Cristea wrote:
 I am wondering if there are plans to provide okular with qt5? I know that qt5 
 is not source compatible with qt4, but I think that there are some speed 
 improvements and new features from qt5 that might be worth trying.

For sure not before the entire Frameworks 5 (aka the next version of KDE
Platforms aka kdelibs) is available.

Ciao
-- 
Luigi
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315818] http links do not work in PDF files

2013-02-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315818

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid aa...@kde.org ---
Jaydeep please, do not say lies, http links work perfectly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315818] http links do not work in PDF files

2013-02-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315818

--- Comment #5 from Albert Astals Cid aa...@kde.org ---
To be perfectly clear what Jaydeep says that does not work is a random text
saying lalala foo bar http://www.kde.org la la without declaring
http://www.kde.org to be a link, but that is *OBVIOUSLY* not an http link, it's
just plain text that happens to be an http link.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315878] New: crashed when on an inline note - clicked out of the popup

2013-02-27 Thread Serena
https://bugs.kde.org/show_bug.cgi?id=315878

Bug ID: 315878
   Summary: crashed when on an inline note - clicked out of the
popup
Classification: Unclassified
   Product: okular
   Version: 0.16.0
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: senseri...@gmail.com

Application: okular (0.16.0)
KDE Platform Version: 4.10.00
Qt Version: 4.8.4
Operating System: Linux 3.7.9-1-ARCH x86_64
Distribution (Platform): Archlinux Packages

-- Information about the crash:
I was editing an inline note (there was a newline in the end).
I accidentally clicked out of the popup (i'm not sure whether it was on the
note or directly on the pdf file, but it was probably on the note)

The crash can be reproduced some of the time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library /usr/lib/libthread_db.so.1.
[KCrash Handler]
#5  0x7f3951b6b618 in QAbstractItemView::mouseReleaseEvent(QMouseEvent*) ()
from /usr/lib/libQtGui.so.4
#6  0x7f39522c84a7 in KColorCells::mouseReleaseEvent(QMouseEvent*) () from
/usr/lib/libkdeui.so.5
#7  0x7f39516b3a49 in QWidget::event(QEvent*) () from
/usr/lib/libQtGui.so.4
#8  0x7f3951a5ed36 in QFrame::event(QEvent*) () from /usr/lib/libQtGui.so.4
#9  0x7f3951b6a57b in QAbstractItemView::viewportEvent(QEvent*) () from
/usr/lib/libQtGui.so.4
#10 0x7f3950c6d816 in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/libQtCore.so.4
#11 0x7f395166415c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/libQtGui.so.4
#12 0x7f3951668e6b in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/libQtGui.so.4
#13 0x7f3952382426 in KApplication::notify(QObject*, QEvent*) () from
/usr/lib/libkdeui.so.5
#14 0x7f3950c6d6ae in QCoreApplication::notifyInternal(QObject*, QEvent*)
() from /usr/lib/libQtCore.so.4
#15 0x7f3951664fcb in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointerQWidget, bool) () from
/usr/lib/libQtGui.so.4
#16 0x7f39516dfad4 in ?? () from /usr/lib/libQtGui.so.4
#17 0x7f39516de861 in QApplication::x11ProcessEvent(_XEvent*) () from
/usr/lib/libQtGui.so.4
#18 0x7f3951704a22 in ?? () from /usr/lib/libQtGui.so.4
#19 0x7f394cf0b845 in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#20 0x7f394cf0bb78 in ?? () from /usr/lib/libglib-2.0.so.0
#21 0x7f394cf0bc34 in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#22 0x7f3950c9bb66 in
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) ()
from /usr/lib/libQtCore.so.4
#23 0x7f395170469e in ?? () from /usr/lib/libQtGui.so.4
#24 0x7f3950c6c3ff in
QEventLoop::processEvents(QFlagsQEventLoop::ProcessEventsFlag) () from
/usr/lib/libQtCore.so.4
#25 0x7f3950c6c688 in
QEventLoop::exec(QFlagsQEventLoop::ProcessEventsFlag) () from
/usr/lib/libQtCore.so.4
#26 0x7f3951b18758 in QDialog::exec() () from /usr/lib/libQtGui.so.4
#27 0x7f39418da29e in ?? () from /usr/lib/kde4/okularpart.so
#28 0x7f39419150db in ?? () from /usr/lib/kde4/okularpart.so
#29 0x7f39516b3a30 in QWidget::event(QEvent*) () from
/usr/lib/libQtGui.so.4
#30 0x7f3951a5ed36 in QFrame::event(QEvent*) () from /usr/lib/libQtGui.so.4
#31 0x7f394190633d in ?? () from /usr/lib/kde4/okularpart.so
#32 0x7f3950c6d816 in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /usr/lib/libQtCore.so.4
#33 0x7f395166415c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib/libQtGui.so.4
#34 0x7f3951668e6b in QApplication::notify(QObject*, QEvent*) () from
/usr/lib/libQtGui.so.4
#35 0x7f3952382426 in KApplication::notify(QObject*, QEvent*) () from
/usr/lib/libkdeui.so.5
#36 0x7f3950c6d6ae in QCoreApplication::notifyInternal(QObject*, QEvent*)
() from /usr/lib/libQtCore.so.4
#37 0x7f3951664fcb in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointerQWidget, bool) () from
/usr/lib/libQtGui.so.4
#38 0x7f39516dfad4 in ?? () from /usr/lib/libQtGui.so.4
#39 0x7f39516de861 in QApplication::x11ProcessEvent(_XEvent*) () from
/usr/lib/libQtGui.so.4
#40 0x7f3951704a22 in ?? () from /usr/lib/libQtGui.so.4
#41 0x7f394cf0b845 in g_main_context_dispatch () from
/usr/lib/libglib-2.0.so.0
#42 0x7f394cf0bb78 in ?? () from /usr/lib/libglib-2.0.so.0
#43 0x7f394cf0bc34 in g_main_context_iteration () from
/usr/lib/libglib-2.0.so.0
#44 0x7f3950c9bb66 in
QEventDispatcherGlib::processEvents(QFlagsQEventLoop::ProcessEventsFlag) ()
from /usr/lib/libQtCore.so.4
#45 0x7f395170469e in ?? () from /usr/lib/libQtGui.so.4
#46 0x7f3950c6c3ff in

[Okular-devel] [okular] [Bug 315703] Zoom, Selection, Text Selection (and possibly other) tools not working in 0.16.0 KDE 4.10 Kubuntu 12.04

2013-02-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315703

--- Comment #3 from Albert Astals Cid aa...@kde.org ---
Do you think you could record a screen capture of what you are exactly doing
(with recordmydesktop or similar tools) to see it live?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-27 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28230
---



part.cpp
http://git.reviewboard.kde.org/r/109096/#comment21097

Why are you using invokeMethod here?



shell/main.cpp
http://git.reviewboard.kde.org/r/109096/#comment21098

Why are those here? Seems to me you are trying to fix multiple things in a 
same review, this is a bad idea, actually you shouldn't even implement print 
and noraise in the same review, one review per feature is better, allows 
smaller and self-contained commits to be done.


- Albert Astals Cid


On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109096/
 ---
 
 (Updated Feb. 24, 2013, 3:01 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Added command line options print. Bug 252462
 
 
 This addresses bugs 252462 and 315538.
 http://bugs.kde.org/show_bug.cgi?id=252462
 http://bugs.kde.org/show_bug.cgi?id=315538
 
 
 Diffs
 -
 
   kdocumentviewer.h 2f77610 
   part.h e3a9418 
   part.cpp f1cdc11 
   shell/main.cpp 226dab8 
   shell/shell.cpp 81d63c2 
 
 Diff: http://git.reviewboard.kde.org/r/109096/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tomáš Poledný
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315878] crashed when on an inline note - clicked out of the popup

2013-02-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315878

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Albert Astals Cid aa...@kde.org ---


*** This bug has been marked as a duplicate of bug 313984 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109119: Txt backend: Drop detectEncoding method and just feed more data to KEncodingProber

2013-02-27 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109119/#review28231
---


Code looks, ok, but now the big question, is this really an improvement? I 
guess the only improvement would be speed-wise and not encoding-detection-wise. 
Have you opened really big files and noticed it is faster? Otherwise maybe 
there is no really need to change the existing code if it works as well?

- Albert Astals Cid


On Feb. 25, 2013, 8:15 p.m., Azat Khuzhin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109119/
 ---
 
 (Updated Feb. 25, 2013, 8:15 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Don't to extra job, when encoding is detected just return encoding.
 
 
 Diffs
 -
 
   generators/txt/document.h 08babea 
   generators/txt/document.cpp badb647 
 
 Diff: http://git.reviewboard.kde.org/r/109119/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Azat Khuzhin
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315842] Okular crashes randomly when printing the second time

2013-02-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=315842

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Albert Astals Cid aa...@kde.org ---


*** This bug has been marked as a duplicate of bug 199780 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-27 Thread Tomáš Poledný

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28234
---



part.cpp
http://git.reviewboard.kde.org/r/109096/#comment21100

I'm sorry my fault. I was not thinking about it. Calling method is better. 
I hope that now everything will be okay.



shell/main.cpp
http://git.reviewboard.kde.org/r/109096/#comment21099

Ok I will make 3 different review request. Sorry for that. Lessons learned 
for next time.


- Tomáš Poledný


On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109096/
 ---
 
 (Updated Feb. 24, 2013, 3:01 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Added command line options print. Bug 252462
 
 
 This addresses bugs 252462 and 315538.
 http://bugs.kde.org/show_bug.cgi?id=252462
 http://bugs.kde.org/show_bug.cgi?id=315538
 
 
 Diffs
 -
 
   kdocumentviewer.h 2f77610 
   part.h e3a9418 
   part.cpp f1cdc11 
   shell/main.cpp 226dab8 
   shell/shell.cpp 81d63c2 
 
 Diff: http://git.reviewboard.kde.org/r/109096/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tomáš Poledný
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109096: Open print dialog from command line

2013-02-27 Thread Tomáš Poledný


 On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote:
  part.cpp, line 1322
  http://git.reviewboard.kde.org/r/109096/diff/3/?file=115231#file115231line1322
 
  Why are you using invokeMethod here?

I'm sorry my fault. I was not thinking about it. Calling method is better. I 
hope that now everything will be okay.


 On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote:
  shell/main.cpp, line 34
  http://git.reviewboard.kde.org/r/109096/diff/3/?file=115232#file115232line34
 
  Why are those here? Seems to me you are trying to fix multiple things 
  in a same review, this is a bad idea, actually you shouldn't even implement 
  print and noraise in the same review, one review per feature is better, 
  allows smaller and self-contained commits to be done.

Ok I will make 3 different review request. Sorry for that. Lessons learned for 
next time.


- Tomáš


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109096/#review28230
---


On Feb. 27, 2013, 11:58 p.m., Tomáš Poledný wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109096/
 ---
 
 (Updated Feb. 27, 2013, 11:58 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Added command line options print. Bug 252462
 
 
 This addresses bug 252462.
 http://bugs.kde.org/show_bug.cgi?id=252462
 
 
 Diffs
 -
 
   kdocumentviewer.h 2f77610 
   part.h 2fcdf0a 
   part.cpp 912716a 
   shell/main.cpp 226dab8 
   shell/shell.cpp 81d63c2 
 
 Diff: http://git.reviewboard.kde.org/r/109096/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tomáš Poledný
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 315883] New: Hyperlinks are not active in PDF

2013-02-27 Thread Jacquemin
https://bugs.kde.org/show_bug.cgi?id=315883

Bug ID: 315883
   Summary: Hyperlinks are not active in PDF
Classification: Unclassified
   Product: okular
   Version: 0.15.5
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: b_jacque...@yahoo.fr

Hyperlinks in PDF cannot be used (or cliqued), although they work in other
softs like Adobe Reader, no matter what the creator of the pdf doc is (LaTeX
and dvi2pdf or dvi2ps and ps2pdf. PDFLaTeX. OpenOffice. LibreOffice...).

Reproducible: Always

Steps to Reproduce:
1. Open a PDF with an active hyperlink
2. Clic on the link
3. Nothing happens (and the mouse pointer tries to select text)
Actual Results:  
No résult

Expected Results:  
Opening (or trying to open) a web browser

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel