Re: [Okular-devel] Review Request 108614: Open url in browser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated March 9, 2013, 8:13 p.m.) Review request for Okular. Changes --- How about this? Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. pdf with links update : http://goo.gl/wBM6p This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs (updated) - ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 103060: Implement the handling of page rotations for source references
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103060/#review28844 --- Michel, do you think you could have a look at the tests/ folder and try to come up with something that exercises this patch to prove it works? I'd be much happier with a unit test, since i have to be honest i am not really sure what we are trying to achieve here so if in the future it breaks having a unittest will be much easier to bring back the expected feature :-) - Albert Astals Cid On Feb. 2, 2013, 8:47 p.m., Michel Ludwig wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103060/ > --- > > (Updated Feb. 2, 2013, 8:47 p.m.) > > > Review request for Okular. > > > Description > --- > > Implement the handling of page rotations for source references. > > > Diffs > - > > core/document.h 1d825e1 > core/document.cpp 372af56 > core/page.h 6bc60c5 > core/page.cpp 4df58e0 > core/utils.h 8d5d5fc > core/utils.cpp 5dd8448 > generators/dvi/generator_dvi.cpp c666933 > generators/poppler/generator_pdf.cpp 0b2c253 > part.cpp f1cdc11 > ui/pagepainter.cpp 91ae211 > ui/pageview.h d8a7653 > ui/pageview.cpp 60a273d > ui/side_reviews.cpp a35f9ed > ui/thumbnaillist.cpp 33a5431 > > Diff: http://git.reviewboard.kde.org/r/103060/diff/ > > > Testing > --- > > > File Attachments > > > Example LaTeX File > http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.tex > Example PDF File > http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.pdf > Example SyncTeX File > > http://git.reviewboard.kde.org/media/uploaded/files/2011/11/08/test.synctex.gz > > > Thanks, > > Michel Ludwig > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/#review28843 --- I am not sure this is the totally correct fix (I'm not saying the code we have now is better). But i do have here epubs that set the color of the text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in case my i would get black on black :-/ On the other hand i see the problem the reporter is having. OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 seems it is declaring it wants its background to be white, wonder why we are not getting it white then :S Do yo have time to investigate why this is happening? Because it we commit this patch directly i feel it would be going from one bug to another, and not sure it makes much sense - Albert Astals Cid On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109364/ > --- > > (Updated March 8, 2013, 11:38 p.m.) > > > Review request for Okular. > > > Description > --- > > Instead of just force it to white. > > This must fix bug 306572. > https://bugs.kde.org/show_bug.cgi?id=306572 > > > This addresses bug 306572. > http://bugs.kde.org/show_bug.cgi?id=306572 > > > Diffs > - > > core/textdocumentgenerator.cpp f370ded > > Diff: http://git.reviewboard.kde.org/r/109364/diff/ > > > Testing > --- > > > Thanks, > > Azat Khuzhin > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109363: Command line argument noraise
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109363/#review28841 --- This review has been submitted with commit 618e320a77106a96cf11fb59d1cec7b303aa177b by Albert Astals Cid on behalf of Tomáš Poledný to branch master. - Commit Hook On March 8, 2013, 7:55 p.m., Tomáš Poledný wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109363/ > --- > > (Updated March 8, 2013, 7:55 p.m.) > > > Review request for Okular. > > > Description > --- > > This path add new command line argument noraise. Window will not be raised > with argument noraise. > > > This addresses bug 315538. > http://bugs.kde.org/show_bug.cgi?id=315538 > > > Diffs > - > > shell/main.cpp 226dab8 > shell/shell.h 270c190 > shell/shell.cpp 81d63c2 > > Diff: http://git.reviewboard.kde.org/r/109363/diff/ > > > Testing > --- > > I tried: > okular > okular -noraise > okular -noraise file_exist.pdf > okular -noraise file_not_exist > okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --noraise > okular https://nonexisturl --noraise > okular -unique -noraise file_exist.pdf > okular -unique -noraise file_exist.pdf && okular -unique file_exist2.pdf > okular -unique -noraise file_exist.pdf file_exist2.pdf > okular -unique file.pdf && okular -unique -noraise file2.pdf > okular -unique -noraise file.pdf && okular -unique file2.pdf > > > Thanks, > > Tomáš Poledný > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315538] okular --unique *does* raise its existing window
https://bugs.kde.org/show_bug.cgi?id=315538 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In||4.11.0 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/618e320a77106a96cf11fb59 ||d1cec7b303aa177b --- Comment #3 from Albert Astals Cid --- Git commit 618e320a77106a96cf11fb59d1cec7b303aa177b by Albert Astals Cid, on behalf of Tomáš Poledný. Committed on 09/03/2013 at 16:34. Pushed by aacid into branch 'master'. Add command line argument noraise This path add new command line argument noraise. Window will not be raised with argument noraise. I tried: okular okular -noraise okular -noraise file_exist.pdf okular -noraise file_not_exist okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --noraise okular https://nonexisturl --noraise okular -unique -noraise file_exist.pdf okular -unique -noraise file_exist.pdf && okular -unique file_exist2.pdf okular -unique -noraise file_exist.pdf file_exist2.pdf okular -unique file.pdf && okular -unique -noraise file2.pdf okular -unique -noraise file.pdf && okular -unique file2.pdf REVIEW: 109363 FIXED-IN: 4.11.0 M +4-1shell/main.cpp M +5-0shell/shell.cpp http://commits.kde.org/okular/618e320a77106a96cf11fb59d1cec7b303aa177b -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/ --- Review request for Okular. Description --- Instead of just force it to white. This must fix bug 306572. https://bugs.kde.org/show_bug.cgi?id=306572 This addresses bug 306572. http://bugs.kde.org/show_bug.cgi?id=306572 Diffs - core/textdocumentgenerator.cpp f370ded Diff: http://git.reviewboard.kde.org/r/109364/diff/ Testing --- Thanks, Azat Khuzhin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
