[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Nicolas Bigaouette
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #13 from Nicolas Bigaouette  ---
Created attachment 77932
  --> https://bugs.kde.org/attachment.cgi?id=77932&action=edit
`kde4-config --localprefix`/share/apps/okular/docdata file

Note: The full file name is:
694554.2012_Moll et al._Inverse bremsstrahlung heating beyond the first Born
approximation for dense plasmas in laser fields.pdf.xml
But I had trouble opening the file. less complained it couldn't open the
different words as files, even if the filename was quoted or the spaces
escaped...

I was able to open it through kate and copy its content elsewhere. This is what
I'm attaching.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Nicolas Bigaouette
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #12 from Nicolas Bigaouette  ---
Created attachment 77931
  --> https://bugs.kde.org/attachment.cgi?id=77931&action=edit
`kde4-config --localprefix`/share/config/okularpartrc (sanitized)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Nicolas Bigaouette
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #11 from Nicolas Bigaouette  ---
Created attachment 77930
  --> https://bugs.kde.org/attachment.cgi?id=77930&action=edit
`kde4-config --localprefix`/share/config/okularrc (sanitized)

I'm attaching the (sanitized) files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 79753] Can't see any in pdf files

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=79753

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 64319] slow to display and fails to print pdf files

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=64319

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #5 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 45255] kghostview does not support links in pdf documents

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=45255

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #5 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 80542] Problem with symlinked PDF's.

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=80542

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 65538] Landscape PDF does not get displayed at all,

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=65538

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 64615] orientation does not work, pgup, pgdn do not work correctly

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=64615

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #3 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 69273] kghostview takes much longer to load a big file than xpdf

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=69273

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #2 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 61922] Some PDF files fail to print

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=61922

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #16 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 94723] trouble showing some pdf's

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=94723

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #11 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 308381] chm with okular and wine

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308381

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 308188] Crash on next page request

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308188

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 308381] chm with okular and wine

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308381

--- Comment #2 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 308188] Crash on next page request

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=308188

--- Comment #2 from Albert Astals Cid  ---
No answer from reporter in a long time, closing down the bug. If you can
provide the information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 307755] Okular se cerro abriendo al pasar de pasar de una pagina determinada en un pdf

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=307755

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
No answer from reporter, closing down the bug. If you can provide the
information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 307804] Okular crashes while trying to open a complex or heavy odp file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=307804

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #2 from Albert Astals Cid  ---
No answer from reporter, closing down the bug. If you can provide the
information we ask for please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #10 from Albert Astals Cid  ---
It's weird how is so easy for you to reproduce and i can't at all. Just to make
sure could you attach your 
`kde4-config --localprefix`/share/config/okularrc
`kde4-config --localprefix`/share/config/okularpartrc
and the file in 
`kde4-config --localprefix`/share/apps/okular/docdata
that corresponds to that file?

Make sure you sanitize them if needed (i.e. maybe remove last opened files and
stuff)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Nicolas Bigaouette
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #9 from Nicolas Bigaouette  ---
I though about this bug report yesterday as it also happened. I just tried it
again and the problem is still present. I'm using 4.10.

The PDF I tried it with is this one, freely available:
http://iopscience.iop.org/1367-2630/14/6/065010

Note that all following tests have been made _without_ trimming margins.

To reproduce, I start at first page. Then I press the right arrow (which I
configured to go to the next page) 8 times. The 8th time, the problem happened.

Sometimes, it's the 15th or 16th time I skip page.

Actually, it might have to do with a page which is not in cache. If I go to the
first page and start to skip pages, the problem will always happen on a page
which seems to load (the pdf is rendered more slowly when the problem happens).
At some point, the whole pdf seems to render faster (its all in a cache
somewhere?) and the problem can't be seen anymore.

It's also possible to reproduce when 2 pages are shown side by side. Again,
once the whole document has been viewed, I can't reproduce it at all, even when
closing the document and reopening it, switching to single page view, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)

2013-03-10 Thread Albert Astals Cid


> On March 9, 2013, 4:12 p.m., Albert Astals Cid wrote:
> > I am not sure this is the totally correct fix (I'm not saying the code we 
> > have now is better). But i do have here epubs that set the color of the 
> > text to black  ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in 
> > case my i would get black on black :-/
> > 
> > On the other hand i see the problem the reporter is having.
> > 
> > OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 
> > seems it is declaring it wants its background to be white, wonder why we 
> > are not getting it white then :S
> > 
> > Do yo have time to investigate why this is happening? Because it we commit 
> > this patch directly i feel it would be going from one bug to another, and 
> > not sure it makes much sense
> 
> Azat Khuzhin wrote:
> I'm working on it, but for now the patch attached here is the simplest 
> way to fix it.
> Because user can change color scheme and read document (background will 
> be changed), instead always white background.
> 
> But for now, I'm trying to extract background from epub documents, and 
> when I do that, I'll upload the patch.
> 
> Azat Khuzhin wrote:
> It seems that we can't extract background color for epub documents (in 
> particular for this one)
> There is no information about background colors.
> 
> We can force text color to opposite (black -> white), but, in my opinion, 
> this is not correct.
> Or we can rewrite epub backend not to use libepub, than, I think, we can 
> get such information.

"user can change color scheme and read document", well they can already do that 
now, no?

"There is no information about background colors." it's there in the CSS we 
pass down to QTextDocument, i guess the question is why that's not working. 

Do you have time to do a simple code check with something like

body {
background-color:#fff;
}

in the css and see if it works? Because that's close to what we are passing 
down to QTextDocument.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review28843
---


On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109364/
> ---
> 
> (Updated March 8, 2013, 11:38 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> Instead of just force it to white.
> 
> This must fix bug 306572.
> https://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> This addresses bug 306572.
> http://bugs.kde.org/show_bug.cgi?id=306572
> 
> 
> Diffs
> -
> 
>   core/textdocumentgenerator.cpp f370ded 
> 
> Diff: http://git.reviewboard.kde.org/r/109364/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Azat Khuzhin
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=316496

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #8 from Albert Astals Cid  ---
I'm going to close the bug i doubt it's our fault. What we do when printing a
pdf file is convert it to ps and send the ps to cups.

With "Print Preview" what you are seeing is the converted ps file, if that
looks correct the problem is somewhere else other than okular, like cups, the
printer drivers or something else.

Sorry we can't help more.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #7 from Valter Mura  ---
And, by the way, the printers worked well when I was on Kubuntu 12.04 on
32-bit.
I changed my system in a 64-bit (with KDE 4.10.1), I don't know if it could be
relevant.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 159601] configurable review tools

2013-03-10 Thread Brallan Aguilar
https://bugs.kde.org/show_bug.cgi?id=159601

Brallan Aguilar  changed:

   What|Removed |Added

 CC||brallanagui...@riseup.net

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #6 from Valter Mura  ---
Yes, it happens with all files, also those different from a fax one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-10 Thread Albert Astals Cid


> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?
> 
> Jaydeep Solanki wrote:
> Yes, because it prevents "asdfhttp://www.google.com"; from getting 
> detected.
> 
> Azat Khuzhin wrote:
> I think that for this it is not necessary.
> Because of "\b" in you first regexp.
> 
> Jaydeep Solanki wrote:
> No.
> '\b' detects word boundry.
> For example, in "asdfhttp://www.google.com";, '/' is not considered as 
> part of a word, so the first 'w' in 'www.' will be considered as boundary, 
> thus detecting 'www.google.com' as a url, which should not be detected.
> A better way to do this is lookbehind assertion, but Qt doesn't support 
> it, so I finally decided to use two regexs.
> 
> Azat Khuzhin wrote:
> Yes, it make sense.
> 
> BTW qt5 support it https://bugreports.qt-project.org/browse/QTBUG-2371.
> Maybe you want to leave a TODO for qt5?
> 
> Jaydeep Solanki wrote:
> Oh, I didn't know that, thanks!
> I'll make sure, this gets improved when kdelibs move to qt5.

Do you think you could implement a unittest (just for the 'static QString 
getUrl' method) like the ones we have in the tests/ folder? Have you ever used 
QtTest? If not drop by #okular and ping me.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28857
---


On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated March 9, 2013, 8:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> pdf with links update : http://goo.gl/wBM6p
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 186531] Trim Margin doesn't work if paper color was set

2013-03-10 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=186531

Jekyll Wu  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #8 from Jekyll Wu  ---
clolse per comment #7

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #5 from Albert Astals Cid  ---
You forgot the first question:
Happens with all files or just one? If just one attach the file.

But given the answers that print to file and print preview work fine i'm going
to blame the drivers of the printer for not, but still can you please answer
the question?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #4 from Valter Mura  ---
Hi Albert,

no, in both cases it does not happen. I get correct copies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=316496

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Albert Astals Cid  ---
Waiting for the info

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #2 from Albert Astals Cid  ---
Happens with all files or just one? If just one attach the file.
Does it happen in print preview?
Does it happen when printing to file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

Valter Mura  changed:

   What|Removed |Added

 CC||valterm...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

--- Comment #1 from Valter Mura  ---
Created attachment 77926
  --> https://bugs.kde.org/attachment.cgi?id=77926&action=edit
printed doc

I attached the printed doc, to show the problem, obviously the original file is
complete.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316496] New: Okular prints out only half page of the pdf fax

2013-03-10 Thread Valter Mura
https://bugs.kde.org/show_bug.cgi?id=316496

Bug ID: 316496
   Summary: Okular prints out only half page of the pdf fax
Classification: Unclassified
   Product: okular
   Version: 0.16.1
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: Fax backend
  Assignee: okular-devel@kde.org
  Reporter: valterm...@gmail.com

When printing with my printer HP C5180, using HPLIP, I always get an corrupted
printing, the documents is printed only for half page.

This does  not occur in Windows environment with the same printer (Adobe
reader, Windows drivers).


Reproducible: Always




HPLIP Software Version: 3.12.6
Device Manager Version: 15.0 (QT4)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 243111] Crash when opening a file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=243111

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 275371] Markups with text do not show the text or leader lines

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=275371

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org,
   ||fabiodu...@hotmail.it
 Ever confirmed|0   |1

--- Comment #2 from Albert Astals Cid  ---
Fabio can you have a look? Almost everything looks right except the "Draft"
thing that seems to be painted twice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 243111] Crash when opening a file

2013-03-10 Thread m.wege
https://bugs.kde.org/show_bug.cgi?id=243111

--- Comment #6 from m.w...@web.de ---
I do not know what file it was and since it is long time ago, I suggest closing
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 243111] Crash when opening a file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=243111

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from Albert Astals Cid  ---
m.w...@web.de waiting for the info i requested in comment #3

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 231135] on page turn the text is blurred despite setting background processing off

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=231135

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |INVALID

--- Comment #2 from Albert Astals Cid  ---
What Pino said, don't see a bug in here

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 225171] [PATCH] return focus to document after closing find bar with close button

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=225171

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Albert Astals Cid  ---
Will, waiting for your updated patch. Also using reviewboard would be a better
idea to be honest

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=205496

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Albert Astals Cid  ---
Nicolas, we made a few fixes in the trim mode, can you please check if you can
still reproduce this bug in okular shipped with KDE 4.10 or newer?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 176780] navigation panel to small for large table of contents

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=176780

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Albert Astals Cid  ---
Do you have such a pdf that needs a that big table of contents? Could you
attach it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 198303] doesn't show anything for a ps.gz file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=198303

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |FIXED

--- Comment #6 from Albert Astals Cid  ---
This should be fixed in Okular shipped with KDE SC >= 4.9.2 Please try there
and make sure it works for you. Sorry it took so long to fix :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 191823] fail while searching, phrase not found -- provide a11y-friendly feedback

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=191823

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Albert Astals Cid  ---
Why is it a no-go from an a11y point of view? The bar changes and you got
nothing selected, i would like to know what you are expecting, and also if you
are really an a11y user or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 307786] Okular reports wrong name for file embedded in PDF

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=307786

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #2 from Albert Astals Cid  ---
No answer from the reporter in a long time, closing down the bug. If you can
provide what we asked for please reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 303809] okular can not find words in dvi file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=303809

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 303809] okular can not find words in dvi file

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=303809

--- Comment #4 from Albert Astals Cid  ---
No answer from the reporter in a long time, closing down the bug. If you can
provide what we asked for please reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 303607] Opening a document

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=303607

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #3 from Albert Astals Cid  ---
Please could you send it to me?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 186531] Trim Margin doesn't work if paper color was set

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=186531

--- Comment #7 from Albert Astals Cid  ---
No answer from the reporter in a long time, closing down the bug. If you can
provide what we asked for please reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 202159] Multiple problems in PDF forms - checkboxes, save as, instant saving

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=202159

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #7 from Albert Astals Cid  ---
Setting back to confirmed as Fabio's comments. Fabio maybe we could extract
what is fixed and what is not and create a new bug? Could you do that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 190731] Okular does not restore left index panel to correct location after restart

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=190731

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||aa...@kde.org
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #3 from Albert Astals Cid  ---
No answer from the reported in a long time, closing down the bug. If you can
provide the answers please reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 310651] DjVu documents blurry at non-unit-fractional zoom levels

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=310651

--- Comment #3 from Albert Astals Cid  ---
To be honest 1) makes more sense to me. Could you contact the djvulibre
developers about it? Seems weird to me they scale twice.

Thanks for the deep analysis :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 261791] Make searching through multiple documents possible

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=261791

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |WONTFIX

--- Comment #1 from Albert Astals Cid  ---
Hi, Okular does not aim to be a "document library" program or similar so we do
not think implementing this feature makes sense from our point of view of what
we want okular to be.

Thanks a lot for caring about Okular and suggesting improvements to it and
sorry we don't agree with your suggested feature :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=249364

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Albert Astals Cid  ---
Any luck?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 182989] "Trim Borders" does not work in presentation mode

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=182989

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Albert Astals Cid  ---
Waiting for an answer

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 229552] "Go to page" should allow relative jumps

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=229552

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Do you know of any software that implements this kind of feature for go to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 188239] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=188239

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Albert Astals Cid  ---
Can you please attach a file with such feature so we can test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 282992] wish: file system browser in sidebar, like Kate

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=282992

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |WONTFIX

--- Comment #1 from Albert Astals Cid  ---
Hi, thanks for making this feature suggestion for Okular but we do not feel
that this addition makes sense to what we want Okular to be so I'm closing down
this bug report.

Thanks for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 293109] Enable form filling in presentation mode

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=293109

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Albert Astals Cid  ---
As stated in comment 2 i don't see why we should provide this feature in
presentation mode, if you can give me a good reason please reopen the bug.

Thanks a lot for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316483] extreme slow down of search in version of wheezy compared to sqeezy

2013-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=316483

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |INVALID

--- Comment #1 from Albert Astals Cid  ---
Dear user, i can not accept a bug against a software that is 2 versions old and
that does not include a pdf to test, please update to the newest version of
okular (0.16.x) and if the slowdown is still reproduceable reopen this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316483] New: extreme slow down of search in version of wheezy compared to sqeezy

2013-03-10 Thread Thomas Zoschke
https://bugs.kde.org/show_bug.cgi?id=316483

Bug ID: 316483
   Summary: extreme slow down of search in version of wheezy
compared to sqeezy
Classification: Unclassified
   Product: okular
   Version: 0.14.3
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: thomaszosc...@aol.com

Dear Maintainer,

Searching (aka. 'Find') a larger pdf-document (1326 pages 11 MB) with a short 
search string from beginning of the document to
the end used to take 22 seconds on my laptop with the squeezy version of okular 
(okular 0.10... debian 4:4.4.5).
After a dist upgrade to debian wheezy (with okular 0.14.3 debian 4:4.8.4) I 
noticed the same search slowed down to somewhat
over a minute. That's a slowdown by almost factor three.
Shouldn't new software generally run faster?
It's annoying as I use searching larger pdfs rather frequently.
I noticed (using xosview) the old okular was running the search on a single CPU 
core while the newer
one is using both CPU cores I have.
This means the total used CPU time increased by factor 6! I understand that 
parallelizing an algorithm some tradeoffs have
to be made, but factor 6 is absolutely unacceptable.
I understand that on an 8 core the new parallelized search might require less 
wallclock time,
but I  *CANNOT*  accept 'by an 8 core' as a bugfix.

The problem might very well reside in one of okulars library packages.


-- System Information:
Debian Release: 7.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages okular depends on:
ii  kde-runtime   4:4.8.4-2
ii  libc6 2.13-38
ii  libfreetype6  2.4.9-1.1
ii  libjpeg8  8d-1
ii  libkdecore5   4:4.8.4-4
ii  libkdeui5 4:4.8.4-4
ii  libkio5   4:4.8.4-4
ii  libkparts44:4.8.4-4
ii  libkprintutils4   4:4.8.4-4
ii  libkpty4  4:4.8.4-4
ii  libokularcore14:4.8.4-3+b1
ii  libphonon44:4.6.0.0-3
ii  libpoppler-qt4-3  0.18.4-5
ii  libqca2   2.0.3-4
ii  libqimageblitz4   1:0.0.6-4
ii  libqt4-dbus   4:4.8.2+dfsg-11
ii  libqt4-svg4:4.8.2+dfsg-11
ii  libqt4-xml4:4.8.2+dfsg-11
ii  libqtcore44:4.8.2+dfsg-11
ii  libqtgui4 4:4.8.2+dfsg-11
ii  libsolid4 4:4.8.4-4
ii  libspectre1   0.2.7-2
ii  libstdc++64.7.2-5
ii  phonon4:4.6.0.0-3
ii  zlib1g1:1.2.7.dfsg-13


Reproducible: Always

Steps to Reproduce:
1. Open a large PDF document, say ISO C++ 2011 standard as PDF.
2. Type Ctrl+F to start a search.
3. Enter a search string that will run thru the hole document, say 'grumpf'.
Actual Results:  
see 'Details'

Expected Results:  
see 'Details'

see 'Details'

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-10 Thread Jaydeep Solanki


> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?
> 
> Jaydeep Solanki wrote:
> Yes, because it prevents "asdfhttp://www.google.com"; from getting 
> detected.
> 
> Azat Khuzhin wrote:
> I think that for this it is not necessary.
> Because of "\b" in you first regexp.
> 
> Jaydeep Solanki wrote:
> No.
> '\b' detects word boundry.
> For example, in "asdfhttp://www.google.com";, '/' is not considered as 
> part of a word, so the first 'w' in 'www.' will be considered as boundary, 
> thus detecting 'www.google.com' as a url, which should not be detected.
> A better way to do this is lookbehind assertion, but Qt doesn't support 
> it, so I finally decided to use two regexs.
> 
> Azat Khuzhin wrote:
> Yes, it make sense.
> 
> BTW qt5 support it https://bugreports.qt-project.org/browse/QTBUG-2371.
> Maybe you want to leave a TODO for qt5?

Oh, I didn't know that, thanks!
I'll make sure, this gets improved when kdelibs move to qt5.


- Jaydeep


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28857
---


On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated March 9, 2013, 8:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> pdf with links update : http://goo.gl/wBM6p
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-10 Thread Jaydeep Solanki


> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?
> 
> Jaydeep Solanki wrote:
> Yes, because it prevents "asdfhttp://www.google.com"; from getting 
> detected.
> 
> Azat Khuzhin wrote:
> I think that for this it is not necessary.
> Because of "\b" in you first regexp.

No.
'\b' detects word boundry.
For example, in "asdfhttp://www.google.com";, '/' is not considered as part of a 
word, so the first 'w' in 'www.' will be considered as boundary, thus detecting 
'www.google.com' as a url, which should not be detected.
A better way to do this is lookbehind assertion, but Qt doesn't support it, so 
I finally decided to use two regexs.


- Jaydeep


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28857
---


On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated March 9, 2013, 8:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> pdf with links update : http://goo.gl/wBM6p
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-10 Thread Jaydeep Solanki


> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote:
> > Seems more appropriate for me. But one more thing, is reg1 still needed?

Yes, because it prevents "asdfhttp://www.google.com"; from getting detected.


- Jaydeep


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review28857
---


On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated March 9, 2013, 8:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> pdf with links update : http://goo.gl/wBM6p
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp b018dfe 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel