[Okular-devel] [okular] [Bug 186531] Trim Margin doesn't work if paper color was set
https://bugs.kde.org/show_bug.cgi?id=186531
--- Comment #9 from Marius Kotsbak mar...@kotsbak.com ---
What do you think about this then:
I confirmed this is the case, so ... there's this function isWhite in
utils.cpp which isn't used anywhere else than in Utils::imageBoundingBox.
I modified it from
inline static bool isWhite( QRgb argb ) {
return ( argb 0xFF ) == 0xFF; // ignore alpha
}
to
inline static bool isPaperColor( QRgb argb ) {
return (argb 0xFF) == (Settings::paperColor().rgb() 0xFF);
}
(obviously had to include settings.h)
and now it works.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 65538] Landscape PDF does not get displayed at all,
https://bugs.kde.org/show_bug.cgi?id=65538 Lars Heineken lars.heine...@gmx.de changed: What|Removed |Added Resolution|INVALID |REMIND --- Comment #5 from Lars Heineken lars.heine...@gmx.de --- Back from the grave :-) The file is now available for download at this location: http://lln.homelinux.net/~lars/IPv6.pdf -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 65538] Landscape PDF does not get displayed at all,
https://bugs.kde.org/show_bug.cgi?id=65538 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|REMIND |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 65538] Landscape PDF does not get displayed at all,
https://bugs.kde.org/show_bug.cgi?id=65538 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #6 from Albert Astals Cid aa...@kde.org --- Can you please describe what problem exactly are you having with the file when opening it with okular and which version of okular? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 65538] Landscape PDF does not get displayed at all,
https://bugs.kde.org/show_bug.cgi?id=65538 Lars Heineken lars.heine...@gmx.de changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |FIXED --- Comment #7 from Lars Heineken lars.heine...@gmx.de --- Just tested with Version 0.14.3 (KDE Development Platform 4.8.5 (4.8.5)) and it works fine. The report can be closed. PS: I switched from KDE to Gnome a few years ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 188239] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight
https://bugs.kde.org/show_bug.cgi?id=188239 --- Comment #4 from Frédéric COIFFIER frederic.coiff...@free.fr --- Created attachment 77951 -- https://bugs.kde.org/attachment.cgi?id=77951action=edit TwoColumnLeft layout example -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 188239] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight
https://bugs.kde.org/show_bug.cgi?id=188239 --- Comment #5 from Frédéric COIFFIER frederic.coiff...@free.fr --- Created attachment 77952 -- https://bugs.kde.org/attachment.cgi?id=77952action=edit TwoColumnRight layout example -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 188239] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight
https://bugs.kde.org/show_bug.cgi?id=188239 Frédéric COIFFIER frederic.coiff...@free.fr changed: What|Removed |Added CC||frederic.coiff...@free.fr --- Comment #6 from Frédéric COIFFIER frederic.coiff...@free.fr --- These two files can be tested with Adobe Reader. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 159601] configurable review tools
https://bugs.kde.org/show_bug.cgi?id=159601 Marcin Szamotulski msza...@accorda-institute.org changed: What|Removed |Added CC||mszamot@accorda-institute.o ||rg -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316549] New: Undo and save problem
https://bugs.kde.org/show_bug.cgi?id=316549 Bug ID: 316549 Summary: Undo and save problem Classification: Unclassified Product: okular Version: 0.14.3 Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: hamid.fe...@gmail.com There is a constraint of not being able to undo your last actions (eg highlighting etc.). The other major and more important problem is that the changes made to the document are instantanously saved!! This means you ought to think twice before performing every single action! Another point to be mentioned is that the color of the highlighting and other commenting tools cannot be changed. One last thing to be considered is that each time you want to highlight (or use any other tool for commenting) you have to click to choose the tool from the pane which makes it tedious. Afterall I made these comments since I found your great pdf browser one of the bests available for Ubuntu. There will be no need to mentioned that all the points stated here are initiated with compared to the most popular pdf browsers available for windlows. Thank you in advance Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote: Seems more appropriate for me. But one more thing, is reg1 still needed? Jaydeep Solanki wrote: Yes, because it prevents asdfhttp://www.google.com; from getting detected. I think that for this it is not necessary. Because of \b in you first regexp. - Azat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review28857 --- On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated March 9, 2013, 8:13 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. pdf with links update : http://goo.gl/wBM6p This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
On March 9, 2013, 4:12 p.m., Albert Astals Cid wrote: I am not sure this is the totally correct fix (I'm not saying the code we have now is better). But i do have here epubs that set the color of the text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in case my i would get black on black :-/ On the other hand i see the problem the reporter is having. OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 seems it is declaring it wants its background to be white, wonder why we are not getting it white then :S Do yo have time to investigate why this is happening? Because it we commit this patch directly i feel it would be going from one bug to another, and not sure it makes much sense I'm working on it, but for now the patch attached here is the simplest way to fix it. Because user can change color scheme and read document (background will be changed), instead always white background. But for now, I'm trying to extract background from epub documents, and when I do that, I'll upload the patch. - Azat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/#review28843 --- On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/ --- (Updated March 8, 2013, 11:38 p.m.) Review request for Okular. Description --- Instead of just force it to white. This must fix bug 306572. https://bugs.kde.org/show_bug.cgi?id=306572 This addresses bug 306572. http://bugs.kde.org/show_bug.cgi?id=306572 Diffs - core/textdocumentgenerator.cpp f370ded Diff: http://git.reviewboard.kde.org/r/109364/diff/ Testing --- Thanks, Azat Khuzhin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 108614: Open url in browser
On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote: Seems more appropriate for me. But one more thing, is reg1 still needed? Jaydeep Solanki wrote: Yes, because it prevents asdfhttp://www.google.com; from getting detected. Azat Khuzhin wrote: I think that for this it is not necessary. Because of \b in you first regexp. Jaydeep Solanki wrote: No. '\b' detects word boundry. For example, in asdfhttp://www.google.com;, '/' is not considered as part of a word, so the first 'w' in 'www.' will be considered as boundary, thus detecting 'www.google.com' as a url, which should not be detected. A better way to do this is lookbehind assertion, but Qt doesn't support it, so I finally decided to use two regexs. Yes, it make sense. BTW qt5 support it https://bugreports.qt-project.org/browse/QTBUG-2371. Maybe you want to leave a TODO for qt5? - Azat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review28857 --- On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/ --- (Updated March 9, 2013, 8:13 p.m.) Review request for Okular. Description --- When selected text is right clicked, it checks for a url, if found, a QAction is added to open the url in the default browser. pdf with links update : http://goo.gl/wBM6p This addresses bug 281027. http://bugs.kde.org/show_bug.cgi?id=281027 Diffs - ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
On March 9, 2013, 4:12 p.m., Albert Astals Cid wrote: I am not sure this is the totally correct fix (I'm not saying the code we have now is better). But i do have here epubs that set the color of the text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in case my i would get black on black :-/ On the other hand i see the problem the reporter is having. OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 seems it is declaring it wants its background to be white, wonder why we are not getting it white then :S Do yo have time to investigate why this is happening? Because it we commit this patch directly i feel it would be going from one bug to another, and not sure it makes much sense Azat Khuzhin wrote: I'm working on it, but for now the patch attached here is the simplest way to fix it. Because user can change color scheme and read document (background will be changed), instead always white background. But for now, I'm trying to extract background from epub documents, and when I do that, I'll upload the patch. It seems that we can't extract background color for epub documents (in particular for this one) There is no information about background colors. We can force text color to opposite (black - white), but, in my opinion, this is not correct. Or we can rewrite epub backend not to use libepub, than, I think, we can get such information. - Azat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/#review28843 --- On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109364/ --- (Updated March 8, 2013, 11:38 p.m.) Review request for Okular. Description --- Instead of just force it to white. This must fix bug 306572. https://bugs.kde.org/show_bug.cgi?id=306572 This addresses bug 306572. http://bugs.kde.org/show_bug.cgi?id=306572 Diffs - core/textdocumentgenerator.cpp f370ded Diff: http://git.reviewboard.kde.org/r/109364/diff/ Testing --- Thanks, Azat Khuzhin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
On March 9, 2013, 4:12 p.m., Albert Astals Cid wrote:
I am not sure this is the totally correct fix (I'm not saying the code we
have now is better). But i do have here epubs that set the color of the
text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in
case my i would get black on black :-/
On the other hand i see the problem the reporter is having.
OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488
seems it is declaring it wants its background to be white, wonder why we
are not getting it white then :S
Do yo have time to investigate why this is happening? Because it we commit
this patch directly i feel it would be going from one bug to another, and
not sure it makes much sense
Azat Khuzhin wrote:
I'm working on it, but for now the patch attached here is the simplest
way to fix it.
Because user can change color scheme and read document (background will
be changed), instead always white background.
But for now, I'm trying to extract background from epub documents, and
when I do that, I'll upload the patch.
Azat Khuzhin wrote:
It seems that we can't extract background color for epub documents (in
particular for this one)
There is no information about background colors.
We can force text color to opposite (black - white), but, in my opinion,
this is not correct.
Or we can rewrite epub backend not to use libepub, than, I think, we can
get such information.
Albert Astals Cid wrote:
user can change color scheme and read document, well they can already
do that now, no?
There is no information about background colors. it's there in the CSS
we pass down to QTextDocument, i guess the question is why that's not
working.
Do you have time to do a simple code check with something like
body {
background-color:#fff;
}
in the css and see if it works? Because that's close to what we are
passing down to QTextDocument.
Azat Khuzhin wrote:
- well they can already do that now, no?
Sure they do, but, the background always be white, without this patch.
I've already tested this, and background-color property is not presented
in output QTextDocument::toHtml()
epub_get_iterator() returns *.html pages, without *.css files
- Azat
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review28843
---
On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/
---
(Updated March 8, 2013, 11:38 p.m.)
Review request for Okular.
Description
---
Instead of just force it to white.
This must fix bug 306572.
https://bugs.kde.org/show_bug.cgi?id=306572
This addresses bug 306572.
http://bugs.kde.org/show_bug.cgi?id=306572
Diffs
-
core/textdocumentgenerator.cpp f370ded
Diff: http://git.reviewboard.kde.org/r/109364/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 186531] Trim Margin doesn't work if paper color was set
https://bugs.kde.org/show_bug.cgi?id=186531 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID |--- Ever confirmed|0 |1 --- Comment #10 from Albert Astals Cid aa...@kde.org --- You see, was it that hard posting it here instead of forcing us to go to a bugtracker that does not have anything to do with KDE? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 186531] [JJ] Trim Margin doesn't work if paper color was set
https://bugs.kde.org/show_bug.cgi?id=186531 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Keywords||junior-jobs Summary|Trim Margin doesn't work if |[JJ] Trim Margin doesn't |paper color was set |work if paper color was set -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 188239] [JJ] Okular doesn't follow PageLayout TwoColumnLeft and TwoColumnRight
https://bugs.kde.org/show_bug.cgi?id=188239 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Keywords||junior-jobs Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- Summary|Okular doesn't follow |[JJ] Okular doesn't follow |PageLayout TwoColumnLeft|PageLayout TwoColumnLeft |and TwoColumnRight |and TwoColumnRight Ever confirmed|0 |1 --- Comment #7 from Albert Astals Cid aa...@kde.org --- Thanks :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316496] Okular prints out only half page of the pdf fax
https://bugs.kde.org/show_bug.cgi?id=316496 --- Comment #9 from Valter Mura valterm...@gmail.com --- Yes, I agree with you. Perhaps it is way the cups/hplip driver communicates with the printer. The strange thing is that, for example, if I print an odt file (LibreOffice), I get the correct printout. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316549] Undo and save problem
https://bugs.kde.org/show_bug.cgi?id=316549 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||aa...@kde.org Resolution|--- |INVALID --- Comment #1 from Albert Astals Cid aa...@kde.org --- Hi, thanks a lot for your comments but I am going to close your bug as invalid. Let me explain why. In this bug you are commenting about lots of various things, hability to undo, hability to change the color of highlighting, hability to save, etc, all of them separate one to another so having all of them together in a single bug report makes it very hard for us to properly assign bugs to people and properly decide when a bug is fixed or not since when too many things are mixed is hard to keep track of them. So I am suggesting you to have a look at https://bugs.kde.org/buglist.cgi?query_format=advancedlist_id=550149bug_status=UNCONFIRMEDbug_status=CONFIRMEDbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDSINFOproduct=okular for the existing bugs/wishes against okular, for the ones that exist for things you are asking (like undo), you should subscribe and vote for them, for the ones that do not exist you should file one bug for each so we can track them properly. Thanks for caring about Okular :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 205496] Okular's Advance to the next page jumps to middle of next page
https://bugs.kde.org/show_bug.cgi?id=205496 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #14 from Albert Astals Cid aa...@kde.org --- Files provided, setting back to unconfirmed -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 205496] Okular's Advance to the next page jumps to middle of next page
https://bugs.kde.org/show_bug.cgi?id=205496 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Version|0.9 |0.16.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 205496] Okular's Advance to the next page jumps to middle of next page
https://bugs.kde.org/show_bug.cgi?id=205496 --- Comment #15 from Albert Astals Cid aa...@kde.org --- Nah, can't still reproduce :-/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109364: Get background color from KColorScheme (kde system settings)
On March 9, 2013, 4:12 p.m., Albert Astals Cid wrote:
I am not sure this is the totally correct fix (I'm not saying the code we
have now is better). But i do have here epubs that set the color of the
text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in
case my i would get black on black :-/
On the other hand i see the problem the reporter is having.
OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488
seems it is declaring it wants its background to be white, wonder why we
are not getting it white then :S
Do yo have time to investigate why this is happening? Because it we commit
this patch directly i feel it would be going from one bug to another, and
not sure it makes much sense
Azat Khuzhin wrote:
I'm working on it, but for now the patch attached here is the simplest
way to fix it.
Because user can change color scheme and read document (background will
be changed), instead always white background.
But for now, I'm trying to extract background from epub documents, and
when I do that, I'll upload the patch.
Azat Khuzhin wrote:
It seems that we can't extract background color for epub documents (in
particular for this one)
There is no information about background colors.
We can force text color to opposite (black - white), but, in my opinion,
this is not correct.
Or we can rewrite epub backend not to use libepub, than, I think, we can
get such information.
Albert Astals Cid wrote:
user can change color scheme and read document, well they can already
do that now, no?
There is no information about background colors. it's there in the CSS
we pass down to QTextDocument, i guess the question is why that's not
working.
Do you have time to do a simple code check with something like
body {
background-color:#fff;
}
in the css and see if it works? Because that's close to what we are
passing down to QTextDocument.
Azat Khuzhin wrote:
- well they can already do that now, no?
Sure they do, but, the background always be white, without this patch.
I've already tested this, and background-color property is not presented
in output QTextDocument::toHtml()
Azat Khuzhin wrote:
epub_get_iterator() returns *.html pages, without *.css files
Have a look at EpubDocument::loadResource
- Albert
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/#review28843
---
On March 8, 2013, 11:38 p.m., Azat Khuzhin wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109364/
---
(Updated March 8, 2013, 11:38 p.m.)
Review request for Okular.
Description
---
Instead of just force it to white.
This must fix bug 306572.
https://bugs.kde.org/show_bug.cgi?id=306572
This addresses bug 306572.
http://bugs.kde.org/show_bug.cgi?id=306572
Diffs
-
core/textdocumentgenerator.cpp f370ded
Diff: http://git.reviewboard.kde.org/r/109364/diff/
Testing
---
Thanks,
Azat Khuzhin
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 252462] Add command line option to print document
https://bugs.kde.org/show_bug.cgi?id=252462 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|CONFIRMED |RESOLVED Version Fixed In||4.11.0 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/5ab30aae15ac69e030695b22 ||a008001426e8cdca --- Comment #2 from Albert Astals Cid aa...@kde.org --- Git commit 5ab30aae15ac69e030695b22a008001426e8cdca by Albert Astals Cid, on behalf of Tomáš Poledný. Committed on 11/03/2013 at 22:52. Pushed by aacid into branch 'master'. Open print dialog from command line REVIEW: 109096 FIXED-IN: 4.11.0 GUI M +17 -1part.cpp M +3-0part.h M +3-0shell/main.cpp M +6-2shell/shell.cpp http://commits.kde.org/okular/5ab30aae15ac69e030695b22a008001426e8cdca -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review29033 --- This review has been submitted with commit 5ab30aae15ac69e030695b22a008001426e8cdca by Albert Astals Cid on behalf of Tomáš Poledný to branch master. - Commit Hook On March 8, 2013, 8:17 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 8, 2013, 8:17 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 11, 2013, 9:53 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 12, 2013, 1:24 a.m.) Review request for Okular. Changes --- Updates based on Albert's review of version 5 of the patch. Description (updated) --- This patch adds undo/redo support to Okular annotation manipulation commands. Functionality: The following actions can be undone and redone: creation and removal of annotations, editing arbitrary annotation properties, relocating annotations with Ctrl+drag, and editing the text contents of an annotation. This patch does not include support for undoing and redoing editing actions on forms. This addresses bug 177501. http://bugs.kde.org/show_bug.cgi?id=177501 Diffs (updated) - core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/document.h 6ff6536 core/document.cpp 5ab759e core/document_p.h fb3aec6 core/page.cpp 1db2763 part.rc 39c1571 ui/annotationpropertiesdialog.cpp 4b02258 ui/annotwindow.h f7df9f6 ui/annotwindow.cpp c1bafb9 ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/107442/diff/ Testing --- I have tested the undoing and redoing of the specified annotation actions using .dvi and .pdf documents. The only known issue is the one described above when using .pdf files. Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations
On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: Tried it looks pretty cool :) Some minor comments inline You will need to rebase your patch, there's a small conflict with a change i did in document.cp Thanks a lot for your feedback! These issues will be addressed in version 6 of the patch On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: core/annotations.h, line 676 http://git.reviewboard.kde.org/r/107442/diff/5/?file=111627#file111627line676 Can you please try moving all these protected/private methods to the private classes instead of to the public ones? Good idea, this actually cleaned up the design a bit On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: core/document.h, line 405 http://git.reviewboard.kde.org/r/107442/diff/5/?file=111629#file111629line405 I'd prefer if we passed the newprops instead of the old ones in here so if you can fix editPageAnnotationContents to only need the new ones too, the three functions will be getting the new data we want to apply. Making it easier if someone (like the Okular Active guys) wants to use these functions I modified this method to not require the old properties by adding a map to the DocumentPrivate class to keep track of the old properties. The new properties are extracted from the annotation passed to the method. On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: core/document.h, line 428 http://git.reviewboard.kde.org/r/107442/diff/5/?file=111629#file111629line428 Do we really need to pass new and old data here? Shouldn't we be able to get one of the two from annotation? Modified this method to only input the new contents, cursor position, and anchor position by adding corresponding maps to the DocumentPrivate class to keep track of the old quantities. On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: core/document.cpp, line 2248 http://git.reviewboard.kde.org/r/107442/diff/5/?file=111630#file111630line2248 You can just do emit m_docPriv-m_parent-annotationContentsBlaBla, no need for the intermediate function call Thanks for the tip. Looks like emitting another class's signal is equivalent to calling a protected method on the class so I needed to make EditAnnotationContentsCommand a friend of Document to make this work. On March 7, 2013, 3:59 p.m., Albert Astals Cid wrote: core/document.cpp, line 2126 http://git.reviewboard.kde.org/r/107442/diff/5/?file=111630#file111630line2126 nitpick, extra space at the end (or missing at the beginning :D not sure what is the file style) Also did some general parenthesis spacing cleanup of this section - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/#review28765 --- On March 12, 2013, 1:24 a.m., Jon Mease wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 12, 2013, 1:24 a.m.) Review request for Okular. Description --- This patch adds undo/redo support to Okular annotation manipulation commands. Functionality: The following actions can be undone and redone: creation and removal of annotations, editing arbitrary annotation properties, relocating annotations with Ctrl+drag, and editing the text contents of an annotation. This patch does not include support for undoing and redoing editing actions on forms. This addresses bug 177501. http://bugs.kde.org/show_bug.cgi?id=177501 Diffs - core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/document.h 6ff6536 core/document.cpp 5ab759e core/document_p.h fb3aec6 core/page.cpp 1db2763 part.rc 39c1571 ui/annotationpropertiesdialog.cpp 4b02258 ui/annotwindow.h f7df9f6 ui/annotwindow.cpp c1bafb9 ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/107442/diff/ Testing --- I have tested the undoing and redoing of the specified annotation actions using .dvi and .pdf documents. The only known issue is the one described above when using .pdf files. Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107442/ --- (Updated March 12, 2013, 1:26 a.m.) Review request for Okular. Changes --- Removed old known issue from the Testing Done description Description --- This patch adds undo/redo support to Okular annotation manipulation commands. Functionality: The following actions can be undone and redone: creation and removal of annotations, editing arbitrary annotation properties, relocating annotations with Ctrl+drag, and editing the text contents of an annotation. This patch does not include support for undoing and redoing editing actions on forms. This addresses bug 177501. http://bugs.kde.org/show_bug.cgi?id=177501 Diffs - core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/document.h 6ff6536 core/document.cpp 5ab759e core/document_p.h fb3aec6 core/page.cpp 1db2763 part.rc 39c1571 ui/annotationpropertiesdialog.cpp 4b02258 ui/annotwindow.h f7df9f6 ui/annotwindow.cpp c1bafb9 ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/107442/diff/ Testing (updated) --- I have tested the undoing and redoing of the specified annotation actions using .dvi and .pdf documents. Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
