[Okular-devel] [okular] [Bug 315703] Zoom, Selection, Text Selection (and possibly other) tools not working in 0.16.0 KDE 4.10 Kubuntu 12.04
https://bugs.kde.org/show_bug.cgi?id=315703 --- Comment #15 from defectosco...@gmail.com --- Thank you for your suggestions, guys. Removing the okularpartrc file seems to have resolved the issue (rather, I simply renamed it). I then tried to check the contents of the renamed file but could not open it without sudo - looks like the owner was set to 'root' for some reason! Not sure if this is related, but I remember Kate giving me errors, something like katerc not writeable. I then changed the owner of the file from 'root' to myself and thus solved the issue. At least Kate cared enough to let me know (: Appreciate your support! -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109627: Outline based selection for annotation elements
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109627/ --- Review request for Okular. Description --- Multiple features in Okular require to determine what object is at a given position. Traditionally, this relied on the bounding boxes of the given object. These do not necessarily correlate with the user would expect (for example, a diagonal line of 1px has a very large bounding box). This patch implementes shape based selection for the following annotation types: Ink, Geometric, Line, Highlight. Other objects default to the old behaviour. Diffs - core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/area.h 4f63759 core/area.cpp d772fc0 core/page.cpp 1db2763 Diff: http://git.reviewboard.kde.org/r/109627/diff/ Testing --- I tested the annotation objects above and a couple of special cases mentioned in the IRC. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- Review request for Okular. Description --- This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316968] Printing a pdf file doesn't add it to the print queue, nor does it generate an error
https://bugs.kde.org/show_bug.cgi?id=316968 --- Comment #4 from Odipides sa0836561...@hotmail.com --- Hi,I've sent a link to an mpeg file I've shared on google drive - you'll be able to see the problem in it's natural habitat. thanksPaul From: aa...@kde.org To: sa0836561...@hotmail.com Subject: [okular] [Bug 316968] Printing a pdf file doesn't add it to the print queue, nor does it generate an error Date: Tue, 19 Mar 2013 19:36:05 + https://bugs.kde.org/show_bug.cgi?id=316968 --- Comment #3 from Albert Astals Cid aa...@kde.org --- Not much logs, i find it really strange you get *nothing*. Does print preview work? Does printing to PDF/PS file work? -- You are receiving this mail because: You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 276042] Okular not zoom to max page dimension when printing
https://bugs.kde.org/show_bug.cgi?id=276042 S sb56...@gmail.com changed: What|Removed |Added CC||sb56...@gmail.com --- Comment #3 from S sb56...@gmail.com --- KDE 4.10.1, still missing this important option. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 185636] More printing options for page control
https://bugs.kde.org/show_bug.cgi?id=185636 S sb56...@gmail.com changed: What|Removed |Added CC||sb56...@gmail.com --- Comment #6 from S sb56...@gmail.com --- KDE 4.10.1, printing odd/even pages seems to be available now, but still no simple and intuitive way to print a range of pages. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109625: Do not re-show tool name in continuous annotation mode
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109625/#review29655 --- Ship it! Looks good - Albert Astals Cid On March 21, 2013, 12:38 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109625/ --- (Updated March 21, 2013, 12:38 a.m.) Review request for Okular. Description --- Right now, the name of the selected annotation tool is re-shown for every stroke in continuous mode. This was probably just an artifact of the implementation but it's IMHO nicer to just show the tool name once. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109625/diff/ Testing --- Local tests show expected behavior. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review29658 --- A few notes: - Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6). - PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ? - I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) - Fabio D'Urso On March 21, 2013, 1:22 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 21, 2013, 1:22 a.m.) Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
On March 21, 2013, 8:11 p.m., Fabio D'Urso wrote: A few notes: - Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6). - PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ? - I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) But you can end one (e.g. a line) - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review29658 --- On March 21, 2013, 1:22 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 21, 2013, 1:22 a.m.) Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 315703] Zoom, Selection, Text Selection (and possibly other) tools not working in 0.16.0 KDE 4.10 Kubuntu 12.04
https://bugs.kde.org/show_bug.cgi?id=315703 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #16 from Albert Astals Cid aa...@kde.org --- PEBKAC -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316968] Printing a pdf file doesn't add it to the print queue, nor does it generate an error
https://bugs.kde.org/show_bug.cgi?id=316968 --- Comment #5 from Albert Astals Cid aa...@kde.org --- Sure, i never say i did not believe you :-) Ok, found something that should help, please run kdebugdialog, write okular on the search bar, and tick all the okular related entries. Now go to okular and try to print, you should get something like okular(11404)/okular (app) Okular::FilePrinter::doPrintFiles: Executing lpr with arguments (-P, Deskjet-3050A-J611-series, -#1, -J, saro_nocompartir.pdf, -o, media=A4, -o, portrait, -o, sides=one-sided, -o, outputorder=normal, -o, Collate=False, -o, OutputMode=FastDraft, -r, /tmp/kde-tsdgeos/okularm11404.ps) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 316968] Printing a pdf file doesn't add it to the print queue, nor does it generate an error
https://bugs.kde.org/show_bug.cgi?id=316968 --- Comment #6 from Albert Astals Cid aa...@kde.org --- And then i forgot to ask anything. The questions are two :D Do you get anything like that? What exactly? And if you run something like pdftops myfile.pdf myfile.ps and then replicate the command line above changing the /tmp/kde-tsdgeos/okularm11404.ps with myfile.ps does it work? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109627: Outline based selection for annotation elements
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109627/#review29666 --- Quick and mostly stylistic review, had a look at how it works for a line and to be honest i found it a bit hard (i.e. i had to be quite on top of the line) to select it, but i guess it is just a matter of getting used to. I am trying to slowly get new features to come with some kind of tests to make sure stuff does not break. Do you have any knowledge of QTest? Do you think you'd be able to create a test for this? In my mind it would be like * Open pdf * Add annotations of all types * Programatically move the mouse to the locations around the annotations and right click and then check if the menu correctly detects we are on the object or not What do you think? core/annotations.cpp http://git.reviewboard.kde.org/r/109627/#comment22104 Make the function static core/annotations.cpp http://git.reviewboard.kde.org/r/109627/#comment22105 function static and to last param core/annotations.cpp http://git.reviewboard.kde.org/r/109627/#comment22106 please make as many of this vars as you can const core/annotations.cpp http://git.reviewboard.kde.org/r/109627/#comment22107 const for quad core/area.h http://git.reviewboard.kde.org/r/109627/#comment22110 Don't think this belongs to area.h to be honest core/area.h http://git.reviewboard.kde.org/r/109627/#comment22108 Please add @p var in your docu like we do in the other places core/area.h http://git.reviewboard.kde.org/r/109627/#comment22109 don't particulary like the distanceSqr name, but it seems we where already using it, so let it be i guess :D - Albert Astals Cid On March 21, 2013, 12:50 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109627/ --- (Updated March 21, 2013, 12:50 a.m.) Review request for Okular. Description --- Multiple features in Okular require to determine what object is at a given position. Traditionally, this relied on the bounding boxes of the given object. These do not necessarily correlate with the user would expect (for example, a diagonal line of 1px has a very large bounding box). This patch implementes shape based selection for the following annotation types: Ink, Geometric, Line, Highlight. Other objects default to the old behaviour. Diffs - core/annotations.h 72abdff core/annotations.cpp 49ab5bd core/annotations_p.h 221572d core/area.h 4f63759 core/area.cpp d772fc0 core/page.cpp 1db2763 Diff: http://git.reviewboard.kde.org/r/109627/diff/ Testing --- I tested the annotation objects above and a couple of special cases mentioned in the IRC. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 --- It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? - Albert Astals Cid On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
