[Okular-devel] [okular] [Bug 316713] Printing odd even pages always prints all pages in range.

2013-03-26 Thread matkor
https://bugs.kde.org/show_bug.cgi?id=316713

--- Comment #2 from mat...@ant.gliwice.pl ---
Yes. Printing to real printer (via network cups server) also prints _all_ pages
in range instead of selected even/odd.  In your case it works properly?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317183] okular/poppler crashes when printing a deleted PDF file

2013-03-26 Thread David Faure
https://bugs.kde.org/show_bug.cgi?id=317183

--- Comment #3 from David Faure fa...@kde.org ---
Indeed. kdesrc-build built the master branch of poppler for me.

Some PDFs render completely blank with that branch, BTW.
I reverted to the poppler-0.22 branch for now, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317183] okular/poppler crashes when printing a deleted PDF file

2013-03-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=317183

--- Comment #4 from Albert Astals Cid aa...@kde.org ---
Blank files shouldn't be happening, do you have a link to any?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 316802] okular crashes when adding a stamp

2013-03-26 Thread Giorgio
https://bugs.kde.org/show_bug.cgi?id=316802

--- Comment #2 from Giorgio snove...@gmail.com ---
Created attachment 78405
  -- https://bugs.kde.org/attachment.cgi?id=78405action=edit
output of valgrind

This is the output of 
valgrind --log-file=okular.out okular
until okular crashed again while adding a stamp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317407] New: can't print pdf, when unknown font (windings) is used

2013-03-26 Thread suse
https://bugs.kde.org/show_bug.cgi?id=317407

Bug ID: 317407
   Summary: can't print pdf, when unknown font (windings) is used
Classification: Unclassified
   Product: okular
   Version: 0.16.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: s...@kabelfunk.de

I have an pdf where the font windings is used, but not embedded (see the list
bullets of attached example).
Trying to print this file on my real printer (PCL 6 / LAN-printer) ends up in a
hanged/freezed printer.
Furthermore on one of the test machine I'm getting the error message: Could
not print the document. Detailed error is Printing process crashed. Please
report to bugs.kde.org when I try to print it to a pdf file.

Installing the windings font from a windows installation is a workaround. Now
it prints on my real printer.

Reproducible: Always

Actual Results:  
PCT printer freezes

Expected Results:  
It should be possible to print such files even when the font is missing and
therefore there a some broken symbols.

The attached example is also using arial and symbol, but have no influence on
my freezed-printer-issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317407] can't print pdf, when unknown font (windings) is used

2013-03-26 Thread suse
https://bugs.kde.org/show_bug.cgi?id=317407

--- Comment #1 from s...@kabelfunk.de ---
Created attachment 78412
  -- https://bugs.kde.org/attachment.cgi?id=78412action=edit
test case with windings font (not embedded)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 281027] Option to open link in browser when hilight link (text starting with http://)

2013-03-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281027

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||4.11.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/1121cff1b8600079909424a9
   ||0923f75b5c3630ad

--- Comment #3 from Albert Astals Cid aa...@kde.org ---
Git commit 1121cff1b8600079909424a90923f75b5c3630ad by Albert Astals Cid, on
behalf of Jaydeep Solanki.
Committed on 26/03/2013 at 22:43.
Pushed by aacid into branch 'master'.

Implement Open url in browser for plain text
REVIEW: 108614
FIXED-IN: 4.11.0

M  +3-0tests/CMakeLists.txt
A  +48   -0tests/urldetecttest.cpp [License: UNKNOWN]  *
M  +11   -0ui/pageview.cpp
A  +22   -0ui/url_utils.h [License: UNKNOWN]  *

The files marked with a * at the end have a non valid license. Please read:
http://techbase.kde.org/Policies/Licensing_Policy and use the headers which are
listed at that page.


http://commits.kde.org/okular/1121cff1b8600079909424a90923f75b5c3630ad

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

2013-03-26 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review29929
---



core/document.cpp
http://git.reviewboard.kde.org/r/107442/#comment22279

wondering if we should assert here that d-m_prevPropsOfAnnotBeingModified 
is null/empty/wathever


- Albert Astals Cid


On March 24, 2013, 12:40 a.m., Jon Mease wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/107442/
 ---
 
 (Updated March 24, 2013, 12:40 a.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 This patch adds undo/redo support to Okular's annotation manipulation 
 commands.
 
 Functionality:
 The following actions can be undone and redone: creation and removal of 
 annotations, editing arbitrary annotation properties, relocating annotations 
 with Ctrl+drag, and editing the text contents of an annotation.
 
 This patch does not include support for undoing and redoing editing actions 
 on forms.
 
   
 
 
 This addresses bug 177501.
 http://bugs.kde.org/show_bug.cgi?id=177501
 
 
 Diffs
 -
 
   core/annotations.h 72abdff 
   core/annotations.cpp 49ab5bd 
   core/annotations_p.h 221572d 
   core/document.h 6ff6536 
   core/document.cpp 5ab759e 
   core/document_p.h fb3aec6 
   core/page.cpp 1db2763 
   part.rc 39c1571 
   ui/annotationpropertiesdialog.cpp 4b02258 
   ui/annotwindow.h f7df9f6 
   ui/annotwindow.cpp c1bafb9 
   ui/guiutils.h 2ae4ab3 
   ui/guiutils.cpp 1d67d3a 
   ui/pageview.cpp b018dfe 
 
 Diff: http://git.reviewboard.kde.org/r/107442/diff/
 
 
 Testing
 ---
 
 I have tested the undoing and redoing of the specified annotation actions 
 using .dvi and .pdf documents.
 
 
 Thanks,
 
 Jon Mease
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

2013-03-26 Thread Jon Mease


 On March 26, 2013, 10:54 p.m., Albert Astals Cid wrote:
  core/document.cpp, line 3239
  http://git.reviewboard.kde.org/r/107442/diff/7/?file=121230#file121230line3239
 
  wondering if we should assert here that 
  d-m_prevPropsOfAnnotBeingModified is null/empty/wathever

Sure, that makes sense. Is a C++ assert statement sufficient? Or would you 
prefer another failure mechanism? 


- Jon


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review29929
---


On March 24, 2013, 12:40 a.m., Jon Mease wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/107442/
 ---
 
 (Updated March 24, 2013, 12:40 a.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 This patch adds undo/redo support to Okular's annotation manipulation 
 commands.
 
 Functionality:
 The following actions can be undone and redone: creation and removal of 
 annotations, editing arbitrary annotation properties, relocating annotations 
 with Ctrl+drag, and editing the text contents of an annotation.
 
 This patch does not include support for undoing and redoing editing actions 
 on forms.
 
   
 
 
 This addresses bug 177501.
 http://bugs.kde.org/show_bug.cgi?id=177501
 
 
 Diffs
 -
 
   core/annotations.h 72abdff 
   core/annotations.cpp 49ab5bd 
   core/annotations_p.h 221572d 
   core/document.h 6ff6536 
   core/document.cpp 5ab759e 
   core/document_p.h fb3aec6 
   core/page.cpp 1db2763 
   part.rc 39c1571 
   ui/annotationpropertiesdialog.cpp 4b02258 
   ui/annotwindow.h f7df9f6 
   ui/annotwindow.cpp c1bafb9 
   ui/guiutils.h 2ae4ab3 
   ui/guiutils.cpp 1d67d3a 
   ui/pageview.cpp b018dfe 
 
 Diff: http://git.reviewboard.kde.org/r/107442/diff/
 
 
 Testing
 ---
 
 I have tested the undoing and redoing of the specified annotation actions 
 using .dvi and .pdf documents.
 
 
 Thanks,
 
 Jon Mease
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-26 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review29923
---


This review has been submitted with commit 
1121cff1b8600079909424a90923f75b5c3630ad by Albert Astals Cid on behalf of 
Jaydeep Solanki to branch master.

- Commit Hook


On March 25, 2013, 7:51 p.m., Jaydeep Solanki wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/108614/
 ---
 
 (Updated March 25, 2013, 7:51 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 When selected text is right clicked, it checks for a url, if found, a QAction 
 is added to open the url in the default browser.
 
 pdf with links update : http://goo.gl/wBM6p
 
 
 This addresses bug 281027.
 http://bugs.kde.org/show_bug.cgi?id=281027
 
 
 Diffs
 -
 
   tests/CMakeLists.txt 6a26b3e 
   tests/urldetecttest.cpp PRE-CREATION 
   ui/pageview.cpp e8d481d 
   ui/url_utils.h PRE-CREATION 
 
 Diff: http://git.reviewboard.kde.org/r/108614/diff/
 
 
 Testing
 ---
 
 just check if the icon appears properly, because I have an issue with the 
 icon.
 
 
 Thanks,
 
 Jaydeep Solanki
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 108614: Open url in browser

2013-03-26 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/
---

(Updated March 26, 2013, 9:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Description
---

When selected text is right clicked, it checks for a url, if found, a QAction 
is added to open the url in the default browser.

pdf with links update : http://goo.gl/wBM6p


This addresses bug 281027.
http://bugs.kde.org/show_bug.cgi?id=281027


Diffs
-

  tests/CMakeLists.txt 6a26b3e 
  tests/urldetecttest.cpp PRE-CREATION 
  ui/pageview.cpp e8d481d 
  ui/url_utils.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108614/diff/


Testing
---

just check if the icon appears properly, because I have an issue with the icon.


Thanks,

Jaydeep Solanki

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel