[Okular-devel] [okular] [Bug 317710] some pdf files crash new version of okular

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=317710

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #10 from Albert Astals Cid aa...@kde.org ---
Got the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] OCR Tool for Okular

2013-04-03 Thread Albert Astals Cid
El Dimecres, 3 d'abril de 2013, a les 14:20:35, Anıl Özbek va escriure:
 Hi,

Hi

 Last week, I've started to write a simple OCR tool for Okular.
 Generally it received good response from KDE users [1-3].
 
 What do you think about adding such a tool to Okular? Is it possible?
 If possible, I'd be happy to help as far as I can do. But I would like
 to say that I'm not experienced in the KDE/Qt development.
 
 Currently my code (which mostly copy/paste from other projects) take
 an image part from active document and save it to os's temp dir. Then
 run a particular OCR app's executable file (for now only Tesseract)
 and convert image to text file. Finally code open the text file and
 copy its content to clipboard. And after all, the temporary files are
 deleted.
 
 I think before going any further it would be better to clarify some
 issues that I encountered.
 
 
 API vs Executable
 ---
 Which one would be better to use? It's easier to use the executable
 file. But using API seems a more right approach. As far as I see
 Tesseract [4] and Cuneiform [5] provide API but I don't know about
 other OCR software.
 
 Maybe instead of trying to give support to more than one OCR software
 we can choose just a default one. But it will restrict the users.
 
 If we use API, Okular will link to OCR software libraries and this
 means more dependencies for Okular package. If we use executable, we
 can check executable file before running it and if it's not installed
 we can show a info message to user which tells something like that:
 additional packages must be installed to use this feature.
 
 If we choose API way these [6-9] way help.
 
 
 OCR Output's Accuracy
 ---
 OCR performance isn't well enough (at least for comics) for now. There
 is almost 50% success. My current code use image directly from comics,
 may be it would be nice to convert image first black and white or
 2-bit and apply some other image operations to make letters clearer.
 Do you have any suggestions about this?
 
 
 Icon for OCR Tool
 ---
 Currently I used scanner icon from Oxygen [10] but if we have a better
 option we can use it.
 
 
 Document Language
 ---
 To give OCR software correct parameters we must know document
 language. For now Okular can't determine language of opened documents
 [11]. Until this feature implemented we can add a new section to
 Okular Configurations for OCR tool. Users can select language for OCR
 process from here as well as which OCR software will be used.

Why should this be a part of Okular and not a separate binary? I can imagine 
millions of other places i'd like to have OCR on. What's the benefit of it 
being Okular-only?

Cheers,
  Albert

 
 
 Links
 ---
 [1] http://wklej.org/id/995982/
 [2] http://www.youtube.com/watch?v=duSTyByIPLc
 [3] https://plus.google.com/113435503145887565355/posts/RqzC3hMcGcd
 [4] https://code.google.com/p/tesseract-ocr/
 [5] https://launchpad.net/cuneiform-linux
 [6]
 https://raw.github.com/ruediger/VobSub2SRT/master/CMakeModules/FindTesserac
 t.cmake [7]
 https://raw.github.com/ck1125/sikuli/master/cmake_modules/FindTesseract.cma
 ke [8]
 https://projects.kde.org/projects/playground/libs/kolena/repository/revisio
 ns/master/entry/cmake/modules/FindTesseract.cmake [9]
 https://raw.github.com/uliss/quneiform_tests/master/cmake/FindCuneiform.cma
 ke [10] http://i.imgur.com/xn8iyDw.png
 [11] https://bugs.kde.org/show_bug.cgi?id=317486
 
 
 Regards,
 --
 Anıl Özbek
 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=267350

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #8 from Albert Astals Cid aa...@kde.org ---
Marcus your problem has nothing to do with this bug, Warren is complaining
about the data leakage into his own home folder.

What you are facing has nothing to do with this. So please open a separate bug
about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] OCR Tool for Okular

2013-04-03 Thread Anıl Özbek
2013/4/3 Albert Astals Cid aa...@kde.org:
 Why should this be a part of Okular and not a separate binary? I can imagine
 millions of other places i'd like to have OCR on. What's the benefit of it
 being Okular-only?

I need small-scale OCR only at three type software:

* Web Browser (Chrome)
* Image Viewer (Gwenview)
* Document Viewer (Okular)

And document viewer comes first for me. Actually there isn't much
benefits of OCR tool at Okular. I can count only one or two:

* It's easier to run (more than once) a builtin tool instead of run a
third party app.
* It works more integrated with Okular (selected text shown with
Okular's notification system) and it can be used very similarly to
other tools in Okular (just select something and selected thing is in
your clipboard like Copy to Clipboard tool does).
* Not everyone can find such a app if it released standalone. Because
it's not a very generic type of software. But if it comes with an
widely used and related application, more people can use it.

Regards,
--
Anıl Özbek
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom

2013-04-03 Thread Thomas Fischer
https://bugs.kde.org/show_bug.cgi?id=249364

--- Comment #7 from Thomas Fischer fisc...@unix-ag.uni-kl.de ---
(In reply to comment #6)
 Any luck?
It looks like the problem you observed is related to mixing best-fit and
continuous view. Both features mess with the vertical scroll bar. The problem
does not appear if you use single-page view.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Warren Turkal
https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #9 from Warren Turkal w...@penguintechs.org ---
To quote my original description:

Expected Results:
The user should be able to Save as... to a new file and just have a copy of
the PDF with the filled in form data.

I believe this is exactly what Marcus was asking for.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #10 from Albert Astals Cid aa...@kde.org ---
Then you used a wrong subject and i decided to ignore this bug, Save as...
should and does work here, please, i'm attaching a filled in (just the first
two lines) with okular of the file you attached that opens fine in Adobe Reader
and shows the data

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #11 from Albert Astals Cid aa...@kde.org ---
Created attachment 78620
  -- https://bugs.kde.org/attachment.cgi?id=78620action=edit
Filled in file

With Hola and Pepe in the first two lines

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #12 from Albert Astals Cid aa...@kde.org ---
FWIW that filled in file was created with poppler 0.23 and can't be opened with
0.22 or older :-/ But that's a bug of those old versions, you can open it with
Adobe Reader to see it working

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317801] New: (certain) postscript files don't get displayed/rendered

2013-04-03 Thread Christian Boxdörfer
https://bugs.kde.org/show_bug.cgi?id=317801

Bug ID: 317801
   Summary: (certain) postscript files don't get
displayed/rendered
Classification: Unclassified
   Product: okular
   Version: 0.16.1
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: PS backend
  Assignee: okular-devel@kde.org
  Reporter: boxdoerfer.christ...@gmail.com

When opening a postscript file (e.g. this[1] one) with okular there's no
content drawn, just white space with the okular icon in the top left. However
if you import it as a PDF file it works just fine.

[1]
http://www.tu-ilmenau.de/fileadmin/media/num/neundorf/Dokumente/Lehre/l_nm.ps

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 317801] (certain) postscript files don't get displayed/rendered

2013-04-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=317801

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
spectre bug https://bugs.freedesktop.org/show_bug.cgi?id=61506

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

2013-04-03 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review30337
---


I was about to commit and then i saw we still have the m_prevAnnotTextCursorPos 
and m_prevAnnotTextAnchorPos maps. Do we really need them? As far as I can see 
they only get used to fill the commands for the AnnotWindow, can't we cache 
old those values to feed the command in AnnotWindow itself?

- Albert Astals Cid


On March 27, 2013, 12:10 p.m., Jon Mease wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/107442/
 ---
 
 (Updated March 27, 2013, 12:10 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 This patch adds undo/redo support to Okular's annotation manipulation 
 commands.
 
 Functionality:
 The following actions can be undone and redone: creation and removal of 
 annotations, editing arbitrary annotation properties, relocating annotations 
 with Ctrl+drag, and editing the text contents of an annotation.
 
 This patch does not include support for undoing and redoing editing actions 
 on forms.
 
   
 
 
 This addresses bug 177501.
 http://bugs.kde.org/show_bug.cgi?id=177501
 
 
 Diffs
 -
 
   core/annotations.h 72abdff 
   core/annotations.cpp 49ab5bd 
   core/annotations_p.h 221572d 
   core/document.h 6ff6536 
   core/document.cpp 5ab759e 
   core/document_p.h fb3aec6 
   core/page.cpp 1db2763 
   part.rc 39c1571 
   ui/annotationpropertiesdialog.cpp 4b02258 
   ui/annotwindow.h f7df9f6 
   ui/annotwindow.cpp c1bafb9 
   ui/guiutils.h 2ae4ab3 
   ui/guiutils.cpp 1d67d3a 
   ui/pageview.cpp b018dfe 
 
 Diff: http://git.reviewboard.kde.org/r/107442/diff/
 
 
 Testing
 ---
 
 I have tested the undoing and redoing of the specified annotation actions 
 using .dvi and .pdf documents.
 
 
 Thanks,
 
 Jon Mease
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] OCR Tool for Okular

2013-04-03 Thread Albert Astals Cid
El Dimecres, 3 d'abril de 2013, a les 21:12:30, Anıl Özbek va escriure:
 2013/4/3 Albert Astals Cid aa...@kde.org:
  Why should this be a part of Okular and not a separate binary? I can
  imagine millions of other places i'd like to have OCR on. What's the
  benefit of it being Okular-only?
 
 I need small-scale OCR only at three type software:
 
 * Web Browser (Chrome)
 * Image Viewer (Gwenview)
 * Document Viewer (Okular)

So are you planning to implement the same feature three times seems a bit 
boring and a hell maintainance wise?

Sincerely I think a standalone application/library is much better. Once that 
standalone application/library exists we might even add a toolbar entry or 
something in okular if we detect it is installed to ease the use to the end 
user.

Cheers,
  Albert

 And document viewer comes first for me. Actually there isn't much
 benefits of OCR tool at Okular. I can count only one or two:
 
 * It's easier to run (more than once) a builtin tool instead of run a
 third party app.
 * It works more integrated with Okular (selected text shown with
 Okular's notification system) and it can be used very similarly to
 other tools in Okular (just select something and selected thing is in
 your clipboard like Copy to Clipboard tool does).
 * Not everyone can find such a app if it released standalone. Because
 it's not a very generic type of software. But if it comes with an
 widely used and related application, more people can use it.
 
 Regards,
 --
 Anıl Özbek
 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 109627: Outline based selection for annotation elements

2013-04-03 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109627/#review30343
---


you say all but the one about distanceConsideredEqual where I'm waiting for a 
reply to my earlier comment but I don't see an earlier comment, are you sure 
you published it?

- Albert Astals Cid


On March 23, 2013, 7:52 p.m., Peter Grasch wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/109627/
 ---
 
 (Updated March 23, 2013, 7:52 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 Multiple features in Okular require to determine what object is at a given 
 position. Traditionally, this relied on the bounding boxes of the given 
 object.
 These do not necessarily correlate with the user would expect (for example, a 
 diagonal line of 1px has a very large bounding box).
 
 This patch implementes shape based selection for the following annotation 
 types:
 Ink, Geometric, Line, Highlight.
 Other objects default to the old behaviour.
 
 
 Diffs
 -
 
   core/annotations.h 72abdff 
   core/annotations.cpp 49ab5bd 
   core/annotations_p.h 221572d 
   core/area.h 4f63759 
   core/area.cpp d772fc0 
   core/page.cpp 1db2763 
   tests/CMakeLists.txt 6a26b3e 
   tests/annotationstest.cpp PRE-CREATION 
 
 Diff: http://git.reviewboard.kde.org/r/109627/diff/
 
 
 Testing
 ---
 
 I tested the annotation objects above and a couple of special cases mentioned 
 in the IRC.
 
 
 Thanks,
 
 Peter Grasch
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

2013-04-03 Thread Marcus Furlong
https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #13 from Marcus Furlong furlo...@gmail.com ---
It's the same bug, just a different title. Instead of saving the form data to
the PDF, it gets saved externally.

Happy to hear it's solved in a newer version of poppler. 0.23 is the
development branch of what will become 0.24?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 107442: Add undo/redo support for annotations

2013-04-03 Thread Jon Mease


 On April 3, 2013, 9:16 p.m., Albert Astals Cid wrote:
  I was about to commit and then i saw we still have the 
  m_prevAnnotTextCursorPos and m_prevAnnotTextAnchorPos maps. Do we really 
  need them? As far as I can see they only get used to fill the commands for 
  the AnnotWindow, can't we cache old those values to feed the command in 
  AnnotWindow itself?

Do you mean have the annotWindow keep track of its own previous cursor and 
anchor positions and then pass them in as arguments along with the annotation's 
new contents? If so I believe I already implemented this approach in a previous 
version of the patch so it won't be hard to dig it back up again.
Thanks


- Jon


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review30337
---


On March 27, 2013, 12:10 p.m., Jon Mease wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/107442/
 ---
 
 (Updated March 27, 2013, 12:10 p.m.)
 
 
 Review request for Okular.
 
 
 Description
 ---
 
 This patch adds undo/redo support to Okular's annotation manipulation 
 commands.
 
 Functionality:
 The following actions can be undone and redone: creation and removal of 
 annotations, editing arbitrary annotation properties, relocating annotations 
 with Ctrl+drag, and editing the text contents of an annotation.
 
 This patch does not include support for undoing and redoing editing actions 
 on forms.
 
   
 
 
 This addresses bug 177501.
 http://bugs.kde.org/show_bug.cgi?id=177501
 
 
 Diffs
 -
 
   core/annotations.h 72abdff 
   core/annotations.cpp 49ab5bd 
   core/annotations_p.h 221572d 
   core/document.h 6ff6536 
   core/document.cpp 5ab759e 
   core/document_p.h fb3aec6 
   core/page.cpp 1db2763 
   part.rc 39c1571 
   ui/annotationpropertiesdialog.cpp 4b02258 
   ui/annotwindow.h f7df9f6 
   ui/annotwindow.cpp c1bafb9 
   ui/guiutils.h 2ae4ab3 
   ui/guiutils.cpp 1d67d3a 
   ui/pageview.cpp b018dfe 
 
 Diff: http://git.reviewboard.kde.org/r/107442/diff/
 
 
 Testing
 ---
 
 I have tested the undoing and redoing of the specified annotation actions 
 using .dvi and .pdf documents.
 
 
 Thanks,
 
 Jon Mease
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel