[Okular-devel] Review Request 109882: Update Okular documentation to the new Undo and Redo features
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/ --- Review request for Documentation and Okular. Description --- A minor update to describe Undo and Redo actions to annotations. Diffs - doc/index.docbook 52e11c8 Diff: http://git.reviewboard.kde.org/r/109882/diff/ Testing --- Checked with checkXML. Works fine when installed with git/master of Okular. Thanks, Yuri Chornoivan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109882: Update Okular documentation to the new Undo and Redo features
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/#review30556 --- doc/index.docbook http://git.reviewboard.kde.org/r/109882/#comment22744 Copy - Undo - Albert Astals Cid On April 6, 2013, 11:38 a.m., Yuri Chornoivan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/ --- (Updated April 6, 2013, 11:38 a.m.) Review request for Documentation and Okular. Description --- A minor update to describe Undo and Redo actions to annotations. Diffs - doc/index.docbook 52e11c8 Diff: http://git.reviewboard.kde.org/r/109882/diff/ Testing --- Checked with checkXML. Works fine when installed with git/master of Okular. Thanks, Yuri Chornoivan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109882: Update Okular documentation to the new Undo and Redo features
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/ --- (Updated April 6, 2013, 1:43 p.m.) Review request for Documentation and Okular. Changes --- Fix menu item (Copy-Undo) Description --- A minor update to describe Undo and Redo actions to annotations. Diffs (updated) - doc/index.docbook 52e11c8 Diff: http://git.reviewboard.kde.org/r/109882/diff/ Testing --- Checked with checkXML. Works fine when installed with git/master of Okular. Thanks, Yuri Chornoivan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109882: Update Okular documentation to the new Undo and Redo features
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/#review30558 --- Ship it! Ship It! - Albert Astals Cid On April 6, 2013, 1:43 p.m., Yuri Chornoivan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109882/ --- (Updated April 6, 2013, 1:43 p.m.) Review request for Documentation and Okular. Description --- A minor update to describe Undo and Redo actions to annotations. Diffs - doc/index.docbook 52e11c8 Diff: http://git.reviewboard.kde.org/r/109882/diff/ Testing --- Checked with checkXML. Works fine when installed with git/master of Okular. Thanks, Yuri Chornoivan ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 317931] New: Underline Annotation Tool does not always flow to the end of the page
https://bugs.kde.org/show_bug.cgi?id=317931 Bug ID: 317931 Summary: Underline Annotation Tool does not always flow to the end of the page Classification: Unclassified Product: okular Version: 0.16.2 Platform: Ubuntu Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: kd...@sfina.com I have observed this behavior with many PDF files of different type / origin. This morning I downloaded this PDF file [1] and started annotating it. When I arrived at page 15 I wanted to mark the last two lines. I pressed the numeric key 4 and started dragging the mouse from the top left corner of the text down to the bottom right. No matter how far I dragged, the marking did not extend to cover the last line. I saved the status of the document [2]. After quitting and restarting Okular, I was able to mark the two lines. [1] https://www.dropbox.com/s/ozskxg4wol7dvrh/2013scc19.pdf [2] https://www.dropbox.com/s/m6ao27izi6dqb84/underlining_bug.okular Reproducible: Sometimes Steps to Reproduce: 1. start with an unnanotated, multi-pages PDF. 2. Use only the marker tool. 3. Mark a few areas on each page. 4. Try to mark into the end of the page. Actual Results: Observed result: sometimes the last line does not get marked. Expected Results: Expected result: all text until the end of the page marked. Workaround: restart Okular. Unfortunately not very convenient if the lecturer has already moved on and talked about other points in the documents and I have to catch up. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Undo/Redo for annotations merged
Thanks Albert (and Fabio) for all of your help along the way on this. I appreciate it. I do plan to tackle both a) and b) below. Not sure yet which order. I could use a little help getting started with the a). I'm having trouble figuring out how to run okular's existing unit tests. When I run (on master) cmake make buildtests make test I get failures for both parttest and searchtest. When I cd into the tests directory and run parttest on its own here is the output I receive. * Start testing of Okular::PartTest * Config: Using QTest library 4.8.3, Qt 4.8.3 PASS : Okular::PartTest::initTestCase() QDEBUG : Okular::PartTest::testReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testReload() qttest(6457) KXMLGUIClient::setXMLFile: cannot find .rc file part.rc for component qttest QDEBUG : Okular::PartTest::testReload() qttest(6457)/okular (app) Okular::DocumentPrivate::loadGeneratorLibrary: Invalid plugin factory for okularGenerator_poppler! PASS : Okular::PartTest::testReload() QDEBUG : Okular::PartTest::testTOCReload() qttest(6457) Okular::Settings::instance: Settings::instance called after the first use - ignoring QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testTOCReload() qttest(6457) KXMLGUIClient::setXMLFile: cannot find .rc file part.rc for component qttest QDEBUG : Okular::PartTest::testTOCReload() qttest(6457)/okular (app) Okular::DocumentPrivate::loadGeneratorLibrary: Invalid plugin factory for okularGenerator_poppler! FAIL! : Okular::PartTest::testTOCReload() Compared values are not the same Actual (part.m_toc-expandedNodes().count()): 0 Expected (3): 3 Loc: [/home/measejm1/Programming/kdeProjects/okular/tests/parttest.cpp(50)] QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457) Okular::Settings::instance: Settings::instance called after the first use - ignoring QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457) KXMLGUIClient::setXMLFile: cannot find .rc file part.rc for component qttest QDEBUG : Okular::PartTest::testFowardPDF(non-utf8) qttest(6457)/okular (app) Okular::DocumentPrivate::loadGeneratorLibrary: Invalid plugin factory for okularGenerator_poppler! FAIL! : Okular::PartTest::testFowardPDF(non-utf8) Compared values are not the same Actual (part.m_document-currentPage()): 4294967295 Expected (0u): 0 Loc: [/home/measejm1/Programming/kdeProjects/okular/tests/parttest.cpp(79)] QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457) Okular::Settings::instance: Settings::instance called after the first use - ignoring QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: QDEBUG : Okular::PartTest::testFowardPDF(utf8) qttest(6457) KXMLGUIClient::setXMLFile: cannot find .rc file part.rc for component qttest QDEBUG :
