Re: [Okular-devel] Review Request 110003: Best-fit zoom
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110003/#review31007 --- Needs fixing: * Choose 100% in the combobox. * Get 75% instead - Albert Astals Cid On April 13, 2013, 6:59 p.m., Thomas Fischer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110003/ > --- > > (Updated April 13, 2013, 6:59 p.m.) > > > Review request for Okular. > > > Description > --- > > Attached patch implements best-fit zoom for Okular. It is a refined version > of the patch submitted in bug report 249364, attachment 51069. The refinement > addresses the scrollbar issues as observed in continuous view mode. > > > This addresses bug 249364. > http://bugs.kde.org/show_bug.cgi?id=249364 > > > Diffs > - > > ui/pageview.h 5e839f2 > ui/pageview.cpp 6e093ef > > Diff: http://git.reviewboard.kde.org/r/110003/diff/ > > > Testing > --- > > > Thanks, > > Thomas Fischer > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/ --- (Updated April 13, 2013, 8:55 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Description --- Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/) This addresses bug 318091. http://bugs.kde.org/show_bug.cgi?id=318091 Diffs - tests/modifyannotationpropertiestest.cpp PRE-CREATION tests/editannotationcontentstest.cpp PRE-CREATION tests/addremoveannotationtest.cpp PRE-CREATION core/page.cpp bb9ae83 tests/CMakeLists.txt 5d1ce2d core/document.cpp 3302b76 tests/testingutils.h PRE-CREATION tests/testingutils.cpp PRE-CREATION tests/translateannotationtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109989/diff/ Testing --- This is testing :-) Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/#review31005 --- This review has been submitted with commit 3c6140b616fe1e4979b229869c378396200bf4de by Albert Astals Cid on behalf of Jon Mease to branch master. - Commit Hook On April 13, 2013, 10:55 a.m., Jon Mease wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109989/ > --- > > (Updated April 13, 2013, 10:55 a.m.) > > > Review request for Okular. > > > Description > --- > > Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle > page rotation) and adds associated unit test. Also adds a plethora of unit > tests covering all of the new annotation undo commands > (https://git.reviewboard.kde.org/r/107442/) > > > This addresses bug 318091. > http://bugs.kde.org/show_bug.cgi?id=318091 > > > Diffs > - > > tests/modifyannotationpropertiestest.cpp PRE-CREATION > tests/editannotationcontentstest.cpp PRE-CREATION > tests/addremoveannotationtest.cpp PRE-CREATION > core/page.cpp bb9ae83 > tests/CMakeLists.txt 5d1ce2d > core/document.cpp 3302b76 > tests/testingutils.h PRE-CREATION > tests/testingutils.cpp PRE-CREATION > tests/translateannotationtest.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109989/diff/ > > > Testing > --- > > This is testing :-) > > > Thanks, > > Jon Mease > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 318091] Undo / Redo of annotation creation doesn't properly handle page rotation
https://bugs.kde.org/show_bug.cgi?id=318091 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/3c6140b616fe1e4979b22986 ||9c378396200bf4de --- Comment #2 from Albert Astals Cid --- Git commit 3c6140b616fe1e4979b229869c378396200bf4de by Albert Astals Cid, on behalf of Jon Mease. Committed on 13/04/2013 at 22:54. Pushed by aacid into branch 'master'. Fix Undo / Redo of annotation creation doesn't properly handle page rotation and adds undo unit tests REVIEW: 109989 M +6-0core/document.cpp M +0-1core/page.cpp M +12 -0tests/CMakeLists.txt A +190 -0tests/addremoveannotationtest.cpp [License: GPL (v2+)] A +519 -0tests/editannotationcontentstest.cpp [License: GPL (v2+)] A +138 -0tests/modifyannotationpropertiestest.cpp [License: GPL (v2+)] A +54 -0tests/testingutils.cpp [License: GPL (v2+)] A +51 -0tests/testingutils.h [License: GPL (v2+)] A +237 -0tests/translateannotationtest.cpp [License: GPL (v2+)] http://commits.kde.org/okular/3c6140b616fe1e4979b229869c378396200bf4de -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom
https://bugs.kde.org/show_bug.cgi?id=249364 --- Comment #10 from Thomas Fischer --- Submitted as review 110003: https://git.reviewboard.kde.org/r/110003/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 110003: Best-fit zoom
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110003/ --- Review request for Okular. Description --- Attached patch implements best-fit zoom for Okular. It is a refined version of the patch submitted in bug report 249364, attachment 51069. The refinement addresses the scrollbar issues as observed in continuous view mode. This addresses bug 249364. http://bugs.kde.org/show_bug.cgi?id=249364 Diffs - ui/pageview.h 5e839f2 ui/pageview.cpp 6e093ef Diff: http://git.reviewboard.kde.org/r/110003/diff/ Testing --- Thanks, Thomas Fischer ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom
https://bugs.kde.org/show_bug.cgi?id=249364 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- Ever confirmed|0 |1 --- Comment #9 from Albert Astals Cid --- Can you please use reviewboard to submit patches? It's much easier to comment in there and also to keep track what is waiting, etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 249364] PATCH: Fit best (best-fit) zoom
https://bugs.kde.org/show_bug.cgi?id=249364 --- Comment #8 from Thomas Fischer --- Please try this clone here, it should work better now: g...@git.kde.org:clones/okular/thomasfischer/bestfit.git -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] OT Writing an Article about Okular
El Divendres, 12 d'abril de 2013, a les 13:30:37, Music Man va escriure: > Hi ! Hi > I'm a high school student interested in FOSS. I am planning to write an > article on FOSS PDF Viewers and was wondering whether anyone could suggest > a way to get in touch with the current project lead or the original project > creator of Okular (preferably their email address ) ? The developers of Okular are in this list :-) I am the current project lead. As for "original project creator", that's a hard one, Okular evolved from KPDF viewer whose original creator name i don't remember, but tbh I don't think there's much code left from that era :D > I love Okular and it's my default PDF viewer, thank you all for taking the > time to develop and maintain it ! You're welcome :-) Cheers, Albert > > Sorry for posting off topic. > > Thanks, > Tushar B. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/ --- Review request for Okular. Description --- Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/) This addresses bug 318091. http://bugs.kde.org/show_bug.cgi?id=318091 Diffs - tests/modifyannotationpropertiestest.cpp PRE-CREATION tests/editannotationcontentstest.cpp PRE-CREATION tests/addremoveannotationtest.cpp PRE-CREATION core/page.cpp bb9ae83 tests/CMakeLists.txt 5d1ce2d core/document.cpp 3302b76 tests/testingutils.h PRE-CREATION tests/testingutils.cpp PRE-CREATION tests/translateannotationtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109989/diff/ Testing --- This is testing :-) Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
