Re: [Okular-devel] Review Request 113434: Added default shortcut Ctrl + I for change colors.

2013-10-26 Thread Ciro Santilli 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113434/
---

(Updated Oct. 26, 2013, 9:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 173264
http://bugs.kde.org/show_bug.cgi?id=173264


Repository: okular


Description
---

Added default shortcut Ctrl + I for change colors.

This should have the exact same of clicking the toolbox Settigs > Configure 
Okular > Accessibility > Change colors and then clicking Ok, therefore changing 
the saved configs.

I am not sure if:

- viewport()->update() is the right way to update the screen after this config 
change? Where is the `update()` method defined? If I tracked well, viewport() 
returns a DocumentViewport, which does not seem to have such a method.

- I placed the new feature in the right class

but it seems to work.


Diffs
-

  ui/pageview.h fd4e3ac 
  ui/pageview.cpp a1ab5bd 

Diff: http://git.reviewboard.kde.org/r/113434/diff/


Testing
---


Thanks,

Ciro Santilli

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 173264] Add hotkey for "Change colors"

2013-10-26 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=173264

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.12.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/afc74e76ef70abf70d993d40
   ||99000742080a8a85

--- Comment #6 from Albert Astals Cid  ---
Git commit afc74e76ef70abf70d993d4099000742080a8a85 by Albert Astals Cid, on
behalf of Ciro Santilli.
Committed on 26/10/2013 at 09:40.
Pushed by aacid into branch 'master'.

Add an action to toggle Change Colors

This has the exact same behaviour of clicking the toolbox Settigs > Configure
Okular > Accessibility > Change colors and then clicking Ok, therefore changing
the saved configs.
FIXED-IN: 4.12.0

M  +11   -0ui/pageview.cpp
M  +1-0ui/pageview.h

http://commits.kde.org/okular/afc74e76ef70abf70d993d4099000742080a8a85

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build became unstable: okular_stable #226

2013-10-26 Thread KDE CI System 
See 

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326479] smart facing mode

2013-10-26 Thread Matthieu Lagouge 
https://bugs.kde.org/show_bug.cgi?id=326479

--- Comment #7 from Matthieu Lagouge  ---
In that case, I think we should better close it. I'm thinking that "following
link" may impede reading if let's say you have several links close to each
other.

Anyway, thanks for having taken the time to answer me and thanks for okular.
I'll still be a happy user!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326479] smart facing mode

2013-10-26 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=326479

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WONTFIX

--- Comment #8 from Albert Astals Cid  ---
Input always appreciated, keep it coming :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326617] Okular fails to print document with a long title

2013-10-26 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=326617

--- Comment #8 from Albert Astals Cid  ---
So, just to be sure, can you confirm that deleting one letter from the title
makes it work? If so i'll try to make sure that when we create the job name
it's not longer than that amount of characters.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326617] Okular fails to print document with a long title

2013-10-26 Thread Olivier Diotte 
https://bugs.kde.org/show_bug.cgi?id=326617

--- Comment #9 from Olivier Diotte  ---
Yes, deleting one letter from the title makes it work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread valto 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #2 from va...@inventati.org ---
Actually I have submitted a bug report to Ubuntu initially, and it was them to
direct me to this web-site saying that it probably has to do with some KDE
libraries.

What exactly do you need me to attach?

Thanks, Daniele V.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread Yuri Chornoivan 
https://bugs.kde.org/show_bug.cgi?id=326605

Yuri Chornoivan  changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #3 from Yuri Chornoivan  ---
(In reply to comment #2)
> Actually I have submitted a bug report to Ubuntu initially, and it was them
> to direct me to this web-site saying that it probably has to do with some
> KDE libraries.
> 
> What exactly do you need me to attach?
> 
> Thanks, Daniele V.

Please attach minimal non-working example in LaTeX (can be constructed with
lipsum package).

BTW, cannot reproduce here with my LaTeX documents (Kile 2.9.60, KDE 4.10.5,
self-compiled poppler+okular from git/master).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread valto 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #4 from va...@inventati.org ---
Created attachment 83130
  --> https://bugs.kde.org/attachment.cgi?id=83130&action=edit
Latex source file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread valto 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #5 from va...@inventati.org ---
Created attachment 83131
  --> https://bugs.kde.org/attachment.cgi?id=83131&action=edit
bibliography file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread valto 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #6 from va...@inventati.org ---
Here they are.

It's still not working properly with both of my laptops. Even though, 1 time
out of 20, it does work.

Thanks for any help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #7 from Albert Astals Cid  ---
Remember, i have no clue about latex, what do i do with those files to
genereate a pdf?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2013-10-26 Thread Yuri Chornoivan 
https://bugs.kde.org/show_bug.cgi?id=326605

--- Comment #8 from Yuri Chornoivan  ---
(In reply to comment #7)
> Remember, i have no clue about latex, what do i do with those files to
> genereate a pdf?

Open the non-working.tex in Kile, wait until the ready to use PDF will be
displayed at the right preview pane (it is generated automatically by default).
Shift-click here and there in PDF, watch how the source code pane synchronize
with Okular preview part.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326711] New: Okular *.desktop files are missing "-icon" in front of %i

2013-10-26 Thread Olivier Diotte 
https://bugs.kde.org/show_bug.cgi?id=326711

Bug ID: 326711
   Summary: Okular *.desktop files are missing "-icon" in front of
%i
Classification: Unclassified
   Product: okular
   Version: 0.17.2
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: olivier+...@diotte.ca

Running this one-liner, as root, fixes it in the meantime:

sed -r -i 's/Exec=okular %U %i -caption %c/Exec=okular %U -icon %i -caption
%c/' /usr/share/applications/kde4/okular*.desktop

Also, this bug happened at least on Okular 0.16.5 too.

Reproducible: Always

Steps to Reproduce:
1. Run "xdg-open /path/to/file.pdf" in a terminal
Actual Results:  
-An okular window appears displaying file.pdf
-An empty okular window with title '%c' appears
-A popup window saying "could not open /home/myuser/%i" appears 

Expected Results:  
Only the file.pdf okular window appears

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326711] Okular *.desktop files are missing "-icon" in front of %i

2013-10-26 Thread Jekyll Wu 
https://bugs.kde.org/show_bug.cgi?id=326711

Jekyll Wu  changed:

   What|Removed |Added

 CC||adap...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel