[Okular-devel] Review Request 114533: Fix adding and removing bookmarks in the thumbnail panel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114533/ --- Review request for Okular. Bugs: 323267 http://bugs.kde.org/show_bug.cgi?id=323267 Repository: okular Description --- Fix adding and removing bookmarks in the thumbnail panel Add and removal of bookmarks via the thumbnail context menu was acting on the current viewport instead of the clicked page. This patch checks whether it should act on the viewport or in the right clicked page. BUGS: 323267 Diffs - part.cpp 7c67d8b26750c38202f0a29820398958f1550612 Diff: http://git.reviewboard.kde.org/r/114533/diff/ Testing --- Thanks, Mailson Menezes ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Possible bug with annotations?
El Dimecres, 18 de desembre de 2013, a les 20:46:02, Fabio D'Urso va escriure: > On Monday, December 16, 2013 10:19:08 PM Albert Astals Cid wrote: > > El Dilluns, 16 de desembre de 2013, a les 17:16:20, Edward Rosten va > > escriure: > > > Hi All, > > > > Hi > > > > > I'm having a problem with annotations and I'm not sure if it's a bug. > > > > > > I've attached 3 files. The original is hello.pdf, a very plain PDF > > > made with PDFlatex. > > > > > > The next file hello-okular.pdf has been annotated with okular. The > > > problem with this file is that annotations don't appear in all > > > readers. They don't appear in xpdf and (worse) don't appear in the PDF > > > reader built into gmail, or the one built into Firefox. They do appear > > > in evince, okular and Acrobat Reader. > > > > > > For the final file, I loaded hello-okular.pdf into Acrobat Reader and > > > saved as hello-okular-adobereader.pdf without making any explicit > > > modifications. Now the annotations appear in all readers. > > > > > > It appears that the annotations only semi-work in other PDF readers at > > > the moment. I also have a vague memory which I can't verify that > > > okular annotations have previously been readable in xpdf (and > > > presumably the others, though I don't remember). > > > > > > Is this a bug? > > > > Looks like it to me. What could be otherwise? > > Sounds like xpdf, gmail and Firefox don't know how to handle annotations > without an appearance stream (Poppler -the library we use to handle PDFs- > doesn't store the appearance stream within the PDF file, whereas Acrobat > does). Basically we're saying "you have to draw a circle annotation" but > we're not telling how (ie "draw a curve using these control points"). > > If they used to work, then I'm wrong and it is a bug. > > > According to the specs the appearance stream is optional, therefore I'm > tempted to say this is not our/Poppler's bug. OTOH, given that so many > readers show this issue, we may want to change Poppler's behavior. > > There is a reason why I haven't done this yet: we would need to embed a font > in case of text notes, but I don't know enough about fonts to do that and I > guess there are also licensing issues to keep in mind. > > Albert, what do you think? *If* our file is correct, someone should file bugs for the other projects, gmail and firefox are still very barebones stuff so they may have not realized they are doing it wrong. Cheers, Albert > > Fabio > > > Cheers, > > > > Albert > > > > > Regards > > > > > > -Ed > > > > ___ > > Okular-devel mailing list > > Okular-devel@kde.org > > https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Possible bug with annotations?
On Monday, December 16, 2013 10:19:08 PM Albert Astals Cid wrote: > El Dilluns, 16 de desembre de 2013, a les 17:16:20, Edward Rosten va escriure: > > Hi All, > > Hi > > > I'm having a problem with annotations and I'm not sure if it's a bug. > > > > I've attached 3 files. The original is hello.pdf, a very plain PDF > > made with PDFlatex. > > > > The next file hello-okular.pdf has been annotated with okular. The > > problem with this file is that annotations don't appear in all > > readers. They don't appear in xpdf and (worse) don't appear in the PDF > > reader built into gmail, or the one built into Firefox. They do appear > > in evince, okular and Acrobat Reader. > > > > For the final file, I loaded hello-okular.pdf into Acrobat Reader and > > saved as hello-okular-adobereader.pdf without making any explicit > > modifications. Now the annotations appear in all readers. > > > > It appears that the annotations only semi-work in other PDF readers at > > the moment. I also have a vague memory which I can't verify that > > okular annotations have previously been readable in xpdf (and > > presumably the others, though I don't remember). > > > > Is this a bug? > > Looks like it to me. What could be otherwise? Sounds like xpdf, gmail and Firefox don't know how to handle annotations without an appearance stream (Poppler -the library we use to handle PDFs- doesn't store the appearance stream within the PDF file, whereas Acrobat does). Basically we're saying "you have to draw a circle annotation" but we're not telling how (ie "draw a curve using these control points"). If they used to work, then I'm wrong and it is a bug. According to the specs the appearance stream is optional, therefore I'm tempted to say this is not our/Poppler's bug. OTOH, given that so many readers show this issue, we may want to change Poppler's behavior. There is a reason why I haven't done this yet: we would need to embed a font in case of text notes, but I don't know enough about fonts to do that and I guess there are also licensing issues to keep in mind. Albert, what do you think? Fabio > Cheers, > Albert > > > Regards > > > > -Ed > > ___ > Okular-devel mailing list > Okular-devel@kde.org > https://mail.kde.org/mailman/listinfo/okular-devel -- Fabio ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328961] Highlight annotation in review side bar when double clicking on it
https://bugs.kde.org/show_bug.cgi?id=328961 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED CC||aa...@kde.org Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328961] New: Highlight annotation in review side bar when double clicking on it
https://bugs.kde.org/show_bug.cgi?id=328961 Bug ID: 328961 Summary: Highlight annotation in review side bar when double clicking on it Classification: Unclassified Product: okular Version: 0.17.4 Platform: unspecified OS: Linux Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: maris@gmail.com Currently there is no connection between selecting an annotation and review side bar. It would be nice to be able to see current (activated) annotation position in the review side bar's tree. Partially it's connected to other issue - it's tricky to activate an annotation that is behind other annotation (example - comment in a stroked-out text). It is possible to find current active note by browsing the review tree, but unfolding tree and highlighting item automatically would be more convenient. This is a reverse version of wish from Bug 323454 . Reproducible: Always -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
