[Okular-devel] fixing Audioplayer Junior job

2014-01-26 Thread GAURAV Agrawal
Hello,


I saw this bug:

Bug 326536 https://bugs.kde.org/show_bug.cgi?id=326536 - Extend
AudioPlayer so that it gives info about if something is playing at the
moment or not
--
 In order to fix it ,I wanted to experience the bug myself, but I am not
able to play any audio file in okular and I cannot see any option of
AudioPlayer in the Okular GUI. I am not being able to proceed because of
this.
Please help me to understand this bug and to guide me to the option of
playing audio file in okular.

Thanks,

Gaurav
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] fixing Audioplayer Junior job

2014-01-26 Thread Albert Astals Cid
El Diumenge, 26 de gener de 2014, a les 20:21:59, GAURAV Agrawal va escriure:
 Hello,
 
 
 I saw this bug:
 
 Bug 326536 https://bugs.kde.org/show_bug.cgi?id=326536 - Extend
 AudioPlayer so that it gives info about if something is playing at the
 moment or not
 --
  In order to fix it ,I wanted to experience the bug myself, but I am not
 able to play any audio file in okular and I cannot see any option of
 AudioPlayer in the Okular GUI. I am not being able to proceed because of
 this.
 Please help me to understand this bug and to guide me to the option of
 playing audio file in okular.

What part of the text of the bug you don't understand?

Cheers,
  Albert

 
 Thanks,
 
 Gaurav

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 326536] Extend AudioPlayer so that it gives info about if something is playing at the moment or not

2014-01-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326536

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
Part of this is already done (the extending part), what still needs to be done
is the right click part.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-01-26 Thread Albert Astals Cid


 On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote:
  ui/pageview.cpp, line 3594
  https://git.reviewboard.kde.org/r/112370/diff/4/?file=220850#file220850line3594
 
  This 6 and 12 are connected to the 6 and 12 used in 
  PageView::slotRelayoutPages? It'd be great if you could add some static int 
  const for them, previously they were used in a span of 5 lines, but they 
  are very far away from eachotehr now so a proper constant is really welcome
 
 Tingnan Zhang wrote:
 Do you prefer to put the 6 and 12 as static members of the class or to 
 make them global constants of this cpp file?
 
 Albert Astals Cid wrote:
 static const in the cpp file.

Tignan?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112370/#review46423
---


On Nov. 28, 2013, 7:35 a.m., Tingnan Zhang wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/112370/
 ---
 
 (Updated Nov. 28, 2013, 7:35 a.m.)
 
 
 Review request for Okular.
 
 
 Repository: okular
 
 
 Description
 ---
 
 BugFix 323434/323435. Zoom factor now will be properly rounded to those 
 interval values like 140%, 250%, etc, when using zoom in and out feature. 
 
 
 Diffs
 -
 
   ui/pageview.h 9c15af674e22c2b162fbd330228eb92545cbf805 
   ui/pageview.cpp 65967bf9399980e89953cce3c6d7145f41155c86 
 
 Diff: https://git.reviewboard.kde.org/r/112370/diff/
 
 
 Testing
 ---
 
 done on local machine
 
 
 Thanks,
 
 Tingnan Zhang
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

2014-01-26 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review48302
---



part.cpp
https://git.reviewboard.kde.org/r/115072/#comment34180

What's this for?


- Albert Astals Cid


On Jan. 20, 2014, 8:11 a.m., Saheb Preet Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115072/
 ---
 
 (Updated Jan. 20, 2014, 8:11 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 328125
 http://bugs.kde.org/show_bug.cgi?id=328125
 
 
 Repository: okular
 
 
 Description
 ---
 
 Okular don't have any play pause button in the presentation mode.
 
 Implemented a playpause action in the action collection in part.cpp.
 
 Used this action in presentationwidget.cpp to add it to the toolbar. Finally 
 connected it to a slot defined in presentationwidget.h
 
 In this slot when the signal is triggered on the next page timer is initiated 
 and its single shot behaviour is turned off. The icon is changed to the pause 
 button icon
 
 When the signal is triggered off the next page timer is stopped and its 
 single shot behaviour is reverted back to true. The icon is changed to the 
 play button.
 
 
 Diffs
 -
 
   part.cpp 88e2c41 
   ui/presentationwidget.h c63e119 
   ui/presentationwidget.cpp 1b63e2f 
 
 Diff: https://git.reviewboard.kde.org/r/115072/diff/
 
 
 Testing
 ---
 
 tested on local machine, working as desired.
 
 
 Thanks,
 
 Saheb Preet Singh
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] fixing AudioPlayer bug

2014-01-26 Thread GAURAV Agrawal
Hi,

Firstly,I wanted to know about audioplayer in okular as I cant locate it in
okular application.
Secondly,I didnt understand the part extending the application.Please if
you could elaborate that for me.

Thanks,

Gaurav
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] fixing AudioPlayer bug

2014-01-26 Thread Albert Astals Cid
El Dilluns, 27 de gener de 2014, a les 02:40:47, GAURAV Agrawal va escriure:
 Hi,

Hi, any reason you sent a new email instead of answering to the other ones 
about this issue?

 Firstly,I wanted to know about audioplayer in okular as I cant locate it in
 okular application.

Really? Did you look *at all*?

$ find -name audioplayer*
./core/audioplayer_p.h
./core/audioplayer.cpp
./core/audioplayer.h

 Secondly,I didnt understand the part extending the application.Please if
 you could elaborate that for me.

No, i can't, the description is perfectly accurate, if you don't understand 
it, you need to perseverate more in understanding the text or find something 
else.

Albert

 
 Thanks,
 
 Gaurav

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 330443] New: Presentation reopens on active desktop while displayed document is changed

2014-01-26 Thread moviuro
https://bugs.kde.org/show_bug.cgi?id=330443

Bug ID: 330443
   Summary: Presentation reopens on active desktop while displayed
document is changed
Classification: Unclassified
   Product: okular
   Version: 0.18.0
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: movi...@gmail.com

The presentation mode pops open on the active desktop whenever the file being
presented changes, even if it was previously on an other desktop. Since it is a
'presentation' mode, it'll hide anything on the current desktop, forcing you to
either close it or move the presentation to an other desktop.

Reproducible: Always

Steps to Reproduce:
1. Open a file with okular
2. Open presentation mode (Ctrl+Shift+P)
3. Switch to an other virtual desktop
4. Modify the file opened in presentation mode (eg rewrite it with an other
file, or add some text to an ODT file...)
Actual Results:  
Presentation is reloaded and displayed on the current desktop (hiding anything
you were doing)

Expected Results:  
Presentation is reloaded on its desktop without interfering with the current
desktop

The actual version I am using is 0.18.1, but is not in the list of versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 330443] Presentation reopens on active desktop while displayed document is changed

2014-01-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=330443

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||aa...@kde.org
Version|0.18.0  |0.18.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 330443] Presentation reopens on active desktop while displayed document is changed

2014-01-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=330443

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-26 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=330431

Jekyll Wu adap...@gmail.com changed:

   What|Removed |Added

  Component|general |general
Version|4.11.4  |0.17.4
   Assignee|gwenview-bugs-n...@kde.org  |okular-devel@kde.org
Product|gwenview|okular

--- Comment #2 from Jekyll Wu adap...@gmail.com ---
I suppose you are re-reporting bug 330426 in English. Reassign to okular
developers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel