Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 7:02 a.m.)


Review request for Okular.


Changes
---

Bug fix: now scroll mode exits correctly under Text Selection Tools.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 119252] please add smooth scrolling

[Yichao Zhou]

https://bugs.kde.org/show_bug.cgi?id=119252

Yichao Zhou  changed:

   What|Removed |Added

 CC||broken.z...@gmail.com

--- Comment #9 from Yichao Zhou  ---
I think this feature is not implemented.  This feature request should not be
flagged as FIXED.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:55 a.m.)


Review request for Okular.


Changes
---

Adjust the scroll speed so that it is similar to the speed in firefox.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:44 a.m.)


Review request for Okular.


Changes
---

Now escape key can exit scroll mode correctly.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 5:31 a.m.)


Review request for Okular.


Changes
---

Bug fix:  Now left-click after a middle-click can exit scroll mode correctly.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

[Jonathan Doman]

> On Jan. 28, 2014, 12:01 a.m., Albert Astals Cid wrote:
> > Can you confirm that 
> > 
> > diff --git a/part.rc b/part.rc
> > index 6b1f44e..0b9cee5 100644
> > --- a/part.rc
> > +++ b/part.rc
> > @@ -84,7 +84,7 @@
> >  
> >  
> >  
> > -
> > +
> >
> >&Help
> >  
> > 
> > fixes the settings menubar jumping issue?

Yeah, that seems to keep everything in order. Should I add that to this patch?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review48432
---


On Jan. 19, 2014, 9:34 p.m., Jonathan Doman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110914/
> ---
> 
> (Updated Jan. 19, 2014, 9:34 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 155515
> http://bugs.kde.org/show_bug.cgi?id=155515
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch adds support for a tabbed interface (multiple documents in one 
> window). The core work just adds a tab bar that switches between multiple 
> embedded okularparts, but there are many other considerations:
>  - Tab context menu allows for duplicating or detaching (detached tabs start 
> in new okular process)
>  - `okular file.pdf` will open file in existing window if possible, unless 
> --new flag is used. It also selects the most recently raised/activated window 
> to use. This mirrors behavior I expect from browsers and other tabbed 
> interfaces.
>  - Warns when closing window with multiple tabs
>  - No warning is given when opening an already open file. This is the 
> behavior I strongly prefer (and observe in other programs), but will change 
> if there is consensus otherwise.
> 
> When selecting different tools in one part, the tool selection propagates to 
> all parts, but the GUI does not reflect that. This bug is present in other 
> programs (e.g. multiple okularparts in Konqueror), so I made no attempt to 
> diagnose or fix.
> 
> One menu item was added for the multiple tab warning option. When testing 
> this, I noticed that items in the Settings menu seem to move around when 
> switching tabs, and I cannot diagnose or fix this. It seems to be related to 
> XMLGUI bug #64754. 
> 
> My development branch is also hosted at 
> https://github.com/jrmrjnck/okular-tabbed
> 
> 
> Diffs
> -
> 
>   part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
>   part.cpp 88e2c41059344dbd11d4c94f99c63a3f5bc8c99b 
>   shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
>   shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
>   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
> 
> Diff: https://git.reviewboard.kde.org/r/110914/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

(Updated Jan. 28, 2014, 3:49 a.m.)


Review request for Okular.


Changes
---

A new version which handles all the comments.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs (updated)
-

  conf/dlgaccessibilitybase.ui 9e76a75 
  conf/okular.kcfg deabd07 
  ui/pageview.h 9c15af6 
  ui/pageview.cpp 65967bf 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4485
> > 
> >
> > Can you explain why the need for a timer?

This is because, in scroll mode, user just moves their mouse a little bit and 
then does nothing.  The screen will automatically scroll until user exits 
scroll mode (by another mouse click).

In order to let the screen scroll duratively, you will need a timer.


> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2307
> > 
> >
> > Since you're repeating these blocks over and over you may want to add 
> > it into a quick function maybe, so that if in the future we need to change 
> > something we don't mistakingly forget one of the places.

bool middlePressZooms();
bool middlePressScrolls();


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> ---
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
> http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
> implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more 
> features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
> selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.h, line 221
> > 
> >
> > missing "r" in Scoll

OK.  But slotAutoScoll() is also missing a "r".  I have fixed that also.


> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 4497
> > 
> >
> > repaint is a bit bad, does update work?

repaint is unnecessary.  I have fixed that.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> ---
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
> http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
> implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more 
> features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
> selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > "* In scroll mode, now okular can load new page correctly"
> > 
> > What does this mean?

It means that the orignal patch in Bugs 219121 will not load new page due to 
the guard code in PageView::slotRequestVisiblePixmaps().


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> ---
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
> http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
> implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more 
> features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
> selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2112
> > 
> >
> > What's the change in this block?
> 
> Yichao Zhou wrote:
> The indentation of that line is not correct.  It just lets me feel bad.

The indentation of that line is not correct.  It just lets me feel bad.


> On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 2112
> > 
> >
> > What's the change in this block?
> 
> Yichao Zhou wrote:
> The indentation of that line is not correct.  It just lets me feel bad.

The indentation of that line is not correct.  It just lets me feel bad.


- Yichao


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> ---
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
> http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
> implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more 
> features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
> selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110914/#review48432
---


Can you confirm that 

diff --git a/part.rc b/part.rc
index 6b1f44e..0b9cee5 100644
--- a/part.rc
+++ b/part.rc
@@ -84,7 +84,7 @@
 
 
 
-
+
   
   &Help
 

fixes the settings menubar jumping issue?

- Albert Astals Cid


On Jan. 19, 2014, 9:34 p.m., Jonathan Doman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110914/
> ---
> 
> (Updated Jan. 19, 2014, 9:34 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 155515
> http://bugs.kde.org/show_bug.cgi?id=155515
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch adds support for a tabbed interface (multiple documents in one 
> window). The core work just adds a tab bar that switches between multiple 
> embedded okularparts, but there are many other considerations:
>  - Tab context menu allows for duplicating or detaching (detached tabs start 
> in new okular process)
>  - `okular file.pdf` will open file in existing window if possible, unless 
> --new flag is used. It also selects the most recently raised/activated window 
> to use. This mirrors behavior I expect from browsers and other tabbed 
> interfaces.
>  - Warns when closing window with multiple tabs
>  - No warning is given when opening an already open file. This is the 
> behavior I strongly prefer (and observe in other programs), but will change 
> if there is consensus otherwise.
> 
> When selecting different tools in one part, the tool selection propagates to 
> all parts, but the GUI does not reflect that. This bug is present in other 
> programs (e.g. multiple okularparts in Konqueror), so I made no attempt to 
> diagnose or fix.
> 
> One menu item was added for the multiple tab warning option. When testing 
> this, I noticed that items in the Settings menu seem to move around when 
> switching tabs, and I cannot diagnose or fix this. It seems to be related to 
> XMLGUI bug #64754. 
> 
> My development branch is also hosted at 
> https://github.com/jrmrjnck/okular-tabbed
> 
> 
> Diffs
> -
> 
>   part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
>   part.cpp 88e2c41059344dbd11d4c94f99c63a3f5bc8c99b 
>   shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
>   shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
>   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
> 
> Diff: https://git.reviewboard.kde.org/r/110914/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=330431

--- Comment #9 from Albert Astals Cid  ---
Sad indeed, the number of bugs and features people ask for is immense and we
are just a couple of volunteers so we can't do everything. Of course you can
always learn to code and fix it yourself or hire someone to fix it for you,
which is much more of what you could do if Okular was not free software.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[BuxarNET]

https://bugs.kde.org/show_bug.cgi?id=330431

--- Comment #8 from BuxarNET  ---
since 2011 and the issue is not solved. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review48420
---



part.cpp


signal() and slot() should not have spaces, it seems it makes the moc stuff 
a bit slower for no reason, see how we have the spaces collapsed in all the 
other connect()s



part.cpp


You don't need this, you can just chain signal to signal in the connect 
statement



ui/pageview.cpp


I'd prefer we disabled/enabled the action depending if we are in continuous 
mode or not, otherwise you end up with an enabled action that does nothing. 
That is pretty bad user wise.


- Albert Astals Cid


On Jan. 27, 2014, 8:24 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115283/
> ---
> 
> (Updated Jan. 27, 2014, 8:24 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326844
> http://bugs.kde.org/show_bug.cgi?id=326844
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> okular do not have a feature to resize the current window to the current page 
> size.
> 
> The bug is solved upto some extent, the window is resizing as desired.
> 
> resize method of qwidget class is used to resize the window.
> 
> The window is resizing  as required but sometimes it doesn't resizes . It has 
> to be moved by mouse and then again click on the button in the menu to resize 
> the window again.  Once it is moved by mouse, it works fine. Now, when the 
> zoom level is changed, the problem starts again.
> 
> I think the problem occurs due to something happening in the other portion of 
> the code.
> 
> I searched about it on the internet and nobody was able to answer the 
> solution to people with same problem. There are some alternative solutions to 
> the problem:-
> 
> ==> Use set geometry instead of resize which works fine. but would have to be 
> taken care of the size of the screen and the original position of the window. 
> Also, repainting the portion outside the window when the window is resized to 
> a smaller window.
> 
> ==> Use a timer which will signal a slot which in turn will resize the 
> window, but that might require qsignalmapper to map the width and height to 
> the slot. ( I didn't tried this solution ).
> 
> The best solution i could find on the internet is this 
> http://qt-project.org/forums/viewthread/25648
> 
> Also, there is one more issue, the fit window to page button in the view menu 
> is enabled by default. It should not be enabled when no document is open. 
> Where should the code for enabling this button should be implemented.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   shell/shell.cpp 1708501 
>   ui/pageview.h 9c15af6 
>   shell/shell.h c065c56 
>   part.rc 6b1f44e 
>   part.h 4b3aafd 
>   part.cpp 88e2c41 
> 
> Diff: https://git.reviewboard.kde.org/r/115283/diff/
> 
> 
> Testing
> ---
> 
> 
> tested when
> ==> window is maximized and restored.
> ==> thumbnails, table of content are opened and closed.
> ==> various toolbars are shown and hidden.
> ==> for all the zoom levels shown in the toolbar and custom zoom level ( 
> example 123.23% ).
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review48419
---



ui/presentationwidget.cpp


Do you need this?



ui/presentationwidget.cpp


Why this?


- Albert Astals Cid


On Jan. 27, 2014, 9:41 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115072/
> ---
> 
> (Updated Jan. 27, 2014, 9:41 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328125
> http://bugs.kde.org/show_bug.cgi?id=328125
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Okular don't have any play pause button in the presentation mode.
> 
> Implemented a playpause action in the action collection in part.cpp.
> 
> Used this action in presentationwidget.cpp to add it to the toolbar. Finally 
> connected it to a slot defined in presentationwidget.h
> 
> In this slot when the signal is triggered on the next page timer is initiated 
> and its single shot behaviour is turned off. The icon is changed to the pause 
> button icon
> 
> When the signal is triggered off the next page timer is stopped and its 
> single shot behaviour is reverted back to true. The icon is changed to the 
> play button.
> 
> 
> Diffs
> -
> 
>   ui/presentationwidget.cpp 1b63e2f 
>   ui/presentationwidget.h c63e119 
> 
> Diff: https://git.reviewboard.kde.org/r/115072/diff/
> 
> 
> Testing
> ---
> 
> tested on local machine, working as desired.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/#review48417
---


"* In scroll mode, now okular can load new page correctly"

What does this mean?


conf/dlgaccessibilitybase.ui


Click -> Press? See below



conf/okular.kcfg


What About MiddlePress and not MiddleClick? Since it's more about stuff 
that happens when you press the button and not release it yet more than stuff 
that happens on click



ui/pageview.h


missing "r" in Scoll



ui/pageview.cpp


const

Also not sure i like he zoomAllowed name, what about "middlePressZooms"?



ui/pageview.cpp


What's the change in this block?



ui/pageview.cpp


Since you're repeating these blocks over and over you may want to add it 
into a quick function maybe, so that if in the future we need to change 
something we don't mistakingly forget one of the places.



ui/pageview.cpp


Can you explain why the need for a timer?



ui/pageview.cpp


repaint is a bit bad, does update work?


- Albert Astals Cid


On Jan. 27, 2014, 5:13 p.m., Yichao Zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115335/
> ---
> 
> (Updated Jan. 27, 2014, 5:13 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 219121
> http://bugs.kde.org/show_bug.cgi?id=219121
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
> implemented that feature with an option in accessibility pages.
> 
> 
> This patch also fixes some problems in the original patch, and provides more 
> features, including
> * In scroll mode, you can press ctrl key to enter zoom mode
> * Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
> selection, etc.)
> * In scroll mode, now okular can load new page correctly
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   ui/pageview.h 9c15af6 
>   conf/okular.kcfg deabd07 
>   conf/dlgaccessibilitybase.ui 9e76a75 
> 
> Diff: https://git.reviewboard.kde.org/r/115335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=330431

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #7 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 283477 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 283477] Missing language specific characters when filling in forms

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=283477

Albert Astals Cid  changed:

   What|Removed |Added

 CC||buxar...@gmail.com

--- Comment #3 from Albert Astals Cid  ---
*** Bug 330431 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[BuxarNET]

https://bugs.kde.org/show_bug.cgi?id=330431

--- Comment #6 from BuxarNET  ---
yes, the problem is the same as in the ticker 283477 and 263042

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=330431

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #5 from Albert Astals Cid  ---
Honestly I don't understand what you mean, is what you are trying to report the
same as https://bugs.kde.org/show_bug.cgi?id=283477 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

[Yichao Zhou]

https://bugs.kde.org/show_bug.cgi?id=219121

--- Comment #10 from Yichao Zhou  ---
https://git.reviewboard.kde.org/r/115335/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

[Yichao Zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115335/
---

Review request for Okular.


Bugs: 219121
http://bugs.kde.org/show_bug.cgi?id=219121


Repository: okular


Description
---

According to the comments in https://bugs.kde.org/show_bug.cgi?id=219121, I 
implemented that feature with an option in accessibility pages.


This patch also fixes some problems in the original patch, and provides more 
features, including
* In scroll mode, you can press ctrl key to enter zoom mode
* Now you can use middle key to scroll in all mouse mode (broswer, zoom, 
selection, etc.)
* In scroll mode, now okular can load new page correctly


Diffs
-

  ui/pageview.cpp 65967bf 
  ui/pageview.h 9c15af6 
  conf/okular.kcfg deabd07 
  conf/dlgaccessibilitybase.ui 9e76a75 

Diff: https://git.reviewboard.kde.org/r/115335/diff/


Testing
---


Thanks,

Yichao Zhou

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330381] create/allow keyboard shortcut to close opened note (or last opened not or all open notes)

[JTPrince]

https://bugs.kde.org/show_bug.cgi?id=330381

JTPrince  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |FIXED

--- Comment #2 from JTPrince  ---
Indeed, it does.  Thank you for pointing this out!  [I marked this as "Fixed",
but I'm not sure if that is the proper way to close this.  Clearly, what really
needs fixing is my own ignorance and not Okular!]

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[BuxarNET]

https://bugs.kde.org/show_bug.cgi?id=330431

--- Comment #3 from BuxarNET  ---
thanks, yes okular

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330431] rus lang

[BuxarNET]

https://bugs.kde.org/show_bug.cgi?id=330431

--- Comment #4 from BuxarNET  ---
Created attachment 84857
  --> https://bugs.kde.org/attachment.cgi?id=84857&action=edit
document

I attach the document

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

[Saheb Preet Singh]

> On Jan. 26, 2014, 4:42 p.m., Albert Astals Cid wrote:
> > part.cpp, line 829
> > 
> >
> > What's this for?

sorry i didn't noticed that


- Saheb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/#review48302
---


On Jan. 27, 2014, 9:41 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115072/
> ---
> 
> (Updated Jan. 27, 2014, 9:41 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 328125
> http://bugs.kde.org/show_bug.cgi?id=328125
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Okular don't have any play pause button in the presentation mode.
> 
> Implemented a playpause action in the action collection in part.cpp.
> 
> Used this action in presentationwidget.cpp to add it to the toolbar. Finally 
> connected it to a slot defined in presentationwidget.h
> 
> In this slot when the signal is triggered on the next page timer is initiated 
> and its single shot behaviour is turned off. The icon is changed to the pause 
> button icon
> 
> When the signal is triggered off the next page timer is stopped and its 
> single shot behaviour is reverted back to true. The icon is changed to the 
> play button.
> 
> 
> Diffs
> -
> 
>   ui/presentationwidget.cpp 1b63e2f 
>   ui/presentationwidget.h c63e119 
> 
> Diff: https://git.reviewboard.kde.org/r/115072/diff/
> 
> 
> Testing
> ---
> 
> tested on local machine, working as desired.
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

[Saheb Preet Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115072/
---

(Updated Jan. 27, 2014, 9:41 a.m.)


Review request for Okular.


Changes
---

updated the above issue


Bugs: 328125
http://bugs.kde.org/show_bug.cgi?id=328125


Repository: okular


Description
---

Okular don't have any play pause button in the presentation mode.

Implemented a playpause action in the action collection in part.cpp.

Used this action in presentationwidget.cpp to add it to the toolbar. Finally 
connected it to a slot defined in presentationwidget.h

In this slot when the signal is triggered on the next page timer is initiated 
and its single shot behaviour is turned off. The icon is changed to the pause 
button icon

When the signal is triggered off the next page timer is stopped and its single 
shot behaviour is reverted back to true. The icon is changed to the play button.


Diffs (updated)
-

  ui/presentationwidget.cpp 1b63e2f 
  ui/presentationwidget.h c63e119 

Diff: https://git.reviewboard.kde.org/r/115072/diff/


Testing
---

tested on local machine, working as desired.


Thanks,

Saheb Preet Singh

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Saheb Preet Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/
---

(Updated Jan. 27, 2014, 8:24 a.m.)


Review request for Okular and Albert Astals Cid.


Bugs: 326844
http://bugs.kde.org/show_bug.cgi?id=326844


Repository: okular


Description
---

okular do not have a feature to resize the current window to the current page 
size.

The bug is solved upto some extent, the window is resizing as desired.

resize method of qwidget class is used to resize the window.

The window is resizing  as required but sometimes it doesn't resizes . It has 
to be moved by mouse and then again click on the button in the menu to resize 
the window again.  Once it is moved by mouse, it works fine. Now, when the zoom 
level is changed, the problem starts again.

I think the problem occurs due to something happening in the other portion of 
the code.

I searched about it on the internet and nobody was able to answer the solution 
to people with same problem. There are some alternative solutions to the 
problem:-

==> Use set geometry instead of resize which works fine. but would have to be 
taken care of the size of the screen and the original position of the window. 
Also, repainting the portion outside the window when the window is resized to a 
smaller window.

==> Use a timer which will signal a slot which in turn will resize the window, 
but that might require qsignalmapper to map the width and height to the slot. ( 
I didn't tried this solution ).

The best solution i could find on the internet is this 
http://qt-project.org/forums/viewthread/25648

Also, there is one more issue, the fit window to page button in the view menu 
is enabled by default. It should not be enabled when no document is open. Where 
should the code for enabling this button should be implemented.


Diffs
-

  ui/pageview.cpp 65967bf 
  shell/shell.cpp 1708501 
  ui/pageview.h 9c15af6 
  shell/shell.h c065c56 
  part.rc 6b1f44e 
  part.h 4b3aafd 
  part.cpp 88e2c41 

Diff: https://git.reviewboard.kde.org/r/115283/diff/


Testing
---


tested when
==> window is maximized and restored.
==> thumbnails, table of content are opened and closed.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level ( 
example 123.23% ).


Thanks,

Saheb Preet Singh

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Saheb Preet Singh]

> On Jan. 24, 2014, 7:24 p.m., Albert Astals Cid wrote:
> > I don't think there's any problem with resizing, i'd say it's only your 
> > math that is wrong
> > int xOffset = pageViewSize.width() - pageSize.width();
> > int yOffset = pageViewSize.height() - pageSize.height();
> > resize( width() - xOffset, height() - yOffset );
> > seems to be what you should really be doing, it doesn't perfectly work, but 
> > it may just be because the sizes you're using are not the correct.
> > 
> > Also I think this feature only makes sense when you're in non continuous 
> > view.
> >

Probably the arguments of resize function would be same in both cases ( in 
yours as well as mine ).
width() - xOffset = width() - pageViewSize.width() + pageSize.width(), when 
xOffset = pageViewSize.width() - pageSize.width();
pageSize.width() + xOffset = width() - pageViewSize.width() + pageSize.width(), 
when xOffset = width() - pageViewSize.width();
same in the case of height.

I changed the implementation as you have stated above.

The feature is not working perfectly because the xOffset (width other than 
pageViewSize) is changing with window's size whereas here xOffset and yOffsets 
are assumed to be constant. This mostly happens when thumbnails or toc etc. are 
open. I can't find out a way in which I can get the final size of these side 
widgets when the window will be resized or some porportionality factor with 
which there width is changing with respect to the whole window.


But the problem that I have stated above persists on my laptop. Steps to 
reproduce the problem :-
==> open okular and maximize the window.
==> change the zoom level, preferably very large from the current zoom level or 
very small.
==> select fit window to page option. Window will be restored but will not be 
resized.
==> If nothing happens then move the window and then again select fit window to 
page. Now the window will be resized, even if size of window is changed or the 
window is maximized.


- Saheb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review48238
---


On Jan. 27, 2014, 8:21 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115283/
> ---
> 
> (Updated Jan. 27, 2014, 8:21 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326844
> http://bugs.kde.org/show_bug.cgi?id=326844
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> okular do not have a feature to resize the current window to the current page 
> size.
> 
> The bug is solved upto some extent, the window is resizing as desired.
> 
> resize method of qwidget class is used to resize the window.
> 
> The window is resizing  as required but sometimes it doesn't resizes . It has 
> to be moved by mouse and then again click on the button in the menu to resize 
> the window again.  Once it is moved by mouse, it works fine. Now, when the 
> zoom level is changed, the problem starts again.
> 
> I think the problem occurs due to something happening in the other portion of 
> the code.
> 
> I searched about it on the internet and nobody was able to answer the 
> solution to people with same problem. There are some alternative solutions to 
> the problem:-
> 
> ==> Use set geometry instead of resize which works fine. but would have to be 
> taken care of the size of the screen and the original position of the window. 
> Also, repainting the portion outside the window when the window is resized to 
> a smaller window.
> 
> ==> Use a timer which will signal a slot which in turn will resize the 
> window, but that might require qsignalmapper to map the width and height to 
> the slot. ( I didn't tried this solution ).
> 
> The best solution i could find on the internet is this 
> http://qt-project.org/forums/viewthread/25648
> 
> Also, there is one more issue, the fit window to page button in the view menu 
> is enabled by default. It should not be enabled when no document is open. 
> Where should the code for enabling this button should be implemented.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   shell/shell.cpp 1708501 
>   ui/pageview.h 9c15af6 
>   shell/shell.h c065c56 
>   part.rc 6b1f44e 
>   part.h 4b3aafd 
>   part.cpp 88e2c41 
> 
> Diff: https://git.reviewboard.kde.org/r/115283/diff/
> 
> 
> Testing
> ---
> 
> 
> tested when
> ==> window is maximized and restored.
> ==> thumbnails, table of content are opened and closed.
> ==> various toolbars are shown and hidden.
> ==> for all the zoom levels shown in the toolbar and custom zoom level ( 
> example 123.23% ).
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Saheb Preet Singh]

> On Jan. 24, 2014, 7:24 p.m., Albert Astals Cid wrote:
> > I don't think there's any problem with resizing, i'd say it's only your 
> > math that is wrong
> > int xOffset = pageViewSize.width() - pageSize.width();
> > int yOffset = pageViewSize.height() - pageSize.height();
> > resize( width() - xOffset, height() - yOffset );
> > seems to be what you should really be doing, it doesn't perfectly work, but 
> > it may just be because the sizes you're using are not the correct.
> > 
> > Also I think this feature only makes sense when you're in non continuous 
> > view.
> >

Probably the arguments of resize function would be same in both cases ( in 
yours as well as mine ).
width() - xOffset = width() - pageViewSize.width() + pageSize.width(), when 
xOffset = pageViewSize.width() - pageSize.width();
pageSize.width() + xOffset = width() - pageViewSize.width() + pageSize.width(), 
when xOffset = width() - pageViewSize.width();
same in the case of height.

I changed the implementation as you have stated above.

The feature is not working perfectly because the xOffset (width other than 
pageViewSize) is changing with window's size whereas here xOffset and yOffsets 
are assumed to be constant. This mostly happens when thumbnails or toc etc. are 
open. I can't find out a way in which I can get the final size of these side 
widgets when the window will be resized or some porportionality factor with 
which there width is changing with respect to the whole window.


But the problem that I have stated above persists on my laptop. Steps to 
reproduce the problem :-
==> open okular and maximize the window.
==> change the zoom level, preferably very large from the current zoom level or 
very small.
==> select fit window to page option. Window will be restored but will not be 
resized.
==> If nothing happens then move the window and then again select fit window to 
page. Now the window will be resized, even if size of window is changed or the 
window is maximized.


- Saheb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review48238
---


On Jan. 27, 2014, 8:21 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115283/
> ---
> 
> (Updated Jan. 27, 2014, 8:21 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326844
> http://bugs.kde.org/show_bug.cgi?id=326844
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> okular do not have a feature to resize the current window to the current page 
> size.
> 
> The bug is solved upto some extent, the window is resizing as desired.
> 
> resize method of qwidget class is used to resize the window.
> 
> The window is resizing  as required but sometimes it doesn't resizes . It has 
> to be moved by mouse and then again click on the button in the menu to resize 
> the window again.  Once it is moved by mouse, it works fine. Now, when the 
> zoom level is changed, the problem starts again.
> 
> I think the problem occurs due to something happening in the other portion of 
> the code.
> 
> I searched about it on the internet and nobody was able to answer the 
> solution to people with same problem. There are some alternative solutions to 
> the problem:-
> 
> ==> Use set geometry instead of resize which works fine. but would have to be 
> taken care of the size of the screen and the original position of the window. 
> Also, repainting the portion outside the window when the window is resized to 
> a smaller window.
> 
> ==> Use a timer which will signal a slot which in turn will resize the 
> window, but that might require qsignalmapper to map the width and height to 
> the slot. ( I didn't tried this solution ).
> 
> The best solution i could find on the internet is this 
> http://qt-project.org/forums/viewthread/25648
> 
> Also, there is one more issue, the fit window to page button in the view menu 
> is enabled by default. It should not be enabled when no document is open. 
> Where should the code for enabling this button should be implemented.
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 65967bf 
>   shell/shell.cpp 1708501 
>   ui/pageview.h 9c15af6 
>   shell/shell.h c065c56 
>   part.rc 6b1f44e 
>   part.h 4b3aafd 
>   part.cpp 88e2c41 
> 
> Diff: https://git.reviewboard.kde.org/r/115283/diff/
> 
> 
> Testing
> ---
> 
> 
> tested when
> ==> window is maximized and restored.
> ==> thumbnails, table of content are opened and closed.
> ==> various toolbars are shown and hidden.
> ==> for all the zoom levels shown in the toolbar and custom zoom level ( 
> example 123.23% ).
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Saheb Preet Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/
---

(Updated Jan. 27, 2014, 8:21 a.m.)


Review request for Okular and Albert Astals Cid.


Changes
---

fixed above stated issues.


Bugs: 326844
http://bugs.kde.org/show_bug.cgi?id=326844


Repository: okular


Description
---

okular do not have a feature to resize the current window to the current page 
size.

The bug is solved upto some extent, the window is resizing as desired.

resize method of qwidget class is used to resize the window.

The window is resizing  as required but sometimes it doesn't resizes . It has 
to be moved by mouse and then again click on the button in the menu to resize 
the window again.  Once it is moved by mouse, it works fine. Now, when the zoom 
level is changed, the problem starts again.

I think the problem occurs due to something happening in the other portion of 
the code.

I searched about it on the internet and nobody was able to answer the solution 
to people with same problem. There are some alternative solutions to the 
problem:-

==> Use set geometry instead of resize which works fine. but would have to be 
taken care of the size of the screen and the original position of the window. 
Also, repainting the portion outside the window when the window is resized to a 
smaller window.

==> Use a timer which will signal a slot which in turn will resize the window, 
but that might require qsignalmapper to map the width and height to the slot. ( 
I didn't tried this solution ).

The best solution i could find on the internet is this 
http://qt-project.org/forums/viewthread/25648

Also, there is one more issue, the fit window to page button in the view menu 
is enabled by default. It should not be enabled when no document is open. Where 
should the code for enabling this button should be implemented.


Diffs (updated)
-

  ui/pageview.cpp 65967bf 
  shell/shell.cpp 1708501 
  ui/pageview.h 9c15af6 
  shell/shell.h c065c56 
  part.rc 6b1f44e 
  part.h 4b3aafd 
  part.cpp 88e2c41 

Diff: https://git.reviewboard.kde.org/r/115283/diff/


Testing
---


tested when
==> window is maximized and restored.
==> thumbnails, table of content are opened and closed.
==> various toolbars are shown and hidden.
==> for all the zoom levels shown in the toolbar and custom zoom level ( 
example 123.23% ).


Thanks,

Saheb Preet Singh

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel