Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Feb. 11, 2014, 10:51 a.m.) Review request for Okular. Changes --- The play/pause button does not depend on global settings now. The patch disables the button when advance slide is set in global settings. It disables the button as user should not be allowed to change the global settings from the widget. Bugs: 328125 http://bugs.kde.org/show_bug.cgi?id=328125 Repository: okular Description --- Okular don't have any play pause button in the presentation mode. Implemented a playpause action in the action collection in part.cpp. Used this action in presentationwidget.cpp to add it to the toolbar. Finally connected it to a slot defined in presentationwidget.h In this slot when the signal is triggered on the next page timer is initiated and its single shot behaviour is turned off. The icon is changed to the pause button icon When the signal is triggered off the next page timer is stopped and its single shot behaviour is reverted back to true. The icon is changed to the play button. Diffs (updated) - part.cpp 283e91a ui/presentationwidget.h c63e119 ui/presentationwidget.cpp 1b63e2f Diff: https://git.reviewboard.kde.org/r/115072/diff/ Testing --- tested on local machine, working as desired. Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Feb. 11, 2014, 10:53 a.m.) Review request for Okular and Albert Astals Cid. Changes --- rebased the patch with current code. Bugs: 326844 http://bugs.kde.org/show_bug.cgi?id=326844 Repository: okular Description --- okular do not have a feature to resize the current window to the current page size. The bug is solved upto some extent, the window is resizing as desired. resize method of qwidget class is used to resize the window. The window is resizing as required but sometimes it doesn't resizes . It has to be moved by mouse and then again click on the button in the menu to resize the window again. Once it is moved by mouse, it works fine. Now, when the zoom level is changed, the problem starts again. I think the problem occurs due to something happening in the other portion of the code. I searched about it on the internet and nobody was able to answer the solution to people with same problem. There are some alternative solutions to the problem:- == Use set geometry instead of resize which works fine. but would have to be taken care of the size of the screen and the original position of the window. Also, repainting the portion outside the window when the window is resized to a smaller window. == Use a timer which will signal a slot which in turn will resize the window, but that might require qsignalmapper to map the width and height to the slot. ( I didn't tried this solution ). The best solution i could find on the internet is this http://qt-project.org/forums/viewthread/25648 Also, there is one more issue, the fit window to page button in the view menu is enabled by default. It should not be enabled when no document is open. Where should the code for enabling this button should be implemented. Diffs (updated) - part.h 6df835b part.cpp 283e91a part.rc 0b9cee5 shell/shell.h 3b9aae0 shell/shell.cpp 8226153 ui/pageview.h 9c15af6 ui/pageview.cpp 65967bf Diff: https://git.reviewboard.kde.org/r/115283/diff/ Testing --- tested when == window is maximized and restored. == thumbnails, table of content are opened and closed. == various toolbars are shown and hidden. == for all the zoom levels shown in the toolbar and custom zoom level ( example 123.23% ). Thanks, Saheb Preet Singh ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 321046] printing some pdfs results in undefinedresult error due to awidthshow command
https://bugs.kde.org/show_bug.cgi?id=321046 Mark van Rossum mvanr...@inf.ed.ac.uk changed: What|Removed |Added CC||mvanr...@inf.ed.ac.uk --- Comment #14 from Mark van Rossum mvanr...@inf.ed.ac.uk --- It is a pity there is a regression like this. Although it might be down to the printer firmware, it is an often used HP printer. Furthermore, other software like acroread and evince do not cause problems... Anyway, here is a workaround: you can define an additional printer cue as a pcl. In my case HP LaserJet 4100 Foomatic/pxlmono This will work fine. Or use acroread -toPostScript as the pdf-PS converter. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 218219] Add Open in New Window Menu Item
https://bugs.kde.org/show_bug.cgi?id=218219 Denis Bitouzé dbito...@wanadoo.fr changed: What|Removed |Added CC||dbito...@wanadoo.fr --- Comment #3 from Denis Bitouzé dbito...@wanadoo.fr --- AFAICS, this feature is still not been implemented in Okular 4.11.4: too bad! :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328874] konqueror crashes when openning pdfs
https://bugs.kde.org/show_bug.cgi?id=328874 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #4 from Christoph Feck christ...@maxiom.de --- No response, changing status. If you have new information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 324273] KIle Crashed
https://bugs.kde.org/show_bug.cgi?id=324273 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO |INVALID --- Comment #4 from Christoph Feck christ...@maxiom.de --- No response, changing status. If you have new information, please add a comment. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 328874] konqueror crashes when openning pdfs
https://bugs.kde.org/show_bug.cgi?id=328874 --- Comment #5 from Mehmet Topsakal meto...@gmail.com --- problem seems to be resolved after upgrade to KDE 4.12 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Okular Sprint in Barcelona
El Dimarts, 4 de febrer de 2014, a les 01:16:38, Albert Astals Cid va escriure: Hi guys, i just created a doodle to see if we can find a date so we can meet in Barcelona from Thursday-Sunday and do the first Okular sprint ever! You can vote at http://doodle.com/t2t269pgw44ygh8e#table Voting closes next week tuesday (11th February). Last minute call, noone else wants to join? Cheers, Albert Cheers, Albert ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
