[Okular-devel] Build failed in Jenkins: okular_stable #311

[KDE CI System]

See 

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[okular_stable] $ /bin/sh -xe /tmp/hudson1013408438836245213.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Branch jenkins set up to track remote branch KDE/4.13 from origin.

== Cleaning Source Tree

HEAD is now at f171420 Ultra ugly hack for getting links to be blue unless 
css'ed
Success build forhudson.tasks.Shell@75a33238
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/okular
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Build failed in Jenkins: okular_stable #310

[KDE CI System]

See 

--
Started by user Ben Cooksley
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[okular_stable] $ /bin/sh -xe /tmp/hudson7682423408803596086.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Branch jenkins set up to track remote branch KDE/4.13 from origin.

== Cleaning Source Tree

HEAD is now at f171420 Ultra ugly hack for getting links to be blue unless 
css'ed
Removing build/
Removing install/
Success build forhudson.tasks.Shell@27ba8e87
Fetching changes from the remote Git repository
Fetching upstream changes from git://anongit.kde.org/okular
ERROR: Couldn't find any revision to build. Verify the repository and branch 
configuration for this job.
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330991] Unable to select table for a second time (without restarting Okular)

[Jonathan Doman]

https://bugs.kde.org/show_bug.cgi?id=330991

Jonathan Doman  changed:

   What|Removed |Added

 CC||jonathan.do...@gmail.com

--- Comment #4 from Jonathan Doman  ---
Perhaps AD does not realize you have to press Esc in order to make another
selection with the table tool. It differs from the other selection tools and is
a bit unintuitive because of this. Taken literally, the steps to reproduce do
behave as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111681/#review52850
---


This review has been submitted with commit 
60cc5dc98e502afd597555c48c8f350714c08349 by Albert Astals Cid on behalf of 
Christoph Feck to branch KDE/4.13.

- Commit Hook


On Aug. 20, 2013, 10:40 a.m., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/111681/
> ---
> 
> (Updated Aug. 20, 2013, 10:40 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 253583 and 322547
> http://bugs.kde.org/show_bug.cgi?id=253583
> http://bugs.kde.org/show_bug.cgi?id=322547
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> As indicated in bug 322547, some documents do not specify a text color, and 
> probably assume the default text color to be black. QTextDocument, however, 
> defaults to using the system text color.
> 
> This patch changes the default text color to Qt::black. It should affect 
> epub, fb2, odt, and plain text generators.
> 
> I think it is better to use this approach instead of changing the paper color 
> to use the system background color (see bug 253583), because
> 
> 1) the document might specify a text color in some places,
> 
> 2) the user is able to change the fg/bg colors anyway using Okular's 
> Accessibility options, and those probably expect black on white.
> 
> 
> Diffs
> -
> 
>   core/textdocumentgenerator.cpp b260b3f 
> 
> Diff: https://git.reviewboard.kde.org/r/111681/diff/
> 
> 
> Testing
> ---
> 
> I tested the document from bug 322547 comment #3.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322547] Using a Dark Colorscheme frequently leads to unreadable text.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=322547

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
   Version Fixed In||4.12.90
 Resolution|WAITINGFORINFO  |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/60cc5dc98e502afd597555c4
   ||8c8f350714c08349

--- Comment #5 from Albert Astals Cid  ---
Git commit 60cc5dc98e502afd597555c48c8f350714c08349 by Albert Astals Cid, on
behalf of Christoph Feck.
Committed on 12/03/2014 at 22:01.
Pushed by aacid into branch 'KDE/4.13'.

TextDocumentGenerator: Use black as default text color

REVIEW: 111681
Related: bug 253583
FIXED-IN: 4.12.90

M  +9-1core/textdocumentgenerator.cpp

http://commits.kde.org/okular/60cc5dc98e502afd597555c48c8f350714c08349

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 253583] Okular uses font color from system settings, but ignores the background color from there.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=253583

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||4.12.90
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/60cc5dc98e502afd597555c4
   ||8c8f350714c08349

--- Comment #13 from Albert Astals Cid  ---
Git commit 60cc5dc98e502afd597555c48c8f350714c08349 by Albert Astals Cid, on
behalf of Christoph Feck.
Committed on 12/03/2014 at 22:01.
Pushed by aacid into branch 'KDE/4.13'.

TextDocumentGenerator: Use black as default text color

REVIEW: 111681
Related: bug 322547
FIXED-IN: 4.12.90

M  +9-1core/textdocumentgenerator.cpp

http://commits.kde.org/okular/60cc5dc98e502afd597555c48c8f350714c08349

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111681/
---

(Updated March 12, 2014, 10:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 253583 and 322547
http://bugs.kde.org/show_bug.cgi?id=253583
http://bugs.kde.org/show_bug.cgi?id=322547


Repository: okular


Description
---

As indicated in bug 322547, some documents do not specify a text color, and 
probably assume the default text color to be black. QTextDocument, however, 
defaults to using the system text color.

This patch changes the default text color to Qt::black. It should affect epub, 
fb2, odt, and plain text generators.

I think it is better to use this approach instead of changing the paper color 
to use the system background color (see bug 253583), because

1) the document might specify a text color in some places,

2) the user is able to change the fg/bg colors anyway using Okular's 
Accessibility options, and those probably expect black on white.


Diffs
-

  core/textdocumentgenerator.cpp b260b3f 

Diff: https://git.reviewboard.kde.org/r/111681/diff/


Testing
---

I tested the document from bug 322547 comment #3.


Thanks,

Christoph Feck

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330991] Unable to select table for a second time (without restarting Okular)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=330991

--- Comment #3 from Christoph Feck  ---
To further investigate this issue, KDE developers need the information
requested in comment #1. If you can provide it, or need help with finding that
information, please add a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330376] Okular crashing when inserting notes in Debian Testing

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=330376

--- Comment #8 from Christoph Feck  ---
To further investigate this issue, KDE developers need the information
requested in comment #6. If you can provide it, or need help with finding that
information, please add a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330149] Yellow Highlighter Does Not working

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=330149

Christoph Feck  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Christoph Feck  ---
No response, changing status. Please reopen, if you have more information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115283/#review52845
---



ui/pageview.cpp


can you give the variable a better name? singlePageViewMode maybe?



ui/pageview.cpp


spacing is wrong



ui/pageview.cpp


please move the declaration inside the foreach



ui/pageview.cpp


Should this todo be removed now that you're disabling the action?


- Albert Astals Cid


On Feb. 25, 2014, 7:02 a.m., Saheb Preet Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115283/
> ---
> 
> (Updated Feb. 25, 2014, 7:02 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 326844
> http://bugs.kde.org/show_bug.cgi?id=326844
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> okular do not have a feature to resize the current window to the current page 
> size.
> 
> The bug is solved upto some extent, the window is resizing as desired.
> 
> resize method of qwidget class is used to resize the window.
> 
> The window is resizing  as required but sometimes it doesn't resizes . It has 
> to be moved by mouse and then again click on the button in the menu to resize 
> the window again.  Once it is moved by mouse, it works fine. Now, when the 
> zoom level is changed, the problem starts again.
> 
> I think the problem occurs due to something happening in the other portion of 
> the code.
> 
> I searched about it on the internet and nobody was able to answer the 
> solution to people with same problem. There are some alternative solutions to 
> the problem:-
> 
> ==> Use set geometry instead of resize which works fine. but would have to be 
> taken care of the size of the screen and the original position of the window. 
> Also, repainting the portion outside the window when the window is resized to 
> a smaller window.
> 
> ==> Use a timer which will signal a slot which in turn will resize the 
> window, but that might require qsignalmapper to map the width and height to 
> the slot. ( I didn't tried this solution ).
> 
> The best solution i could find on the internet is this 
> http://qt-project.org/forums/viewthread/25648
> 
> Also, there is one more issue, the fit window to page button in the view menu 
> is enabled by default. It should not be enabled when no document is open. 
> Where should the code for enabling this button should be implemented.
> 
> 
> Diffs
> -
> 
>   part.h 6df835b 
>   part.cpp 283e91a 
>   part.rc 0b9cee5 
>   shell/shell.h 3b9aae0 
>   shell/shell.cpp 8226153 
>   ui/pageview.h 9c15af6 
>   ui/pageview.cpp 65967bf 
> 
> Diff: https://git.reviewboard.kde.org/r/115283/diff/
> 
> 
> Testing
> ---
> 
> 
> tested when
> ==> window is maximized and restored.
> ==> thumbnails, table of content are opened and closed.
> ==> various toolbars are shown and hidden.
> ==> for all the zoom levels shown in the toolbar and custom zoom level ( 
> example 123.23% ).
> 
> 
> Thanks,
> 
> Saheb Preet Singh
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 319042] Make "Save As" directory/file same as opening directory/file

[Christian ML]

https://bugs.kde.org/show_bug.cgi?id=319042

--- Comment #8 from Christian ML  ---
Sorry, please ignore my last posting - "save copy as" seems to do exactly what
I need.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 319042] Make "Save As" directory/file same as opening directory/file

[Christian ML]

https://bugs.kde.org/show_bug.cgi?id=319042

Christian ML  changed:

   What|Removed |Added

 CC||c...@uni-muenster.de

--- Comment #7 from Christian ML  ---
I have to add a point to this old thread, because I just upgraded okular and
noticed the new behaviour:

One frequent situation is opening a (pdf) from within a browser, looking at it
and then eventually saving a copy of it. The new default "save as" dir is then
/tmp, which I find very annoying.

Is there a way to set my own default save directory ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel