[Okular-devel] [okular] [Bug 313815] Add Print current view option to the print dialogue
https://bugs.kde.org/show_bug.cgi?id=313815 Bill Wilkinson wrw...@yahoo.com changed: What|Removed |Added CC||wrw...@yahoo.com --- Comment #1 from Bill Wilkinson wrw...@yahoo.com --- Agreed! I do a number of things which require zooming in to a document to print an enlarged version of part of a page, and this would be greatly appreciated! As Adobe has apparently stopped development on the linux version of Reader, there's a glaring hole for this functionality. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334088] Upgraded to Kubuntu 14.04, Okular crashes with Fatal IO error
https://bugs.kde.org/show_bug.cgi?id=334088 --- Comment #28 from ptomb...@xcski.com --- Why is this marked as fixed when it's still happening? As far as I can tell, the problems with libkscreen aren't fixed in 1.0.4, which is the latest released version. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Jenkins build became unstable: okular_master #471
See http://build.kde.org/job/okular_master/471/changes ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334088] Upgraded to Kubuntu 14.04, Okular crashes with Fatal IO error
https://bugs.kde.org/show_bug.cgi?id=334088 --- Comment #29 from Albert Astals Cid aa...@kde.org --- Well, they seem to be fixed to me, what problem are you having exactly? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Jenkins build is back to stable : okular_master #472
See http://build.kde.org/job/okular_master/472/ ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334088] Upgraded to Kubuntu 14.04, Okular crashes with Fatal IO error
https://bugs.kde.org/show_bug.cgi?id=334088 --- Comment #30 from ptomb...@xcski.com --- Well, I'm still getting the exact same errors (unless I set KSCREEN_BACKEND=Fake), but maybe your fix hasn't been pushed to Kubuntu's repos yet? The comments on https://bugs.kde.org/show_bug.cgi?id=331784 indicate that libkscreen 1.0.4 doesn't fix it and there isn't a 1.0.5 yet. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334088] Upgraded to Kubuntu 14.04, Okular crashes with Fatal IO error
https://bugs.kde.org/show_bug.cgi?id=334088 --- Comment #31 from Albert Astals Cid aa...@kde.org --- Yeah you're right, libkscreen still crashes, it's still a libscreen bug, nothing to fix in okular -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334088] Upgraded to Kubuntu 14.04, Okular crashes with Fatal IO error
https://bugs.kde.org/show_bug.cgi?id=334088 --- Comment #32 from ptomb...@xcski.com --- I guess that's the age-old question - is a bug fixed when you've fixed your part, or is it fixed when the reported behaviour stops happening. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 118685: Make tabs rearrangeable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118685/ --- (Updated July 30, 2014, 10:15 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Bugs: 334018 http://bugs.kde.org/show_bug.cgi?id=334018 Repository: okular Description --- Catch the tabMoved signal emitted by the tab bar in order to rearrange the internal data. Slightly more than the single line I thought it would be. Diffs - shell/shell.h f25b3d8c01215534b9a7097d1e229607c8f98ef3 shell/shell.cpp 9ee422a60feb31286abc5ec178ce64835fd80781 Diff: https://git.reviewboard.kde.org/r/118685/diff/ Testing --- Tested that the GUI remains coherent when moving two tabs around many times. As before, the tool selections aren't quite coherent, but that's for another patch. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334018] Tabs should be rearrangeable
https://bugs.kde.org/show_bug.cgi?id=334018 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Version Fixed In||4.14.0 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/375c72dc66759e91074363f1 ||0677a938a195f4e4 --- Comment #3 from Albert Astals Cid aa...@kde.org --- Git commit 375c72dc66759e91074363f10677a938a195f4e4 by Albert Astals Cid, on behalf of Jonathan Doman. Committed on 30/07/2014 at 22:15. Pushed by aacid into branch 'KDE/4.14'. Make tabs rearrangeable FIXED-IN: 4.14.0 REVIEW: 118685 M +8-0shell/shell.cpp M +1-0shell/shell.h http://commits.kde.org/okular/375c72dc66759e91074363f10677a938a195f4e4 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334510] Opening a second file from shell with a relative folder name when tabs are used fails
https://bugs.kde.org/show_bug.cgi?id=334510 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||jonathan.do...@gmail.com --- Comment #2 from Albert Astals Cid aa...@kde.org --- Jonathan any chance we can get a fix for this for 4.14.0 (tagging in one week)? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334566] If a document fails to open, the empty window/tab is not used when a another document is open
https://bugs.kde.org/show_bug.cgi?id=334566 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org, ||jonathan.do...@gmail.com --- Comment #1 from Albert Astals Cid aa...@kde.org --- Jonathan any chance we can get a fix for this for 4.14.0 (tagging in one week)? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 335852] Multiple tabs session restore fails
https://bugs.kde.org/show_bug.cgi?id=335852 --- Comment #4 from Albert Astals Cid aa...@kde.org --- Jonathan any chance we can get a fix for this for 4.14.0 (tagging in one week)? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334019] Okular should warn if closing with multiple tabs opened
https://bugs.kde.org/show_bug.cgi?id=334019 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular
On jul. 14, 2014, 10:57 p.m., Albert Astals Cid wrote:
I'd say we're still leaking m_currentTransition sometimes, like for example
PresentationWidget::slotPrevPage has
if ( m_transitionTimer-isActive() )
{
m_transitionTimer-stop();
update();
}
so the transition step won't be called and m_currentTransition won't be
deleted. Isn't it easier if you just make it a member variable instead of a
pointer so we don't have to worry about it?
Saheb Preet Singh wrote:
Fixed the above said issues.
Sir I also wanted to ask you something,
its commented in the code // implement missing transitions (a binary
raster engine needed here)
Am I implementing the feature in a right way ?? Is there any other better
way of doing it??
Yes, this is fine, sorry i'm not reviewing fast enough. We are in feature
freeze for next release anyway so this can only go into the December release.
Will make sure i finish the review before then :)
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review62357
---
On jul. 16, 2014, 7:53 a.m., Saheb Preet Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/
---
(Updated jul. 16, 2014, 7:53 a.m.)
Review request for Okular.
Bugs: 317073
http://bugs.kde.org/show_bug.cgi?id=317073
Repository: okular
Description
---
implemented fade in and fade out transition for presentation mode in okular.
Diffs
-
conf/dlgpresentationbase.ui 31db693
conf/okular.kcfg f980989
ui/presentationwidget.h a99b8ce
ui/presentationwidget.cpp 4aaec2a
Diff: https://git.reviewboard.kde.org/r/115532/diff/
Testing
---
Thanks,
Saheb Preet Singh
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119550/ --- Review request for Okular. Bugs: 334510 http://bugs.kde.org/show_bug.cgi?id=334510 Repository: okular Description --- When opening files through DBus, relative file names don't work if the processes are in different working directories. Ensure that all arguments are made absolute. Diffs - shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51 Diff: https://git.reviewboard.kde.org/r/119550/diff/ Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 119550: Use absolute filepath when attaching to existing windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119550/ --- (Updated July 30, 2014, 11:50 p.m.) Review request for Okular. Bugs: 334510 http://bugs.kde.org/show_bug.cgi?id=334510 Repository: okular Description --- When opening files through DBus, relative file names don't work if the processes are in different working directories. Ensure that all arguments are made absolute. Diffs (updated) - shell/main.cpp d2e0ec72fd43b560d25ac7f903462641cdbbff51 Diff: https://git.reviewboard.kde.org/r/119550/diff/ Testing --- Tested steps described in bug report. Thanks, Jonathan Doman ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 334510] Opening a second file from shell with a relative folder name when tabs are used fails
https://bugs.kde.org/show_bug.cgi?id=334510 --- Comment #3 from Jonathan Doman jonathan.do...@gmail.com --- Thanks for the tip, Willem. The patch is posted. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
