[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

2015-03-31 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=318998

Simon Andric simonandr...@gmail.com changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 115532: Fade In and Fade Out transition in presentation mode okular

2015-03-31 Thread sahil sehgal

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115532/#review78289
---


The Revision 12 works fine but there is still some glitches when we fastly 
switch over the pages.

- sahil sehgal


On March 26, 2015, 7:01 a.m., Saheb Preet Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115532/
 ---
 
 (Updated March 26, 2015, 7:01 a.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 317073
 http://bugs.kde.org/show_bug.cgi?id=317073
 
 
 Repository: okular
 
 
 Description
 ---
 
 implemented fade in and fade out transition for presentation mode in okular.
 
 
 Diffs
 -
 
   conf/dlgpresentationbase.ui 31db693 
   conf/okular.kcfg f980989 
   ui/presentationwidget.h a99b8ce 
   ui/presentationwidget.cpp d676069 
 
 Diff: https://git.reviewboard.kde.org/r/115532/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Saheb Preet Singh
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 123085: Use descriptive KGuiItem labels for buttons in calls to KMessageBox

2015-03-31 Thread sahil sehgal


 On March 30, 2015, 7:48 p.m., Albert Astals Cid wrote:
  part.cpp, line 1468
  https://git.reviewboard.kde.org/r/123085/diff/1/?file=355932#file355932line1468
 
  why the extra verbosity?

Just to make it more descriptive as according to the bug that was reported


- sahil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123085/#review78250
---


On March 20, 2015, 5:46 p.m., sahil sehgal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123085/
 ---
 
 (Updated March 20, 2015, 5:46 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 309739
 http://bugs.kde.org/show_bug.cgi?id=309739
 
 
 Repository: okular
 
 
 Description
 ---
 
 Earlier the KmessageBox dialog box contained yes, no or continue buttons 
 without any description. But now there is description like Continue 
 searching etc in the boxes.
 
 
 Diffs
 -
 
   part.cpp 36438af 
   ui/searchlineedit.cpp 2add7fa 
 
 Diff: https://git.reviewboard.kde.org/r/123085/diff/
 
 
 Testing
 ---
 
 Executed successfully on the dialog boxes.
 
 
 Thanks,
 
 sahil sehgal
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 123085: Use descriptive KGuiItem labels for buttons in calls to KMessageBox

2015-03-31 Thread sahil sehgal


 On March 30, 2015, 7:48 p.m., Albert Astals Cid wrote:
  ui/searchlineedit.cpp, line 258
  https://git.reviewboard.kde.org/r/123085/diff/1/?file=355933#file355933line258
 
  Why is Continue from beginning a better answer than Yes to the 
  question Continue from beginning?

Yes you are right Yes is a better answer.


- sahil


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123085/#review78250
---


On March 20, 2015, 5:46 p.m., sahil sehgal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123085/
 ---
 
 (Updated March 20, 2015, 5:46 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 309739
 http://bugs.kde.org/show_bug.cgi?id=309739
 
 
 Repository: okular
 
 
 Description
 ---
 
 Earlier the KmessageBox dialog box contained yes, no or continue buttons 
 without any description. But now there is description like Continue 
 searching etc in the boxes.
 
 
 Diffs
 -
 
   part.cpp 36438af 
   ui/searchlineedit.cpp 2add7fa 
 
 Diff: https://git.reviewboard.kde.org/r/123085/diff/
 
 
 Testing
 ---
 
 Executed successfully on the dialog boxes.
 
 
 Thanks,
 
 sahil sehgal
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 321992] Feature request: Can the highlighter automatically fill the attached pop-up note with highlighted text.

2015-03-31 Thread Chris George
https://bugs.kde.org/show_bug.cgi?id=321992

Chris George technat...@gmail.com changed:

   What|Removed |Added

 CC||technat...@gmail.com

--- Comment #9 from Chris George technat...@gmail.com ---
I am working with a text editor/outliner to create academic papers. Having the
content of highlighted text appear in the xml metadata would be immensely
useful and save considerable time and effort when summarizing papers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 123176: Fix include and library information of OkularConfig.cmake.

2015-03-31 Thread Andreas Cord-Landwehr

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123176/
---

(Updated March 31, 2015, 4:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 9e603cc9239fc26879cb7a95548572aa35162f53 by Andreas 
Cord-Landwehr to branch frameworks.


Repository: okular


Description
---

This fixes two issues:
1. ${_okularBaseDir} provides a path to somedir/lib which prevents the 
include dir to be found
2. the find_library search does not consider the architecture prefixes (here I 
am unsure if I fixed it correctly or if NO_DEFAULT_PATH had a deeper meaning)


Diffs
-

  OkularConfig.cmake 59537c6 

Diff: https://git.reviewboard.kde.org/r/123176/diff/


Testing
---

Manual testing.


Thanks,

Andreas Cord-Landwehr

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Jenkins build is still unstable: okular_master_qt5 #2

2015-03-31 Thread KDE CI System
See http://build.kde.org/job/okular_master_qt5/changes

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 123085: Use descriptive KGuiItem labels for buttons in calls to KMessageBox

2015-03-31 Thread Albert Astals Cid

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123085/#review78297
---


Sorry but that is a general bug, and i don't agree with your choices, i think 
our wording is just fine.

- Albert Astals Cid


On mar. 20, 2015, 5:46 p.m., sahil sehgal wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/123085/
 ---
 
 (Updated mar. 20, 2015, 5:46 p.m.)
 
 
 Review request for Okular.
 
 
 Bugs: 309739
 http://bugs.kde.org/show_bug.cgi?id=309739
 
 
 Repository: okular
 
 
 Description
 ---
 
 Earlier the KmessageBox dialog box contained yes, no or continue buttons 
 without any description. But now there is description like Continue 
 searching etc in the boxes.
 
 
 Diffs
 -
 
   part.cpp 36438af 
   ui/searchlineedit.cpp 2add7fa 
 
 Diff: https://git.reviewboard.kde.org/r/123085/diff/
 
 
 Testing
 ---
 
 Executed successfully on the dialog boxes.
 
 
 Thanks,
 
 sahil sehgal
 


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Hash instead of file location

2015-03-31 Thread Albert Astals Cid
El Dilluns, 30 de març de 2015, a les 19:37:11, E. M. Recio va escriure:
 I see what you mean. I rarely open the PDF from the application itself.
 I usually open it by double clicking. If it would calc the md5sum of the
 file while opening it, then it would know that it's already seen the
 file and apply the appropriate attributes/tagging from its corresponding
 XML file. The only down side to this is that it would probably balk at
 large files and take forever to open it.

Yes, calculating the md5 means reading all the file, which is very suboptimal, 
also that kind of on-open bookmark updating seems a bit weird since it's 
asymetric, i.e. only updates the bookmark once you open that file, but not if 
you open a different file and try to open the file from okular

 
 Also, unrelated note, where can I download plugins (i.e.: to open
 OpenOffice files, etc.) Is there a developer guide to writing plugins in
 case that one doesn't exist?

Calligra includes OpenDocument backends, there's a developer guide at 
http://api.kde.org/4.x-api/kdegraphics-apidocs/okular/html/okular_generators.html

Cheers,
  Albert

 
 -e
 
 On 2015-03-29 18:40, Albert Astals Cid wrote:
  El Dissabte, 28 de març de 2015, a les 18:56:23, E. M. Recio va escriure:
  So I don't know if this is the right venue, so I apologize in advance.
  
  When I view a PDF file, and I add a bookmark, it writes the updated data
  based on file location to the users' local configuration directory. If
  you move the file, it loses all of that additional information. I was
  wondering if it could be switched to an md5 sum of the file to match the
  updated attributes to the file itself. So if I download a file into my
  downloads folder then move it into a relevant directory, I won't lose
  my bookmarks/attributes.
  
  With bookmarks you can open an unopened bookmarked file from the bookmarks
  view, how are you going to do that if you don't store the path?
  
  Cheers,
  
 Albert
  
  Just floating a balloon... what is the general view?
  
  -e
  ___
  Okular-devel mailing list
  Okular-devel@kde.org
  https://mail.kde.org/mailman/listinfo/okular-devel
  
  ___
  Okular-devel mailing list
  Okular-devel@kde.org
  https://mail.kde.org/mailman/listinfo/okular-devel
 
 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel