Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---

Ship it!


With this I can build Kile, so I'd say Ship it

- Alex Richardson


On April 14, 2015, 8:48 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated April 14, 2015, 8:48 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

[Andreas Cord-Landwehr]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/
---

(Updated April 14, 2015, 7:48 nachm.)


Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
Shalygin.


Changes
---

Thanks, both issues are fixed in the new diff.


Repository: okular


Description
---

Replace both the package version file by a generated file, as well as 
OkularConfig.cmake package configuration file.
Note that with this change the compatibility CMake variable OKULAR_FOUND is not 
set anymore, use Okular_FOUND instead.

This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
#123176


Diffs (updated)
-

  CMakeLists.txt 56c9976 
  OkularConfig.cmake 171b845 
  OkularConfig.cmake.in PRE-CREATION 
  core/version.h 855df95 

Diff: https://git.reviewboard.kde.org/r/123314/diff/


Testing
---

Manual testing on a Debian system

@Eugene: does it fix the regression for you?


Thanks,

Andreas Cord-Landwehr

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build is still unstable: okular_master_qt5 #6

[KDE CI System]

See 

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/
---

Review request for Okular.


Repository: okular


Description
---

Fix the export header not being found in interfaces/*.h


Diffs
-

  CMakeLists.txt 56c99761d36609d30b79194061d719b4d7f26f94 
  interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0 
  interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440 
  interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d 
  interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6 
  interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44 

Diff: https://git.reviewboard.kde.org/r/123363/diff/


Testing
---


Thanks,

Alex Richardson

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

[Alex Richardson]

> On April 10, 2015, 6:59 p.m., Eugene Shalygin wrote:
> > I cann't say that it fixes the issue. Maybe it does, but I just can not 
> > make it working.
> > 
> > I'm testing with Kile. Kile needs access to 
> > okular/interfaces/viewerinterface.h. However, this file contains `#include 
> > "okularcore_export.h"`. Thus, path to Okular includes is needed. But 
> > OKULAR_INCLUDE_DIR is gone.  OK, let's try to do this in the new way. So I 
> > add KF5::okularcore target to the dependencies (BTW, why KF5?). But have 
> > you seen its INTERFACE_LINK_LIBRARIES property? 
> > KF5::Archive;KF5::JS;KF5::JSApi;KF5::KDELibs4Support;KF5::KIOCore;KF5::ThreadWeaver;KF5::Wallet;Phonon::phonon4qt5;m;/usr/lib64/libz.so.
> >  Are all of them indeed needed just to link with Okular?
> > 
> > So, what am I doing wrong?
> 
> Alex Richardson wrote:
> I just looked at some of the frameworks and I think what is needed for 
> the include dirs is
> 
> ```
> target_include_directories(okularcore INTERFACE 
> "$")
> ```
> assuming anyone using the library uses `#include 
> ` 
> 
> 
> Additionally the `#include "okularcore_export.h"` inside the interfaces 
> include dir seems wrong to me, that should probably be `#include 
> "../core/okularcore_export.h"`
> 
> Andreas Cord-Landwehr wrote:
> Shall I add it to this patch or is it worth another RR?

Seems that the relative path won't work. Alternate solution here: 
https://git.reviewboard.kde.org/r/123363/


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78774
---


On April 10, 2015, 5:14 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated April 10, 2015, 5:14 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78932
---


I have now managed to get Kile to compile after applying the following patch: 
https://paste.kde.org/pcqb8yjuz and once 
https://git.reviewboard.kde.org/r/123363/ has been applied


CMakeLists.txt (line 325)


I would change this to `NAMESPACE Okular::`



OkularConfig.cmake.in (line 3)


This is missing a few dependencies:

```
find_dependency(Qt5PrintSupport @QT_REQUIRED_VERSION@)
find_dependency(Qt5Widgets @QT_REQUIRED_VERSION@)
find_dependency(KF5CoreAddons @KF5_REQUIRED_VERSION@)
find_dependency(KF5Config @KF5_REQUIRED_VERSION@)
find_dependency(KF5XmlGui @KF5_REQUIRED_VERSION@)
```


- Alex Richardson


On April 10, 2015, 5:14 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated April 10, 2015, 5:14 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

[t0mplar]

https://bugs.kde.org/show_bug.cgi?id=341318

--- Comment #5 from t0mp...@gmx.de ---
That sounds like you got a lot farther than I did :-) 
I looked into the code a bit but didn't find the right spot to jump in
(probably due to my incompetence when it comes to C++). At the moment I don't
have time to implement this feature, but if you do, I would gladly help testing
it.
I hope that we can get this new feature merged, because for me it's the only
one missing to make okular the perfect document viewer :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

[felix_mauch]

https://bugs.kde.org/show_bug.cgi?id=341318

--- Comment #4 from felix_ma...@web.de ---
After some code browsing, I guess the following solution should work:

DocumentPrivate::loadViewsInfo seems to be a good starting point as it's the
xml parser. Following the function calls you end up in PageView::setCapability
where you could implement another switch case and then add another function to
pageview analog to the PageView::updateZoom function that handles other view
features.
Of course DocumentPrivate::saveViewsInfo needs to be adjusted, too. I didn't
look at the process pipeline there, but that should be rather simple, I guess,
since that's only grabbing available data and sending it to the XML-writer.

Basically, I think it's not too much work, so the main question is: Is there a
chance that this gets merged? Albert wasn't so clear about that ;)

@t0mplar: Would you like to implement this? Otherwise tell me then I'll try to
find some time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

[felix_mauch]

https://bugs.kde.org/show_bug.cgi?id=341318

felix_ma...@web.de changed:

   What|Removed |Added

 CC||felix_ma...@web.de

--- Comment #3 from felix_ma...@web.de ---
I totally agree, that this would be a cool features, as I think others might
think, as well. There exist numerous bugreports regarding this particular
feature or another view feature (such as 2page-facing):

https://bugs.kde.org/show_bug.cgi?id=295506
https://bugs.kde.org/show_bug.cgi?id=309808
https://bugs.kde.org/show_bug.cgi?id=200183

@t0mplar: Did you make any progress on this?

Cheers Felix

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel