Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h

2015-04-15 Thread Alex Richardson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/
---

(Updated April 16, 2015, 12:55 a.m.)


Review request for Okular.


Changes
---

Use a relative path instead


Repository: okular


Description
---

Fix the export header not being found in interfaces/*.h


Diffs (updated)
-

  CMakeLists.txt 836b1912f29a5a83b52f40eb52ab6bfee327dd68 
  interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0 
  interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440 
  interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d 
  interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6 
  interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44 

Diff: https://git.reviewboard.kde.org/r/123363/diff/


Testing (updated)
---

Kile compiles now.


Thanks,

Alex Richardson

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h

2015-04-15 Thread Alex Richardson 


> On April 15, 2015, 10:58 p.m., Albert Astals Cid wrote:
> > Why are you creating a new export?

I tried using a relative path instead ("../core/okularcorexport.h") but that 
would fail the build because the export header is in $CMAKE_BINARY_DIR.
I'll try fixing the include paths while building instead and then use a 
relative path.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/#review79007
---


On April 14, 2015, 8:33 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123363/
> ---
> 
> (Updated April 14, 2015, 8:33 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Fix the export header not being found in interfaces/*.h
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c99761d36609d30b79194061d719b4d7f26f94 
>   interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0 
>   interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440 
>   interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d 
>   interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6 
>   interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44 
> 
> Diff: https://git.reviewboard.kde.org/r/123363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 346149] Konqui crash when closing tab with okular kpart

2015-04-15 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=346149

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In||KDE Applications 15.04.1
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/aed8a9b3cd72c389424e24a6
   ||ac72b6908d875423

--- Comment #1 from Albert Astals Cid  ---
Git commit aed8a9b3cd72c389424e24a6ac72b6908d875423 by Albert Astals Cid.
Committed on 15/04/2015 at 22:10.
Pushed by aacid into branch 'Applications/15.04'.

Fix crash on closing

Tell the document we're no longer an observer in the destructor
FIXED-IN: KDE Applications 15.04.1

M  +6-0ui/magnifierview.cpp
M  +1-0ui/magnifierview.h
M  +0-1ui/pageview.cpp

http://commits.kde.org/okular/aed8a9b3cd72c389424e24a6ac72b6908d875423

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123363: Fix the export header not being found in interfaces/*.h

2015-04-15 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123363/#review79007
---


Why are you creating a new export?

- Albert Astals Cid


On abr. 14, 2015, 7:33 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123363/
> ---
> 
> (Updated abr. 14, 2015, 7:33 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Fix the export header not being found in interfaces/*.h
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c99761d36609d30b79194061d719b4d7f26f94 
>   interfaces/configinterface.h d5e64336e7015a4b3068e10b2ce1caea77015da0 
>   interfaces/guiinterface.h 4b4dca0c839fb32eb28c3d710f7b06401e9c4440 
>   interfaces/printinterface.h 460d33eb4e25e09e89a11bbbd126a5d610472f7d 
>   interfaces/saveinterface.h 8ae1bea648ab6a0452ea0964dbf20ca3e9fb8fc6 
>   interfaces/viewerinterface.h c174059d78b5f4c329232406cacb5e5f49bf7f44 
> 
> Diff: https://git.reviewboard.kde.org/r/123363/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 329740] Okular hangs in presentation mode when displaying PDFs when default printer is not accessible

2015-04-15 Thread Anssi Hannula 
https://bugs.kde.org/show_bug.cgi?id=329740

Anssi Hannula  changed:

   What|Removed |Added

 CC||an...@mageia.org

--- Comment #7 from Anssi Hannula  ---
On Mageia, the following stopgap measure was applied in Jan 2015 until this is
properly fixed:
http://svnweb.mageia.org/packages/cauldron/okular/current/SOURCES/okular-4.14.3-revert-show-paper-size-names-to-avoid-freeze.patch?revision=811673&view=markup

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 329740] Okular hangs in presentation mode when displaying PDFs when default printer is not accessible

2015-04-15 Thread Lisandro Damián Nicanor Pérez Meyer 
https://bugs.kde.org/show_bug.cgi?id=329740

Lisandro Damián Nicanor Pérez Meyer  changed:

   What|Removed |Added

 CC||perezme...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build is still unstable: okular_master_qt5 #8

2015-04-15 Thread KDE CI System 
See 

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Andreas Cord-Landwehr 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/
---

(Updated April 15, 2015, 7:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
Shalygin.


Changes
---

Submitted with commit ac258e49f1d7efe5fe950776ce334a9107923b07 by Andreas 
Cord-Landwehr to branch frameworks.


Repository: okular


Description
---

Replace both the package version file by a generated file, as well as 
OkularConfig.cmake package configuration file.
Note that with this change the compatibility CMake variable OKULAR_FOUND is not 
set anymore, use Okular_FOUND instead.

This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
#123176


Diffs
-

  CMakeLists.txt 56c9976 
  OkularConfig.cmake 171b845 
  OkularConfig.cmake.in PRE-CREATION 
  core/version.h 855df95 

Diff: https://git.reviewboard.kde.org/r/123314/diff/


Testing
---

Manual testing on a Debian system

@Eugene: does it fix the regression for you?


Thanks,

Andreas Cord-Landwehr

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin 


> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
> 
> Eugene Shalygin wrote:
> I can't.  My changes to test Kile are the following: 
> http://pastebin.com/HMv9Ziku. And GCC says:
> 
> In file included from ../../src/kileviewmanager.cpp:62:0:
> /usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
> okularcore_export.h: No such file or directory
> #include "okularcore_export.h"
> 
> Pephaps Okular::okularcore target should add path to its headers 
> (/usr/include/okular/core/) to include_directories?
> 
> Eugene Shalygin wrote:
> Instead of that now `/usr/lib64/cmake/Okular/OkularTargets.cmake` 
> contains `INTERFACE_INCLUDE_DIRECTORIES 
> "${_IMPORT_PREFIX}/include/KF5;${_IMPORT_PREFIX}/include"`
> 
> Andreas Cord-Landwehr wrote:
> @Eugene: just to check, did you apply all three patches (this RR, the 
> other RR by Alex, and the paste from Alex with the patch for Kile)?
> 
> Eugene Shalygin wrote:
> @cordlandwehr: Thank you, I've missed the second Okular patch! Now Kile 
> compiles. But OkularTargets.cmake still contains that line which 
> `include/KF5` which I beleive to be  incorrect.
> 
> Alex Richardson wrote:
> I just pushed a fix for that issue, can you retest?

@arichardson now it is fine


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On Квітень 14, 2015, 9:48 після полудня, Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated Квітень 14, 2015, 9:48 після полудня)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 329740] Okular hangs in presentation mode when displaying PDFs when default printer is not accessible

2015-04-15 Thread martin f . krafft 
https://bugs.kde.org/show_bug.cgi?id=329740

martin f. krafft  changed:

   What|Removed |Added

 CC||bugs.kde.org@pobox.madduck.
   ||net

--- Comment #6 from martin f. krafft  ---
I had also reported this bug here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740707

Any news? The problem still exists, 15 months later… :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins build is still unstable: okular_master_qt5 #7

2015-04-15 Thread KDE CI System 
See 

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Alex Richardson 


> On April 14, 2015, 9:34 p.m., Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
> 
> Eugene Shalygin wrote:
> I can't.  My changes to test Kile are the following: 
> http://pastebin.com/HMv9Ziku. And GCC says:
> 
> In file included from ../../src/kileviewmanager.cpp:62:0:
> /usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
> okularcore_export.h: No such file or directory
> #include "okularcore_export.h"
> 
> Pephaps Okular::okularcore target should add path to its headers 
> (/usr/include/okular/core/) to include_directories?
> 
> Eugene Shalygin wrote:
> Instead of that now `/usr/lib64/cmake/Okular/OkularTargets.cmake` 
> contains `INTERFACE_INCLUDE_DIRECTORIES 
> "${_IMPORT_PREFIX}/include/KF5;${_IMPORT_PREFIX}/include"`
> 
> Andreas Cord-Landwehr wrote:
> @Eugene: just to check, did you apply all three patches (this RR, the 
> other RR by Alex, and the paste from Alex with the patch for Kile)?
> 
> Eugene Shalygin wrote:
> @cordlandwehr: Thank you, I've missed the second Okular patch! Now Kile 
> compiles. But OkularTargets.cmake still contains that line which 
> `include/KF5` which I beleive to be  incorrect.

I just pushed a fix for that issue, can you retest?


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On April 14, 2015, 8:48 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated April 14, 2015, 8:48 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 346149] Konqui crash when closing tab with okular kpart

2015-04-15 Thread Dawit Alemayehu 
https://bugs.kde.org/show_bug.cgi?id=346149

Dawit Alemayehu  changed:

   What|Removed |Added

  Component|general |general
   Assignee|konq-b...@kde.org   |okular-devel@kde.org
Version|4.14.2  |unspecified
Product|konqueror   |okular

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin 


> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
> 
> Eugene Shalygin wrote:
> I can't.  My changes to test Kile are the following: 
> http://pastebin.com/HMv9Ziku. And GCC says:
> 
> In file included from ../../src/kileviewmanager.cpp:62:0:
> /usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
> okularcore_export.h: No such file or directory
> #include "okularcore_export.h"
> 
> Pephaps Okular::okularcore target should add path to its headers 
> (/usr/include/okular/core/) to include_directories?
> 
> Eugene Shalygin wrote:
> Instead of that now `/usr/lib64/cmake/Okular/OkularTargets.cmake` 
> contains `INTERFACE_INCLUDE_DIRECTORIES 
> "${_IMPORT_PREFIX}/include/KF5;${_IMPORT_PREFIX}/include"`
> 
> Andreas Cord-Landwehr wrote:
> @Eugene: just to check, did you apply all three patches (this RR, the 
> other RR by Alex, and the paste from Alex with the patch for Kile)?

@cordlandwehr: Thank you, I've missed the second Okular patch! Now Kile 
compiles. But OkularTargets.cmake still contains that line which `include/KF5` 
which I beleive to be  incorrect.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On Квітень 14, 2015, 9:48 після полудня, Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated Квітень 14, 2015, 9:48 після полудня)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Andreas Cord-Landwehr 


> On April 14, 2015, 8:34 p.m., Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
> 
> Eugene Shalygin wrote:
> I can't.  My changes to test Kile are the following: 
> http://pastebin.com/HMv9Ziku. And GCC says:
> 
> In file included from ../../src/kileviewmanager.cpp:62:0:
> /usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
> okularcore_export.h: No such file or directory
> #include "okularcore_export.h"
> 
> Pephaps Okular::okularcore target should add path to its headers 
> (/usr/include/okular/core/) to include_directories?
> 
> Eugene Shalygin wrote:
> Instead of that now `/usr/lib64/cmake/Okular/OkularTargets.cmake` 
> contains `INTERFACE_INCLUDE_DIRECTORIES 
> "${_IMPORT_PREFIX}/include/KF5;${_IMPORT_PREFIX}/include"`

@Eugene: just to check, did you apply all three patches (this RR, the other RR 
by Alex, and the paste from Alex with the patch for Kile)?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On April 14, 2015, 7:48 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated April 14, 2015, 7:48 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin 


> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it
> 
> Eugene Shalygin wrote:
> I can't.  My changes to test Kile are the following: 
> http://pastebin.com/HMv9Ziku. And GCC says:
> 
> In file included from ../../src/kileviewmanager.cpp:62:0:
> /usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
> okularcore_export.h: No such file or directory
> #include "okularcore_export.h"
> 
> Pephaps Okular::okularcore target should add path to its headers 
> (/usr/include/okular/core/) to include_directories?

Instead of that now `/usr/lib64/cmake/Okular/OkularTargets.cmake` contains 
`INTERFACE_INCLUDE_DIRECTORIES 
"${_IMPORT_PREFIX}/include/KF5;${_IMPORT_PREFIX}/include"`


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On Квітень 14, 2015, 9:48 після полудня, Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated Квітень 14, 2015, 9:48 після полудня)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 123314: Use generated version and CMake config files

2015-04-15 Thread Eugene Shalygin 


> On Квітень 14, 2015, 10:34 після полудня, Alex Richardson wrote:
> > With this I can build Kile, so I'd say Ship it

I can't.  My changes to test Kile are the following: 
http://pastebin.com/HMv9Ziku. And GCC says:

In file included from ../../src/kileviewmanager.cpp:62:0:
/usr/include/okular/interfaces/viewerinterface.h:13:31: fatal error: 
okularcore_export.h: No such file or directory
#include "okularcore_export.h"

Pephaps Okular::okularcore target should add path to its headers 
(/usr/include/okular/core/) to include_directories?


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123314/#review78939
---


On Квітень 14, 2015, 9:48 після полудня, Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123314/
> ---
> 
> (Updated Квітень 14, 2015, 9:48 після полудня)
> 
> 
> Review request for Okular, Albert Astals Cid, Alex Richardson, and Eugene 
> Shalygin.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Replace both the package version file by a generated file, as well as 
> OkularConfig.cmake package configuration file.
> Note that with this change the compatibility CMake variable OKULAR_FOUND is 
> not set anymore, use Okular_FOUND instead.
> 
> This patch (should) fix the regression on eg. Gentoo systems introduced by RR 
> #123176
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56c9976 
>   OkularConfig.cmake 171b845 
>   OkularConfig.cmake.in PRE-CREATION 
>   core/version.h 855df95 
> 
> Diff: https://git.reviewboard.kde.org/r/123314/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on a Debian system
> 
> @Eugene: does it fix the regression for you?
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel