[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #16 from Yichao Zhou --- Hi Dmitry, I tried to reply to this bug this afternoon by email from my smartphone but it seems I did not do it correctly. Sorry for the confusion. The problem about my patch was that the maintainer thought that we should use the middle mouse to pan the page (like we do in evince and some 3D modelling software) instead of scrolling the page (like we do in firefox/adobe reader). I proposed that I could implement all of the three modes (zoom, pan, scroll) and let the user choose them. It seemed that Albert agreed on this. However because that patch works well on my gentoo box and I really do not need to pan feature, I put this task behind my schedule. I realized that this patch does not work on KF5 recently. But I no longer use KDE frequently (maybe I will be back in the future) now so I will not work on this in short term. Feel free to implement it if you want to see this feature in the upstream! Communication with Albert before working is a good idea to make sure that your patch will be merged finally. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #15 from Dmitry Osipenko --- Hi Yichao, Sorry, I thought you've abandoned your effort. Are you going to re-spin the patch? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #14 from Yichao Zhou --- > > https://bugs.kde.org/show_bug.cgi?id=219121 > > Dmitry Osipenko changed: > >What|Removed |Added > > > CC||dig...@gmail.com > > --- Comment #13 from Dmitry Osipenko --- > After 5 years I'm still carrying patch to make okular usable. Hopefully, > it's > not a big burden with gentoo :) > > @Albert, do you remember what was the problem with Yichao's patch? I'd > like to > help finalizing it. > > -- > You are receiving this mail because: > You are on the CC list for the bug. > You voted for the bug. > -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom
https://bugs.kde.org/show_bug.cgi?id=219121 Dmitry Osipenko changed: What|Removed |Added CC||dig...@gmail.com --- Comment #13 from Dmitry Osipenko --- After 5 years I'm still carrying patch to make okular usable. Hopefully, it's not a big burden with gentoo :) @Albert, do you remember what was the problem with Yichao's patch? I'd like to help finalizing it. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 ยป Linux,gcc - Build # 70 - Still unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 21:50:54 + Build duration: 6 min 26 sec CHANGE SET Revision 9689a8eccd39469fa6c7ecd37b7ea12f8498f6e6 by Marco Martin: (add missing file) change: add mobile/app/package/contents/ui/OkularDrawer.qml Revision d0ecab47368288ec00318dccb6dfcd9fc79a8e8b by ps_ml: (Windows string fixes) change: edit generators/dvi/dviRenderer_prescan.cpp change: edit generators/epub/converter.cpp change: edit ui/latexrenderer.cpp change: edit generators/dvi/special.cpp change: edit generators/dvi/psgs.cpp change: edit ui/pageview.cpp JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.annotationstestFailed: TestSuite.mainshelltestFailed: TestSuite.parttest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 20/22 (91%)FILES 130/260 (50%)CLASSES 130/260 (50%)LINE 11569/37390 (31%)CONDITIONAL 4886/7594 (64%) By packages FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 874/1617 (54%)CONDITIONAL 389/652 (60%) autotests FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1689/1726 (98%)CONDITIONAL 938/1672 (56%) conf FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/830 (7%)CONDITIONAL 2/4 (50%) conf.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 7/14 (50%) core FILES 40/48 (83%)CLASSES 40/48 (83%)LINE 4098/9182 (45%)CONDITIONAL 1770/2464 (72%) core.script FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/503 (0%)CONDITIONAL 0/0 (100%) generators.comicbook FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/428 (2%)CONDITIONAL 0/0 (100%) generators.dvi FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3583 (0%)CONDITIONAL 1/2 (50%) generators.epub FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 182/337 (54%)CONDITIONAL 73/111 (66%) generators.fax FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/443 (2%)CONDITIONAL 0/0 (100%) generators.fictionbook FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/543 (3%)CONDITIONAL 4/8 (50%) generators.ooo FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1190 (1%)CONDITIONAL 2/4 (50%) generators.plucker FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/107 (5%)CONDITIONAL 1/2 (50%) generators.plucker.unpluck FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1600 (0%)CONDITIONAL 0/0 (100%) generators.poppler FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 625/1224 (51%)CONDITIONAL 253/397 (64%) generators.spectre FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/224 (11%)CONDITIONAL 3/6 (50%) generators.tiff FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/227 (4%)CONDITIONAL 0/0 (100%) generators.txt FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/54 (24%)CONDITIONAL 2/4 (50%) generators.xps FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1301 (1%)CONDITIONAL 1/2 (50%) interfaces FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 8/16 (50%) shell FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 375/547 (69%)CONDITIONAL 184/256 (72%) ui FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 3524/11694 (30%)CONDITIONAL 1248/1980 (63%)___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 126379: Windows string fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126379/ --- (Updated Dec. 28, 2015, 9:50 p.m.) Status -- This change has been marked as submitted. Review request for kdewin and Okular. Changes --- Submitted with commit d0ecab47368288ec00318dccb6dfcd9fc79a8e8b by Patrick Spendrin to branch frameworks. Repository: okular Description --- This patch changes multiline QStringLiterals to QString::fromLatin1 as QStringLiterals doesn't understand multiline strings on windows. Also, strncasecmp is replaced by the portable qstricmp function provided by QByteArray header. Diffs - generators/dvi/dviRenderer_prescan.cpp 783c7273c6f7d1be03f5e970dc23e0a24a31197f generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 Diff: https://git.reviewboard.kde.org/r/126379/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 126379: Windows string fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126379/#review90227 --- Ship it! I don't really care so i guess ship it, but this will break again once we use the clazy tool that warns us that the QString::fromLatin1 is doing an unneeded QString allocation. So may make sense to either fix QStringLiteral on windows or fix the code in a way it works both on windows and linux without using QString::fromLatin1 - Albert Astals Cid On des. 27, 2015, 12:28 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126379/ > --- > > (Updated des. 27, 2015, 12:28 a.m.) > > > Review request for kdewin and Okular. > > > Repository: okular > > > Description > --- > > This patch changes multiline QStringLiterals to QString::fromLatin1 > as QStringLiterals doesn't understand multiline strings on windows. > Also, strncasecmp is replaced by the portable qstricmp function provided > by QByteArray header. > > > Diffs > - > > generators/dvi/dviRenderer_prescan.cpp > 783c7273c6f7d1be03f5e970dc23e0a24a31197f > generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 > generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c > generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 > ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a > ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 > > Diff: https://git.reviewboard.kde.org/r/126379/diff/ > > > Testing > --- > > Windows. > > > Thanks, > > Patrick Spendrin > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 126379: Windows string fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126379/#review90208 --- +1 - Aleix Pol Gonzalez On Dec. 27, 2015, 1:28 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126379/ > --- > > (Updated Dec. 27, 2015, 1:28 a.m.) > > > Review request for kdewin and Okular. > > > Repository: okular > > > Description > --- > > This patch changes multiline QStringLiterals to QString::fromLatin1 > as QStringLiterals doesn't understand multiline strings on windows. > Also, strncasecmp is replaced by the portable qstricmp function provided > by QByteArray header. > > > Diffs > - > > generators/dvi/dviRenderer_prescan.cpp > 783c7273c6f7d1be03f5e970dc23e0a24a31197f > generators/dvi/psgs.cpp b1eedc42864abf5a868a5bc6eebf258b1f7cf168 > generators/dvi/special.cpp 6a9fe69b2d44cfed95284b4d37f767c00c73721c > generators/epub/converter.cpp 16a6b5beabe1803ea4cdacc4d571edca7ff9ec23 > ui/latexrenderer.cpp 8e42a9f88a8aa4ff73b544bf41642d59ca86474a > ui/pageview.cpp 13727e4647781cd9222956cae2c9e3fbc1a42324 > > Diff: https://git.reviewboard.kde.org/r/126379/diff/ > > > Testing > --- > > Windows. > > > Thanks, > > Patrick Spendrin > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
