[Okular-devel] Review Request 127055: Added sidebar collapsed state setting

2016-02-12 Thread Evan Hosseini

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127055/
---

Review request for Okular.


Bugs: 344599
http://bugs.kde.org/show_bug.cgi?id=344599


Repository: okular


Description
---

Added setting for storing sidebar collapsed state, so we can restore the 
setting next time application is started.


Diffs
-

  conf/okular.kcfg d90fe23 
  part.cpp 0dd663d 
  ui/sidebar.h 5856378 
  ui/sidebar.cpp 1c23c41 

Diff: https://git.reviewboard.kde.org/r/127055/diff/


Testing
---

Verified code properly stores sidebar collapsed state, and is able to load and 
apply the stored setting on next application start.


Thanks,

Evan Hosseini

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 359319] New: Can't open files with space in filename

2016-02-12 Thread naraesk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=359319

Bug ID: 359319
   Summary: Can't open files with space in filename
   Product: okular
   Version: unspecified
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: m...@naraesk.eu

I cannot open file via clicking on them or via console if the filename or path
contains a space. There is just a popup "Could not open". However, if the file
is opened by file → open there isn't any problem at all.

See also: https://forum.kde.org/viewtopic.php?f=251=130914

I'm using the frameworks branch of okular. The bug was introduced with one of
the latest commits.
The bug was introduced with one of the latest commits.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

2016-02-12 Thread Fahad Al-Saidi

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92307
---



any feedback?

- Fahad Al-Saidi


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel