Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-16 Thread Aleix Pol Gonzalez 


> On Feb. 10, 2016, 12:23 a.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.
> 
> Albert Astals Cid wrote:
> There's more things in Linux land than Plasma and Gnome, i'm worried 
> about such an ugly dialog for those people.

Let's create a wiki for them to install the Plasma integration? This way 
they'll be fixing all of it, not just this precise dialog.

Or I can discard this review and port it to use KFileWidget. Or undeprecate 
KFileDialog?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 3:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 3:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127021: Remove most KDELibs4Support linking

2016-02-16 Thread Albert Astals Cid 


> On Feb. 9, 2016, 11:23 p.m., Albert Astals Cid wrote:
> > The new dialog "file type" looks fugly and tehre's no "all file types" 
> > anymore.
> 
> Aleix Pol Gonzalez wrote:
> https://git.reviewboard.kde.org/r/127024/
> 
> :)
> 
> Albert Astals Cid wrote:
> that won't fix http://i.imgur.com/AwIzhqr.png right? That's the Qt dialog 
> i guess? Is it really supposed to be that ugly?
> 
> Aleix Pol Gonzalez wrote:
> You don't have it set up properly, you should be getting the normal 
> KFileWidget-based dialog.
> 
> Albert Astals Cid wrote:
> I know i don't have it setup to give me the "Plasma experience", it's 
> giving me the "Okular experience outside plasma", and it is a serious 
> regression to what we have by using KFileDialog, don't you think?
> 
> Aleix Pol Gonzalez wrote:
> As I see it, there's no non-_Plasma Experience_. In Gnome, it should use 
> the GTK thingie, in Plasma it should use the Plasma dialog, and on Windows or 
> Android, whatever they use there: so it's not a regression but a feature.

There's more things in Linux land than Plasma and Gnome, i'm worried about such 
an ugly dialog for those people.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127021/#review92202
---


On Feb. 10, 2016, 2:23 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127021/
> ---
> 
> (Updated Feb. 10, 2016, 2:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Drops KDELibs4Support usage, mostly it wasn't actually used, except for that 
> KFileDialog usage that I ported.
> 
> 
> Diffs
> -
> 
>   shell/shell.cpp c97054a 
> 
> Diff: https://git.reviewboard.kde.org/r/127021/diff/
> 
> 
> Testing
> ---
> 
> Opening dialog seems to work fine, tests still pass except for parttest, but 
> I'm unsure it's related: https://paste.kde.org/p37pdubgf
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

2016-02-16 Thread Albert Astals Cid 


> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > 
> >
> > The model has to know about the treeview, see line 209. This also makes 
> > sure that the model is deleted when the view is deleted, just like when 
> > this is used as a KPart (see finishReload).
> 
> Albert Astals Cid wrote:
> > This also makes sure that the model is deleted when the view is deleted
> 
> But that already happens becase the view is the parent of the model, no?
> 
> Miklós Máté wrote:
> You have to call setParent() to make the view parent of the model, it 
> doesn't happen automatically. You can connect multiple views to a single 
> model, but only one of them can be its parent, or they would all want to free 
> the model on exit.

Really, read the code, specially the tocmodel constructor and see that we call 
m_model = new TOCModel( document, m_treeView );

Do you really not see that the model parent is already the treeview? 

Just add qDebug() << "MO" << m_model->QObject::parent() << m_treeView; 
after the constructor and see it yourself


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92277
---


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> ---
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> fixes bug #342076
> 
> 
> Diffs
> -
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127049: Port to FindPoppler from extra-cmake-modules

2016-02-16 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127049/#review92475
---



It can go in if it's good, someone else needs to review/approve, maybe Alex?

- Albert Astals Cid


On Feb. 14, 2016, 3:43 p.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127049/
> ---
> 
> (Updated Feb. 14, 2016, 3:43 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This changes cmake machinery to support FindPoppler which was recently added 
> to extra-cmake-modules.
> 
> FindPoppler was added in extra-cmake-modules-5.19, so the dep needed to be 
> raised.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b93c5f9 
>   cmake/modules/FindPoppler-Qt5.cmake 80a7862 
>   generators/CMakeLists.txt e2bd28e 
>   generators/poppler/CMakeLists.txt 248825e 
> 
> Diff: https://git.reviewboard.kde.org/r/127049/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

2016-02-16 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 16 Feb 2016 18:05:24 +
Build duration: 4 min 13 sec

CHANGE SET
Revision 14c936ea1b0a9094b476da45160ebb23614f3a39 by Albert Astals Cid: (Fix 
for CUPS printing)
  change: edit core/fileprinter.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/22 (91%)FILES 131/260 (50%)CLASSES 131/260 (50%)LINE 12422/37349 
(33%)CONDITIONAL 5448/8412 (65%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 878/1629 
(54%)CONDITIONAL 395/654 (60%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1710/1727 
(99%)CONDITIONAL 941/1696 (55%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/830 (7%)CONDITIONAL 2/4 
(50%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4398/9194 
(48%)CONDITIONAL 2023/2835 (71%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/503 (0%)CONDITIONAL 0/0 
(100%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/422 (2%)CONDITIONAL 0/0 
(100%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3578 (0%)CONDITIONAL 
1/2 (50%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 182/331 (55%)CONDITIONAL 
73/111 (66%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/0 
(100%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/537 (3%)CONDITIONAL 4/8 
(50%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1185 (1%)CONDITIONAL 
2/4 (50%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/101 (5%)CONDITIONAL 
1/2 (50%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1600 (0%)CONDITIONAL 0/0 
(100%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 625/1218 (51%)CONDITIONAL 
253/397 (64%)
generators.spectre
FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/218 (11%)CONDITIONAL 
3/6 (50%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/220 (5%)CONDITIONAL 
0/0 (100%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/4 
(50%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1293 (1%)CONDITIONAL 
1/2 (50%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 406/555 (73%)CONDITIONAL 
223/300 (74%)
ui
FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 4021/11693 
(34%)CONDITIONAL 1509/2357 (64%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Jenkins-kde-ci: okular frameworks kf5-qt5 » Linux,gcc - Build # 84 - Fixed!

2016-02-16 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/okular%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 16 Feb 2016 18:05:24 +
Build duration: 4 min 13 sec

CHANGE SET
Revision 14c936ea1b0a9094b476da45160ebb23614f3a39 by Albert Astals Cid: (Fix 
for CUPS printing)
  change: edit core/fileprinter.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/22 (91%)FILES 131/260 (50%)CLASSES 131/260 (50%)LINE 12422/37349 
(33%)CONDITIONAL 5448/8412 (65%)

By packages
  

FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 878/1629 
(54%)CONDITIONAL 395/654 (60%)
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1710/1727 
(99%)CONDITIONAL 941/1696 (55%)
conf
FILES 1/17 (6%)CLASSES 1/17 (6%)LINE 54/830 (7%)CONDITIONAL 2/4 
(50%)
conf.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 17/17 (100%)CONDITIONAL 
7/14 (50%)
core
FILES 41/48 (85%)CLASSES 41/48 (85%)LINE 4398/9194 
(48%)CONDITIONAL 2023/2835 (71%)
core.script
FILES 0/9 (0%)CLASSES 0/9 (0%)LINE 0/503 (0%)CONDITIONAL 0/0 
(100%)
generators.comicbook
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 10/422 (2%)CONDITIONAL 0/0 
(100%)
generators.dvi
FILES 1/47 (2%)CLASSES 1/47 (2%)LINE 10/3578 (0%)CONDITIONAL 
1/2 (50%)
generators.epub
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 182/331 (55%)CONDITIONAL 
73/111 (66%)
generators.fax
FILES 1/6 (17%)CLASSES 1/6 (17%)LINE 7/437 (2%)CONDITIONAL 0/0 
(100%)
generators.fictionbook
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 16/537 (3%)CONDITIONAL 4/8 
(50%)
generators.ooo
FILES 3/11 (27%)CLASSES 3/11 (27%)LINE 14/1185 (1%)CONDITIONAL 
2/4 (50%)
generators.plucker
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 5/101 (5%)CONDITIONAL 
1/2 (50%)
generators.plucker.unpluck
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/1600 (0%)CONDITIONAL 0/0 
(100%)
generators.poppler
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 625/1218 (51%)CONDITIONAL 
253/397 (64%)
generators.spectre
FILES 2/5 (40%)CLASSES 2/5 (40%)LINE 24/218 (11%)CONDITIONAL 
3/6 (50%)
generators.tiff
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 10/220 (5%)CONDITIONAL 
0/0 (100%)
generators.txt
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 13/48 (27%)CONDITIONAL 2/4 
(50%)
generators.xps
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 10/1293 (1%)CONDITIONAL 
1/2 (50%)
interfaces
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 12/13 (92%)CONDITIONAL 
8/16 (50%)
shell
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 406/555 (73%)CONDITIONAL 
223/300 (74%)
ui
FILES 35/53 (66%)CLASSES 35/53 (66%)LINE 4021/11693 
(34%)CONDITIONAL 1509/2357 (64%)___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127013: Properly show marker for current section in TOC

2016-02-16 Thread Miklós Máté 


> On Feb. 11, 2016, 10:27 p.m., Miklós Máté wrote:
> > ui/toc.cpp, line 44
> > 
> >
> > The model has to know about the treeview, see line 209. This also makes 
> > sure that the model is deleted when the view is deleted, just like when 
> > this is used as a KPart (see finishReload).
> 
> Albert Astals Cid wrote:
> > This also makes sure that the model is deleted when the view is deleted
> 
> But that already happens becase the view is the parent of the model, no?

You have to call setParent() to make the view parent of the model, it doesn't 
happen automatically. You can connect multiple views to a single model, but 
only one of them can be its parent, or they would all want to free the model on 
exit.


- Miklós


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127013/#review92277
---


On Feb. 8, 2016, 5:49 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127013/
> ---
> 
> (Updated Feb. 8, 2016, 5:49 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> fixes bug #342076
> 
> 
> Diffs
> -
> 
>   ui/toc.cpp 09625af 
>   ui/tocmodel.cpp ce93366 
> 
> Diff: https://git.reviewboard.kde.org/r/127013/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127049: Port to FindPoppler from extra-cmake-modules

2016-02-16 Thread Armin K. 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127049/#review92445
---



e-c-m 5.19 has been released. Can I get a green light on this one?

- Armin K.


On Feb. 14, 2016, 3:43 p.m., Armin K. wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127049/
> ---
> 
> (Updated Feb. 14, 2016, 3:43 p.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This changes cmake machinery to support FindPoppler which was recently added 
> to extra-cmake-modules.
> 
> FindPoppler was added in extra-cmake-modules-5.19, so the dep needed to be 
> raised.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b93c5f9 
>   cmake/modules/FindPoppler-Qt5.cmake 80a7862 
>   generators/CMakeLists.txt e2bd28e 
>   generators/poppler/CMakeLists.txt 248825e 
> 
> Diff: https://git.reviewboard.kde.org/r/127049/diff/
> 
> 
> Testing
> ---
> 
> It builds.
> 
> 
> Thanks,
> 
> Armin K.
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 334019] Okular should warn if closing with multiple tabs opened

2016-02-16 Thread Viktor Yu . Kovalskiy via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=334019

Viktor Yu. Kovalskiy  changed:

   What|Removed |Added

 CC||vityoks...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel