Re: [Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

[Gleb Popov]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127328/#review93529
---



Can you, please, elaborate on pt. 2? What does not work exactly?

>2) When compiling okularplugin, the existing definition of okularpart_EXPORTS 
>on the generated settings.cpp does not work with MinGW, for reasons that I do 
>not understand. Setting the definition on the whole target, instead, works.

- Gleb Popov


On March 14, 2016, 3:17 a.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127328/
> ---
> 
> (Updated March 14, 2016, 3:17 a.m.)
> 
> 
> Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb 
> Popov.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Three parts to this patch:
> 1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not 
> compiler-specific.
> 2) When compiling okularplugin, the existing definition of okularpart_EXPORTS 
> on the generated settings.cpp does not work with MinGW, for reasons that I do 
> not understand. Setting the definition on the whole target, instead, works.
> 3) The okularpart lib will automatically be named libokularpart, and 
> subsequently not be found when trying to load it via KPluginLoader. Tell 
> cmake to drop the "lib"-prefix.
> 
> See also:
> - Discussion on list 
> https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html
> - A previous review request addressed issue 2 for MSVC 
> https://git.reviewboard.kde.org/r/125742/
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e17bc25 
>   interfaces/viewerinterface.h e9e76a2 
>   mobile/components/CMakeLists.txt e09326a 
> 
> Diff: https://git.reviewboard.kde.org/r/127328/diff/
> 
> 
> Testing
> ---
> 
> Builds on Windows with MinGW. Starts, and loads okularpart, successfully.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127351: Added ability to view embedded files

[Daniel Lichtenberger]

> On March 14, 2016, 12:28 a.m., Albert Astals Cid wrote:
> > Could you please fix all the indentation to be like the one in the file?

ui/embeddedfilesdialog.{h,cpp} use both tabs and spaces (even within the same 
method). Should I just convert them to spaces-only?


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127351/#review93500
---


On March 12, 2016, 8:52 a.m., Daniel Lichtenberger wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127351/
> ---
> 
> (Updated March 12, 2016, 8:52 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 295567
> http://bugs.kde.org/show_bug.cgi?id=295567
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The selected embedded file(s) are extracted to QDir::tempPath() and the
> default application associated with the file type is launched with KRun.
> 
> Double-click on an embedded file also launches the view action.
> 
> The temporary files are cleaned up automatically when the dialog is
> closed.
> 
> 
> Diffs
> -
> 
>   ui/embeddedfilesdialog.h f3e2d038f4ffe2b64af15c94c7ec0cfb8a68834c 
>   ui/embeddedfilesdialog.cpp b400e879b2849a931e069669c984a6b578ffd536 
>   ui/guiutils.h fffe04488b27d92d9a7bc623da653d0c1df87ae8 
>   ui/guiutils.cpp 3bf3ad64b57396792c3aa33298265561ee35ed1a 
> 
> Diff: https://git.reviewboard.kde.org/r/127351/diff/
> 
> 
> Testing
> ---
> 
> Tested with 
> 
> http://www.opf-labs.org/format-corpus/pdfCabinetOfHorrors/fileAttachment.pdf 
> 
> and the PDF file in
> 
> http://www.sdbtransfer.de/app/download/10536876499/SuperSauber1_EDASXbau.zip?t=1453751464
> 
> 
> Thanks,
> 
> Daniel Lichtenberger
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 127372: Small fix for indentation

[Nicolas Frattaroli]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127372/
---

Review request for Okular.


Repository: okular


Description
---

Somebody used tabs instead of spaces for four lines when the entirety of the 
file uses spaces. Eww!


Diffs
-

  ui/pagepainter.cpp 57e8620 

Diff: https://git.reviewboard.kde.org/r/127372/diff/


Testing
---


Thanks,

Nicolas Frattaroli

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Page scaling filters

[Nicolas F.]

Hi,

I've noticed that Okular seems to do page scaling using something bad
like bilinear. I'm interested in improving this by providing the option
to choose (slower) high-quality filters. I'm starting with re-examining
the current page drawing code and determining how to re-factor it to
account for this, and have a few questions.

1. What does PagePainter::scalePixmapOnImage do, and why? It seems to
just copy data from a pixmap to an image. Is this function even relevant?

2. PagePainter::paintCroppedPageOnPainter has a lot of code paths for
what one would assume should be a fairly simple operation. Is there a
historical reason for its complexity? I see it reimplements the entire
thing at least once for when it's not using a backbuffer.

3. PagePainter::paintCroppedPageOnPainter paints on QImage objects which
means the software rasteriser will be used. Since presumably nothing is
done with those images other than then being displayed, wouldn't it be
better to use a QOpenGLPaintDevice?

Thanks for any answers.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 127328: Fix build on Windows (MinGW)

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127328/#review93503
---




CMakeLists.txt (line 305)


Make it `add_library(okularpart MODULE ${okularpart_SRCS})` and you won't 
need to drop the prefix.



interfaces/viewerinterface.h (line 14)


Should use generate_export_header() and generate the export macros at 
configure time.


- Aleix Pol Gonzalez


On March 14, 2016, 1:17 a.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127328/
> ---
> 
> (Updated March 14, 2016, 1:17 a.m.)
> 
> 
> Review request for Okular, Aleix Pol Gonzalez, Alex Richardson, and Gleb 
> Popov.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Three parts to this patch:
> 1) The plaform #ifdef in interfaces/viewerinterface.h is platform, not 
> compiler-specific.
> 2) When compiling okularplugin, the existing definition of okularpart_EXPORTS 
> on the generated settings.cpp does not work with MinGW, for reasons that I do 
> not understand. Setting the definition on the whole target, instead, works.
> 3) The okularpart lib will automatically be named libokularpart, and 
> subsequently not be found when trying to load it via KPluginLoader. Tell 
> cmake to drop the "lib"-prefix.
> 
> See also:
> - Discussion on list 
> https://mail.kde.org/pipermail/okular-devel/2016-March/022480.html
> - A previous review request addressed issue 2 for MSVC 
> https://git.reviewboard.kde.org/r/125742/
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e17bc25 
>   interfaces/viewerinterface.h e9e76a2 
>   mobile/components/CMakeLists.txt e09326a 
> 
> Diff: https://git.reviewboard.kde.org/r/127328/diff/
> 
> 
> Testing
> ---
> 
> Builds on Windows with MinGW. Starts, and loads okularpart, successfully.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 177778] make it possible to resize resizable annotations

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=18

nono31...@gmail.com changed:

   What|Removed |Added

 CC||nono31...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel