[okular] [Bug 374358] Okular Flatpak fails to launch on Fedora 25: libpcreposix.so.0 not found

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=374358

--- Comment #3 from Aleix Pol  ---
Dependency coming from KJS.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
   |lar/f3f077e1a632c6eed77564f |lar/84c9910da9533b9b08fc5a4
   |f92117a11f7855f2a   |0f693d6763152b331

--- Comment #11 from Antonio Rojas  ---
Git commit 84c9910da9533b9b08fc5a40f693d6763152b331 by Antonio Rojas.
Committed on 08/01/2017 at 18:48.
Pushed by arojas into branch 'master'.

Avoid duplicates in the available backends list

If a generator can open multiple mime types that match the same file, avoid
showing a backend chooser dialog with multiple instances of the same
backend

REVIEW: 129791

M  +2-2core/document.cpp

https://commits.kde.org/okular/84c9910da9533b9b08fc5a40f693d6763152b331

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/oku
   ||lar/f3f077e1a632c6eed77564f
   ||f92117a11f7855f2a

--- Comment #10 from Antonio Rojas  ---
Git commit f3f077e1a632c6eed77564ff92117a11f7855f2a by Antonio Rojas.
Committed on 08/01/2017 at 18:38.
Pushed by arojas into branch 'Applications/16.12'.

Avoid duplicates in the available backends list

If a generator can open multiple mime types that match the same file, avoid
showing a backend chooser dialog with multiple instances of the same
backend

REVIEW: 129791

M  +2-2core/document.cpp

https://commits.kde.org/okular/f3f077e1a632c6eed77564ff92117a11f7855f2a

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129791: Avoid duplicates in the available backends list

[Antonio Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129791/
---

(Updated Jan. 8, 2017, 6:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular and Albert Astals Cid.


Changes
---

Submitted with commit f3f077e1a632c6eed77564ff92117a11f7855f2a by Antonio Rojas 
to branch Applications/16.12.


Bugs: 374650
http://bugs.kde.org/show_bug.cgi?id=374650


Repository: okular


Description
---

If a generator can open two mime types that match the same file, okular will 
show a selection dialog containing two copies of the same generator when 
opening that file. This patch avoids having duplicates in the backend list.


Diffs
-

  core/document.cpp 19526627 

Diff: https://git.reviewboard.kde.org/r/129791/diff/


Testing
---

Tried opening a PDF, okular opens it directly. Before this patch, if the "Show 
backend selection dialog" option was enabled, it would show a backend selection 
dialog with two copies od the poppler generator.


Thanks,

Antonio Rojas

Re: Review Request 129791: Avoid duplicates in the available backends list

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129791/#review101881
---


Fix it, then Ship it!





core/document.cpp (line 2203)


We probably want the same check here, right?


- Albert Astals Cid


On Jan. 8, 2017, 11:21 a.m., Antonio Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129791/
> ---
> 
> (Updated Jan. 8, 2017, 11:21 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 374650
> http://bugs.kde.org/show_bug.cgi?id=374650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> If a generator can open two mime types that match the same file, okular will 
> show a selection dialog containing two copies of the same generator when 
> opening that file. This patch avoids having duplicates in the backend list.
> 
> 
> Diffs
> -
> 
>   core/document.cpp 19526627 
> 
> Diff: https://git.reviewboard.kde.org/r/129791/diff/
> 
> 
> Testing
> ---
> 
> Tried opening a PDF, okular opens it directly. Before this patch, if the 
> "Show backend selection dialog" option was enabled, it would show a backend 
> selection dialog with two copies od the poppler generator.
> 
> 
> Thanks,
> 
> Antonio Rojas
> 
>

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101879
---



This is starting to look acceptable.

Could you please add an autotest that fails without this code and works with it?

- Albert Astals Cid


On Jan. 8, 2017, 1:26 p.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 8, 2017, 1:26 p.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=362856

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #21 from Christoph Cullmann  ---
I did take a look, IMHO the problem (beside the missing 

   // These attributes must be set before a Q(Gui)Application is constructed.
+QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
+QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);

calls) is that the generators render the stuff in a QImage but that has not set
the right scale factor nor dimensions.

During writing our company PDF helper viewer
(https://github.com/AbsInt/FirstAid), I run into the same issue with libpoppler
and altered our rendering code to:

/**
 * we render in too high resolution and then set the right ratio
 */
cachedPage = new QImage(page->renderToImage(resX() *
devicePixelRatio(), resY() * devicePixelRatio(), -1, -1, -1, -1,
Poppler::Page::Rotate0));
cachedPage->setDevicePixelRatio(devicePixelRatio());

This did the trick, unfortunately Okular is more complex than our toy program
therefore I am not that sure where to adjust that :/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?
> 
> Marduk Bolanos wrote:
> I understand that you are worried about this being a general 
> string-comparison function, but AFAIK with the current search algorithm the 
> case you are considering will not occur. If I missed your point, please 
> explain in more detail.
> 
> Albert Astals Cid wrote:
> Are you really defending that 
> 
> int addTwoNumbers(int a, int b) {
>  return 4;
> }
> 
> is correct because we only pass a = 2 and b = 2?
> 
> Marduk Bolanos wrote:
> Let's think about it. 
> 
> This is a function that compares strings. Let's agree that a string is an 
> array of chars of size N. 
> 
> What does it mean to compare two strings? In particular, what does it 
> mean that two strings are equal?
> 
> If you define that two strings are equal if both arrays are equal, then 
> this corresponds to the original behaviour of the function. Let's say that in 
> this case the strings are obviously equal.
> 
> You may also define that for N = 2 two strings are equal if either they 
> are obviously equal or the first char in both arrays is the same and the last 
> char in one array is space and the last char in the other array is newline.
> 
> In your previous comment you mentioned you would like to define that for 
> all N two strings are equal if the first N-1 chars in both arrays are equal 
> and the last char in one array is space and the last char in the other array 
> is newline. That is fine, but it is not necessary for the search 
> functionality.
> 
> As you can see, there is no absolute notion of equality of two strings. 
> What you call the correct behaviour of the function depends on how you define 
> the equality of two strings.
> 
> Anthony Fieroni wrote:
> So Marduk, do it that way
> 
> if ( from.endsWith(QStringLiteral("\n") && to.endsWith(QStringLiteral(" 
> ")) {
> return from.trimmed().compare( to.trimmed(), Qt::CaseInsensitive ) == 
> 0;
> }
> 
> Marduk Bolanos wrote:
> Done. Excellent solution! Thanks Anthony.

Actually, aiming at generality it would be better if the return value of the 
function given any two strings were 

`from.trimmed().compare( to.trimmed(), Qt::CaseInsensitive ) == 0;`

I did that in the last diff.


- Marduk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Jan. 8, 2017, 1:26 p.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 8, 2017, 1:26 p.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/
---

(Updated Jan. 8, 2017, 1:26 p.m.)


Review request for Okular and Oliver Sander.


Changes
---

Avoid code duplication i.e DRY


Repository: okular


Description
---

A blank space in the query is matched against a newline character in the PDF.


Diffs (updated)
-

  okular/core/textpage.cpp 44dfa14 

Diff: https://git.reviewboard.kde.org/r/129557/diff/


Testing
---

Tried a few PDF files. It works.


Thanks,

Marduk Bolanos

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?
> 
> Marduk Bolanos wrote:
> I understand that you are worried about this being a general 
> string-comparison function, but AFAIK with the current search algorithm the 
> case you are considering will not occur. If I missed your point, please 
> explain in more detail.
> 
> Albert Astals Cid wrote:
> Are you really defending that 
> 
> int addTwoNumbers(int a, int b) {
>  return 4;
> }
> 
> is correct because we only pass a = 2 and b = 2?
> 
> Marduk Bolanos wrote:
> Let's think about it. 
> 
> This is a function that compares strings. Let's agree that a string is an 
> array of chars of size N. 
> 
> What does it mean to compare two strings? In particular, what does it 
> mean that two strings are equal?
> 
> If you define that two strings are equal if both arrays are equal, then 
> this corresponds to the original behaviour of the function. Let's say that in 
> this case the strings are obviously equal.
> 
> You may also define that for N = 2 two strings are equal if either they 
> are obviously equal or the first char in both arrays is the same and the last 
> char in one array is space and the last char in the other array is newline.
> 
> In your previous comment you mentioned you would like to define that for 
> all N two strings are equal if the first N-1 chars in both arrays are equal 
> and the last char in one array is space and the last char in the other array 
> is newline. That is fine, but it is not necessary for the search 
> functionality.
> 
> As you can see, there is no absolute notion of equality of two strings. 
> What you call the correct behaviour of the function depends on how you define 
> the equality of two strings.
> 
> Anthony Fieroni wrote:
> So Marduk, do it that way
> 
> if ( from.endsWith(QStringLiteral("\n") && to.endsWith(QStringLiteral(" 
> ")) {
> return from.trimmed().compare( to.trimmed(), Qt::CaseInsensitive ) == 
> 0;
> }

Done. Excellent solution! Thanks Anthony.


- Marduk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Jan. 8, 2017, 12:55 p.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 8, 2017, 12:55 p.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/
---

(Updated Jan. 8, 2017, 12:55 p.m.)


Review request for Okular and Oliver Sander.


Changes
---

A string `s` followed by newline is equal to `s` followed by space


Repository: okular


Description
---

A blank space in the query is matched against a newline character in the PDF.


Diffs (updated)
-

  okular/core/textpage.cpp 44dfa14 

Diff: https://git.reviewboard.kde.org/r/129557/diff/


Testing
---

Tried a few PDF files. It works.


Thanks,

Marduk Bolanos

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Anthony Fieroni]

> On Ян. 8, 2017, 3:27 преди обяд, Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?
> 
> Marduk Bolanos wrote:
> I understand that you are worried about this being a general 
> string-comparison function, but AFAIK with the current search algorithm the 
> case you are considering will not occur. If I missed your point, please 
> explain in more detail.
> 
> Albert Astals Cid wrote:
> Are you really defending that 
> 
> int addTwoNumbers(int a, int b) {
>  return 4;
> }
> 
> is correct because we only pass a = 2 and b = 2?
> 
> Marduk Bolanos wrote:
> Let's think about it. 
> 
> This is a function that compares strings. Let's agree that a string is an 
> array of chars of size N. 
> 
> What does it mean to compare two strings? In particular, what does it 
> mean that two strings are equal?
> 
> If you define that two strings are equal if both arrays are equal, then 
> this corresponds to the original behaviour of the function. Let's say that in 
> this case the strings are obviously equal.
> 
> You may also define that for N = 2 two strings are equal if either they 
> are obviously equal or the first char in both arrays is the same and the last 
> char in one array is space and the last char in the other array is newline.
> 
> In your previous comment you mentioned you would like to define that for 
> all N two strings are equal if the first N-1 chars in both arrays are equal 
> and the last char in one array is space and the last char in the other array 
> is newline. That is fine, but it is not necessary for the search 
> functionality.
> 
> As you can see, there is no absolute notion of equality of two strings. 
> What you call the correct behaviour of the function depends on how you define 
> the equality of two strings.

So Marduk, do it that way

if ( from.endsWith(QStringLiteral("\n") && to.endsWith(QStringLiteral(" ")) {
return from.trimmed().compare( to.trimmed(), Qt::CaseInsensitive ) == 0;
}


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Ян. 5, 2017, 12:20 след обяд, Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Ян. 5, 2017, 12:20 след обяд)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?
> 
> Marduk Bolanos wrote:
> I understand that you are worried about this being a general 
> string-comparison function, but AFAIK with the current search algorithm the 
> case you are considering will not occur. If I missed your point, please 
> explain in more detail.
> 
> Albert Astals Cid wrote:
> Are you really defending that 
> 
> int addTwoNumbers(int a, int b) {
>  return 4;
> }
> 
> is correct because we only pass a = 2 and b = 2?

Let's think about it. 

This is a function that compares strings. Let's agree that a string is an array 
of chars of size N. 

What does it mean to compare two strings? In particular, what does it mean that 
two strings are equal?

If you define that two strings are equal if both arrays are equal, then this 
corresponds to the original behaviour of the function. Let's say that in this 
case the strings are obviously equal.

You may also define that for N = 2 two strings are equal if either they are 
obviously equal or the first char in both arrays is the same and the last char 
in one array is space and the last char in the other array is newline.

In your previous comment you mentioned you would like to define that for all N 
two strings are equal if the first N-1 chars in both arrays are equal and the 
last char in one array is space and the last char in the other array is 
newline. That is fine, but it is not necessary for the search functionality.

As you can see, there is no absolute notion of equality of two strings. What 
you call the correct behaviour of the function depends on how you define the 
equality of two strings.


- Marduk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Jan. 5, 2017, 10:20 a.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 5, 2017, 10:20 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #9 from Oliver Sander  ---
I confirm that the patch avoids the duplicate 'poppler' entry for me.  Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Albert Astals Cid]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?
> 
> Marduk Bolanos wrote:
> I understand that you are worried about this being a general 
> string-comparison function, but AFAIK with the current search algorithm the 
> case you are considering will not occur. If I missed your point, please 
> explain in more detail.

Are you really defending that 

int addTwoNumbers(int a, int b) {
 return 4;
}

is correct because we only pass a = 2 and b = 2?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Jan. 5, 2017, 10:20 a.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 5, 2017, 10:20 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

Review Request 129791: Avoid duplicates in the available backends list

[Antonio Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129791/
---

Review request for Okular and Albert Astals Cid.


Bugs: 374650
http://bugs.kde.org/show_bug.cgi?id=374650


Repository: okular


Description
---

If a generator can open two mime types that match the same file, okular will 
show a selection dialog containing two copies of the same generator when 
opening that file. This patch avoids having duplicates in the backend list.


Diffs
-

  core/document.cpp 19526627 

Diff: https://git.reviewboard.kde.org/r/129791/diff/


Testing
---

Tried opening a PDF, okular opens it directly. Before this patch, if the "Show 
backend selection dialog" option was enabled, it would show a backend selection 
dialog with two copies od the poppler generator.


Thanks,

Antonio Rojas

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=374650

Antonio Rojas  changed:

   What|Removed |Added

 CC||aro...@archlinux.org

--- Comment #8 from Antonio Rojas  ---
https://git.reviewboard.kde.org/r/129791/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129557: [okular] Enable searching for a phrase split by a newline character in a PDF

[Marduk Bolanos]

> On Jan. 8, 2017, 1:27 a.m., Albert Astals Cid wrote:
> > please explain me why "a\n" and "a " should return true but "aa\n" and "aa 
> > " should return false?

I understand that you are worried about this being a general string-comparison 
function, but AFAIK with the current search algorithm the case you are 
considering will not occur. If I missed your point, please explain in more 
detail.


- Marduk


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129557/#review101856
---


On Jan. 5, 2017, 10:20 a.m., Marduk Bolanos wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129557/
> ---
> 
> (Updated Jan. 5, 2017, 10:20 a.m.)
> 
> 
> Review request for Okular and Oliver Sander.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> A blank space in the query is matched against a newline character in the PDF.
> 
> 
> Diffs
> -
> 
>   okular/core/textpage.cpp 44dfa14 
> 
> Diff: https://git.reviewboard.kde.org/r/129557/diff/
> 
> 
> Testing
> ---
> 
> Tried a few PDF files. It works.
> 
> 
> Thanks,
> 
> Marduk Bolanos
> 
>

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Patrick]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #7 from Patrick  ---
As far as I can see the problem isn't a duplicate generator but a problem with
mimetypes. Freedesktop defines "application/x-pdf" as an alias of
"application/pdf". The poppler backend supports both mimetypes, but in the
mimetype lookup (QMimeType mimeType = mimeDatabase.mimeTypeForName(supported)
in DocumentPrivate::generatorForMimeType) the result is the same mimetype
"application/pdf".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374650] Duplicate okular_poppler backend selection entry

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374650

--- Comment #6 from Oliver Sander  ---
Sure, here it is:

[/home/sander/okular-{test|save}] are two additional source trees that I happen
to have in my home directory.]

~> locate okularGenerator_poppler
/home/sander/okular/build/generators/poppler/okularGenerator_poppler.so
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.cpp
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/CXX.includecache
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/DependInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/annots.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/cmake_clean.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.internal
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/flags.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/formfields.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/link.txt
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/okularGenerator_poppler_automoc.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/pdfsettings.cpp.o
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/progress.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/AutogenInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/AutomocOldMocDefinitions.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/DependInfo.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/build.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/cmake_clean.cmake
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/depend.internal
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/depend.make
/home/sander/okular/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir/progress.make
/home/sander/okular/build/generators/poppler/okularGenerator_poppler_automoc.dir/moc_generator_pdf_24QWUT7JV56U7I.cpp
/home/sander/okular/generators/poppler/libokularGenerator_poppler.json
/home/sander/okular-inst/lib/x86_64-linux-gnu/plugins/okular/generators/okularGenerator_poppler.so
/home/sander/okular-save/build/generators/poppler/okularGenerator_poppler.so
/home/sander/okular-save/build/generators/poppler/okularGenerator_poppler_automoc.cpp
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler_automoc.dir
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/CXX.includecache
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/DependInfo.cmake
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/annots.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/build.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/cmake_clean.cmake
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.internal
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/depend.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/flags.make
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/formfields.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/generator_pdf.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/link.txt
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/okularGenerator_poppler_automoc.cpp.o
/home/sander/okular-save/build/generators/poppler/CMakeFiles/okularGenerator_poppler.dir/pdfsettings.cpp.o