Re: Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

[Albert Astals Cid]

> On March 11, 2017, 4:51 p.m., Albert Astals Cid wrote:
> > ui/findbar.cpp, line 50
> > 
> >
> > Why this line?
> 
> Marco Scarpetta wrote:
> Because when we call *m_automaticSearchAct->setChecked( 
> Okular::Settings::searchAutomatic() )* and 
> *Okular::Settings::searchAutomatic()* is false, the signal 
> *::toggled* won't be emitted since the checked property is false by 
> default. If *Okular::Settings::searchAutomatic()* is true, 
> *::toggled* will be emitted and on line 183, 
> *m_search->lineEdit()->setAutomaticSearch* will be called with *true* as 
> argument.

Ok, i see, bit convoluted but fair enough.


> On March 11, 2017, 4:51 p.m., Albert Astals Cid wrote:
> > ui/findbar.cpp, line 72
> > 
> >
> > I think "Find as you type" is much better than "Automatic search", what 
> > do you think?
> 
> Marco Scarpetta wrote:
> Yes, I think so, too. Do I have to change variables names, functions 
> names etc? (I think yes)

Not mandatory but if you have the time to do it, it's always nice to have the 
user visible text and the code variables being similar since it makes for 
easier finding in the source code.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129956/#review102788
---


On Feb. 20, 2017, 8:50 a.m., Marco Scarpetta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129956/
> ---
> 
> (Updated Feb. 20, 2017, 8:50 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 326522
> http://bugs.kde.org/show_bug.cgi?id=326522
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Implement an option to disable the automatic search while typing in okular 
> findbar. When the "automatic search" option is disabled the user must press 
> the return key to start searching.
> 
> 
> Diffs
> -
> 
>   conf/okular.kcfg e06dd91b 
>   ui/findbar.h 2c34d0de 
>   ui/findbar.cpp 09201e78 
>   ui/searchlineedit.h b8230e65 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129956/diff/
> 
> 
> Testing
> ---
> 
> I ran okular and tested that both searching modes work.
> 
> 
> Thanks,
> 
> Marco Scarpetta
> 
>

Re: Review Request 129785: Stop debug spam in release builds

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129785/
---

(Updated March 12, 2017, 10:18 p.m.)


Status
--

This change has been discarded.


Review request for Okular.


Repository: okular


Description
---

Okular core prints lots of debug messages, stop that in release builds.


Diffs
-

  OkularConfigureChecks.cmake 70fe8768 
  ui/formwidgets.cpp 7e68b5c7 

Diff: https://git.reviewboard.kde.org/r/129785/diff/


Testing
---


Thanks,

Miklós Máté

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

[Miklós Máté]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129286/
---

(Updated March 12, 2017, 10:17 p.m.)


Status
--

This change has been discarded.


Review request for Okular.


Repository: okular


Description
---

The one in the DVI generator is a maybe-unused warning, but it's a false 
positive, because there were no unhandled enum values.


Diffs
-

  generators/dvi/generator_dvi.cpp d1536cc 
  ui/pageview.cpp bb540cb 
  ui/presentationwidget.cpp e6ecdc5 

Diff: https://git.reviewboard.kde.org/r/129286/diff/


Testing
---


Thanks,

Miklós Máté

Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch

[Albert Astals Cid]

> On March 11, 2017, 5:03 p.m., Albert Astals Cid wrote:
> > Which compiler are you using that gives you those warnings?
> 
> Miklós Máté wrote:
> 3 months ago I think I used gcc 5.something. Currently I have gcc 6.3, 
> and it doesn't issue a warning for the dvi generator. Yay for fewer false 
> positives.

Ok, i'll discard this then.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129286/#review102792
---


On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129286/
> ---
> 
> (Updated Oct. 30, 2016, 2:29 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> The one in the DVI generator is a maybe-unused warning, but it's a false 
> positive, because there were no unhandled enum values.
> 
> 
> Diffs
> -
> 
>   generators/dvi/generator_dvi.cpp d1536cc 
>   ui/pageview.cpp bb540cb 
>   ui/presentationwidget.cpp e6ecdc5 
> 
> Diff: https://git.reviewboard.kde.org/r/129286/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Miklós Máté
> 
>

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

[Lukas Schneiderbauer]

https://bugs.kde.org/show_bug.cgi?id=362856

Lukas Schneiderbauer  changed:

   What|Removed |Added

 CC||lukas.schneiderbauer@gmail.
   ||com

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129956: Allow to disable automatic search while typing (Fixes bug #326522)

[Marco Scarpetta]

> On Mar. 11, 2017, 4:51 p.m., Albert Astals Cid wrote:
> > ui/findbar.cpp, line 50
> > 
> >
> > Why this line?

Because when we call *m_automaticSearchAct->setChecked( 
Okular::Settings::searchAutomatic() )* and 
*Okular::Settings::searchAutomatic()* is false, the signal *::toggled* 
won't be emitted since the checked property is false by default. If 
*Okular::Settings::searchAutomatic()* is true, *::toggled* will be 
emitted and on line 183, *m_search->lineEdit()->setAutomaticSearch* will be 
called with *true* as argument.


> On Mar. 11, 2017, 4:51 p.m., Albert Astals Cid wrote:
> > ui/findbar.cpp, line 72
> > 
> >
> > I think "Find as you type" is much better than "Automatic search", what 
> > do you think?

Yes, I think so, too. Do I have to change variables names, functions names etc? 
(I think yes)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129956/#review102788
---


On Feb. 20, 2017, 8:50 a.m., Marco Scarpetta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129956/
> ---
> 
> (Updated Feb. 20, 2017, 8:50 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 326522
> http://bugs.kde.org/show_bug.cgi?id=326522
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Implement an option to disable the automatic search while typing in okular 
> findbar. When the "automatic search" option is disabled the user must press 
> the return key to start searching.
> 
> 
> Diffs
> -
> 
>   conf/okular.kcfg e06dd91b 
>   ui/findbar.h 2c34d0de 
>   ui/findbar.cpp 09201e78 
>   ui/searchlineedit.h b8230e65 
>   ui/searchlineedit.cpp baac8be0 
> 
> Diff: https://git.reviewboard.kde.org/r/129956/diff/
> 
> 
> Testing
> ---
> 
> I ran okular and tested that both searching modes work.
> 
> 
> Thanks,
> 
> Marco Scarpetta
> 
>