[okular] [Bug 377458] Please add ability to "delete pages"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377458

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377456] Please add "eraser"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377456

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
   Severity|major   |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377451] Pleas add "reorder page" from thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377451

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377460] Please add ability to "Edit metadata (document info)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377460

Nate Graham  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377457] Please add ability to "add new (blank) pages"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377457

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
   Severity|normal  |wishlist

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 376692] Search function fails to find phrases split over two lines

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=376692

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377451] Pleas add "reorder page" from thumbnails

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377451

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #1 from Nate Graham  ---
Continuing the theme from https://bugs.kde.org/show_bug.cgi?id=377456 et al...

"Okular is not an editor (annotations are a bit different), so this is unlikely
to happen."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377567] Some annotation not visible in Google Chrome PDF viewer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377567

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 383651 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383651

Nate Graham  changed:

   What|Removed |Added

 CC||ramos.kie...@gmail.com

--- Comment #5 from Nate Graham  ---
*** Bug 377567 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377567] Some annotation not visible in Google Chrome PDF viewer

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377567

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #5 from Nate Graham  ---
Related to or a duplicate of https://bugs.kde.org/show_bug.cgi?id=383651

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377625] Moving annotations causes their border color, shape and features to change

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=377625

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382139] Sidebar tab button text unreadable on hover and when current tab is not focused

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382139

Nate Graham  changed:

   What|Removed |Added

Summary|Sidebar button text |Sidebar tab button text
   |unreadable on hover |unreadable on hover and
   ||when current tab is not
   ||focused

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382139] Sidebar button text unreadable on hover

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382139

--- Comment #3 from Nate Graham  ---
Submitted a patch that fixes this: https://phabricator.kde.org/D7793

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7793

To: ngraham, aacid, #okular, #kde_applications, broulik, sander
Cc: aacid

D7793: Improve text visibility for Okular sidebar tabs that are hovered-over or selected-but-out-of-focus when using Breeze color scheme

[Nathaniel Graham]

ngraham created this revision.
ngraham added a project: Okular.

REVISION SUMMARY
  Changed the colors used from the active theme so that there is never a 
white-on-light-blue situation that makes the text unreadable.
  
  Here are the changes when using the Breeze color scheme:
  
  - When an inactive tab is hovered over, the text is now dark (was light 
before)
  - When a selected tab loses focus, the text is now dark (was light before)
  
  Tested to make sure dark themes do not experience a regression.
  
  BUG: 382139

TEST PLAN
  Tested on KDE Neon (dev unstable). Verified that with the default Breeze 
color scheme, tab text is more readable when hovered over and then active but 
not in focus. See before and after:
  
  F3909143: After.png 
  
  F3909142: Before.png 
  
  Also tested these changes with all standard color schemes shipped with Neon 
to make sure that there were no visual regressions.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7793

AFFECTED FILES
  ui/sidebar.cpp

To: ngraham, aacid, #okular, #kde_applications, broulik, sander
Cc: aacid

[okular] [Bug 370949] PDF bookmarks off by one

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=370949

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Yes, please report against poppler:
https://bugs.freedesktop.org/enter_bug.cgi?product=poppler

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 378186] annotations created by okular display wrongly in adobe reader

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=378186

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382139] Sidebar button text unreadable on hover

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382139

--- Comment #2 from Nate Graham  ---
It appears that Okular is using the wrong color from the active color theme
here. It is using Selection Text for tab items that you are hovering over, when
it should be using View Text (which is what most programs use for items that
you are hovering over).

The problem is only noticeable with the Breeze color scheme, since it is a
light theme that uses a light color for Selection Text; most light themes use a
dark color for this, and most dark themes have a dark background to contrast
against a light color here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=267350

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 379631] Please add notification "Encrypted" in title bar for encrypted PDF or document

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=379631

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 379749] Crash when saving/closing a PDF with forms

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=379749

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 374406] Cannot set print margins to zero - renders Okular useless for printing labels

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=374406

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED
 CC||pointedst...@zoho.com

--- Comment #6 from Nate Graham  ---
This isn't an issue with Okular or the Qt print dialog; the allowable minimum
margins are determined further down the printing stack, by CUPS or LPR another
part of the printing system. My printer + CUPS +LPR combination allows 0"
margins on all sides, for example. You might try reporting against CUPS or LPR.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 380459] read out loud

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=380459

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Nate Graham  ---
This isn't a part of Okular, is it? Isn't this a different program or a system
service?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 380872] When use Review tool the highlight tool selection is too big

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=380872

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Nate Graham  ---
Yeah I can't reproduce this either with a newer version of Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 186531] [JJ] Trim Margin doesn't work if paper color was set

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=186531

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 380506] crashing on an annotated document loses new annotations

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=380506

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Nate Graham  ---
Yeah, the bug here is that Okular crashed, not that the annotations didn't get
saved before you could complete the Save function. Okular shouldn't have
crashed! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 363513] Tabs should be more homogeneously sized

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363513

Nate Graham  changed:

   What|Removed |Added

 CC||alex-a...@hotmail.com

--- Comment #6 from Nate Graham  ---
*** Bug 381875 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 381875] Tab width uneven: a large file name hide all the others

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381875

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||pointedst...@zoho.com
 Resolution|--- |DUPLICATE

--- Comment #3 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 363513 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382139] Sidebar button text unreadable on hover

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382139

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Nate Graham  ---
I agree. White text on a light background is a usability issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382238] zoom locked

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382238

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||pointedst...@zoho.com
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Nate Graham  ---
Raphael, can you provide the info Oliver asked for?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 365161] Can't select which pages to print

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=365161

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Yeah, and the Qt bug is https://bugreports.qt.io/browse/QTBUG-1311.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 347794] landscape A3 page incorrectly scaled down to printout A4 paper size

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=347794

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 383734 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383734] Print job with media=Custom swaps width and height which results in shrinked printouts

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383734

Nate Graham  changed:

   What|Removed |Added

 CC||t.kleindie...@web.de

--- Comment #5 from Nate Graham  ---
*** Bug 347794 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 343834] Okular doesn't print some form fields

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=343834

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383734] Print job with media=Custom swaps width and height which results in shrinked printouts

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383734

Nate Graham  changed:

   What|Removed |Added

 CC||psychon...@nothingisreal.co
   ||m

--- Comment #4 from Nate Graham  ---
*** Bug 363788 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 363788] Fit to page printing does incorrect scaling and unwanted offsetting

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363788

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #15 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 383734 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 263042] XFA Forms are not supported

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=263042

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 363513] Tabs should be more homogeneously sized

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363513

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 252596] okular printing options not working when printing to file (pdf/ps)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=252596

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383734] Print job with media=Custom swaps width and height which results in shrinked printouts

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383734

Nate Graham  changed:

   What|Removed |Added

 CC||pascal+...@niklaus.org

--- Comment #3 from Nate Graham  ---
*** Bug 348171 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 348171] Scaling problem during printing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=348171

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Nate Graham  ---
Very likely a duplicate of https://bugs.kde.org/show_bug.cgi?id=383734

Can you let me know if the problem reproduces using Okular from git master?

*** This bug has been marked as a duplicate of bug 383734 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382863] Okular does not submit PDF form content

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382863

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382860] Okular does not execute any basic PDF form action

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382860

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382858] PDF form bug in displaying popdown boxes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382858

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 331697] can't fill out pdf form

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=331697

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 271728] Okular does not calculate in PDF forms

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=271728

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 305915] Submit button not displayed in PDF form opened in Okular

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=305915

--- Comment #17 from Nate Graham  ---
And also Uwe, I do not in any way mean to suggest that you are flaming Albert.
You are being really patient and professional here, and for that we are
appreciative!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382859] Okular does not execute JavaScript of PDF forms

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382859

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382857] PDF form bug in displaying dependent radiobuttons

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382857

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 305915] Submit button not displayed in PDF form opened in Okular

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=305915

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

--- Comment #16 from Nate Graham  ---
For what it's worth,  too have yet to encounter a PDF with forms that I could
actually fill out with Okular. :( We might want to mark the feature in the UI
as experimental or "use at your own risk" or something. I have to agree with
Uwe that it may be better to disable or at least warn about a half-working
feature than let people try it, get frustrated with bugs that make it very
broken. They often get angry and want to flame the developers, which is very
depressing and saps people's motivation to actually fix the issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7714: Show dialog to ask when closing when more than tab open

[Thomas Pfeiffer]

colomar added a comment.


  Why don't we simply copy the Firefox dialog?
  Firefox has a big userbase and with the default settings, the vast majority 
of users will see this dialog at some point. Therefore if their wording was 
problematic, it's very likely someone would have flamed them for it.
  So I'd consider their dialog "real-world tested".
  
  F3908986: image.png 
  
  It has explicitly named buttons (Close Tabs and Cancel), it uses the question 
icon, it has clear wording. If it's difficult to determine the number of open 
tabs at this point, just using "multiple" instead would be okay as well. The 
situation is the same. No need to reinvent the wheel here.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7714

To: aacid
Cc: colomar, rkflx, #okular, aacid

D7671: Fix automatic reload of files saved with QSaveFile

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D7671#144616, @rkflx wrote:
  
  > For completeness, for a file watch on "x" (not sure whether you may have 
confused file and dir watches as well as file and dir Okular code pathes in 
your reply), we get:
  >
  > - `touch x` (no x yet) → "created" signal
  > - `touch x` (again) → "dirty" signal
  > - `touch ../y && mv ../y x` → "deleted" signal and "created" signal
  > - `rm x` → "deleted" signal
  >
  >   To me this seems logical and consistent, only the documentation regarding 
"move" is lacking. Of course we could argue that `touch` (no x yet), `mv` and 
`rm` should also send an additional "dirty" signal. Above I said "it should 
not", because it breaks backwards compatibility with existing KDirWatch users 
(they get signals they may have wanted to avoid, or they have a separate code 
path for "create") and there are already more specialized signals. In addition, 
only adding to the documentation is less risky than invasive changes to 
KDirWatch's internals (it has to work for all backends and on all platforms, 
after all).
  
  
  i'm not going to keep discussing this here, makes no sense, if you want to 
discuss on KDirwarch use the kde-frameworks-devel thread.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7671

To: progwolff, aacid
Cc: sander, rkflx, #okular, aacid

Re: Review Request 130226: CHM Generator Lib Update

[Gilbert Assaf]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/
---

(Updated Sept. 12, 2017, 9:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 6b27aa53fa7ba034f7808601ebdc13bbf8b0e020 by Gilbert Assaf 
to branch master.


Repository: okular


Description
---

This patch updates our copy of the chm lib from kchmviewer. The lib files 
itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
some changes. In contrast to kchmviewer we still use khtml and therefor still 
need msits.


Diffs
-

  cmake/modules/FindLibZip.cmake PRE-CREATION 
  generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
  generators/chm/lib/ebook.h PRE-CREATION 
  generators/chm/lib/ebook.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm.h PRE-CREATION 
  generators/chm/lib/ebook_chm.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
  generators/chm/lib/ebook_epub.h PRE-CREATION 
  generators/chm/lib/ebook_epub.cpp PRE-CREATION 
  generators/chm/lib/ebook_search.h PRE-CREATION 
  generators/chm/lib/ebook_search.cpp PRE-CREATION 
  generators/chm/lib/ebook_url.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
  generators/chm/lib/helper_search_index.h PRE-CREATION 
  generators/chm/lib/helper_search_index.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
  generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
  generators/chm/lib/libchmfile_search.cpp 
76532b18282913ff97c8509d8e384ec0b1f48dfb 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.h 
5228b04c10718d407fc49df2e69d220d4efff67c 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 


Diff: https://git.reviewboard.kde.org/r/130226/diff/2/


Testing
---


Thanks,

Gilbert Assaf

D7714: Show dialog to ask when closing when more than tab open

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D7714#144296, @rkflx wrote:
  
  > > What part of "Are you sure you want to quit" Yes/No you find ambiguous?
  >
  > KDE's HIG says
  >
  >   Label command buttons with an imperative verb.
  >   
  >
  > and also
  >
  >   Use descriptive button labels instead of standard Yes/No or OK/Cancel 
buttons. For example, if the user must choose to continue or stop an action, 
provide the buttons "Continue" and "Cancel".
  >   
  >
  > and IIRC there was even a time when a lot of KDE dialogs were converted 
from Yes/No style to a more action oriented style.
  
  
  So how would you name them, since you're the one blocking on wording, you may 
as well suggest those names ;)
  
  > 
  > 
  >> This has nothing to do with "this window", it's about the application 
itself being closed.
  > 
  > Try opening multiple Okular windows with tabs and quit. Only one window 
(from the perspective of the user) will be closed.
  
  Ok, since you're better at the wording, please suggest a full wording for the 
dialog.
  
  > 
  > 
  >> Why is warning better?
  > 
  > The "i" in the icon stands for "information", but in reality you are asking 
the user to pick between two buttons (the "warning" icons signals "attention, 
decide between two things!" with the imperative literally depicted by "!") Of 
course, a question mark would also work (maybe even better).
  
  I still disagree with Warning, I'll change it to Question once you give me 
the correct wordings for the other items.
  
  > 
  > 
  >> That's why firefox wording that i copied is much better
  > 
  > Fair enough. It would be a nice touch if you could also change it in 
Dolphin then, though.
  
  I'm not going to fix Dolphin *right now*. I may create a new feature for 
KMessageDialog that allows for people to use different wording instead of 
"Don't ask me again", and maybe then port Dolphin to it, but that's separate 
from this feature.
  
  > 
  > 
  >> that doesn't have anything to do with this, we have multiple "don't ask me 
again" already, so this can't be a blocker.
  > 
  > I thought it was a relevant question, so I brought it up. I'm sorry you 
feel attacked.
  
  What part of "you can't block this feature on an already existing problem" 
you think means i feel attacked?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7714

To: aacid
Cc: colomar, rkflx, #okular, aacid

[okular] [Bug 382011] SyncTeX 2017 upgrade

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=382011

Henrik Fehlauer  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Henrik Fehlauer  ---
D7594 has now landed in Okular's master branch, therefore we can consider this
bug/wish as done.

If there are any other questions/comments/requests regarding SyncTeX in Okular,
do not hesitate to comment here or open a new bug. Thanks again for reaching
out.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7594: Update to synctex 1.19

[Henrik Fehlauer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:bd20e48c3c8c: Update to synctex 1.19 (authored by rkflx).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7594?vs=19133=19459

REVISION DETAIL
  https://phabricator.kde.org/D7594

AFFECTED FILES
  autotests/parttest.cpp
  core/document.cpp
  core/document_p.h
  core/synctex/patches/00-disable-SYNCTEX_INLINE.diff
  core/synctex/patches/01-fix-win32-define.diff
  core/synctex/patches/04-gcc-specify-printf-format.diff
  core/synctex/patches/05-fix-error-formats.diff
  core/synctex/patches/06-mingw-_synctex_error.diff
  core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff
  core/synctex/patches/08-fix_cpp_comments.diff
  core/synctex/patches/09-fix_path_comparison.diff
  core/synctex/patches/10-fix-typo.diff
  core/synctex/patches/11-fix-unused-parameters-warnings.diff
  core/synctex/patches/12-omit-no-file-warning.diff
  core/synctex/patches/13-fix-Wundef-warnings.diff
  core/synctex/patches/14-fix-misc-compiler-warnings.diff
  core/synctex/patches/15-prevent-leaks-and-segfault.diff
  core/synctex/patches/series
  core/synctex/synctex_parser.c
  core/synctex/synctex_parser.h
  core/synctex/synctex_parser_advanced.h
  core/synctex/synctex_parser_local.h
  core/synctex/synctex_parser_readme.md
  core/synctex/synctex_parser_readme.txt
  core/synctex/synctex_parser_utils.c
  core/synctex/synctex_parser_utils.h
  core/synctex/synctex_parser_version.txt

To: rkflx, #okular, sander, #kile, aacid
Cc: mludwig, aacid

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=383915

Henrik Fehlauer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||17.12.0
  Latest Commit||https://commits.kde.org/oku
   ||lar/bd20e48c3c8c82ed11ae73a
   ||ae0467c8ef49fca3b
 Status|ASSIGNED|RESOLVED

--- Comment #12 from Henrik Fehlauer  ---
Git commit bd20e48c3c8c82ed11ae73aae0467c8ef49fca3b by Henrik Fehlauer.
Committed on 12/09/2017 at 19:56.
Pushed by rkflx into branch 'master'.

Update to synctex 1.19

Summary:
This should prevent crashes when reloading some synctex-enabled pdf
files created with newer versions of TeXLive. We also gain bugfixes,
features and improved accuracy from the last 6 years of synctex
development.

Procedure followed:
- svn co svn://tug.org/texlive/trunk/Build/source/texk/web2c/synctexdir
- Check out revision 45150
- Update files present in core/synctex/*
- Adapt Okular code to changes
- Review and drop or update/apply old patches using quilt
- Create missing patches for local synctex changes
- New patch: Omit warning message when opening non-synctex pdf
- Two new patches to fix more compiler warnings
- New patch: Plug multiple leaks and prevent a segfault

TODO for later:
- Move sync file detection code to Okular to never call into synctex C code for
non-synctex files
- Evaluate feasibility of upstreaming all patches for TeXLive 2018 and using
synctex as a library
FIXED-IN: 17.12.0

Test Plan:
- No crash in synctex on reloading empty.pdf from bugreport anymore.
- Shift-clicking on a word in a simple pdf opens Kate with the corresponding
tex line.
- Forward and backward search in Kile seems to work.
- Works with synctex files from both TeXLive 2015 and 2017.
- PartTest::testForwardPDF still passes.
- No additional memory leaks in autotests and with basic synctex and
non-synctex usage of Okular.

Reviewers: #okular, sander, #kile, aacid

Reviewed By: #okular, aacid

Subscribers: mludwig, aacid

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7594

M  +4-4autotests/parttest.cpp
M  +5-5core/document.cpp
M  +1-1core/document_p.h
M  +9-8core/synctex/patches/00-disable-SYNCTEX_INLINE.diff
D  +0-42   core/synctex/patches/01-fix-win32-define.diff
M  +51   -12   core/synctex/patches/04-gcc-specify-printf-format.diff
D  +0-13   core/synctex/patches/05-fix-error-formats.diff
M  +10   -9core/synctex/patches/06-mingw-_synctex_error.diff
D  +0-21  
core/synctex/patches/07-synctex_scanner_new_with_output_file-reset-mode.diff
M  +29   -23   core/synctex/patches/08-fix_cpp_comments.diff
D  +0-22   core/synctex/patches/09-fix_path_comparison.diff
A  +17   -0core/synctex/patches/10-fix-typo.diff
A  +49   -0core/synctex/patches/11-fix-unused-parameters-warnings.diff
A  +17   -0core/synctex/patches/12-omit-no-file-warning.diff
A  +326  -0core/synctex/patches/13-fix-Wundef-warnings.diff
A  +62   -0core/synctex/patches/14-fix-misc-compiler-warnings.diff
A  +54   -0core/synctex/patches/15-prevent-leaks-and-segfault.diff
M  +6-4core/synctex/patches/series
M  +8471 -4038 core/synctex/synctex_parser.c
M  +410  -332  core/synctex/synctex_parser.h
A  +552  -0core/synctex/synctex_parser_advanced.h [License: BSD X11
(BSD like)]
M  +1-1core/synctex/synctex_parser_local.h
A  +246  -0core/synctex/synctex_parser_readme.md
D  +0-141  core/synctex/synctex_parser_readme.txt
M  +176  -92   core/synctex/synctex_parser_utils.c
M  +39   -19   core/synctex/synctex_parser_utils.h
M  +1-1core/synctex/synctex_parser_version.txt

https://commits.kde.org/okular/bd20e48c3c8c82ed11ae73aae0467c8ef49fca3b

-- 
You are receiving this mail because:
You are the assignee for the bug.