Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-09-26 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103741
---



Do you think you could do an autotest using formSamples.pdf ?

- Albert Astals Cid


On set. 23, 2017, 7:08 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> ---
> 
> (Updated set. 23, 2017, 7:08 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
> http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
> CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which 
> state I should reset/clear them. Especially for ComboBox, I am not sure if 
> clearing them could be harmful.
> 
> 
> Diffs
> -
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp a1215ce7d88b428dccdc5cac54ad6c934a81d494 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 9766422b927d23330ce9fced5af8d406cee6ccd2 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:1364d0e97b22: Properly create KPixmapSequence (authored 
by elvisangelaccio).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7996?vs=19947=19958

REVISION DETAIL
  https://phabricator.kde.org/D7996

AFFECTED FILES
  ui/searchlineedit.cpp

To: elvisangelaccio, #okular, aacid
Cc: aacid, #okular

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7996#149307, @elvisangelaccio wrote:
  
  > The weird thing is that I can't find the change with git blame. Shouldn't 
we just restore the old implementation?
  
  
  Ah no, we can't since KIconLoader is tier3...

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7996

To: elvisangelaccio, #okular, aacid
Cc: aacid, #okular

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  In https://phabricator.kde.org/D7996#149273, @aacid wrote:
  
  > Whoever decided to change from iconName to fullpath deserves some 
punishment for having a class constructor that has exactly signature but 
behaves totally different.
  >
  > every single instance is broken
  >  
https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082
  >  https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147
  >  
https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162
  >  
https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140
  >
  > meh, i'll forget this to make my life better.
  
  
  I had a look, kdelibs has
  
KPixmapSequence::KPixmapSequence(const QString , int size)
: d(new Private)
{
d->loadSequence(QPixmap(KIconLoader::global()->iconPath(xdgIconName, 
-size)), QSize(size, size));
}
  
  while kwidgetaddons has
  
KPixmapSequence::KPixmapSequence(const QString , int size)
: d(new Private)
{
d->loadSequence(QPixmap(fullPath), QSize(size, size));
} 
  
  The weird thing is that I can't find the change with git blame. Shouldn't we 
just restore the old implementation?

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7996

To: elvisangelaccio, #okular, aacid
Cc: aacid, #okular

Re: Review Request 129893: Implement continuous search

2017-09-26 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---

(Updated Sept. 26, 2017, 9:28 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular, KDE Usability and Albert Astals Cid.


Repository: okular


Description
---

Show non-intrusive info messages whenever the search start over from the 
beginning or the bottom of the document, instead of asking the user if s/he 
wants to continue the search. This is consistent with search in KWrite/Kate and 
with web browsers.


Diffs
-

  core/document.cpp 91c623b58d1d98e11afdce73bc3f1f68becd657c 
  ui/searchlineedit.cpp 74e6ef60c06c2d4e0b30be1eb6804545f58bd8eb 


Diff: https://git.reviewboard.kde.org/r/129893/diff/4/


Testing
---

Search for something in a pdf, click Next until reaching the end of document. 
Click again Next and the search starts over from the beginning of the document, 
without the "Continue from the beginning?" dialog.


File Attachments


Before: dialog asks if the search should continue from the beginning.
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png
After: always continue search from beginning, with a non-intrusive notification.
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png


Thanks,

Elvis Angelaccio

[okular] [Bug 385015] Okular does not show XMP metadata for PDFs

2017-09-26 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=385015

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #4 from Albert Astals Cid  ---
This needs work

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129893: Implement continuous search

2017-09-26 Thread Elvis Angelaccio 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129893/
---

(Updated Sept. 26, 2017, 8:42 p.m.)


Review request for Okular, KDE Usability and Albert Astals Cid.


Changes
---

Removed the roundtrip core->ui->core


Repository: okular


Description
---

Show non-intrusive info messages whenever the search start over from the 
beginning or the bottom of the document, instead of asking the user if s/he 
wants to continue the search. This is consistent with search in KWrite/Kate and 
with web browsers.


Diffs (updated)
-

  core/document.cpp 91c623b58d1d98e11afdce73bc3f1f68becd657c 
  ui/searchlineedit.cpp 74e6ef60c06c2d4e0b30be1eb6804545f58bd8eb 


Diff: https://git.reviewboard.kde.org/r/129893/diff/4/

Changes: https://git.reviewboard.kde.org/r/129893/diff/3-4/


Testing
---

Search for something in a pdf, click Next until reaching the end of document. 
Click again Next and the search starts over from the beginning of the document, 
without the "Continue from the beginning?" dialog.


File Attachments


Before: dialog asks if the search should continue from the beginning.
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png
After: always continue search from beginning, with a non-intrusive notification.
  
https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png


Thanks,

Elvis Angelaccio

Re: Quick question on packages for Ubuntu

2017-09-26 Thread Albert Astals Cid 
El dimarts, 26 de setembre de 2017, a les 10:47:56 CEST, Antonello Lobianco va 
escriure:
> Quick question on packages for Ubuntu
> Hello,
>  just a quick question. I'm using Ubuntu 16.04 and installed okular from
> official pkg sources.
> I have installed pkg okular 4:15.12.3-0ubuntu1 (that seems to be the latest
> version).
> Okular reports me okular version 0.24.2 and kde 4.14.16
> 
> On okular download page (https://okular.kde.org/download.php) however it is
> reported that the latest version of okular for ubuntu 16.04 should be
> 15.12.3.

Yes, and as you said it is the version that you have installed.

> 
> My main concern is that the version I have seems not to have multiple
> drawing colours in presentation mode and the capability to save them, but
> from the doc (
> https://docs.kde.org/trunk5/en/kdegraphics/okular/configpresentation.html)
> it seems the last version allow to choose colours (and hopefully to save
> the draws made during presentation).
> 
> Is there a newer binary package for Ubuntu 16.04 that I missed somehow ?

You should ask this in some ubuntu related mailing list, we do not provide 
packages for ubuntu.

If ubuntu 16.04 has support for flatpak you can try using the experimental 
flatpak packages https://community.kde.org/Guidelines_and_HOWTOs/Flatpak

Cheers,
  Albert

> 
> Kind regards,
>   Antonello

D7996: Properly create KPixmapSequence

2017-09-26 Thread Albert Astals Cid 
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Whoever decided to change from iconName to fullpath deserves some punishment 
for having a class constructor that has exactly signature but behaves totally 
different.
  
  every single instance is broken
  https://lxr.kde.org/source/frameworks/kpeople/src/widgets/mergedialog.cpp#0082
  https://lxr.kde.org/source/frameworks/knewstuff/src/uploaddialog.cpp#0147
  
https://lxr.kde.org/source/calligra/krita/libs/ui/widgets/kis_cie_tongue_widget.cpp#0162
  
https://lxr.kde.org/source/extragear/base/nepomuk-webminer/src/lib/ui/fetcherdialog.cpp#0140
  
  meh, i'll forget this to make my life better.

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7996

To: elvisangelaccio, #okular, aacid
Cc: aacid, #okular

Quick question on packages for Ubuntu

2017-09-26 Thread Antonello Lobianco 
Quick question on packages for Ubuntu
Hello,
 just a quick question. I'm using Ubuntu 16.04 and installed okular from
official pkg sources.
I have installed pkg okular 4:15.12.3-0ubuntu1 (that seems to be the latest
version).
Okular reports me okular version 0.24.2 and kde 4.14.16

On okular download page (https://okular.kde.org/download.php) however it is
reported that the latest version of okular for ubuntu 16.04 should be
15.12.3.

My main concern is that the version I have seems not to have multiple
drawing colours in presentation mode and the capability to save them, but
from the doc (
https://docs.kde.org/trunk5/en/kdegraphics/okular/configpresentation.html)
it seems the last version allow to choose colours (and hopefully to save
the draws made during presentation).

Is there a newer binary package for Ubuntu 16.04 that I missed somehow ?

Kind regards,
  Antonello

-- 
Antonello Lobianco
AgroParisTech, Laboratoire d'Economie Forestière
14 Rue Girardet - 54000 Nancy, France
Tel: +33.383396865
Email, university: antonello.lobia...@inra.fr

Email, personal: antone...@lobianco.org
http://antonello.lobianco.org

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  The KPixmapSequence constructor needs the full path of the icon, so the
  current code doesn't work and generates a "Invalid pixmap specified"
  warning at runtime. By using KIconLoader we can fix this issue.

TEST PLAN
  Search something and reach the end of document to make the animation start.

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7996

AFFECTED FILES
  ui/searchlineedit.cpp

To: elvisangelaccio
Cc: #okular, aacid

D7996: Properly create KPixmapSequence

2017-09-26 Thread Elvis Angelaccio 
elvisangelaccio added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7996

To: elvisangelaccio, #okular
Cc: #okular, aacid