D7874: Show tooltip for annotations without handle too

[Luigi Toscano]

ltoscano added a comment.


  For the people that will land up here later: it seems that both are valid 
(BUG and BUGS), see line 422 here:
  
https://websvn.kde.org/trunk/kde-common/svn/hooks/post-commit.pl?revision=1446260=markup
  
  About the reviewers, you don't need to set the reviewer if the automated 
Herald rule sets a mailing list to the subscribers list. The mail will land in 
the proper place, despite what Phabricator says.
  And even if having a reviewer is preferred, then the rules should be updated 
rather than adding explicit reviewers IMHO.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: ltoscano, ngraham, rkflx, tobiasdeiminger, #okular, aacid

D7874: Show tooltip for annotations without handle too

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D7874#149711, @rkflx wrote:
  
  > I can confirm the fix and was not able to find any regressions (found an 
unrelated bug, though).
  >
  > Sorry for not noticing this earlier. Maybe you'd interest more reviewers in 
the future if you followed standard Phab practices, i.e. set some (group or 
normal) reviewers and provide a test plan.
  
  
  It gets sent to the okular-devel mailing list automatically, that's where i 
expect people that care about okular reviews to be :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger, #okular, aacid

D7874: Show tooltip for annotations without handle too

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger, #okular, aacid

D7874: Show tooltip for annotations without handle too

[Albert Astals Cid]

aacid added a comment.


  ~/okular:master$ git log | grep BUGS: | wc -l
  258
  
  ;)
  
  As far as i know it's just a synonym

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger, #okular, aacid

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=330820

Albert Astals Cid  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

--- Comment #12 from Albert Astals Cid  ---
The duplication you did is wrong.

This bug is that the pages are getting cropped when they should not, nothing to
do with adding extra scaling options.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7874: Show tooltip for annotations without handle too

[Nathaniel Graham]

ngraham added a comment.


  Sorry, I was under the impression that only "BUG: [number]" worked. I didn't 
know that "BUGS:" worked too. Is that used to indicate multiple bugs?

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: ngraham, rkflx, tobiasdeiminger, #okular, aacid

D7874: Show tooltip for annotations without handle too

[Albert Astals Cid]

aacid added a comment.


  I would really appreciate if you didn't unnecessarily change my summary.

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7874

To: aacid, rkflx
Cc: rkflx, tobiasdeiminger, #okular, aacid

[okular] [Bug 384147] Hovering over annotations no longer shows contents in tooltip

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=384147

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 357626] Please add "Remove bookmark" in popup menu

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=357626

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 380459] read out loud

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=380459

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384695] Configurable horizontal scrolling key (ALT or SHIFT) + WHEEL

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=384695

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384700] "Accessibilty Reading Aids Shortcut" New feature request

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=384700

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377458] Please add ability to "delete pages"

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=377458

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377456] Please add "eraser"

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=377456

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=383651

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 186531] [JJ] Trim Margin doesn't work if paper color was set

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=186531

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 382858] PDF form bug in displaying popdown boxes

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=382858

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8051: Custom background color

[Henrik Fehlauer]

rkflx added a comment.


  Thanks for bringing this to Phabricator and implementing my suggestion on 
such short notice. I tested your patch and cannot find anything wrong with it 
in terms of behaviour. For the code if have a trivial nitpick (see below) and I 
have a comment regarding the commit message. Please fix both, then I would be 
in favour of committing this. However, we should probably wait for @aacid's 
agreement here.
  
  > Can you please fix the summary so that it's not necessary to read the 
reviewboard entry?
  
  I think you might have followed this advice a little bit too literal. The 
summary and test plan of this Diff will become the commit message. Therefore 
just a link (like it was before) is too little and a verbatim copy of the 
complete discussion (as it is now) is too much. Please change it to just 
summarize in a couple of sentences:
  
  - what is meant by the commit title (i.e. it adds an option to the config 
dialog which can be used to customize the background color around the displayed 
page)
  - why the change is useful (i.e. `QPalette::Dark` sometimes results in 
colours which are unpleasant, or users just want a different colour with 
changing it desktop-wide not being an option)
  - why the feature is relevant (i.e. many users voting on bugzilla, other apps 
also allow it)
  - what's the maintenance cost of the feature (i.e. nearly none)
  - who will be affected (i.e. only those users who opt to change the default)
  
  This would help anyone using `git blame` to reason about the code in the 
future tremendously, as well providing context for your reviewers. Your test 
plan is already quite good, no need to change it. Keep the `BUG: 182994` added 
by @ngraham, this will automatically close the bug once committed. Extra points 
for the screenshot :)

INLINE COMMENTS

> okular.kcfg:298
> +  
> +
>   

Do not add this empty line.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx
Cc: aacid, ltoscano, ngraham

[okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=267350

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 362996] Okular does not prompt to save form data

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=362996

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8051: Custom background color

[Nathaniel Graham]

ngraham added reviewers: aacid, elvisangelaccio, rkflx.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular, aacid, elvisangelaccio, rkflx
Cc: aacid, ltoscano, ngraham

D6268: HiDPI Support for Okular

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D6268

To: hetzenecker, davidedmundson, aacid
Cc: gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid

[okular] [Bug 385200] Low resolution rendering when using display scaling on HiDPI monitor

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=385200

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #2 from Henrik Fehlauer  ---
Recently a GSoC student worked on resolving this, see
https://phabricator.kde.org/D6268 to track progress.

If you want to run the experimental version with HiDPI support, Neon makes this
easy:
  apt-get build-dep okular
  git clone https://anongit.kde.org/okular && cd okular
  git checkout gsoc2017_hidpi_support
  mkdir build && cd build
  cmake .. && make
  ./shell/okular

> The rest of my desktop is looking excellent

Let's just hope it does not crash again regularly in front of a large audience…
;)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 362856] HiDPI: Wrong render resolution with display scaling

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=362856

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net
Summary|[Frameworks] Wrong render   |HiDPI: Wrong render
   |resolution, possibly caused |resolution with display
   |by Plasma 5 "Scale Display" |scaling

--- Comment #32 from Henrik Fehlauer  ---
See https://phabricator.kde.org/D6268 to track progress.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=362856

Christoph Feck  changed:

   What|Removed |Added

 CC||markus@semantic-mediawiki.o
   ||rg

--- Comment #31 from Christoph Feck  ---
*** Bug 385200 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385200] Low resolution rendering when using display scaling on HiDPI monitor

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=385200

Christoph Feck  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Christoph Feck  ---


*** This bug has been marked as a duplicate of bug 362856 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 385200] New: Low resolution rendering when using display scaling on HiDPI monitor

[Markus Krötzsch]

https://bugs.kde.org/show_bug.cgi?id=385200

Bug ID: 385200
   Summary: Low resolution rendering when using display scaling on
HiDPI monitor
   Product: okular
   Version: 1.2.1
  Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: mar...@semantic-mediawiki.org
  Target Milestone: ---

Created attachment 108087
  --> https://bugs.kde.org/attachment.cgi?id=108087=edit
Okular's low resolution view in comparison to Evince

On a high-resolution display (QHD+), Okular's font rendering is noticeably
inferior to the rest of the desktop, and also to the rendering in Evince.
Looking closely, it appears that the displayed image is a scaled-up version of
a lower resolution rendering. This occurs across all formats that I have tested
(PDF, PS, ODT).

The attached screenshot illustrates the problem, showing the same PDF in Okular
(left) and Evince (right).

This is a HiDPI monitor, and I am using KDE's built-in "scale" option set to
"2" (System Settings -- Displays and Monitor -- Displays: Scale Display). It
seems plausible that Okular wrongly applies this scaling by first rendering the
file in a low resolution and then scaling the resulting bitmap, instead of
producing a bitmap using the scaled resolution right away (i.e., it applies
bitmap scaling to a vector graphics). Otherwise I am on KDE Neon at default
settings for Okular and Evince. I changed Okular's memory setting to
"aggressive" without any effect on this issue.

I do not think that this bug is related to any other font rendering issues
associated with display scaling. The rest of my desktop is looking excellent
(making Okular stick out even more).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D8051: Custom background color

[Albert Freeman]

albertfreeman updated this revision to Diff 20077.
albertfreeman added a comment.


  Reverted changes of accelerators that my Qt Designer automatically made.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8051?vs=20070=20077

REVISION DETAIL
  https://phabricator.kde.org/D8051

AFFECTED FILES
  CMakeLists.txt
  conf/dlggeneral.cpp
  conf/dlggeneral.h
  conf/dlggeneralbase.ui
  conf/okular.kcfg
  ui/pageview.cpp

To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham

D8051: Custom background color

[Albert Freeman]

albertfreeman edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham

D8051: Custom background color

[Albert Freeman]

albertfreeman edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham

D8051: Custom background color

[Albert Freeman]

albertfreeman edited the summary of this revision.
albertfreeman added a subscriber: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: aacid, ltoscano, ngraham

D8051: Custom background color

[Albert Freeman]

albertfreeman retitled this revision from "Custom background color to be 
enabled and changed from settings" to "Custom background color".

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid

D8051: Custom background color to be enabled and changed from settings

[Albert Freeman]

albertfreeman retitled this revision from "Enable custom background color to be 
enabled and changed from settings" to "Custom background color to be enabled 
and changed from settings".

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid

D8051: Enable custom background color to be enabled and changed from settings

[Luigi Toscano]

ltoscano added a comment.


  Can you please fix the summary so that it's not necessary to read the 
reviewboard entry?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D8051

To: albertfreeman, #okular
Cc: ltoscano, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

[Luigi Toscano]

ltoscano added a comment.


  In https://phabricator.kde.org/D7949#150283, @ngraham wrote:
  
  > Yes, your work here is much appreciated.
  >
  > Since this fixes grayscale printing, can you mark it with "BUG: 368758"?
  
  
  As long as it fixes the issue only (if I understand it correctly) with a 
non-default and experimental option, I'd suggest to use CCBUG: which adds the 
commit message but does not close the bug. The bug then will be closed when the 
main choice works.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7949

To: sander, #okular
Cc: ltoscano, rkflx, michaelweghorn, ngraham, aacid

[okular] [Bug 383589] Annotation toolbar icons are blurry on a Hidpi screen

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=383589

--- Comment #4 from Oliver Sander  ---
I does.

-- 
You are receiving this mail because:
You are the assignee for the bug.