[okular] [Bug 387247] New: okular [12.17beta] crash upon highlighting text in pdfs
https://bugs.kde.org/show_bug.cgi?id=387247 Bug ID: 387247 Summary: okular [12.17beta] crash upon highlighting text in pdfs Product: okular Version: unspecified Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: PDF backend Assignee: okular-devel@kde.org Reporter: robby.engelm...@igfs-ev.de Target Milestone: --- Highlighting 5-10 textpositions in a pdf leads to crash every time. Unfortunately, drkonqi is not triggered here, thus I do not have a backtrace. It is not limited to long pdfs as first thought (https://bugs.kde.org/show_bug.cgi?id=375506) -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 375506] Crashing when highlighting in long document
https://bugs.kde.org/show_bug.cgi?id=375506 --- Comment #2 from Robby Engelmann --- Bit differently from the original description (for windows), here pdf pages are always shown, but okular crashes after highlighting 4-6 text positions every time. And I do not have any custom settings applied -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 375506] Crashing when highlighting in long document
https://bugs.kde.org/show_bug.cgi?id=375506 Robby Engelmann changed: What|Removed |Added CC||robby.engelm...@igfs-ev.de --- Comment #1 from Robby Engelmann --- I also see a crash in okular (KDE apps 17.12 beta) running on the latest Tumbleweed snapshot. I do not have a bugtrace because drkonqi does not start. However, it also crashes upon highlighting text in a large pdf document. If you need more information to fix it, please let me know how to obtain them! -- You are receiving this mail because: You are the assignee for the bug.
KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 70 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/70/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 24 Nov 2017 02:35:42 + Build duration: 2 hr 32 min and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 3 test(s), Skipped: 1 test(s), Total: 14 test(s)Failed: TestSuite.addremoveannotationtestFailed: TestSuite.annotationstestFailed: TestSuite.documenttestFailed: TestSuite.editannotationcontentstestFailed: TestSuite.editformstestFailed: TestSuite.kimgiotestFailed: TestSuite.modifyannotationpropertiestestFailed: TestSuite.parttestFailed: TestSuite.searchtestFailed: TestSuite.translateannotationtest
D8980: Fix rubber band selection drawing contents misaligned with scaling
anthonyfieroni added a reviewer: aacid. anthonyfieroni added inline comments. INLINE COMMENTS > pageview.cpp:1708 > p.drawPixmap( 0, 0, doubleBuffer, > -blendRect.left() - > contentsRect.left(), blendRect.top() - contentsRect.top(), > +blendRect.left() - > contentsRect.left() * devicePixelRatioF(), blendRect.top() - > contentsRect.top() * devicePixelRatioF(), > blendRect.width() * > devicePixelRatioF(), blendRect.height() * devicePixelRatioF() ); Are you sure there haven't parentheses over subtractions REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8980 To: davidedmundson, aacid Cc: anthonyfieroni, #okular, gassaf, ngraham, aacid
KDE CI: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 - Build # 22 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20WindowsMSVCQt5.9/22/ Project: Applications okular stable-kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 23 Nov 2017 23:31:04 + Build duration: 3 hr 41 min and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 3 test(s), Skipped: 1 test(s), Total: 14 test(s)Failed: TestSuite.addremoveannotationtestFailed: TestSuite.annotationstestFailed: TestSuite.documenttestFailed: TestSuite.editannotationcontentstestFailed: TestSuite.editformstestFailed: TestSuite.kimgiotestFailed: TestSuite.modifyannotationpropertiestestFailed: TestSuite.parttestFailed: TestSuite.searchtestFailed: TestSuite.translateannotationtest
KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 69 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/69/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 23 Nov 2017 23:04:38 + Build duration: 3 hr 30 min and counting JUnit Tests Name: (root) Failed: 10 test(s), Passed: 3 test(s), Skipped: 1 test(s), Total: 14 test(s)Failed: TestSuite.addremoveannotationtestFailed: TestSuite.annotationstestFailed: TestSuite.documenttestFailed: TestSuite.editannotationcontentstestFailed: TestSuite.editformstestFailed: TestSuite.kimgiotestFailed: TestSuite.modifyannotationpropertiestestFailed: TestSuite.parttestFailed: TestSuite.searchtestFailed: TestSuite.translateannotationtest
KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 13 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/13/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 23 Nov 2017 23:31:04 + Build duration: 9 min 39 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (22/25)51% (138/271)51% (138/271)37% (14565/39259)25% (6935/27305)Coverage Breakdown by Package Name FilesClassesLinesConditionals100% (5/5)100% (5/5)58% (1062/1841)41% (555/1361)autotests100% (14/14)100% (14/14)98% (2259/2298)50% (1421/2865)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core85% (41/48)85% (41/48)54% (5040/9388)39% (2452/6305)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.epub100% (3/3)100% (3/3)55% (184/335)43% (78/183)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)63% (44/70)28% (5/18)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)52% (6
D8980: Fix rubber band selection drawing contents misaligned with scaling
davidedmundson created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY in drawPixmap(source, sourceRect) the source rect is in native pixels. In this code the size was scaled by the DPR, but the location was not. blendRect is the contents of a selection rectangle, offset from the bounding darker blue rectangle. Hence we haven't really noticed. This completely fixes the rectangle when the scale == 2.0/3.0 Some smaller artifacts remain on fractional scale factors, which is a separate code bug with the same symptoms. CCBUG: 386111 REPOSITORY R223 Okular BRANCH scaling_fixes REVISION DETAIL https://phabricator.kde.org/D8980 AFFECTED FILES ui/pageview.cpp To: davidedmundson Cc: #okular, gassaf, ngraham, aacid
D8832: Fix highlight/annotation clipping with Qt scaling
davidedmundson added a comment. Oops, I didn't read that. :/ Sorry. cherry-picked. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8832 To: davidedmundson, rkflx Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
D8832: Fix highlight/annotation clipping with Qt scaling
rkflx added a comment. > Closed by commit https://phabricator.kde.org/R223:1a3dc7d8e05fe0cd2d83ad5ed6365045e3f8e202 While `master` is quite "stable", I meant `Applications/17.12`, of course ;) Will cherry-pick tomorrow… REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8832 To: davidedmundson, rkflx Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 14 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/14/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Thu, 23 Nov 2017 23:04:38 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report88% (22/25)51% (138/271)51% (138/271)37% (14559/39259)25% (6941/27305)Coverage Breakdown by Package Name FilesClassesLinesConditionals100% (5/5)100% (5/5)58% (1062/1841)41% (555/1361)autotests100% (14/14)100% (14/14)98% (2259/2298)50% (1429/2865)conf6% (1/17)6% (1/17)7% (53/805)0% (1/272)conf.autotests100% (1/1)100% (1/1)100% (17/17)50% (7/14)core85% (41/48)85% (41/48)54% (5040/9388)39% (2450/6305)core.script0% (0/9)0% (0/9)0% (0/494)0% (0/230)generators.comicbook29% (2/7)29% (2/7)3% (10/397)0% (0/430)generators.dvi2% (1/46)2% (1/46)0% (9/3571)0% (1/2423)generators.epub100% (3/3)100% (3/3)55% (184/335)43% (78/183)generators.fax17% (1/6)17% (1/6)2% (7/432)0% (0/585)generators.fictionbook60% (3/5)60% (3/5)3% (16/531)0% (2/454)generators.kimgio100% (1/1)100% (1/1)63% (44/70)28% (5/18)generators.kimgio.tests100% (1/1)100% (1/1)100% (49/49)46% (24/52)generators.mobipocket60% (3/5)60% (3/5)11% (13/115)0% (0/120)generators.ooo27% (3/11)27% (3/11)1% (14/1125)0% (0/736)generators.plucker100% (1/1)100% (1/1)4% (4/98)0% (0/36)generators.plucker.unpluck0% (0/6)0% (0/6)0% (0/1652)0% (0/876)generators.poppler60% (3/5)60% (3/5)52% (687/1330)39%
D8832: Fix highlight/annotation clipping with Qt scaling
This revision was automatically updated to reflect the committed changes. Closed by commit R223:1a3dc7d8e05f: Fix highlight/annotation clipping with Qt scaling (authored by davidedmundson). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8832?vs=22420&id=22862 REVISION DETAIL https://phabricator.kde.org/D8832 AFFECTED FILES ui/pagepainter.cpp To: davidedmundson, rkflx Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
D8832: Fix highlight/annotation clipping with Qt scaling
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. LGTM, solves the bug for me too and I could not break anything when testing. As nobody brought up any issues so far, I'd say this can land (stable branch). REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D8832 To: davidedmundson, rkflx Cc: rkflx, sander, ngraham, #okular, gassaf, aacid
D8838: Don't request pixmaps twice when opening okular
rkflx added a comment. Sorry for the delay, finally could do some testing. First I was quite enthusiastic about what I saw, but then some oddities came up so I cannot draw a conclusion on what I would recommend to do here yet. Any final patch (i.e. not fulfilled by current patch version) should ensure IMO: - Thumbnails are less important than the main view and therefore should not delay its rendering. - If we can currently render a fast document without any delay, we should not regress on that. Here is what seems odd: > files after okular is open don't suffer this IIUC, your explanation is about resize events when the window is opening. However, adding debug output to `resizeEvent` (for `isEmpty()` and for `!isEmpty()`) as well as `slotRequestVisiblePixmaps` shows that this is also happening for a simple Reload. This suggests those events are entirely controlled by Okular code and may be fixable there? Next, I reverted both `delayResizeEventTimer` related changes to evaluate your fix to the second problem (tested with `dublin-center-street.pdf` @ 200% zoom, with T: thumbnails render, M: main view renders, D: weird delay of several seconds): || master| patch | patch w/o timer | | -- | - | - | --- | | start normal | M-D-M-T-M | T-D-M | M-D-T-M | | reload normal | M-D-M-T-M | T-D-M | M-D-T-M | | start rotated | M-D-M-T-M | T-D-M | M-D-T-M | | reload rotated | M-D-M-T-M | T-D-M | M-D-T-M | | Note: - For normal documents the last M in -M-T-M would sometimes be omitted when choosing another initial window size. - For rotated documents the last M would sometimes affect only parts of the window. - T-D-M would sometimes turn into D-T-M when repeating the same test. - I still do not understand what D is about (in the other Diff you said "There's no text generation for main view and one for thumbnail, there is no reason to generate text twice", but this does not really answer the question I asked?). - Ideal log: M-T (or rather in parallel ;) In conclusion, I'm not convinced that the standalone fix for the second problem is completely working either. This is all very strange, maybe you could have another look? I suspect there is still something else going on, so perhaps we are not yet seeing the root cause? Especially for rotated pages in some cases reloading results in more redraws compared to normal pages and removing window focus can provoke blank pages. > Ideally here the solution is page rendering cancellation Yeah, that would be great. Given the other solutions also have problems, this could be worth thinking about? --- Refs: https://phabricator.kde.org/F5477455, https://phabricator.kde.org/D8379#164630 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, gassaf, ngraham, aacid
[okular] [Bug 387204] Paper weight
https://bugs.kde.org/show_bug.cgi?id=387204 --- Comment #2 from s.pellegr...@villaaurora.it --- Yes, I was referring to the print dialog. Thank you for replying. Stefano --- Messaggio originale --- Da: Albert Astals Cid Reply-to: bug-cont...@kde.org A: s.pellegr...@villaaurora.it Oggetto: [okular] [Bug 387204] Paper weight Data: Wed, 22 Nov 2017 20:13:49 + https://bugs.kde.org/show_bug.cgi?id=387204 Albert Astals Cid changed: What|Removed |Added - --- Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO CC||aa...@kde.org --- Comment #1 from Albert Astals Cid --- is this a request for the print dialog? If so this is a Qt bug, we only use the dialog that Qt provides. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 207748] LTR languages searches text backwards
https://bugs.kde.org/show_bug.cgi?id=207748 --- Comment #17 from Fahad Al-Saidi --- this bug also effect the copying the RTL text. the copied text is reversed. -- You are receiving this mail because: You are the assignee for the bug.
