D11051: Remembering side navigation panel state

[Dileep Sankhla]

dileepsankhla added a comment.


  The state can be saved whenever a sidebar item is clicked in 
Sidebar::itemClicked but again as discussed earlier, it will be asymmetrical as 
to save in sidebar.cpp. Should I implement a signal slot mechanism in part.cpp 
to achieve so or should I find another way?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: tobiasdeiminger, aacid, sander, #okular, michaelweghorn, ngraham

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

[Albert Astals Cid]

aacid added a comment.


  Isn't that translation breaking
  
  RotationJobInternal::run
  
  ?
  
  Why would you translate the image there?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11901

To: ahmadosama, #okular
Cc: aacid, ngraham, #okular, michaelweghorn

[okular] [Bug 392648] search:options:from current page doesn't work

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392648

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Albert Astals Cid  ---
from current page only applies to the first time you search a term. If you want
to start a new search start a new search and don't reuse your last one (you can
do that by pressing Esc twice)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392682] Okular ignores umask on save file as

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392682

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org
 Ever confirmed|0   |1

--- Comment #1 from Albert Astals Cid  ---
Seems the QTemporaryFile in Part::saveAs is to blame, i guess we should apply a
similar solution to
https://git.reviewboard.kde.org/r/122612/diff/2#index_header

Anyone has time for it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11051: Remembering side navigation panel state

[Albert Astals Cid]

aacid added a comment.


  In D11051#239040 , 
@tobiasdeiminger wrote:
  
  > > One thing that may fix it is changing
  > > 
  > >   m_sidebar = new Sidebar( parentWidget );
  > > 
  > > to
  > > 
  > >   m_sidebar = new Sidebar();
  > > 
  > > in part.cpp, this micht change the part/child relationships and get 
yourself of this problem. can you give it a quick try?
  >
  > Seems like sidebar becomes a (grand-)child of Shells QTabWidget, no matter 
what you set as parent widget in Sidebar Ctor. This is because of ##setWidget( 
m_sidebar )## in Part::Part(), and  ##m_tabWidget->addTab( firstPart->widget(), 
QString() )## in Shell::Shell(). Then C++ Dtor order lets Shell::~Shell (cleans 
up child widgets, including sidebar) be called earlier than Part::~Part.
  >
  > > Should we stick to it or should we consider saving the stats in the 
Sidebar::~Sidebar()?
  >
  > Would it be an option to save sidebar state in ##Part::closeUrl()##?
  >  It is called early enough by Shell Dtor. For me it fixes the segfault, and 
"closeUrl" sounds like a reasonable action to cause document related state 
saving.
  
  
  The thing is that whether you have the panel open or not is not really 
document related.
  
  I think what we should do is just save the option when it changes, like we do 
in Part::slotShowLeftPanel and Part::slotShowBottomBar

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: tobiasdeiminger, aacid, sander, #okular, michaelweghorn, ngraham

D11051: Remembering side navigation panel state

[Albert Astals Cid]

aacid added a comment.


  In D11051#238586 , @dileepsankhla 
wrote:
  
  > I tried but it is still giving me the segfault. The interesting thing, in 
my opinion, is whenever you open Okular and close it down without changing the 
sidebar state, it doesn't give a segfault whereas changing the sidebar state 
and closing it gives the error. 
  >  Should we stick to it
  
  
  Stick to what?
  
  > or should we consider saving the stats in the Sidebar::~Sidebar()?
  
  I already said that saving the value in sidebar and loading it in part is 
very un-intuitive, that doesn't seem to have changed ;)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: tobiasdeiminger, aacid, sander, #okular, michaelweghorn, ngraham

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=353401

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #26 from Albert Astals Cid  ---
(In reply to Tobias Deiminger from comment #25)
> To avoid those inconsistencies, I'd like to promote the idea of widgets that
> have a FormWidget-like PageView integration, but use generator/poppler as
> the one and only render engine.

Seems like an interesting idea to explore, just remember that you're going to
need more layers of abstraction since okular core doesn't know anything about
poppler

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392682] New: Okular ignores umask on save file as

[Falk Krönert]

https://bugs.kde.org/show_bug.cgi?id=392682

Bug ID: 392682
   Summary: Okular ignores umask on save file as
   Product: okular
   Version: 1.3.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: falkkroen...@gmx.net
  Target Milestone: ---

If a pdf is saved (changed or unchanged) via "File Save As…". the resulting
file has 0600 permissions, regardless of umask settings. Tested on nfs and
non-nfs locations (both for the opened and the saved file).

Reproducible: always

How to test:
1. Set umask to anything other than 0077 and run okular from that shell.
2. Open a pdf file.
3. Save as a differently named pdf file.
4. Check the permissions on the original and the saved file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392671] Can not read pdf content in okuler.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=392671

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME
 CC||n...@kde.org

--- Comment #1 from Nate Graham  ---
You're using an ancient version of Okular (and likely poppler, too). Please see
https://community.kde.org/Get_Involved/Bug_Reporting#Step_2:_Make_sure_it_hasn.27t_already_been_fixed

The attached PDF displays for me just fine using Okular from KDE Applications
17.12. I even see the digital signature watermark.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 392671] New: Can not read pdf content in okuler.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392671

Bug ID: 392671
   Summary: Can not read pdf content in okuler.
   Product: okular
   Version: 0.26.1
  Platform: Debian stable
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: bapat.avin...@gmail.com
  Target Milestone: ---

Created attachment 111797
  --> https://bugs.kde.org/attachment.cgi?id=111797&action=edit
PDF file not able to read the content in Okular, but can be read in adobe
reader.

Not able to read the content.I am attaching the document.The same document can
be read in adobe reader.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D11051: Remembering side navigation panel state

[Tobias Deiminger]

tobiasdeiminger added a comment.


  > One thing that may fix it is changing
  > 
  >   m_sidebar = new Sidebar( parentWidget );
  > 
  > to
  > 
  >   m_sidebar = new Sidebar();
  > 
  > in part.cpp, this micht change the part/child relationships and get 
yourself of this problem. can you give it a quick try?
  
  Seems like sidebar becomes a (grand-)child of Shells QTabWidget, no matter 
what you set as parent widget in Sidebar Ctor. This is because of ##setWidget( 
m_sidebar )## in Part::Part(), and  ##m_tabWidget->addTab( firstPart->widget(), 
QString() )## in Shell::Shell(). Then C++ Dtor order lets Shell::~Shell (cleans 
up child widgets, including sidebar) be called earlier than Part::~Part.
  
  > Should we stick to it or should we consider saving the stats in the 
Sidebar::~Sidebar()?
  
  Would it be an option to save sidebar state in ##Part::closeUrl()##?
  It is called early enough by Shell Dtor. For me it fixes the segfault, and 
"closeUrl" sounds like a reasonable action to cause document related state 
saving.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11051

To: dileepsankhla, #okular, aacid
Cc: tobiasdeiminger, aacid, sander, #okular, michaelweghorn, ngraham

D10932: [Okular] Option to reset forms

[Ahmad Osama]

ahmadosama updated this revision to Diff 31204.
ahmadosama added a comment.


  Removing white spaces.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10932?vs=29771&id=31204

REVISION DETAIL
  https://phabricator.kde.org/D10932

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/resetformstest.cpp
  core/document.cpp
  core/document.h
  core/documentcommands.cpp
  core/documentcommands_p.h
  part.rc
  ui/pageview.cpp
  ui/pageview.h

To: ahmadosama, #okular, aacid
Cc: cfeck, ngraham, aacid, #okular, michaelweghorn

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

[Ahmad Osama]

ahmadosama added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11901

To: ahmadosama, #okular
Cc: #okular, michaelweghorn, ngraham, aacid

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

[Ahmad Osama]

ahmadosama created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
ahmadosama requested review of this revision.

REVISION SUMMARY
  The highlights were removed when rotating the page, also the 
RotaionJob::rotationMatrix function was not rotating the Highlihgts correctly.
  I removed the deletion and modified the rotaionMatrix function by making it 
shorter and adding a translation after the rotatin. I tried different rotations 
and they are working fine.
  BUG: 387282

REPOSITORY
  R223 Okular

BRANCH
  HighlightTextBug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11901

AFFECTED FILES
  core/page.cpp
  core/rotationjob.cpp

To: ahmadosama
Cc: #okular, michaelweghorn, ngraham, aacid