D12352: Make it possible to disable the build of okularkirigami

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> Documents.qml:56
>  }
> -text: i18n("No Documents found. To start to read, put some files in 
> the Documents folder of your device.")
> -wrapMode: Text.WordWrap
> -horizontalAlignment: Text.AlignHCenter
> -verticalAlignment: Text.AlignVCenter
> +Kirigami.Label {
> +text: i18n("No Documents found. To start to read, put some files 
> in the Documents folder of your device.")

This, and all the changes in Document.qml are unrelated.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12352

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 97 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/97/
 Project:
Applications okular kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 20 Apr 2018 01:34:48 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: TestSuite.mainshelltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(23/26)53%
(148/277)53%
(148/277)36%
(14211/39854)24%
(6634/27889)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)54%
(996/1848)36%
(495/1369)autotests93%
(14/15)93%
(14/15)85%
(2051/2399)41%
(1287/3165)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core86%
(42/49)86%
(42/49)54%
(5162/9582)39%
(2487/6455)core.script100%
(12/12)100%
(12/12)37%
(237/634)17%
(44/266)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3572)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)55%
(184/335)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook60%
(3/5)60%
(3/5)3%
(16/570)0%
(2/476)generators.kimgio100%
(1/1)100%
(1/1)63%
(44/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket60%
(3/5)60%
(3/5)11%
(13/115)0%
(0/120)generators.ooo27%
(3/11)27%
(3/11)1%
(14/1125)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)51%

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/71/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 20 Apr 2018 01:34:48 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D12352: Make it possible to disable the build of okularkirigami

[Aleix Pol Gonzalez]

apol updated this revision to Diff 32616.
apol added a comment.


  Improve description

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12352?vs=32569=32616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12352

AFFECTED FILES
  CMakeLists.txt
  mobile/app/package/contents/ui/Documents.qml

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

D12352: Make it possible to disable the build of okularkirigami

[Luca Beltrame]

lbeltrame added inline comments.

INLINE COMMENTS

> CMakeLists.txt:127
>  
> -add_subdirectory( mobile )
> +option(BUILD_OKULARKIRIGAMI "Builds the convergent application" ON)
> +if (BUILD_OKULARKIRIGAMI)

Doesn't specify much about what a "convergent" application is (unless it's 
specified elsewhere). Perhaps "Builds a Kirigami-based, convergent version of 
Okular"?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D12352

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

D12352: Make it possible to disable the build of okularkirigami

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Okular, mart, aacid, lbeltrame.
Restricted Application added a project: Okular.
apol requested review of this revision.

REVISION SUMMARY
  Some distros seem to have the option.
  
  BUG: 393119

TEST PLAN
  Still builds, can disable build

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12352

AFFECTED FILES
  CMakeLists.txt

To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid

[okular] [Bug 393119] No way to disable okularkirigami building

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=393119

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #1 from Aleix Pol  ---
https://phabricator.kde.org/D12352

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384700] Setting a shortcut for "Toggle Change Colors" is not remembered

[frafl]

https://bugs.kde.org/show_bug.cgi?id=384700

frafl  changed:

   What|Removed |Added

 CC||fr...@fuhlbrueck.net

--- Comment #4 from frafl  ---
Similar Problem with show/hide navigation area and main toolbar on
Ubuntu 17.10 and 18.04 (Okular 1.3.3).

Where are the shortcuts saved?
$HOME/.config/okularrc only shows the shortcut for the main toolbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10797: Add asterisk when an annotation is associated to non-empty popup

[Simone Gaiarin]

simgunz updated this revision to Diff 32535.
simgunz added a comment.


  - Propagate dataChanged in Author and Page proxy models

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10797?vs=31569=32535

BRANCH
  annotations-with-note

REVISION DETAIL
  https://phabricator.kde.org/D10797

AFFECTED FILES
  ui/annotationproxymodels.cpp
  ui/annotationproxymodels.h
  ui/guiutils.cpp

To: simgunz, #okular, aacid
Cc: rkflx, aacid, ngraham, michaelweghorn