KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.10 - Build # 37 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.10/37/
 Project:
Applications okular kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Mon, 23 Apr 2018 22:24:54 +
 Build duration:
7 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 414.42 KB...]   Creating library ..\..\lib\okularGenerator_mobi.lib and object ..\..\lib\okularGenerator_mobi.exp   Creating library ..\..\lib\okularGenerator_mobi.lib and object ..\..\lib\okularGenerator_mobi.exp[ 85%] Built target okularGenerator_mobiScanning dependencies of target shelltest[ 85%] Building CXX object autotests/CMakeFiles/shelltest.dir/shelltest.cpp.obj[ 85%] Building CXX object autotests/CMakeFiles/shelltest.dir/__/shell/shellutils.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/shelltest.dir/shelltest_autogen/mocs_compilation.cpp.objshelltest.cppmocs_compilation.cppshellutils.cpp[ 86%] Linking CXX executable ..\bin\shelltest.exe[ 86%] Built target shelltestScanning dependencies of target addremoveannotationtest[ 86%] Building CXX object autotests/CMakeFiles/addremoveannotationtest.dir/addremoveannotationtest.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/addremoveannotationtest.dir/testingutils.cpp.obj[ 86%] Building CXX object autotests/CMakeFiles/addremoveannotationtest.dir/addremoveannotationtest_autogen/mocs_compilation.cpp.objaddremoveannotationtest.cppmocs_compilation.cpptestingutils.cpp[ 87%] Linking CXX executable ..\bin\addremoveannotationtest.exe[ 87%] Built target addremoveannotationtestScanning dependencies of target annotationstest[ 87%] Building CXX object autotests/CMakeFiles/annotationstest.dir/annotationstest.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/annotationstest.dir/annotationstest_autogen/mocs_compilation.cpp.objannotationstest.cppmocs_compilation.cpp[ 88%] Linking CXX executable ..\bin\annotationstest.exe[ 88%] Built target annotationstestScanning dependencies of target searchtest[ 88%] Building CXX object autotests/CMakeFiles/searchtest.dir/searchtest.cpp.obj[ 88%] Building CXX object autotests/CMakeFiles/searchtest.dir/searchtest_autogen/mocs_compilation.cpp.objsearchtest.cppmocs_compilation.cpp[ 88%] Linking CXX executable ..\bin\searchtest.exe[ 88%] Built target searchtestScanning dependencies of target documenttest[ 89%] Building CXX object autotests/CMakeFiles/documenttest.dir/documenttest.cpp.obj[ 89%] Building CXX object autotests/CMakeFiles/documenttest.dir/documenttest_autogen/mocs_compilation.cpp.objdocumenttest.cppmocs_compilation.cpp[ 89%] Linking CXX executable ..\bin\documenttest.exe[ 89%] Built target documenttestScanning dependencies of target editannotationcontentstest[ 89%] Building CXX object autotests/CMakeFiles/editannotationcontentstest.dir/editannotationcontentstest.cpp.obj[ 89%] Building CXX object autotests/CMakeFiles/editannotationcontentstest.dir/testingutils.cpp.obj[ 89%] Building CXX object autotests/CMakeFiles/editannotationcontentstest.dir/editannotationcontentstest_autogen/mocs_compilation.cpp.objeditannotationcontentstest.cppmocs_compilation.cpptestingutils.cpp[ 90%] Linking CXX executable ..\bin\editannotationcontentstest.exe[ 90%] Built target editannotationcontentstestScanning dependencies of target editformstest[ 90%] Building CXX object autotests/CMakeFiles/editformstest.dir/editformstest.cpp.obj[ 90%] Building CXX object autotests/CMakeFiles/editformstest.dir/editformstest_autogen/mocs_compilation.cpp.objeditformstest.cppmocs_compilation.cpp[ 91%] Linking CXX executable ..\bin\editformstest.exe[ 91%] Built target editformstestScanning dependencies of target translateannotationtest[ 92%] Building CXX object autotests/CMakeFiles/translateannotationtest.dir/translateannotationtest.cpp.obj[ 92%] Building CXX object autotests/CMakeFiles/translateannotationtest.dir/testingutils.cpp.obj[ 92%] Building CXX object autotests/CMakeFiles/translateannotationtest.dir/translateannotationtest_autogen/mocs_compilation.cpp.objtranslateannotationtest.cppmocs_compilation.cpptestingutils.cpp[ 93%] Linking CXX executable ..\bin\translateannotationtest.exe[ 93%] Built target translateannotationtestScanning dependencies of target modifyannotationpropertiestest[ 93%] Building CXX object autotests/CMakeFiles/modifyannotationpropertiestest.dir/modifyannotationpropertiestest.cpp.obj[ 94%] Building CXX object autotests/CMakeFiles/modifyannotationpropertiestest.dir/testingutils.cpp.obj[ 94%] Building CXX object autotests/CMakeFiles/modifyannotationpropertiestest.dir/modifyannotationpropertiestest_autogen/mocs_compilation.cpp.objmodifyannotationpropertiestest.cppmocs_compilation.cpptestingutils.cpp[ 94%] Linking CXX executable ..\bin\modifyannotationpropertiestest.exe[ 94%] Built target modifyannotationpropertiestestScanning dependencies of target calculatetexttest[ 95%] Building CXX object autotests/CMakeFiles/calculatetexttest.dir/calculatetexttest.cpp.obj[ 95%] Building CXX object autotests/CMakeFiles/ca

D11609: Add support for chained / next actions

[Albert Astals Cid]

aacid added a comment.


  Are you sure you need s_doNotDeleteLinks ? I mean the links where deleting in 
resolveMediaLinks doesn't look like they can be nextActions, since it's the 
Opening/Closing/Activation actions we're resolving on
  
void PDFGenerator::resolveMediaLinkReferences( Okular::Page *page )
  
  no?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11609

To: aheinecke, #okular
Cc: aacid, ngraham

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/80/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 22:08:35 +
 Build duration:
8 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 17 test(s)

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 79 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/79/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 21:55:53 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

D11597: Add test for visibility changes

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:7eb72911f8f1: Add test for visibility changes (authored 
by aheinecke, committed by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11597?vs=32469&id=32923#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11597?vs=32469&id=32923

REVISION DETAIL
  https://phabricator.kde.org/D11597

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/visibilitytest.pdf
  autotests/visibilitytest.cpp

To: aheinecke, #okular, aacid
Cc: aacid, ngraham

D11597: Add test for visibility changes

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  ok

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11597

To: aheinecke, #okular, aacid
Cc: aacid, ngraham

D11596: Add support for dynamic visibility

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:bf90867c13ed: Add support for dynamic visibility 
(authored by aheinecke, committed by aacid).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11596?vs=31736&id=32922

REVISION DETAIL
  https://phabricator.kde.org/D11596

AFFECTED FILES
  core/form.cpp
  core/form.h
  core/script/kjs_field.cpp
  generators/poppler/CMakeLists.txt
  generators/poppler/formfields.cpp
  generators/poppler/formfields.h
  generators/poppler/generator_pdf.cpp

To: aheinecke, #okular, aacid
Cc: aacid, ngraham

D11596: Add support for dynamic visibility

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  ok, i guess

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D11596

To: aheinecke, #okular, aacid
Cc: aacid, ngraham

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/58/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 21:22:58 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/57/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 21:09:28 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 78 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/78/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 23 Apr 2018 21:09:43 +
 Build duration:
7 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)

D12049: Obey umask rules when saving new file

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:c5592689874f: Obey umask rules when saving new file 
(authored by chinmoyr, committed by aacid).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12049?vs=31692&id=32915

REVISION DETAIL
  https://phabricator.kde.org/D12049

AFFECTED FILES
  part.cpp

To: chinmoyr, #okular, aacid
Cc: ngraham, aacid

[okular] [Bug 392682] Okular ignores umask on save file as

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=392682

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/c5592689874f41df393b44f
   ||3ba572acc751c5645
 Resolution|--- |FIXED

--- Comment #2 from Albert Astals Cid  ---
Git commit c5592689874f41df393b44f3ba572acc751c5645 by Albert Astals Cid, on
behalf of Chinmoy Ranjan Pradhan.
Committed on 23/04/2018 at 21:07.
Pushed by aacid into branch 'Applications/18.04'.

Obey umask rules when saving new file

Summary:
Okular saves a new file with permissions 0600 completely ignoring the umask
value. This is because it
makes use of QTemporaryFile which creates file with the said permissions and
which then Okular copies
to the new location.
So to overcome this generate new file permissions using old mask value and
change permissions of the
new file.

Test Plan:
Set umask to 0040
Open a pdf file from the same shell and save it under a new name.
Before patch:
file permisions -> 0600
After patch:
file permisions -> 0606

Reviewers: #okular, aacid

Tags: #okular

Differential Revision: https://phabricator.kde.org/D12049

M  +12   -0part.cpp

https://commits.kde.org/okular/c5592689874f41df393b44f3ba572acc751c5645

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12049: Obey umask rules when saving new file

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  I'll land it

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12049

To: chinmoyr, #okular, aacid
Cc: ngraham, aacid

D10932: [Okular] Option to reset forms

[Albert Astals Cid]

aacid added a comment.


  In D10932#248786 , @ngraham wrote:
  
  > +1 for keeping this open and refining the behavior rather than abandoning 
it.
  
  
  How do you refine the behaviour in the case i mentioned where there are 
javascript actions associated with contents of the fields changing? What is the 
refined way to do that?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10932

To: ahmadosama, #okular, aacid
Cc: rkflx, cfeck, ngraham, aacid, #okular

D10932: [Okular] Option to reset forms

[Albert Astals Cid]

aacid added a comment.


  In D10932#248618 , @rkflx wrote:
  
  > FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows 
a dialog asking "This option will reset all form fields to their default 
values. You may lose some data. Are you sure?".
  >
  > Let me know if you have specific example documents I should test this 
applications with, to see how they solved some of the more complicated aspects.
  
  
  Can you try it with 
https://cgit.kde.org/okular.git/plain/autotests/data/formSamples.pdf ? what 
does it do with the "Option buttons" on the top left?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10932

To: ahmadosama, #okular, aacid
Cc: rkflx, cfeck, ngraham, aacid, #okular

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=381328

--- Comment #11 from Albert Astals Cid  ---
(In reply to Henrik Fehlauer from comment #10)
> (OT)
> 
> > since Henrik didn't seem to want to answer my question
> What? I always try to answer questions in the best way possible. In fact, I
> specified where my way of accessing the zip file came from: "a standard
> Plasma installation". If you are looking for the name of the repository the
> particular code responsible for that functionality lives in, you should put
> that in your original (or follow-up) question. Don't just assume I built it
> from source and then blame me for not getting you the answer you looked for.

Don't be pedantic, it's not smart.

I clearly said "So are you going to tell me where i can find the zip ioslave so
i can try to fix this bug or what?" and instead of answering "I don't know, I'm
not a technical guy, you'll have to find for yourself", you simply ignored my
question and didn't answer it at all, probably because you're angry I'm using
the proper name of the technology for some reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.