[okular] [Bug 396822] Form data are not printed out completely

2018-09-04 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=396822

--- Comment #3 from Christoph Feck  ---
To further investigate this issue, KDE developers need the information
requested in comment #1. If you can provide it, or need help with finding that
information, please add a comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 397059] Printing from Okular creates 31% bigger image on the paper

2018-09-04 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=397059

--- Comment #5 from Christoph Feck  ---
If you can provide the information requested in comment #4, please add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15204: Add typewriter annotation tool

2018-09-04 Thread Tobias Deiminger 
tobiasdeiminger edited the summary of this revision.
tobiasdeiminger edited the test plan for this revision.
tobiasdeiminger added a dependency: D15279: Store all annotation color 
attributes as ARGB string.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15204

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid

D15279: Store all annotation color attributes as ARGB string

2018-09-04 Thread Tobias Deiminger 
tobiasdeiminger added a dependent revision: D15204: Add typewriter annotation 
tool.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15279

To: tobiasdeiminger
Cc: okular-devel, ngraham, aacid

D15279: Store all annotation color attributes as ARGB string

2018-09-04 Thread Tobias Deiminger 
tobiasdeiminger created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
tobiasdeiminger requested review of this revision.

REVISION SUMMARY
  This is mainly preparation for D15204  
(typewriter), where storing RGB won't be sufficient any longer.
  Typewriter will need transparent background (alpha=0x00), which can only be 
expressed as ARGB string.
  
  Current code handles name format identical for all annotations. It doesn't 
hurt to store all annotations in ARGB format, so instead of introducing special 
handling for typewriter, let's store all annotation color attributes as ARGB 
string.

TEST PLAN
  - when [Reviews] section in okularpartrc is initially generated, all 
annotation color attributes are in #AARRGGBB format
  - saving into archive stores color with alpha channel (#AARRGGBB), for all 
kind of annotations

REPOSITORY
  R223 Okular

BRANCH
  annotation_rgba

REVISION DETAIL
  https://phabricator.kde.org/D15279

AFFECTED FILES
  conf/editannottooldialog.cpp
  core/annotations.cpp
  ui/data/tools.xml

To: tobiasdeiminger
Cc: okular-devel, ngraham, aacid

[okular] [Bug 398217] Permanent Highlighter stops working when switching from Okular to other apps and back

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=398217

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15204: Add typewriter annotation tool

2018-09-04 Thread Tobias Deiminger 
tobiasdeiminger added a comment.


  In D15204#320195 , @sander wrote:
  
  > Would it a good idea to split those changes that deal with the color alpha 
channel into a separate patch?  That would make reviewing easier, and lead to 
more legible git history.
  
  
  Good idea. Alpha channel changes for other annotations are small in LOC and 
independent from typewriter. We can easily shift that to a new revision.

INLINE COMMENTS

> sander wrote in parttest.cpp:45
> Is this change really needed for the Typewriter tool, or is it 'just' related 
> cleanup of the `CloseDialogHelper` class? If the latter, can we move it into 
> a separate patch?

> Is this change really needed for the Typewriter tool

It was indeed required. `qApp->activeModalWidget()`was the simples way to 
lookup the modal dialog. As a consequence, `Okular::Part *p` was no longer 
required. `QMetaObject::invokeMethod(button, "click", Qt::QueuedConnection)` 
was required to avoid crashes.

Though the latter is probably a workaround for a hidden bug in Okulars 
`PickPointEngine::addTextNote`. Try this: Fire up okular in KDABs gammaray, 
select inline note tool, and click into a page. Now 20..50 QInputDialogs pop up 
immediately, instead of 1. That's basically the same as what we encountered in 
the test prior using `invokeMethod`.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15204

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid

Poppler on Android builds

2018-09-04 Thread Aleix Pol 
 Hey,
I guess you knew there are Okular Android builds:
https://binary-factory.kde.org/view/Android/job/Okular_android/

Build is broken now because the Android NDK doesn't have std::stoi.
https://binary-factory.kde.org/view/Android/job/Okular_android/146/console

I'll change it to build the poppler-0.68.0 tag for now.

Hope that makes sense to you, tell me otherwise.
Aleix

[okular] [Bug 377487] Find and List all instances of a searched word

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=377487

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 238123] Okular: Overview list of search results

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=238123

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 377487 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=377487

Nate Graham  changed:

   What|Removed |Added

 CC||war...@gmx.de

--- Comment #9 from Nate Graham  ---
*** Bug 238123 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377487] Find and List all instances of a searched word

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=377487

Nate Graham  changed:

   What|Removed |Added

 CC||bing...@gmail.com

--- Comment #8 from Nate Graham  ---
*** Bug 398176 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398176] Feature Request: Add total count to and automatic highlighting to all terms found with Find function

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=398176

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||n...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Nate Graham  ---


*** This bug has been marked as a duplicate of bug 377487 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398137] Okular fails to print first page of PDF file

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=398137

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||n...@kde.org
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Nate Graham  ---
When you say, "fails to print first page", do you mean that it starts printing
from the second page? Or that it never prints anything? Can you verify in the
print options that you have it set up to print all pages?

Can you attach a PDF that exhibits this problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398108] Annoying switch from Browse to Text Selection when annotating

2018-09-04 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=398108

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398202] provide navigation for annotations

2018-09-04 Thread Martin Corley 
https://bugs.kde.org/show_bug.cgi?id=398202

--- Comment #4 from Martin Corley  ---
Man, I'm being dense.  Many thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398202] provide navigation for annotations

2018-09-04 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=398202

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |INVALID

--- Comment #3 from Albert Astals Cid  ---
If you want a flatter list just unclick the group by page and group by author
buttons

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15205: Support setting font color for typewriter annotation

2018-09-04 Thread Oliver Sander 
sander added inline comments.

INLINE COMMENTS

> CMakeLists.txt:108
> +}
> +" HAVE_POPPLER_0_67)
> +

This will have to be at least 0.69...

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15205

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid

D15204: Add typewriter annotation tool

2018-09-04 Thread Oliver Sander 
sander added a comment.


  Would it a good idea to split those changes that deal with the color alpha 
channel into a separate patch?  That would make reviewing easier, and lead to 
more legible git history.

INLINE COMMENTS

> parttest.cpp:45
>  public:
> -CloseDialogHelper(Okular::Part *p, QDialogButtonBox::StandardButton b) : 
> m_part(p), m_button(b), m_clicked(false)
>  {

Is this change really needed for the Typewriter tool, or is it 'just' related 
cleanup of the `CloseDialogHelper` class? If the latter, can we move it into a 
separate patch?

> pageviewannotator.cpp:274
>  clicked = false;
> -
>  // safety check

Whitespace change

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15204

To: tobiasdeiminger
Cc: sander, okular-devel, ngraham, aacid

[okular] [Bug 398202] provide navigation for annotations

2018-09-04 Thread Martin Corley 
https://bugs.kde.org/show_bug.cgi?id=398202

--- Comment #2 from Martin Corley  ---
Thanks for the response.

My apologies: Have used okular for years and somehow missed that(!).  So then
my only wish would be that this view was much flatter, to reduce the number of
clicks to get to a page with an annotation.  (In my dream version, text of
comments would be available in the reviews panel too: cf Mendeley).

-- 
You are receiving this mail because:
You are the assignee for the bug.