[okular] [Bug 338976] loading "hangs" if file is on unaccessible remote mounted filesystem

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=338976

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Andrew Crouthamel  ---
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you
help us out and re-test if the bug is valid in the latest version? This bug
will be moved back to REPORTED Status for manual review later, which may take a
while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339807] Save in FTP Folder reports existing File although there isn't

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=339807

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #3 from Andrew Crouthamel  ---
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you
help us out and re-test if the bug is valid in the latest version? This bug
will be moved back to REPORTED Status for manual review later, which may take a
while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 341945] Wrong rendering with scrolling in PDF

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=341945

Andrew Crouthamel  changed:

   What|Removed |Added

 Resolution|--- |UNMAINTAINED
 Status|REPORTED|RESOLVED

--- Comment #6 from Andrew Crouthamel  ---
I'm going to mark this unmaintained. Please reopen if I am mistaken on Mac
support.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 395497] Menubar - No text

2018-11-20 Thread tdr
https://bugs.kde.org/show_bug.cgi?id=395497

--- Comment #4 from tdr  ---
Adding some more information and a +1 to this.

Okular 1.1.3
Kubuntu 17.10
KDE Plasma 5.12.4
KDE Frameworks 5.44.0
QT 5.9.1

Steps to reproduce:

1. Open Okular
2. Click "Settings" and deactivate "Show menubar"
3. Right-click the toolbar and select "Configure Toolbars"
4. Scroll to "Show Menubar" in the "Available actions" section
5. Click the right arrow (">") to add it to the "Current actions" section
6. Click "Apply"
7. Click "OK"

-- The menubar is replaced with a blank bar --

8. Activate the "Show menubar" button

-- The menubar has mislabelled first-level items, some are labelled "No Text".
--

9. Right-click the toolbar and select "Configure Toolbars"
10. Click "Defaults"
11. Click "Reset"

-- The menubar is restored and functions properly --

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 395497] Menubar - No text

2018-11-20 Thread tdr
https://bugs.kde.org/show_bug.cgi?id=395497

tdr  changed:

   What|Removed |Added

 CC||dsmi...@gmail.com

--- Comment #3 from tdr  ---
Created attachment 116435
  --> https://bugs.kde.org/attachment.cgi?id=116435&action=edit
Screenshot of empty menubar

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339734] Running dvips embeds A4 paper size in resulting output

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=339734

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #2 from Andrew Crouthamel  ---
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you
help us out and re-test if the bug is valid in the latest version? This bug
will be moved back to REPORTED Status for manual review later, which may take a
while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339126] Search should not discard - from the end of line if the search line contains it.

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=339126

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #2 from Andrew Crouthamel  ---
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you
help us out and re-test if the bug is valid in the latest version? This bug
will be moved back to REPORTED Status for manual review later, which may take a
while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 313041] Cannot print using distant cups server

2018-11-20 Thread Andrew Crouthamel
https://bugs.kde.org/show_bug.cgi?id=313041

Andrew Crouthamel  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Andrew Crouthamel  ---
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you
help us out and re-test if the bug is valid in the latest version? This bug
will be moved back to REPORTED Status for manual review later, which may take a
while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D17053: Fix link on MacOS

2018-11-20 Thread René J . V . Bertin
rjvbb requested changes to this revision.
rjvbb added a comment.
This revision now requires changes to proceed.


  > @rjvbb what do you say? makes sense?
  
  Yes, this is required. I've got a bunch of patches for Okular I never got 
around to sub/committing. 
  The patch as proposed is OK as a packaging patch, but requires some polishing 
before it's fit for upstreaming. You can take inspiration from my version of 
this patch:
  
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -216,7 +216,7 @@ generate_export_header(okularcore BASE_NAME okularcore 
EXPORT_FILE_NAME "${CMAKE
 
 # Special handling for linking okularcore on OSX/Apple
 IF(APPLE)
-SET(OKULAR_IOKIT "-framework IOKit" CACHE STRING "Apple IOKit 
framework")
+SET(OKULAR_APPLE_FRAMEWORKS "-framework IOKit -framework CoreGraphics 
-framework CoreFoundation" CACHE STRING "required Apple frameworks")
 ENDIF(APPLE)
 
 # Extra library needed by imported synctex code on Windows
@@ -226,7 +226,7 @@ endif(WIN32)
 
 target_link_libraries(okularcore
 PRIVATE
-${OKULAR_IOKIT}
+${OKULAR_APPLE_FRAMEWORKS}
 ${SHLWAPI}
 KF5::Archive
 KF5::JS

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17053

To: darcyshen, #okular, rjvbb
Cc: aacid, rjvbb, okular-devel, ngraham, darcyshen


D17054: Retina Support for MacOS

2018-11-20 Thread René J . V . Bertin
rjvbb added a comment.


  This change does more than just enabling hidpi support in the plist.
  
  > Given you've been doing the same patch for multipple apps now, any chance 
this can be generated using an ECM macro, pernhaps populated from the app's 
desktop file or appstream data?
  
  Generating the correct XML from that data is maybe a bit of a tall order for 
cmake's language?
  
  As to the hidpi support: why is it necessary to set that in the plist in 
addition to what's done in the code? This seems like something that should be 
fixed in Qt's cmake modules or even in cmake itself (wherever the default 
Info.plist model comes from).
  
  FWIW, `LSMultipleInstancesProhibited` should of course not be set by default 
(should it for Okular which seems to launch in multiple instances on Linux?)
  
  Lastly: please add `kde-mac` to the subscriber list for Mac-related reviews.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

To: darcyshen, #okular
Cc: rjvbb, broulik, ltoscano, okular-devel, ngraham, darcyshen, aacid


D17053: Fix link on MacOS

2018-11-20 Thread Albert Astals Cid
aacid added subscribers: rjvbb, aacid.
aacid added a comment.


  @rjvbb what do you say? makes sense?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17053

To: darcyshen, #okular
Cc: aacid, rjvbb, okular-devel, ngraham, darcyshen


D16941: Fix inconsistent viewport positioning in PageView

2018-11-20 Thread Albert Astals Cid
aacid added a comment.


  You have until December 6 
https://community.kde.org/Schedules/Applications/18.12_Release_Schedule

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16941

To: tobiasdeiminger, #okular
Cc: sander, aacid, okular-devel, ngraham, darcyshen


[okular] [Bug 397463] okular session management

2018-11-20 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=397463

avlas  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|RESOLVED|REPORTED
 Resolution|DUPLICATE   |---

--- Comment #8 from avlas  ---
(In reply to Nate Graham from comment #7)
> Yep, looks like it!
> 
> *** This bug has been marked as a duplicate of bug 364680 ***

I disagree. Bug 364680 is only about restoring last session. This bug has
become about session management as in Kate. See comment below:

> I would actually love to have okular sessions (regardless of Bug 387490) as 
> they are a very nice way to organize pdf 'workflows'. I am a researcher, and 
> or me okular sessions would be as important as kate sessions when I put the 
> coding 'hat' on. And I bet this may be similar for other users.

If this is closed as duplicate I will need to create a new one with the name:
"okular session management", which is exactly the same title as this current
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 397463] okular session management

2018-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=397463

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Nate Graham  ---
Yep, looks like it!

*** This bug has been marked as a duplicate of bug 364680 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] feature request: restore previous session

2018-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 364680] feature request: restore previous session

2018-11-20 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=364680

Nate Graham  changed:

   What|Removed |Added

 CC||jsar...@gmail.com

--- Comment #5 from Nate Graham  ---
*** Bug 397463 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 397463] okular session management

2018-11-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=397463

--- Comment #6 from Christoph Feck  ---
Duplicate of bug 364680?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D17054: Retina Support for MacOS

2018-11-20 Thread Kai Uwe Broulik
broulik added a comment.


  Given you've been doing the same patch for multipple apps now, any chance 
this can be generated using an ECM macro, pernhaps populated from the app's 
desktop file or appstream data?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

To: darcyshen, #okular
Cc: broulik, ltoscano, okular-devel, ngraham, darcyshen, aacid


D17054: Retina Support for MacOS

2018-11-20 Thread Luigi Toscano
ltoscano added a comment.


  (Please fix the edit policy of the review, which is now too restricted)
  Also:
  
https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

To: darcyshen, #okular
Cc: ltoscano, okular-devel, ngraham, aacid


D17054: Retina Support for MacOS

2018-11-20 Thread Darcy Shen
darcyshen created this revision.
darcyshen added a reviewer: Okular.
darcyshen created this object with edit policy "Administrators".
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
darcyshen requested review of this revision.

TEST PLAN
  see https://github.com/KDE-mac/homebrew-kde/pull/270

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17054

AFFECTED FILES
  shell/CMakeLists.txt
  shell/MacOSXBundleInfo.plist.in

To: darcyshen, #okular
Cc: okular-devel, ngraham, aacid


D17053: Fix link on MacOS

2018-11-20 Thread Darcy Shen
darcyshen added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17053

To: darcyshen, #okular
Cc: okular-devel, ngraham, aacid


D17053: Fix link on MacOS

2018-11-20 Thread Darcy Shen
darcyshen created this revision.
darcyshen created this object with edit policy "Administrators".
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
darcyshen requested review of this revision.

TEST PLAN
  Tested using Homebrew on MacOS.
  
  See https://github.com/KDE-mac/homebrew-kde/pull/270

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17053

AFFECTED FILES
  CMakeLists.txt

To: darcyshen
Cc: okular-devel, ngraham, aacid


D16941: Fix inconsistent viewport positioning in PageView

2018-11-20 Thread Tobias Deiminger
tobiasdeiminger added a comment.


  @aacid When is the last chance to get something into 18.12 release? Already 
passed?
  
  I'm asking because we have two interfering issues here, where the first 
should be reasonably fixed with this diff (test still missing), but the second 
may take longer. Maybe we can split it, and get the first in?
  
  1. inconsistent calculation of viewport placement (fixed now)
  2. viewport displaced a bit again, when `finished` signals arrive from pixmap 
generation thread asynchronously, causing `notifyPageChanged( page, 
DocumentObserver::BoundingBox )` and `PageView::slotRelayoutPages`
  
  If there's a chance to get 1 in, I'll focus on it (i.e., implement a test).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16941

To: tobiasdeiminger, #okular
Cc: sander, aacid, okular-devel, ngraham