D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn added a comment.


  In D18179#394712 , @aacid wrote:
  
  > The only way i can think of is making the long form not havve default values
  >
  > https://paste.kde.org/p55lx6vrh
  
  
  Thanks, that looks good. I have done it this way now.
  
  (Note to self: Make sure not to have strange settings in 
$HOME/.cups/lpoptions while testing ...)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49715.
michaelweghorn added a comment.


  Changes in this revision:
  
  - make new 'printFiles()' have no default values for parameters, so that 
param order can be the same as in the original one (thanks Albert!)
  
  - add "TODO" comment to merge both versions

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49614&id=49715

BRANCH
  michaelweghorn/UPDATE_D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#394709 , @aacid wrote:
  
  > I don't really have the time to spend print stuff to check if this does 
what it says it does, so i'm just doing code review from the pure formal way.
  
  
  Many thanks for taking the time to look at this anyway!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn marked 4 inline comments as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49697.
michaelweghorn added a comment.


  Adapted according to Albert's feedback:
  
  - Remove (now) unneeded imclude
  - remove 'virtual' keyword in derived class

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=49608&id=49697

BRANCH
  michaelweghorn/UPDATE_D10974

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  CMakeLists.txt
  core/document.h
  core/fileprinter.cpp
  core/printoptionswidget.cpp
  core/printoptionswidget.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  interfaces/printinterface.h
  part.cpp

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

[okular] [Bug 403263] Okular scales down pages when printing

[Sergio]

https://bugs.kde.org/show_bug.cgi?id=403263

--- Comment #4 from Sergio  ---
Mentioning the item above as distributions are typically happy to
incorporate/backport mere bug fixes, but typically not sympathetic to requests
to update to totally new versions of software nor to backport new features in
order to have bugs fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 403263] Okular scales down pages when printing

[Sergio]

https://bugs.kde.org/show_bug.cgi?id=403263

--- Comment #3 from Sergio  ---
May not be an exact duplicate as but 348172 looks more like as an enhancement
request or a request to restore functionality that got lost in the KDE 4 -> KDE
5 transition, while this is a bug.

While the provision of scaling options according 348172 would eliminate this
bug as a side effect, until those are in place IMHO Okular should never scale
down pages that already fit in the paper size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

[Simone Gaiarin]

simgunz added a comment.


  I use the side review panel only when I need to go through all the reviews 
one by one, so it is annoying having to expand all the elements by hand. Maybe 
a expand/collapse all solution would be a better solution. (The long answer is 
in  T8553  ).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18283

To: joaonetto
Cc: simgunz, aacid, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

[Vasiliy Glazov]

https://bugs.kde.org/show_bug.cgi?id=330820

--- Comment #13 from Vasiliy Glazov  ---
Bug still present.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18283: Auto-expand all tree elements in the side panel when the panel is first shown

[Simone Gaiarin]

simgunz added a task: T8553: Improve review side panel.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18283

To: joaonetto
Cc: simgunz, aacid, okular-devel, tfella, ngraham, darcyshen

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

[Vasiliy Glazov]

https://bugs.kde.org/show_bug.cgi?id=330820

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.