[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=403848

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
(In reply to happy from comment #0)
> ADDITIONAL INFORMATION
> Minor (for me) because I don't often do markup and I can just uncheck "warn
> me if closing multiple tabs"; but if modifying documents was part of your
> work flow then this would be more severe (ie: false warnings obscuring real
> ones)

Can you explain what exactly you mean by this?

A quick test for me showed that when unchecking "warn me if closing multiple
tabs",

* no dialog appears when closing multiple unmodified documents (as you want it
to be)
* a dialog "Do you want to save your changes to  or discard them?" still
appears if any of the documents was modified (e.g. an annotation was added)

This is what I would have expected and what I'd consider to be the "correct"
behaviour. Can you describe what should be different in your eyes?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18396

To: vkrause, aacid
Cc: mart, okular-devel, tfella, ngraham, darcyshen, aacid


D18398: Fix a few more QML runtime errors/warnings

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18398

To: vkrause, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid


D18397: Fix crash on canceling the file open dialog

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol, nicolasfella, aacid
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid


D18399: Fix launching Okular by opening a document from the file browser

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18399

To: vkrause, aacid
Cc: okular-devel, tfella, ngraham, darcyshen, aacid


[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread happy
https://bugs.kde.org/show_bug.cgi?id=403848

--- Comment #3 from happy  ---
(In reply to Yuri Chornoivan from comment #1)
> This warning can be useful because sometimes you can unintentionally close
> the window trying to close the current document only.

Yes, I totally agree, I do that all the time (it's the downside of tabs).

What the bug report is about is about is QUITTING Okular, particularly when
done automatically on session log out.  I'm sorry I used the word "CLOSING".

I always use "Restore Previous Session" type logins; so I always (well, for
most applications) get all my windows back anyway.
As I said, it's a problem if something hangs up the machine shutting down...
particularly when there's no need.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread happy
https://bugs.kde.org/show_bug.cgi?id=403848

--- Comment #4 from happy  ---
> This is what I would have expected and what I'd consider to be the "correct"
> behaviour. Can you describe what should be different in your eyes?

Thank you for trying that, I didn't try markup.  See my reply to Yuri about
clarification.

I guess I'm requesting a third behaviour on quitting the application?
IE: with the "warn me" behaviour unsuppressed, so that closing a window will
generate warnings that _quitting_ the application won't ?
(eg: EXACTLY the same behaviour as Firefox)

-- 
You are receiving this mail because:
You are the assignee for the bug.