D18744: Add action in Edit menu to select the text on current page

[Albert Astals Cid]

aacid requested changes to this revision.
aacid added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> shubham wrote in pageview.cpp:5598
> If removed, it causes crash.

Sorry but that's not a valid answer, you'll have to explain why sometimes you 
have to delete area and why sometimes not

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Shubham]

shubham added a comment.


  In D18744#437473 , @ngraham wrote:
  
  > In D18744#437461 , @shubham 
wrote:
  >
  > > Try to fix the crash. I could not test it because for me I could not see 
the entry added to the menu.
  >
  >
  > You gotta fix that. :) Try deleting `~/.local/share/kxmlgui5/okular/partrc` 
Does that help?
  
  
  Thanks, that is helpful.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> aacid wrote in pageview.cpp:5598
> Why this return?

If removed, it causes crash.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Nathaniel Graham]

ngraham added a comment.


  In D18744#437461 , @shubham wrote:
  
  > Try to fix the crash. I could not test it because for me I could not see 
the entry added to the menu.
  
  
  You gotta fix that. :) Try deleting `~/.local/share/kxmlgui5/okular/partrc` 
Does that help?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Shubham]

shubham updated this revision to Diff 54700.
shubham added a comment.


  Try to fix the crash

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18744?vs=54493&id=54700

BRANCH
  arcpatch-D18744

REVISION DETAIL
  https://phabricator.kde.org/D18744

AFFECTED FILES
  doc/index.docbook
  part.cpp
  part.h
  part.rc
  ui/pageview.cpp
  ui/pageview.h

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D18744: Add action in Edit menu to select the text on current page

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I just re-tested and now the menu item crashes when used, no matter which PDF 
I try. :(
  
  Again, please test before submitting or updating a patch.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, 
alexde, ngraham, okular-devel, gennad, joaonetto, tfella, skadinna, darcyshen, 
aacid

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

[Oliver Sander]

sander added a comment.


  I do use my stylus for drawing on slides in presentation mode.  I am not 
particularly happy with the quality of that, but compressing tablet events 
doesn't seem to make it worse.  So no objections from my side.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16519

To: kezik, #okular
Cc: sander, aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

[kezi]

kezik added a comment.


  Hi, thanks for the feedback.
  
  I think uncompressed tablet events are useful for example on krita, when you 
don't want to lose the "high frequency" content of the drawing on the screen, 
and latency is not a big issue.
  I don't see any downsides for okular, mouse events are already compressed, 
this patch only fixes a Qt "documented quirk"

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16519

To: kezik, #okular
Cc: sander, aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

[Oliver Sander]

sander added a comment.


  I tried this on my ThinkPad Yoga 12, which comes with a stylus to write on 
the screen with.  I confirm that this patch noticeably improves the scrolling 
behavior when using the stylus for scrolling.
  
  I am curious though: what are the downsides to enabling tablet event 
compression?  When would I want to disable it?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16519

To: kezik, #okular
Cc: sander, aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen

D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet

[kezi]

kezik updated this revision to Diff 54655.
kezik retitled this revision from "Don't call scrollTo every time there's a 
mouseMoveEvent, use a timer instead" to "Set Qt::AA_CompressTabletEvents 
attribute to avoid latency when scrolling with a tablet".
kezik edited the summary of this revision.
kezik added a comment.


  This is the correct fix for this issue, disregard the past patch

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16519?vs=44486&id=54655

REVISION DETAIL
  https://phabricator.kde.org/D16519

AFFECTED FILES
  shell/main.cpp

To: kezik, #okular
Cc: aacid, okular-devel, #okular, joaonetto, tfella, ngraham, darcyshen