D19123: Added option to search for whole words only

2019-04-03 Thread Albert Astals Cid 
aacid added a comment.


  Not sure if i'm reading the tests code wrong, but shouldn't
  
  QTest::newRow("albert test") << (QVector() << QStringLiteral("it") 
<< QStringLiteral(" should find this afind")) << QStringLiteral("find") << 
TEST_NEXT_AND_PREV;
  
  pass?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D19123

To: joaonetto, #okular, aacid
Cc: davidhurka, yurchor, aacid, ngraham, okular-devel, joaonetto, tfella, 
darcyshen

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

2019-04-03 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=403914

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Albert Astals Cid  ---
Ok thanks. If you can reproduce it again please reopen the bug.

Thanks for caring about okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

2019-04-03 Thread Erik Quaeghebeur 
https://bugs.kde.org/show_bug.cgi?id=403914

--- Comment #2 from Erik Quaeghebeur  ---
(In reply to Albert Astals Cid from comment #1)
> can you reproduce this crash?
No, currently not (on 1.6.3). Feel free to close.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

2019-04-03 Thread Albert Astals Cid 
aacid added inline comments.

INLINE COMMENTS

> fileprinter.h:58
> + *
> + * @since 1.7
> + */

the since will need to be 1.8 (and all the other 1.7 you added)

> fileprinter.h:61
> +enum ScaleMode {
> +None = 0,
> +FitToPrintArea = 1

Make this no Scale or something similar since otherwise

FilePrinter::None seems like you're saying "none printer"

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

2019-04-03 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=403914

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
can you reproduce this crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

2019-04-03 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  All options work perfectly in my testing, both with and without rasterized 
printing enabled. If @aacid is good with the code, I think this could land.

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

2019-04-03 Thread Nathaniel Graham 
ngraham added a comment.


  Never mind, removing the dependency made it work. Stupid Arc. :( Testing 
now...

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

2019-04-03 Thread Michael Weghorn 
michaelweghorn added a comment.


  In D10974#442825 , @ngraham wrote:
  
  > Do you really not have commit access yet? You should apply. :) 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
  >
  > Meanwhile, I'll land this for you.
  
  
  Thanks a lot! Actually, I haven't contributed very much to KDE so far, so 
don't think I really qualify for commit access.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

2019-04-03 Thread Michael Weghorn 
michaelweghorn removed a dependency: D10974: Add option to ignore print margins 
for non-PDF generators.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

2019-04-03 Thread Michael Weghorn 
michaelweghorn removed a dependent revision: D18179: PDF: Implement scaling 
options for non-rasterized printing.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

2019-04-03 Thread Nathaniel Graham 
ngraham added a comment.


  This patch no longer applies cleanly to master:
  
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
Already up to date.
Deleted branch arcpatch-D18179 (was 8bf1a9117).
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D18179.
Created and checked out branch arcpatch-D10974.
Checking patch part.cpp...
Checking patch interfaces/printinterface.h...
Checking patch generators/poppler/generator_pdf.h...
Checking patch generators/poppler/generator_pdf.cpp...
Checking patch core/printoptionswidget.h...
Checking patch core/printoptionswidget.cpp...
Checking patch core/fileprinter.cpp...
Checking patch core/document.h...
Checking patch CMakeLists.txt...
Applied patch part.cpp cleanly.
Applied patch interfaces/printinterface.h cleanly.
Applied patch generators/poppler/generator_pdf.h cleanly.
Applied patch generators/poppler/generator_pdf.cpp cleanly.
Applied patch core/printoptionswidget.h cleanly.
Applied patch core/printoptionswidget.cpp cleanly.
Applied patch core/fileprinter.cpp cleanly.
Applied patch core/document.h cleanly.
Applied patch CMakeLists.txt cleanly.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D10974'

STDOUT
On branch arcpatch-D18179
You are currently cherry-picking commit 4cc9a85f0.

nothing to commit, working tree clean


STDERR
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git reset'

(Run with `--trace` for a full exception trace.)
  
  Could you rebase on master?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

2019-04-03 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:8bf1a911751b: Add option to ignore print margins for 
non-PDF generators (authored by michaelweghorn, committed by ngraham).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=49697=55345

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  CMakeLists.txt
  core/document.h
  core/fileprinter.cpp
  core/printoptionswidget.cpp
  core/printoptionswidget.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  interfaces/printinterface.h
  part.cpp

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

2019-04-03 Thread Nathaniel Graham 
ngraham added a comment.


  Do you really not have commit access yet? You should apply. :) 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
  
  Meanwhile, I'll land this for you.

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D10974

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

2019-04-03 Thread Michael Weghorn 
michaelweghorn added a comment.


  In D10974#442598 , @aacid wrote:
  
  > If someone wants to test it and approve it and Michael says he'll fix any 
bug that arises from here i'm happy enough
  
  
  I promise that I'll try to fix any issues arising from this. The same goes 
for D18179 .

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D10974

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen