[okular] [Bug 406237] PDFs get an added margin when printing

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=406237

--- Comment #13 from Matthew Trescott  ---
I've opened separate bug reports.

https://bugs.kde.org/show_bug.cgi?id=408270
https://bugs.kde.org/show_bug.cgi?id=408271
https://bugs.kde.org/show_bug.cgi?id=408272
https://bugs.kde.org/show_bug.cgi?id=408273

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408273] New: Scaling mode "Print original size" is confusing

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408273

Bug ID: 408273
   Summary: Scaling mode "Print original size" is confusing
   Product: okular
   Version: 1.7.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: matthewtresc...@gmail.com
  Target Milestone: ---

Created attachment 120544
  --> https://bugs.kde.org/attachment.cgi?id=120544=edit
Sample PDF for testing

Split from https://bugs.kde.org/show_bug.cgi?id=406237

SUMMARY
When selecting "Print original size" as the scaling setting, the document is
shifted down and left, rather than being cropped.

STEPS TO REPRODUCE
1. Open any PDF (such as the one attached)
2. Open the Print menu, choose a paper size smaller than the one of the
original document, and select "Print original size" as the scaling mode.
3. Click "Print."

OBSERVED RESULT
The document's contents are shifted down and left to fit the printer's margins.

EXPECTED RESULT
The document's contents are overlayed with a blank margin prior to being sent
tot the print driver.

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3

ADDITIONAL INFORMATION
The current system for this kind of printing may even have problems for RTL
languages (I do not know since I have not tested this). I think a simpler, more
elegant solution would be to replace this scaling mode with one called "Crop to
fit printable area." This new scaling mode would add blank margins to the PDF
before sending it to the print driver, rather than allowing the printer to
figure out that it can't print part of the document. I'm not sure how useful
that would be in practice compared to the "Fit to full page" scale mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408272

--- Comment #1 from Matthew Trescott  ---
Note: split from https://bugs.kde.org/show_bug.cgi?id=406237

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408271

--- Comment #1 from Matthew Trescott  ---
Note: split from https://bugs.kde.org/show_bug.cgi?id=406237

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408272] New: The default scaling method should be "Fit to Full Page"

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408272

Bug ID: 408272
   Summary: The default scaling method should be "Fit to Full
Page"
   Product: okular
   Version: 1.7.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: matthewtresc...@gmail.com
  Target Milestone: ---

When printing, "fit to printable area" is the default scaling setting. However,
most PDF documents have margins built-in and so do not need the extra margins
added by this setting. "Fit to full page" should be the default.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408271] New: Print-to-PDF defaults to A4 regardless of locale or original document size

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408271

Bug ID: 408271
   Summary: Print-to-PDF defaults to A4 regardless of locale or
original document size
   Product: okular
   Version: 1.7.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: matthewtresc...@gmail.com
  Target Milestone: ---

Created attachment 120543
  --> https://bugs.kde.org/attachment.cgi?id=120543=edit
Sample document for testing

SUMMARY
The title pretty much says it all. Personally, I feel that since Okular aims to
be a viewer for many more types of files other than PDF (EPUB, ODF, etc.) it
should be able to act as a one-to-one converter to PDF. For example, you should
be able to open an PostScript file with many different page sizes and use
Okular's Print-to-PDF function to create an identical PDF, with the page sizes
preserved.

However, I can also understand the reasoning behind the current default
setting. It also makes sense that using Print-to-PDF would force the document
to fit into a consistent, standard paper size. If this remains the default,
however, the default paper size should be dependent on locale (en_US should
have Letter for example).

STEPS TO REPRODUCE
1. Open the attached PDF.
2. Go to File > Print and select Print to PDF.
3. Hit "Print" and observe the output.

OBSERVED RESULT
The Letter-size document produces an A4-size PDF.

EXPECTED RESULT
The PDF produced via Print-to-PDF is Letter-sized for either of the following
reasons:
1. The original document was Letter-sized, and the original document's page
size(s) are preserved, OR
2. Letter is the default paper size for my locale (en_US).

SOFTWARE/OS VERSIONS
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #5 from Matthew Trescott  ---
Also note that this bug is unaffected by the scaling settings available when
"Force rasterization" is selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #4 from Matthew Trescott  ---
Note that this doesn't occur with other software like LibreOffice, so I don't
think it's a problem with CUPS or the PPD.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #3 from Matthew Trescott  ---
Created attachment 120542
  --> https://bugs.kde.org/attachment.cgi?id=120542=edit
Output from /var/spool/cups

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #2 from Matthew Trescott  ---
Created attachment 120541
  --> https://bugs.kde.org/attachment.cgi?id=120541=edit
Sample PDF used

This is the sample PDF I printed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #1 from Matthew Trescott  ---
Created attachment 120540
  --> https://bugs.kde.org/attachment.cgi?id=120540=edit
The PPD for my printer

This is the PPD for the printer I use. It is a Samsung C1860FW laser printer.
The PPD is from /usr/share/foomatic/db/source/PPD/Samsung

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] New: Okular always prints in A4 on physical printers, even when Letter is the default

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=408270

Bug ID: 408270
   Summary: Okular always prints in A4 on physical printers, even
when Letter is the default
   Product: okular
   Version: 1.7.1
  Platform: Archlinux Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: matthewtresc...@gmail.com
  Target Milestone: ---

Split from https://bugs.kde.org/show_bug.cgi?id=406237

I turned off WiFi temporarily so
CUPS would hold my print job (it's a network printer), then printed my
Letter-size PDF. I double-checked the printer properties in Okular to make
sure that it was set to Letter (Letter is the default for the print queue
so the paper size was already correctly set). However, when I opened the
corresponding PostScript document in /var/spool/cups, it had the distinctive
sqrt(2) side ratio of A-size paper. This confirms the results I had when I
permitted the print jobs to go through previously and discovered this bug---I
just didn't want to waste paper this time.

Attachments are coming shortly.

System: 
Arch Linux (fairly up-to-date)
CUPS 2.2.11

-- 
You are receiving this mail because:
You are the assignee for the bug.

D21202: [WIP] Support animated PDF

[Joao Oliveira]

joaonetto updated this revision to Diff 59102.
joaonetto added a comment.


  Updated with the code against master

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21202?vs=59101=59102

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21202

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/data/kjsfunctionstest.pdf
  autotests/kjsfunctionstest.cpp
  core/document.cpp
  core/document.h
  core/script/executor_kjs.cpp
  core/script/executor_kjs_p.h
  core/script/kjs_app.cpp
  core/script/kjs_app_p.h
  core/script/kjs_display.cpp
  core/script/kjs_display_p.h
  core/script/kjs_document.cpp
  core/script/kjs_field.cpp
  core/script/kjs_ocg.cpp
  core/script/kjs_ocg_p.h
  core/scripter.cpp
  ui/formwidgets.cpp
  ui/pageview.cpp

To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, 
darcyshen, aacid

D21202: [WIP] Support animated PDF

[Joao Oliveira]

joaonetto reopened this revision.
joaonetto added a comment.


  Wasn't supposed to be closed. It closed with a wrong commit on my side branch.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21202

To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, 
darcyshen, aacid

D21202: [WIP] Support animated PDF

[Joao Oliveira]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:a3628c1f97e9: Revert mend (authored by 
joaonetto).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21202?vs=59100=59101#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21202?vs=59100=59101

REVISION DETAIL
  https://phabricator.kde.org/D21202

AFFECTED FILES
  autotests/kjsfunctionstest.cpp

To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, 
darcyshen, aacid

D21202: [WIP] Support animated PDF

[Joao Oliveira]

joaonetto updated this revision to Diff 59100.
joaonetto edited the summary of this revision.
joaonetto added a comment.


  Changed button code to be transparent when there's no text.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21202?vs=59045=59100

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21202

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/data/kjsfunctionstest.pdf
  autotests/kjsfunctionstest.cpp
  core/document.cpp
  core/document.h
  core/script/executor_kjs.cpp
  core/script/executor_kjs_p.h
  core/script/kjs_app.cpp
  core/script/kjs_app_p.h
  core/script/kjs_display.cpp
  core/script/kjs_display_p.h
  core/script/kjs_document.cpp
  core/script/kjs_field.cpp
  core/script/kjs_ocg.cpp
  core/script/kjs_ocg_p.h
  core/scripter.cpp
  ui/formwidgets.cpp
  ui/pageview.cpp

To: joaonetto, aacid, #okular
Cc: pino, anthonyfieroni, sander, okular-devel, joaonetto, tfella, ngraham, 
darcyshen, aacid

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  In D15580#473781 , @davidhurka 
wrote:
  
  > Using double-click is probably used to some [how many?] Okular users, but 
others asked for something like a sticky button. An option to make selected 
actions sticky by default, without sticky button, would be perfect for me.
  >  From other applications I know left-click: use the tool, right-click: stop 
using the tool. If there is no fallback tool (see below), the tool will be 
remembered for the next left click.
  >
  > Actually, I don’t know any application where a tool automatically 
deselects. Do you have an example?
  
  
  It's very common in the Mac world, which is what I'm most familiar with 
outside of the Linux world.
  
  Sticky-by-default would probably be okay as long as we can make it //very// 
clear how to un-select the tool. Probably implementing multiple methods would 
be good (hit esc key, left-click again on the tool, right-click anywhere, etc).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, joaonetto, tfella, darcyshen, aacid

D15580: New annotation toolbar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> part.rc:2
>  
>  
>  

Increase version.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, joaonetto, tfella, darcyshen, aacid

D15580: New annotation toolbar

[David Hurka]

davidhurka added a comment.


  In D15580#473733 , @ngraham wrote:
  
  > >> - I can't figure out what Pin Annotation actually does
  > > 
  > > If checked the current annotation tool is kept selected after use (as 
double-click does in the current Okular). Needs a better name/tooltip. Added to 
TODO.
  >
  > Can't we just keep the old double-click behavior? I think that's good. 
Various other similar tools use a double-click to mean "activate this tool and 
then keep it active after you've used it once"  so it's not a totally alien UI. 
Then we could keep the pin icon as an additional visual status indicator of 
whether the current tool is "sticky" or not.
  
  
  Using double-click is probably used to some [how many?] Okular users, but 
others asked for something like a sticky button. An option to make selected 
actions sticky by default, without sticky button, would be perfect for me.
  From other applications I know left-click: use the tool, right-click: stop 
using the tool. If there is no fallback tool (see below), the tool will be 
remembered for the next left click.
  
  Actually, I don’t know any application where a tool automatically deselects. 
Do you have an example?
  
  > 
  > 
  >>> - It's not clear to me how to select existing annotations once an 
annotation tool has been activated; consider maybe adding a "select 
annotations" tool or mode under the Selection dropdown menu.
  >> 
  >> Currently you need to click Esc to deselect the annotation, then you can 
select the annotations (standard Browse mode). If instead 'pin annotation' is 
unchecked, the annotation is deselected automatically and you can select 
annotation. Beside the fact that clicking on an annotation does not select it 
(added to TODO) and that selecting and annotation does not switch to Browse 
mode (added to TODO), it works as the current version of Okular. I think we do 
not need a dedicated Selection tool.
  > 
  > Got it. My first impulse to deselect the currently-active annotation tool 
was to to click on it again. Currently this does nothing. Maybe it should 
de-select it.
  
  Clicking a selected tool to deselect sounds ok to me, although they are 
probably an exclusive action group. That would allow to use exactly one 
shortcut to enable and disable a single annotation tool.
  
  Does right-click still work to deselect a tool? That is how I know it from 
many other applications (not all).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, 
tfella, darcyshen, aacid

D21549: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties of Kirigami

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:3a380e162081: mobile: ThumbnailsBase: Rename properties 
to avoid overriding final properties… (authored by jbbgameich).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21549?vs=59036=59076

REVISION DETAIL
  https://phabricator.kde.org/D21549

AFFECTED FILES
  mobile/app/package/contents/ui/ThumbnailsBase.qml

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21549: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties of Kirigami

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Confirmed.

REPOSITORY
  R223 Okular

BRANCH
  fix-final-properties

REVISION DETAIL
  https://phabricator.kde.org/D21549

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21549: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties of Kirigami

[Jonah Brüchert]

jbbgameich added a comment.


  I don't think those properties are currently used anywhere.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21549

To: jbbgameich, #okular
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21551: mobile: Thumbnails: improve placement of searchField and label

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:27ede6c1ddbf: mobile: Thumbnails: improve placement of 
searchField and label (authored by jbbgameich).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21551?vs=59038=59074

REVISION DETAIL
  https://phabricator.kde.org/D21551

AFFECTED FILES
  mobile/app/package/contents/ui/Thumbnails.qml
  mobile/app/package/contents/ui/ThumbnailsBase.qml

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D15580: New annotation toolbar

[Nathaniel Graham]

ngraham added a comment.


  >> - The Color button should actually show the current color rather than a 
generic icon
  > 
  > This should already work.
  
  My mistake, it totally does work!
  
  >> - The Inner color button needs something to show that it exists; right now 
it just looks like whitespace in the toolbar. It should show its color like the 
other button, and for "no color", maybe an empty transparent square?
  > 
  > Also the icons of color and inner color need to be done from scratch. I was 
thinking at a circle fillable with the current color and a border to show it 
exists.
  
  Yep, that sounds good. Also I found out why it looked invisible: its icon 
disappears when using the Line tool, or any other tool that doesn't have an 
inner color, and does not restore its icon when using a tool that does have an 
inner color. It should probably become conditionally and temporarily disabled 
instead.
  
  >> - Straight Line is mis-named, it's for drawing anything //but// a straight 
line! :) Should be something like "Freehand line"
  > 
  > Have you removed .config/okularpartrc ? Otherwise the toolbar picks up the 
annotation in you custom orders and the buttons are mismatched.
  
  Yep, I did. Did it again for good measure. It still says, "Straight Line": 
F6866309: Screenshot_20190603_092649.png 
  
  >> - I can't figure out what Pin Annotation actually does
  > 
  > If checked the current annotation tool is kept selected after use (as 
double-click does in the current Okular). Needs a better name/tooltip. Added to 
TODO.
  
  Can't we just keep the old double-click behavior? I think that's good. 
Various other similar tools use a double-click to mean "activate this tool and 
then keep it active after you've used it once"  so it's not a totally alien UI. 
Then we could keep the pin icon as an additional visual status indicator of 
whether the current tool is "sticky" or not.
  
  >> - It's not clear to me how to select existing annotations once an 
annotation tool has been activated; consider maybe adding a "select 
annotations" tool or mode under the Selection dropdown menu.
  > 
  > Currently you need to click Esc to deselect the annotation, then you can 
select the annotations (standard Browse mode). If instead 'pin annotation' is 
unchecked, the annotation is deselected automatically and you can select 
annotation. Beside the fact that clicking on an annotation does not select it 
(added to TODO) and that selecting and annotation does not switch to Browse 
mode (added to TODO), it works as the current version of Okular. I think we do 
not need a dedicated Selection tool.
  
  Got it. My first impulse to deselect the currently-active annotation tool was 
to to click on it again. Currently this does nothing. Maybe it should de-select 
it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, 
darcyshen, aacid

D21551: mobile: Thumbnails: improve placement of searchField and label

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  drawer-design

REVISION DETAIL
  https://phabricator.kde.org/D21551

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21549: mobile: ThumbnailsBase: Rename properties to avoid overriding final properties of Kirigami

[Nathaniel Graham]

ngraham added a comment.


  Does this also need to be renamed by anything that uses those properties?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21549

To: jbbgameich, #okular
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

[okular] [Bug 408254] New: Okular crashes with an encrypted pdf from Adobe sign

[Nico Kruber]

https://bugs.kde.org/show_bug.cgi?id=408254

Bug ID: 408254
   Summary: Okular crashes with an encrypted pdf from Adobe sign
   Product: okular
   Version: 1.7.1
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: nico.kru...@gmail.com
  Target Milestone: ---

SUMMARY

I'm trying to open a pdf I received and downloaded from Adobe Sign (which I
unfortunately can't share). Whenever I open it, Okular immediately crashes -
pdf preview in Dolphin as well as pdf import in Gimp seem to work though.

STEPS TO REPRODUCE
1. open pdf

OBSERVED RESULT
crash

EXPECTED RESULT
no crash

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kernel 5.1.4, x86_64
(available in About System)
KDE Plasma Version: 5.15.5
KDE Frameworks Version: 5.58.0
Qt Version: 5.12.3
libpoppler: 0.72.0

ADDITIONAL INFORMATION

Backtrace from the crash:

Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7fb22a7bb900 (LWP 7168))]

Thread 3 (Thread 0x7fb226e48700 (LWP 7170)):
#0  0x7fb22c504c9f in poll () from /lib64/libc.so.6
#1  0x7fb22b158dbe in ?? () from /usr/lib64/libglib-2.0.so.0
#2  0x7fb22b158edf in g_main_context_iteration () from
/usr/lib64/libglib-2.0.so.0
#3  0x7fb22ca96e1b in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib64/libQt5Core.so.5
#4  0x7fb22ca3fbdb in
QEventLoop::exec(QFlags) () from
/usr/lib64/libQt5Core.so.5
#5  0x7fb22c881751 in QThread::exec() () from /usr/lib64/libQt5Core.so.5
#6  0x7fb22cd144e6 in ?? () from /usr/lib64/libQt5DBus.so.5
#7  0x7fb22c8828d2 in ?? () from /usr/lib64/libQt5Core.so.5
#8  0x7fb22bc40faa in start_thread () from /lib64/libpthread.so.0
#9  0x7fb22c50f71f in clone () from /lib64/libc.so.6

Thread 2 (Thread 0x7fb228751700 (LWP 7169)):
#0  0x7fb22c504c9f in poll () from /lib64/libc.so.6
#1  0x7fb22bcc5cc2 in ?? () from /usr/lib64/libxcb.so.1
#2  0x7fb22bcc78ba in xcb_wait_for_event () from /usr/lib64/libxcb.so.1
#3  0x7fb228961e28 in ?? () from /usr/lib64/libQt5XcbQpa.so.5
#4  0x7fb22c8828d2 in ?? () from /usr/lib64/libQt5Core.so.5
#5  0x7fb22bc40faa in start_thread () from /lib64/libpthread.so.0
#6  0x7fb22c50f71f in clone () from /lib64/libc.so.6

Thread 1 (Thread 0x7fb22a7bb900 (LWP 7168)):
[KCrash Handler]
#6  0x7fb22c572311 in __strlen_avx2 () from /lib64/libc.so.6
#7  0x7fb22c49ed9f in strdup () from /lib64/libc.so.6
#8  0x7fb21ca5b77d in SignatureInfo::setSubjectDN
(this=this@entry=0x55759f4d1040, subjectDN=0x0) at
/usr/src/debug/poppler-0.72.0-1.4.x86_64/poppler/SignatureInfo.cc:127
#9  0x7fb21c9c9ec0 in FormFieldSignature::validateSignature
(forceRevalidation=, validationTime=4294967295,
doVerifyCert=true, this=0x55759f5f59b0) at
/usr/src/debug/poppler-0.72.0-1.4.x86_64/poppler/Form.cc:1750
#10 FormFieldSignature::validateSignature (this=0x55759f5f59b0,
doVerifyCert=, forceRevalidation=,
validationTime=4294967295) at
/usr/src/debug/poppler-0.72.0-1.4.x86_64/poppler/Form.cc:1690
#11 0x7fb21cbeb3e4 in Poppler::FormFieldSignature::validate
(this=this@entry=0x55759f5f5950, opt=opt@entry=1, validationTime=...) at
/usr/src/debug/poppler-qt5-0.72.0-1.4.x86_64/qt5/src/poppler-form.cc:681
#12 0x7fb21cbeb940 in Poppler::FormFieldSignature::validate
(this=0x55759f5f5950,
opt=opt@entry=Poppler::FormFieldSignature::ValidateVerifyCertificate) at
/usr/src/debug/poppler-qt5-0.72.0-1.4.x86_64/qt5/src/poppler-form.cc:674
#13 0x7fb21cc75e53 in PopplerFormFieldSignature::PopplerFormFieldSignature
(this=0x55759f5f5b70, field=0x55759f5f5950) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/generators/poppler/formfields.cpp:387
#14 0x7fb21cc6e9bd in PDFGenerator::addFormFields (this=,
popplerPage=, page=) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/generators/poppler/generator_pdf.cpp:1978
#15 0x7fb21cc6ec90 in PDFGenerator::loadPages
(this=this@entry=0x55759f4c5020, pagesVector=..., rotation=rotation@entry=0,
clear=clear@entry=false) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/generators/poppler/generator_pdf.cpp:787
#16 0x7fb21cc6f04f in PDFGenerator::init (this=this@entry=0x55759f4c5020,
pagesVector=..., password=...) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/generators/poppler/generator_pdf.cpp:683
#17 0x7fb21cc6f258 in PDFGenerator::loadDocumentWithPassword
(this=0x55759f4c5020, filePath=..., pagesVector=..., password=...) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/generators/poppler/generator_pdf.cpp:638
#18 0x7fb2259b18bc in Okular::DocumentPrivate::openDocumentInternal
(this=0x55759eb902a0, offer=..., isstdin=isstdin@entry=false, docFile=...,
filedata=..., password=...) at
/usr/src/debug/okular-19.04.1-1.2.x86_64/core/document.cpp:875
#19 0x7fb2259b1f3b in 

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=408222

Tobias Deiminger  changed:

   What|Removed |Added

 CC||haxti...@posteo.de

--- Comment #9 from Tobias Deiminger  ---
Created attachment 120522
  --> https://bugs.kde.org/attachment.cgi?id=120522=edit
side by side comparison of test-1 rendered with Evince (l) and Okular (r)

(In reply to yousifjkadom from comment #6)
> If you concentrate well, you will noticed that black tone (DENSITY OF BLACK)
> is lower in Okular than Evence. So, picture in Okular less in dexterity than
> Evince.

I'm with Albert, the scans look equally bad in both Evince and Okular (see
attachment). Regarding black tone, I measured RGB values with KColorChooser and
they are just the same.

Can you show how it looks different at your side? I mean don't just attach the
PDF, but a screenshot showing it in Evince next to Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #12 from Michael Weghorn  ---
(In reply to fabrice salvaire from comment #11)
> I filled an issue about that some years ago ...
> 
> In concrete terms, we cannot print a document using Okular if we need a 1:1
> scale.
> 
> In other words, a user will get wrong dimensions if it prints a 10 cm square
> using Okular.
> 
> This issue doesn't happen if we print using the lpr command, but Evince has
> the same issue if we don't change the default setting so as to apply any
> scale adjustment  (i.e. tweak a parameter in a tab ...).
> 
> The right way is to implement printing as in Acroread !!!

As mentioned above, Okular now allows to apply different options for scaling if
you have a recent enough version. With regard to what option should be selected
by default, that can for sure be discussed...


@Matthew: Any more comments/ideas on comment 10? Otherwise, if there's a common
understanding, I'd suggest to continue the single aspects in separate new bug
reports as needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D21550: mobile: OkularDrawer: port to QQC2

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:8dfdfa69fcf1: mobile: OkularDrawer: port to QQC2 
(authored by jbbgameich).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21550?vs=59064=59065

REVISION DETAIL
  https://phabricator.kde.org/D21550

AFFECTED FILES
  mobile/app/package/contents/ui/OkularDrawer.qml

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21550: mobile: OkularDrawer: port to QQC2

[Jonah Brüchert]

jbbgameich updated this revision to Diff 59064.
jbbgameich added a comment.


  - mobile: okularDrawer: Restore non-flat ToolButton design

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21550?vs=59062=59064

BRANCH
  drawer-qqc2

REVISION DETAIL
  https://phabricator.kde.org/D21550

AFFECTED FILES
  mobile/app/package/contents/ui/OkularDrawer.qml

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21550: mobile: OkularDrawer: port to QQC2

[Jonah Brüchert]

jbbgameich updated this revision to Diff 59062.
jbbgameich added a comment.


  - mobile: OkularDrawer: Add buttons to ButtonGroup to replace ExclusiveGroup

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21550?vs=59037=59062

BRANCH
  drawer-qqc2

REVISION DETAIL
  https://phabricator.kde.org/D21550

AFFECTED FILES
  mobile/app/package/contents/ui/OkularDrawer.qml

To: jbbgameich, #okular, ngraham
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21551: mobile: Thumbnails: improve placement of searchField and label

[Jonah Brüchert]

jbbgameich added a comment.


  Before: F6866125: image.png 
  After:  F6866141: image.png 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21551

To: jbbgameich, #okular
Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=408222

--- Comment #7 from yousifjka...@yahoo.com ---
Created attachment 120518
  --> https://bugs.kde.org/attachment.cgi?id=120518=edit
test-1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=408222

--- Comment #8 from yousifjka...@yahoo.com ---
Created attachment 120519
  --> https://bugs.kde.org/attachment.cgi?id=120519=edit
test-2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=408222

--- Comment #6 from yousifjka...@yahoo.com ---
Hi.Sorry for delay in response, it was at night in my country & I went to sleep
just after posting this bug.

Dear, I attach 2 PDF files, each composed from single page. In each page (each
PDF file) there are:

- pictures
- Arabic characters
- English characters

If you can not evaluate Arabic, then please look carefully for both pictures &
English paragraphs. Please concentrate on BLACK TONE.

If you concentrate well, you will noticed that black tone (DENSITY OF BLACK) is
lower in Okular than Evence. So, picture in Okular less in dexterity than
Evince.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408102] After every Plasma update the toolbar configuration is lost

[Sete]

https://bugs.kde.org/show_bug.cgi?id=408102

--- Comment #4 from Sete  ---
I will report it in the Manjaro website.
Thanks a lot!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15580: New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  There is a TODO list of the working and planned feature on task T8076 
. Some of your suggestions are already there 
and I added the missing one. I have updated the description of this review to 
point to that TODO for better clarity.
  
  In D15580#473460 , @ngraham wrote:
  
  > getting there!
  >
  > UI review of the latest version:
  >
  > - Having the annotation tools on the main toolbar makes it overflow for all 
but the largest window sizes. How about putting them in a secondary toolbar 
below the main one that's hidden until the user shows it by clicking on a "Show 
annotation tools" item on the main toolbar and/or menubar?
  
  
  Already in TODO
  
  > - The Line width dropdown menu button should make the whole button 
clickable to show the drop-down rather than only the space under the arrow on 
the right
  
  Added to TODO
  
  > - The entries in the Line width dropdown should visually reflect the width 
of the line. Could these graphics be generated programmatically rather than 
using icons?
  
  Added to TODO
  
  > - Squiggle and Arrow need new icons; please file a bug on Breeze | Icons 
and request them
  
  Already in TODO. (I was waiting before requesting icons to see if I managed 
to get something working :-) )
  
  > - The `draw-polygon` icon might make it seem like that tool can only draw 
pentagons, consider using `draw_polyline` or `draw-polygon-star` instead
  
  I'll set it to draw_polyline
  
  > - The Color button should actually show the current color rather than a 
generic icon
  
  This should already work.
  
  > - The Inner color button needs something to show that it exists; right now 
it just looks like whitespace in the toolbar. It should show its color like the 
other button, and for "no color", maybe an empty transparent square?
  
  Also the icons of color and inner color need to be done from scratch. I was 
thinking at a circle fillable with the current color and a border to show it 
exists.
  
  > - Straight Line is mis-named, it's for drawing anything //but// a straight 
line! :) Should be something like "Freehand line"
  
  Have you removed .config/okularpartrc ? Otherwise the toolbar picks up the 
annotation in you custom orders and the buttons are mismatched.
  
  > - I can't figure out what Pin Annotation actually does
  
  If checked the current annotation tool is kept selected after use (as 
double-click does in the current Okular). Needs a better name/tooltip. Added to 
TODO.
  
  > - It's not clear to me how to select existing annotations once an 
annotation tool has been activated; consider maybe adding a "select 
annotations" tool or mode under the Selection dropdown menu.
  
  Currently you need to click Esc to deselect the annotation, then you can 
select the annotations (standard Browse mode). If instead 'pin annotation' is 
unchecked, the annotation is deselected automatically and you can select 
annotation. Beside the fact that clicking on an annotation does not select it 
(added to TODO) and that selecting and annotation does not switch to Browse 
mode (added to TODO), it works as the current version of Okular. I think we do 
not need a dedicated Selection tool.
  
  In D15580#473460 , @ngraham wrote:
  
  > getting there!
  >
  > UI review of the latest version:
  >
  > - Having the annotation tools on the main toolbar makes it overflow for all 
but the largest window sizes. How about putting them in a secondary toolbar 
below the main one that's hidden until the user shows it by clicking on a "Show 
annotation tools" item on the main toolbar and/or menubar?
  > - The Line width dropdown menu button should make the whole button 
clickable to show the drop-down rather than only the space under the arrow on 
the right
  > - The entries in the Line width dropdown should visually reflect the width 
of the line. Could these graphics be generated programmatically rather than 
using icons?
  > - Squiggle and Arrow need new icons; please file a bug on Breeze | Icons 
and request them
  > - The `draw-polygon` icon might make it seem like that tool can only draw 
pentagons, consider using `draw_polyline` or `draw-polygon-star` instead
  > - The Color button should actually show the current color rather than a 
generic icon
  > - The Inner color button needs something to show that it exists; right now 
it just looks like whitespace in the toolbar. It should show its color like the 
other button, and for "no color", maybe an empty transparent square?
  > - Straight Line is mis-named, it's for drawing anything //but// a straight 
line! :) Should be something like "Freehand line"
  > - I can't figure out what Pin Annotation actually does
  > - It's not clear to me how to select existing annotations once an 
annotation tool has been activated; consider maybe adding a "select 
annotations" tool or mode under the 

D15580: New annotation toolbar

[Simone Gaiarin]

simgunz edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, 
darcyshen, aacid