D15580: New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  In D15580#481323 , @davidhurka 
wrote:
  
  > Don’t have UI feedback that asks for action already in this patch. :)
  >
  > In D15580#481270 , @simgunz 
wrote:
  >
  > > F6902170: Screenshot_20190617_165440.png 

  >
  >
  >
  >
  > - Maybe the 4 left buttons should indicate that they require further action 
(drawing). Currently they look like buttons in a word processor, where you have 
to select the text first. *1) Using the existing dynamic annotation icons might 
look better, as soon as someone made them more low-resolution friently.
  
  
  I am more in favor of using standard breeze icons for the annotation tools. I 
opened a bug to ask for the icons 
(https://bugs.kde.org/show_bug.cgi?id=408283), so we can ask for a specific 
design that make them understandable.
  
  > 
  > 
  > - The first two separators look a bit like only the first four buttons are 
annotation tools, and the next 3+2 buttons are just options. I. e. there is not 
a mutually exclusion between the 4+3+2 buttons, but only between the 4, 3, and 
2 individually. Maybe it’s better to group them not with separators, but with 
ToolActions/ToggleActionMenus. Could be tested later by customizing the toolbar 
via Configure Toolbars.
  
  I agree in removing the separators.
  
  > *1) Maybe an interesting idea: Select some text in Text Selection mode, 
then just click the annotation button.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, fbampaloukas, joaonetto, tfella, darcyshen

[okular] [Bug 408683] blank page until I scroll

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=408683

--- Comment #3 from Albert Astals Cid  ---
Do you have a hidpi screen?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408849] okular crashes scrolling through certain pdf

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=408849

Tobias Deiminger  changed:

   What|Removed |Added

 CC||haxti...@posteo.de
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Tobias Deiminger  ---
I can't cause a crash by simply scrolling. However, a crash happens
reproducible when right-clicking the "Protrusion" link on left margin of page
4, using latest okular and poppler master, with backtrace as follows:

Thread 1 "okular" received signal SIGSEGV, Segmentation fault.
0x7fffe6a99989 in PageView::createProcessLinkMenu(PageViewItem*, QPoint
const&) () from ./okularpart.so
(gdb) bt
#0  0x7fffe6a99989 in PageView::createProcessLinkMenu(PageViewItem*, QPoint
const&) () from ./okularpart.so
#1  0x7fffe6a8eaee in PageView::mouseReleaseEvent(QMouseEvent*) () from
./okularpart.so
#2  0x757a8f98 in QWidget::event(QEvent*) () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#3  0x7584aaee in QFrame::event(QEvent*) () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#4  0x7fffe6a93a43 in PageView::viewportEvent(QEvent*) () from
./okularpart.so
#5  0x74cfa2dd in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) ()
from /home/tobias/kde/qt5/lib/libQt5Core.so.5
#6  0x7576a3d5 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#7  0x75772567 in QApplication::notify(QObject*, QEvent*) () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#8  0x74cfa558 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /home/tobias/kde/qt5/lib/libQt5Core.so.5
#9  0x75770eb2 in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) ()
   from /home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#10 0x757c4113 in ?? () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#11 0x757c6729 in ?? () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#12 0x7576a3fc in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#13 0x757719cf in QApplication::notify(QObject*, QEvent*) () from
/home/tobias/kde/qt5/lib/libQt5Widgets.so.5
#14 0x74cfa558 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /home/tobias/kde/qt5/lib/libQt5Core.so.5
#15 0x751033db in
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
()
   from /home/tobias/kde/qt5/lib/libQt5Gui.so.5
#16 0x75104f55 in
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)
()
   from /home/tobias/kde/qt5/lib/libQt5Gui.so.5
#17 0x750ddc3b in
QWindowSystemInterface::sendWindowSystemEvents(QFlags)
()
   from /home/tobias/kde/qt5/lib/libQt5Gui.so.5
#18 0x7fffe90a88eb in ?? ()
   from
/media/tobias/edf72459-168b-43b6-b35a-f2b198488c25/tobias/Dev/OSScontrib/kde/qt5/plugins/platforms/../../lib/libQt5XcbQpa.so.5
#19 0x74cf888a in
QEventLoop::exec(QFlags) () from
/home/tobias/kde/qt5/lib/libQt5Core.so.5
#20 0x74d01a40 in QCoreApplication::exec() () from
/home/tobias/kde/qt5/lib/libQt5Core.so.5
#21 0x5556197c in main ()

I'm setting this to confirmed, but note that in worst case you and me saw two
unrelated issues with the same document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Vasyl Teliman]

https://bugs.kde.org/show_bug.cgi?id=408818

Vasyl Teliman  changed:

   What|Removed |Added

Version|unspecified |1.7.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Vasyl Teliman]

https://bugs.kde.org/show_bug.cgi?id=408818

--- Comment #6 from Vasyl Teliman  ---
By the way, I've failed to mention here that it'd worked OK until I've decided
to update KDE to 5.16.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Vasyl Teliman]

https://bugs.kde.org/show_bug.cgi?id=408818

--- Comment #5 from Vasyl Teliman  ---
Created attachment 120959
  --> https://bugs.kde.org/attachment.cgi?id=120959&action=edit
The file that causes this crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Vasyl Teliman]

https://bugs.kde.org/show_bug.cgi?id=408818

--- Comment #4 from Vasyl Teliman  ---
(In reply to Elvis Angelaccio from comment #3)
> No need to, I changed the product of this one. :)

I'm sorry again. It seems I've already sent one :). Here is a link (you might
want to mark it as duplicate): https://bugs.kde.org/show_bug.cgi?id=408851

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=408818

Elvis Angelaccio  changed:

   What|Removed |Added

Product|ark |okular
  Component|general |general
   Assignee|elvis.angelac...@kde.org|okular-devel@kde.org

--- Comment #3 from Elvis Angelaccio  ---
No need to, I changed the product of this one. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408851] New: Crash when trying to open *.fb2 file

[Vasyl Teliman]

https://bugs.kde.org/show_bug.cgi?id=408851

Bug ID: 408851
   Summary: Crash when trying to open *.fb2 file
   Product: okular
   Version: 1.7.2
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: vasnik...@gmail.com
  Target Milestone: ---

Application: okular (1.7.2)

Qt Version: 5.12.3
Frameworks Version: 5.59.0
Operating System: Linux 4.15.0-51-generic x86_64
Distribution: KDE neon User Edition 5.16

-- Information about the crash:
- What I was doing when the application crashed:
I was trying to open *.fb2 file when the app crashed. It worked smoothly before
I updated KDE to 5.16.0

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f1d46fb6200 (LWP 2255))]

Thread 4 (Thread 0x7f1d1ad3a700 (LWP 2258)):
#0  0x7f1d3f9bd9f3 in futex_wait_cancelable (private=,
expected=0, futex_word=0x55e86aa1cab8) at
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x55e86aa1ca68,
cond=0x55e86aa1ca90) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x55e86aa1ca90, mutex=0x55e86aa1ca68) at
pthread_cond_wait.c:655
#3  0x7f1d1b9d8dcb in ?? () from /usr/lib/x86_64-linux-gnu/dri/i965_dri.so
#4  0x7f1d1b9d8af7 in ?? () from /usr/lib/x86_64-linux-gnu/dri/i965_dri.so
#5  0x7f1d3f9b76db in start_thread (arg=0x7f1d1ad3a700) at
pthread_create.c:463
#6  0x7f1d42c2188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 3 (Thread 0x7f1d2c481700 (LWP 2257)):
#0  0x7f1d42c14bf9 in __GI___poll (fds=0x7f1d24004db0, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7f1d3d6864c9 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f1d3d6865dc in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f1d43557dcb in QEventDispatcherGlib::processEvents
(this=0x7f1d24000b20, flags=...) at kernel/qeventdispatcher_glib.cpp:424
#4  0x7f1d434f903a in QEventLoop::exec (this=this@entry=0x7f1d2c480d70,
flags=..., flags@entry=...) at kernel/qeventloop.cpp:225
#5  0x7f1d433204ca in QThread::exec (this=) at
thread/qthread.cpp:531
#6  0x7f1d439c6015 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#7  0x7f1d43321c72 in QThreadPrivate::start (arg=0x7f1d43c3dd80) at
thread/qthread_unix.cpp:361
#8  0x7f1d3f9b76db in start_thread (arg=0x7f1d2c481700) at
pthread_create.c:463
#9  0x7f1d42c2188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7f1d351f3700 (LWP 2256)):
#0  0x7f1d42c14bf9 in __GI___poll (fds=0x7f1d351f2ca8, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7f1d4043a747 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#2  0x7f1d4043c36a in xcb_wait_for_event () from
/usr/lib/x86_64-linux-gnu/libxcb.so.1
#3  0x7f1d37fda578 in QXcbEventQueue::run (this=0x55e86a4ac660) at
qxcbeventqueue.cpp:228
#4  0x7f1d43321c72 in QThreadPrivate::start (arg=0x55e86a4ac660) at
thread/qthread_unix.cpp:361
#5  0x7f1d3f9b76db in start_thread (arg=0x7f1d351f3700) at
pthread_create.c:463
#6  0x7f1d42c2188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 1 (Thread 0x7f1d46fb6200 (LWP 2255)):
[KCrash Handler]
#6  0x7f1d2aa2beef in std::__atomic_base::load
(__m=std::memory_order_relaxed, this=0x888389482a74d1) at
/usr/include/c++/7/bits/atomic_base.h:396
#7  QAtomicOps::load (_q_value=...) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qatomic_cxx11.h:227
#8  QBasicAtomicInteger::load (this=0x888389482a74d1) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qbasicatomic.h:103
#9  QtPrivate::RefCount::isShared (this=0x888389482a74d1) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qrefcount.h:101
#10 QLinkedList::detach (this=0x7f1d43593240
) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qlinkedlist.h:106
#11 QLinkedList::append (this=this@entry=0x7f1d43593240
, t=@0x7fff1710cb30:
0x55e86aba9db0) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlinkedlist.h:394
#12 0x7f1d2aa32348 in
Okular::TextDocumentGenerator::loadDocumentWithPassword (this=,
fileName=..., pagesVector=..., password=...) at
./core/textdocumentgenerator.cpp:342
#13 0x7f1d2aa0c05a in Okular::DocumentPrivate::openDocumentInternal
(this=0x55e86a5b7180, offer=..., isstdin=isstdin@entry=false, docFile=...,
filedata=..., password=...) at ./core/document.cpp:875
#14 0x7f1d2aa0c6fd in Okular::Document::openDocument
(this=this@entry=0x55e86a5ad6c0, docFile=..., url=..., _mime=..., password=...)
at ./core/document.cpp:2443
#15 0x7f1d2ad396db in Okular::Part::doOpenFile
(this=this@entry=0x55e86a573e70, mimeA=..., fileNameToOpen

[okular] [Bug 408849] New: okular crashes scrolling through certain pdf

[Peter Hedwig]

https://bugs.kde.org/show_bug.cgi?id=408849

Bug ID: 408849
   Summary: okular crashes scrolling through certain pdf
   Product: okular
   Version: 1.7.2
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: peter.hed...@web.de
  Target Milestone: ---

Application: okular (1.7.2)

Qt Version: 5.12.3
Frameworks Version: 5.59.0
Operating System: Linux 5.1.10-050110-generic x86_64
Distribution: KDE neon User Edition 5.16

-- Information about the crash:
- What I was doing when the application crashed:

1. open https://ctan.kako-dev.de/macros/latex/contrib/microtype/microtype.pdf
with okular
2. scroll through the pdf and expect a crash at around page 3

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f0a1310a200 (LWP 6405))]

Thread 20 (Thread 0x7f09c9216700 (LWP 6436)):
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x7f0a0f4a3f75 in QtLinuxFutex::_q_futex (val3=0, addr2=0x0, val2=0,
val=3, op=0, addr=) at thread/qfutex_p.h:92
#2  QtLinuxFutex::futexWait >
(expectedValue=, futex=...) at thread/qfutex_p.h:107
#3  lockInternal_helper (timeout=-1, elapsedTimer=0x0, d_ptr=...) at
thread/qmutex_linux.cpp:142
#4  QBasicMutex::lockInternal (this=0x55e2e365e5f0) at
thread/qmutex_linux.cpp:159
#5  0x7f0a0f4a415b in QMutex::lock (this=) at
thread/qmutex.cpp:227
#6  0x7f09e009957b in PDFGenerator::textPage (this=0x55e2e335b720,
request=0x55e2e3ff5f90) at ./generators/poppler/generator_pdf.cpp:1301
#7  0x7f09f6d09915 in Okular::TextPageGenerationThread::run
(this=0x55e2e3ff5f70) at ./core/generator_p.cpp:131
#8  0x7f0a0f4a3c72 in QThreadPrivate::start (arg=0x55e2e3ff5f70) at
thread/qthread_unix.cpp:361
#9  0x7f0a0bb3a6db in start_thread (arg=0x7f09c9216700) at
pthread_create.c:463
#10 0x7f0a0eda388f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 19 (Thread 0x7f09a6c1d700 (LWP 6435)):
[KCrash Handler]
#6  QVariant::clear (this=this@entry=0x7f0926c1cb28) at
kernel/qvariant.cpp:2400
#7  0x7f0a0f6c23b8 in QVariant::operator= (this=0x7f0926c1cb28,
variant=...) at kernel/qvariant.cpp:2335
#8  0x7f09f6cbd18d in Okular::Action::setNativeId
(this=this@entry=0x7f09900284c0, id=...) at ./core/action.cpp:57
#9  0x7f09e0096c57 in createLinkFromPopplerLink
(popplerLink=popplerLink@entry=0x7f09900284c0, deletePopplerLink=false,
deletePopplerLink@entry=true) at ./generators/poppler/generator_pdf.cpp:508
#10 0x7f09e0097a15 in generateLinks (popplerLinks=...) at
./generators/poppler/generator_pdf.cpp:563
#11 0x7f09e009b740 in PDFGenerator::image (this=0x55e2e335b720,
request=0x55e2e3cd3480) at ./generators/poppler/generator_pdf.cpp:1194
#12 0x7f09f6d0a195 in Okular::PixmapGenerationThread::run
(this=0x55e2e335ead0) at ./core/generator_p.cpp:62
#13 0x7f0a0f4a3c72 in QThreadPrivate::start (arg=0x55e2e335ead0) at
thread/qthread_unix.cpp:361
#14 0x7f0a0bb3a6db in start_thread (arg=0x7f09a6c1d700) at
pthread_create.c:463
#15 0x7f0a0eda388f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 18 (Thread 0x7f09ca7fc700 (LWP 6422)):
#0  0x7f0a0bb409f3 in futex_wait_cancelable (private=,
expected=0, futex_word=0x55e2e2e81d80) at
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x55e2e2e81d30,
cond=0x55e2e2e81d58) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x55e2e2e81d58, mutex=0x55e2e2e81d30) at
pthread_cond_wait.c:655
#3  0x7f09e7b1b85b in ?? () from
/usr/lib/x86_64-linux-gnu/dri/radeonsi_dri.so
#4  0x7f09e7b1b457 in ?? () from
/usr/lib/x86_64-linux-gnu/dri/radeonsi_dri.so
#5  0x7f0a0bb3a6db in start_thread (arg=0x7f09ca7fc700) at
pthread_create.c:463
#6  0x7f0a0eda388f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 17 (Thread 0x7f09caffd700 (LWP 6421)):
#0  0x7f0a0bb409f3 in futex_wait_cancelable (private=,
expected=0, futex_word=0x55e2e2e81d80) at
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x55e2e2e81d30,
cond=0x55e2e2e81d58) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x55e2e2e81d58, mutex=0x55e2e2e81d30) at
pthread_cond_wait.c:655
#3  0x7f09e7b1b85b in ?? () from
/usr/lib/x86_64-linux-gnu/dri/radeonsi_dri.so
#4  0x7f09e7b1b457 in ?? () from
/usr/lib/x86_64-linux-gnu/dri/radeonsi_dri.so
#5  0x7f0a0bb3a6db in start_thread (arg=0x7f09caffd700) at
pthread_create.c:463
#6  0x7f0a0eda388f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 16 (Thread 0x7f09cb7fe700 (LWP 6420)):
#0  0x7f0a0bb409f3 in futex_wait_cancelabl

D15580: New annotation toolbar

[David Hurka]

davidhurka added a comment.


  Don’t have UI feedback that asks for action already in this patch. :)
  
  In D15580#481270 , @simgunz wrote:
  
  > F6902170: Screenshot_20190617_165440.png 

  
  
  
  
  - Maybe the 4 left buttons should indicate that they require further action 
(drawing). Currently they look like buttons in a word processor, where you have 
to select the text first. *1) Using the existing dynamic annotation icons might 
look better, as soon as someone made them more low-resolution friently.
  
  - The first two separators look a bit like only the first four buttons are 
annotation tools, and the next 3+2 buttons are just options. I. e. there is not 
a mutually exclusion between the 4+3+2 buttons, but only between the 4, 3, and 
2 individually. Maybe it’s better to group them not with separators, but with 
ToolActions/ToggleActionMenus. Could be tested later by customizing the toolbar 
via Configure Toolbars.
  
  *1) Maybe an interesting idea: Select some text in Text Selection mode, then 
just click the annotation button.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, fbampaloukas, joaonetto, tfella, darcyshen

D15580: New annotation toolbar

[Simone Gaiarin]

simgunz updated this revision to Diff 60004.
simgunz added a comment.


  - Fix and simplify width action
  - Fix and simplify opacity action
  - Fix annotation tools actions
  - Rename color action
  - Formatting

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15580?vs=59954&id=60004

BRANCH
  annotation-toolbar-stable

REVISION DETAIL
  https://phabricator.kde.org/D15580

AFFECTED FILES
  CMakeLists.txt
  conf/dlgannotations.cpp
  conf/dlgannotationsbase.ui
  conf/okular.kcfg
  part.rc
  ui/annotationactionhandler.cpp
  ui/annotationactionhandler.h
  ui/data/tools.xml
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewannotator.cpp
  ui/pageviewannotator.h
  ui/pageviewutils.cpp
  ui/pageviewutils.h
  ui/toolaction.cpp

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, fbampaloukas, joaonetto, tfella, darcyshen

D21195: [RFC] Create a Change Colors menu (with toolbar button)

[David Hurka]

davidhurka edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21195

To: davidhurka, #okular, #vdg
Cc: GB_2, davidre, aacid, ngraham, okular-devel, fbampaloukas, joaonetto, 
tfella, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[Simone Gaiarin]

simgunz added a comment.


  In D21755#481293 , @davidhurka 
wrote:
  
  > In D21755#481269 , @simgunz 
wrote:
  >
  > > Currently I am using ToolAction in the new annotation toolbar to selected 
among different geometrical annotation. [...]
  > >  For this purpose I need that the action are checkable, and that the 
ToggleActionMenu is checkable displaying the selected action (exaclty as 
ToolAction).
  > >
  > > [...] For my use case, I would probably need to be able to display 
tooltips for each action in the ToggleActionMenu, to describe what they are.
  > >
  > > [...] I need to use it for Geometrical annotations and for the Stamp 
annotation. For this last one I would need to display the different available 
stamps, so each action in the ToggleActionMenu should just be a checkable 
action with a full width image and no text. [...]
  >
  >
  > Maybe it’s better to use a KSelectAction directly? Not sure whether it 
shows the current selection on the toolbar button, but probably it does so in 
combobox mode.
  >
  > For the stamps, you probably need a combobox with a custom item view.
  
  
  The problem of KSelectAction is that in ComboBoxMode it looks pretty ugly and 
does not show the checked Action. My guess is that this is the reason why 
ToolAction was created in the first place.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka updated this revision to Diff 60002.
davidhurka added a comment.


  - Add license headers
  
  Is this correct?

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21755?vs=59958&id=60002

BRANCH
  create-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21755

AFFECTED FILES
  CMakeLists.txt
  ui/pageview.cpp
  ui/toggleactionmenu.cpp
  ui/toggleactionmenu.h
  ui/toolaction.cpp
  ui/toolaction.h

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka edited the summary of this revision.
davidhurka edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka added a comment.


  In D21755#481269 , @simgunz wrote:
  
  > Currently I am using ToolAction in the new annotation toolbar to selected 
among different geometrical annotation. [...]
  >  For this purpose I need that the action are checkable, and that the 
ToggleActionMenu is checkable displaying the selected action (exaclty as 
ToolAction).
  >
  > [...] For my use case, I would probably need to be able to display tooltips 
for each action in the ToggleActionMenu, to describe what they are.
  >
  > [...] I need to use it for Geometrical annotations and for the Stamp 
annotation. For this last one I would need to display the different available 
stamps, so each action in the ToggleActionMenu should just be a checkable 
action with a full width image and no text. [...]
  
  
  Maybe it’s better to use a KSelectAction directly? Not sure whether it shows 
the current selection on the toolbar button, but probably it does so in 
combobox mode.
  
  For the stamps, you probably need a combobox with a custom item view.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen

[okular] [Bug 408837] New: Okular crash when opening PDF from Firefox

[George Stevenson]

https://bugs.kde.org/show_bug.cgi?id=408837

Bug ID: 408837
   Summary: Okular crash when opening PDF from Firefox
   Product: okular
   Version: 1.7.2
  Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: em...@georgestevenson.co.za
  Target Milestone: ---

Application: okular (1.7.2)

Qt Version: 5.12.3
Frameworks Version: 5.59.0
Operating System: Linux 4.18.0-21-generic x86_64
Distribution: KDE neon User Edition 5.16

-- Information about the crash:
- What I was doing when the application crashed:
Click to download a pdf document from Google Drive (in Firefox). Rather than
save the pdf, select Open and select Okular from list of apps. Okular opens but
immediately crash again. Tried multiple times.

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f0c80581200 (LWP 21434))]

Thread 4 (Thread 0x7f0c545cd700 (LWP 21447)):
#0  0x7f0c78f8d9f3 in futex_wait_cancelable (private=,
expected=0, futex_word=0x5648a8cd1c28) at
../sysdeps/unix/sysv/linux/futex-internal.h:88
#1  __pthread_cond_wait_common (abstime=0x0, mutex=0x5648a8cd1bd8,
cond=0x5648a8cd1c00) at pthread_cond_wait.c:502
#2  __pthread_cond_wait (cond=0x5648a8cd1c00, mutex=0x5648a8cd1bd8) at
pthread_cond_wait.c:655
#3  0x7f0c5512adcb in ?? () from /usr/lib/x86_64-linux-gnu/dri/i965_dri.so
#4  0x7f0c5512aaf7 in ?? () from /usr/lib/x86_64-linux-gnu/dri/i965_dri.so
#5  0x7f0c78f876db in start_thread (arg=0x7f0c545cd700) at
pthread_create.c:463
#6  0x7f0c7c1f188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 3 (Thread 0x7f0c65c35700 (LWP 21436)):
#0  0x7f0c76c533d2 in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#1  0x7f0c76c55963 in g_main_context_prepare () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f0c76c563fb in ?? () from /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f0c76c565dc in g_main_context_iteration () from
/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
#4  0x7f0c7cb27dcb in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f0c7cac903a in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#6  0x7f0c7c8f04ca in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#7  0x7f0c7cf96015 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
#8  0x7f0c7c8f1c72 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#9  0x7f0c78f876db in start_thread (arg=0x7f0c65c35700) at
pthread_create.c:463
#10 0x7f0c7c1f188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 2 (Thread 0x7f0c6e8f5700 (LWP 21435)):
#0  0x7f0c7c1e4bf9 in __GI___poll (fds=0x7f0c6e8f4ca8, nfds=1, timeout=-1)
at ../sysdeps/unix/sysv/linux/poll.c:29
#1  0x7f0c79a0a747 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
#2  0x7f0c79a0c36a in xcb_wait_for_event () from
/usr/lib/x86_64-linux-gnu/libxcb.so.1
#3  0x7f0c716dc578 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#4  0x7f0c7c8f1c72 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#5  0x7f0c78f876db in start_thread (arg=0x7f0c6e8f5700) at
pthread_create.c:463
#6  0x7f0c7c1f188f in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Thread 1 (Thread 0x7f0c80581200 (LWP 21434)):
[KCrash Handler]
#6  SECMOD_ReferenceModule (module=0x0) at pk11util.c:847
#7  0x7f0c531a6c8c in SECMOD_AddModule (newModule=0x5648a9134f80) at
pk11util.c:541
#8  0x7f0c531a6d30 in SECMOD_AddNewModuleEx (moduleName=0x7f0c536b108d
"Root Certs", dllPath=0x7f0c536b107f "libnssckbi.so", defaultMechanismFlags=0,
cipherEnableFlags=0, modparms=, nssparms=) at
pk11util.c:695
#9  0x7f0c5365f8fe in SignatureHandler::init_nss() () from
/usr/lib/x86_64-linux-gnu/libpoppler.so.73
#10 0x7f0c5365fc99 in SignatureHandler::SignatureHandler(unsigned char*,
int) () from /usr/lib/x86_64-linux-gnu/libpoppler.so.73
#11 0x7f0c53581c25 in FormFieldSignature::validateSignature(bool, bool,
long) () from /usr/lib/x86_64-linux-gnu/libpoppler.so.73
#12 0x7f0c53970d55 in Poppler::FormFieldSignature::validate(int, QDateTime
const&) const () from /usr/lib/x86_64-linux-gnu/libpoppler-qt5.so.1
#13 0x7f0c5397119f in
Poppler::FormFieldSignature::validate(Poppler::FormFieldSignature::ValidateOptions)
const () from /usr/lib/x86_64-linux-gnu/libpoppler-qt5.so.1
#14 0x7f0c53bbf240 in PopplerFormFieldSignature::PopplerFormFieldSignature
(this=0x5648a90e5680, field=0x5648a90e57b0) at
./generators/poppler/formfields.cpp:387
#15 0x7f0c53bb9626 in PDFGenerator::addFormFields
(this=this@entry=0x5648a90979f0, 

[okular] [Bug 408834] New: okular (file name) gives error pointing to KDE connect although that is not in use

[rkeating]

https://bugs.kde.org/show_bug.cgi?id=408834

Bug ID: 408834
   Summary: okular (file name) gives error pointing to KDE connect
although that is not in use
   Product: okular
   Version: 1.7.2
  Platform: Kubuntu Packages
OS: Linux
Status: REPORTED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: rqkeat...@gmail.com
  Target Milestone: ---

SUMMARY
Running okular on the command line followed by an image name gives an error
about KDE connect.  I don't even use KDE connect.  This started when I updated
to Plasma 5.16 via the Kubuntu backports.

STEPS TO REPRODUCE
1. On the command line run: "okular myfile.jpg" 

OBSERVED RESULT
The following error comes out:

org.kde.kcoreaddons: Expected JSON property "X-Purpose-PluginTypes" to be a
single string. but it is a stringlist
discarding "Send SMS via KDE Connect..." "ShareUrl"

Then the picture is displayed on screen.

EXPECTED RESULT
No error message.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 19.04 with KDE Plasma desktop
(available in About System)
KDE Plasma Version: 5.16.0
KDE Frameworks Version: 5.59.0
Qt Version: 5.12.2

ADDITIONAL INFORMATION

This started when I updated to Plasma 5.16 from the Kubuntu backports.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D15580: New annotation toolbar

[Simone Gaiarin]

simgunz added a comment.


  Favorite annotations:
  The Star adds the currently selected tool to the favorite list, the bookmark 
symbol displays the list of the favorite tools:
  F6902170: Screenshot_20190617_165440.png 

  
  Customize the favorite tools:
  F6902180: Screenshot_20190617_165644.png 

  
  Opacity selector:
  Activates on click and displays a list of possible opacities with an icon:
  F6902184: Screenshot_20190617_165734.png 


REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, 
okular-devel, fbampaloukas, joaonetto, tfella, darcyshen

D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[Simone Gaiarin]

simgunz added a comment.


  In D21755#480908 , @davidhurka 
wrote:
  
  > From my point of view, this is complete now. 3 TODOs left (see revision 
description at the top).
  >
  > ToolAction used its own tooltip for the toolbar buttons. Tell me if that is 
still needed.
  >
  > @simgunz you just told that you will use ToolAction? If you show me your 
implementation, it’s ok for me to use that instead. Otherwise you can tell me 
what you need (tooltips?). :)
  
  
  Currently I am using ToolAction in the new annotation toolbar to selected 
among different geometrical annotation. ToolAction is placed in the toolbar and 
behaves as it behave for the mouse selection tools. I think that replacing it 
with your more general tool is a good thing.
  For this purpose I need that the action are checkable, and that the 
ToggleActionMenu is checkable displaying the selected action (exaclty as 
ToolAction).
  
  I did remove the tooltip from ToolAction because it was broken: the tooltip 
was displayed when hoovering over the ToolAction while it was selected, and a 
different less informative tooltip was displayed when not selected. Moreover 
the tooltip was about holding the button, thing that now has been removed if I 
am not wrong. For my use case, I would probably need to be able to display 
tooltips for each action in the ToggleActionMenu, to describe what they are.
  
  If ToggleActionMenu provides the same functionality that ToolAction was 
providing I can use it without problems. I need to use it for Geometrical 
annotations and for the Stamp annotation. For this last one I would need to 
display the different available stamps, so each action in the ToggleActionMenu 
should just be a checkable action with a full width image and no text. Still 
not sure how to do this. Maybe I just need to create a custom QWidgetAction to 
represent the stamp, and than this action can be plugged into the 
ToggleActionMenu. Need to think about it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, 
ngraham, darcyshen