[okular] [Bug 409345] Okular crashes on opening menu
https://bugs.kde.org/show_bug.cgi?id=409345 --- Comment #2 from Christoph Feck --- Qt 5.13.0 regression? -- You are receiving this mail because: You are the assignee for the bug.
Re: How to select a sidebar item when the sidebar is collapsed in autotests/parttest
El dimarts, 2 de juliol de 2019, a les 0:52:42 CEST, Mayank Choudhary va escriure: > Hello, > > I'm writing an autotest in parttest.cpp where initially when the part is > opened, the sidebar is collapsed. Now I need to click on thumbnails item > (say) in order to open it. How can I? What would the user do? Click on it, right? So the test should ideally do the same by using QTest::mouseClick Cheers, Albert
How to select a sidebar item when the sidebar is collapsed in autotests/parttest
Hello, I'm writing an autotest in parttest.cpp where initially when the part is opened, the sidebar is collapsed. Now I need to click on thumbnails item (say) in order to open it. How can I? I tried part.m_sidebar->setCurrentItem(thumbsbox) but as thumbsbox is declared in Part ctor, I'm unable to use it in autotest. Please help. Thanks Mayank
[okular] [Bug 407998] Okular scales down pages when printing
https://bugs.kde.org/show_bug.cgi?id=407998 --- Comment #13 from Sergio --- Bad news: as of Okular 1.7.2 it is possible to require no scaling by also asking for rasterization, but unfortunately this causes the page to get printed with a significant offset to the right. Sending the page to the printer with lp does not cause the issue. I do not know if this is already fixed given the progress that is being reported in this thread in the area. Please let me know if I should open another bug for this issue. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 409345] Okular crashes on opening menu
https://bugs.kde.org/show_bug.cgi?id=409345 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Resolution|--- |NOT A BUG Status|REPORTED|RESOLVED --- Comment #1 from Albert Astals Cid --- Your system is broken, this is not an okular bug. Please seek advise in opensuse help system. -- You are receiving this mail because: You are the assignee for the bug.
D22118: Shifts focus to the document when collapsing a sidebar view
aacid added a comment. can we get an autotest so we don't regress in the future? Seems like it should be ultra hard? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, darcyshen, aacid
D22118: Shifts focus to the document when collapsing a sidebar view
mayankchoudhary added a comment. Please before the merge commit, change my username to "Mayank Choudhary". REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, darcyshen, aacid
D22145: Add "Open Containing Folder" feature
davidhurka added a comment.
How does it work when the document is not local, or is deleted?
E. g. do
okular https://20years.kde.org/book/20yearsofKDE.pdf
INLINE COMMENTS
> part.cpp:3711
> +{
> +KIO::highlightInFileManager( {realUrl()} );
> +}
Did someone test this with an encrypted PDF file?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D22145
To: ngraham, #okular, aacid, sander
Cc: davidhurka, okular-devel, maguirre, fbampaloukas, joaonetto, tfella,
ngraham, darcyshen, aacid
D22118: Shifts focus to the document when collapsing a sidebar view
mayankchoudhary added a comment. @aacid May you please review this ? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D22118 To: mayankchoudhary, #okular, aacid, sander, ngraham Cc: ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, darcyshen, aacid
[okular] [Bug 383943] HiDPI: Rendering glitches near the page boundaries
https://bugs.kde.org/show_bug.cgi?id=383943 Oliver Sander changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #5 from Oliver Sander --- This issue was closed by accident with Comment 2. However, the patch mentioned there does not actually fix the problem. The commits that lead to Comment 3 and Comment 4 do fix the issue, but note that they are on a feature branch, not on master. Hence, the issue is still open, but there is a patch at https://invent.kde.org/kde/okular/merge_requests/6. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 383943] HiDPI: Rendering glitches near the page boundaries
https://bugs.kde.org/show_bug.cgi?id=383943 Oliver Sander changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |okular/commit/c73de7e6a1937 |okular/commit/dec6923c56a99 |05de2ae06772d799eadfec9842f |dc7bdf59c890c0ee310fb12fc23 --- Comment #4 from Oliver Sander --- Git commit dec6923c56a99dc7bdf59c890c0ee310fb12fc23 by Oliver Sander. Committed on 01/07/2019 at 12:12. Pushed by sander into branch 'fix-bug-383943-hidpi-glitches'. Make page boundary rendering more robust Okular renders a simple 'shadow' at the right and the bottom of each page. The code for this is a bit fragile: After the page is rendered, Okular paints a black outline, and then the shadow. The shadow is a hand-implemented gradient, painted line by line. Finally, the remaining area is painted in the background color. No pixel is ever touched twice. Unfortunately, the code is buggy, and in hidpi / fractional scaling situations, some pixels are never touched. This results in rendering glitches as reported in https://bugs.kde.org/show_bug.cgi?id=383943 Instead of trying to fix the previous approach, this patch makes the code more robust by changing the order of the painting operations. After painting the page, the code now first paints the background, which is now enlarged to cover everything off the page. Finally, the black outline and shadow are drawn on the previously drawn background. This makes sures that no pixel is ever left uninitialized. It also allows to simplify the shadow drawing operation a bit. M +41 -28 ui/pageview.cpp https://invent.kde.org/kde/okular/commit/dec6923c56a99dc7bdf59c890c0ee310fb12fc23 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 383943] HiDPI: Rendering glitches near the page boundaries
https://bugs.kde.org/show_bug.cgi?id=383943 Oliver Sander changed: What|Removed |Added Latest Commit|https://cgit.kde.org/okular |https://invent.kde.org/kde/ |.git/commit/?id=ecc1141e029 |okular/commit/c73de7e6a1937 |3e1a30e0f8787d86dcc6309ffb0 |05de2ae06772d799eadfec9842f |c0 | --- Comment #3 from Oliver Sander --- Git commit c73de7e6a193705de2ae06772d799eadfec9842f by Oliver Sander. Committed on 01/07/2019 at 12:09. Pushed by sander into branch 'fix-bug-383943-hidpi-glitches'. Make page boundary rendering more robust Okular renders a simple 'shadow' at the right and the bottom of each page. The code for this is a bit fragile: After the page is rendered, Okular paints a black outline, and then the shadow. The shadow is a hand-implemented gradient, painted line by line. Finally, the remaining area is painted in the background color. No pixel is ever touched twice. Unfortunately, the code is buggy, and in hidpi / fractional scaling situations, some pixels are never touched. This results in rendering glitches as reported in https://bugs.kde.org/show_bug.cgi?id=383943 Instead of trying to fix the previous approach, this patch makes the code more robust by changing the order of the painting operations. After painting the page, the code now first paints the background, which is now enlarged to cover everything off the page. Finally, the black outline and shadow are drawn on the previously drawn background. This makes sures that no pixel is ever left uninitialized. It also allows to simplify the shadow drawing operation a bit. M +41 -28 ui/pageview.cpp https://invent.kde.org/kde/okular/commit/c73de7e6a193705de2ae06772d799eadfec9842f -- You are receiving this mail because: You are the assignee for the bug.
