D22259: Reduce default sidebar icon size

[Noah Davis]

ndavis added a comment.


  I like the idea of having a thinner sidebar, but I don't like the idea of 
having unlabeled views by default. I think hiding labels would hurt usability 
for first time users.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22259

To: stevenv, #okular, #vdg
Cc: ndavis, okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

D22259: Reduce default sidebar icon size

[Steven vanZyl]

stevenv created this revision.
stevenv added reviewers: Okular, VDG.
stevenv added a project: Okular.
stevenv requested review of this revision.

REVISION SUMMARY
  This patch reduces the default size of the sidebar icons from 48px "Large" to 
32px "Normal" and hides the text underneath the icons by default.
  
  This is a minor code change but makes a noticeable visual difference, looking 
cleaner and taking up considerably less space.
  
  Before changes F6964356: before.png 
  
  After changes F6964360: after.png 

TEST PLAN
  None

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22259

AFFECTED FILES
  conf/okular.kcfg

To: stevenv, #okular, #vdg
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, tfella, ngraham, 
darcyshen, aacid

Re: How to select a sidebar item when the sidebar is collapsed in autotests/parttest

[Albert Astals Cid]

El dimarts, 2 de juliol de 2019, a les 21:50:53 CEST, Mayank Choudhary va 
escriure:
> I tried  QTest::mouseMove() & QPoint() method but the cursor moves out of
> the okular instead of the sidebar. Does part.m_sidebar is the right
> candidate for selecting the sidebar?

Maybe you can push your code to a clone in invent.kde.org so we can see it?

It's hard to figure out what is wrong with code when the description is so 
vague.

Cheers,
  Albert

> 
> On Tue, 2 Jul 2019, 4:30 am Albert Astals Cid,  wrote:
> 
> > El dimarts, 2 de juliol de 2019, a les 0:52:42 CEST, Mayank Choudhary va
> > escriure:
> > > Hello,
> > >
> > > I'm writing an autotest in parttest.cpp where initially when the part is
> > > opened, the sidebar is collapsed. Now I need to click on thumbnails item
> > > (say) in order to open it. How can I?
> >
> > What would the user do? Click on it, right? So the test should ideally do
> > the same by using QTest::mouseClick
> >
> > Cheers,
> >   Albert
> >
> >
> >
> 

[okular] [Bug 409462] Crash when right-clicking on an active button

[David]

https://bugs.kde.org/show_bug.cgi?id=409462

--- Comment #4 from David  ---
Ah, yes, okularpart.

The backtrace is with the released version, but after reporting, I built it and
installed in ~/.local. But yes, I was loading the okularpart from the system.
Fixing the paths, it works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409462] Crash when right-clicking on an active button

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=409462

--- Comment #3 from Albert Astals Cid  ---
No, it does not crash with master

Did you build master yourself?

Did you install to /usr? (hope you didn't)

Because your backtrace says you're using /usr/lib64/qt5/plugins/okularpart.so

So if you did build yourself, you're not running the thing you built. Read the
bottom of https://okular.kde.org/download.php

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409462] Crash when right-clicking on an active button

[David]

https://bugs.kde.org/show_bug.cgi?id=409462

--- Comment #2 from David  ---
It may not be a duplicate.

That bug is marked as resolved, but this crash keeps happening on a freshly
built version from master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409455] Request: Make signature notification more unobtrusive

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=409455

Albert Astals Cid  changed:

   What|Removed |Added

   Severity|normal  |wishlist
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408849] okular crashes scrolling through certain pdf

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=408849

Albert Astals Cid  changed:

   What|Removed |Added

 CC||davidmen...@gmail.com

--- Comment #7 from Albert Astals Cid  ---
*** Bug 409462 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409462] Crash when right-clicking on an active button

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=409462

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 408849 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 409462] New: Crash when right-clicking on an active button

[David]

https://bugs.kde.org/show_bug.cgi?id=409462

Bug ID: 409462
   Summary: Crash when right-clicking on an active button
   Product: okular
   Version: 1.6.2
  Platform: Fedora RPMs
OS: Linux
Status: REPORTED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: davidmen...@gmail.com
  Target Milestone: ---

Application: okular (1.6.2)

Qt Version: 5.11.3
Frameworks Version: 5.58.0
Operating System: Linux 5.1.11-200.fc29.x86_64 x86_64
Distribution: "Fedora release 29 (Twenty Nine)"

-- Information about the crash:
- What I was doing when the application crashed:

Right click on the enable/disable buttons on the margin note in page 4 of this
document triggers the crash:
http://ctan.uib.no/macros/latex2e/contrib/microtype/microtype.pdf

The crash can be reproduced every time.

-- Backtrace:
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/usr/lib64/libthread_db.so.1".
[Current thread is 1 (Thread 0x7febb2e4e940 (LWP 14041))]

Thread 3 (Thread 0x7feba4ce0700 (LWP 14043)):
#0  0x7febb5fc0fe4 in read () at /usr/lib64/libc.so.6
#1  0x7febb3506e90 in  () at /usr/lib64/libglib-2.0.so.0
#2  0x7febb34bfe9b in g_main_context_check () at
/usr/lib64/libglib-2.0.so.0
#3  0x7febb34c0350 in  () at /usr/lib64/libglib-2.0.so.0
#4  0x7febb34c04d0 in g_main_context_iteration () at
/usr/lib64/libglib-2.0.so.0
#5  0x7febb667485b in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib64/libQt5Core.so.5
#6  0x7febb66233db in
QEventLoop::exec(QFlags) () at
/usr/lib64/libQt5Core.so.5
#7  0x7febb648ad36 in QThread::exec() () at /usr/lib64/libQt5Core.so.5
#8  0x7febb68caf89 in  () at /usr/lib64/libQt5DBus.so.5
#9  0x7febb649419b in  () at /usr/lib64/libQt5Core.so.5
#10 0x7febb5cc658e in start_thread () at /usr/lib64/libpthread.so.0
#11 0x7febb5fd0713 in clone () at /usr/lib64/libc.so.6

Thread 2 (Thread 0x7feba5b87700 (LWP 14042)):
#0  0x7febb5fc5481 in poll () at /usr/lib64/libc.so.6
#1  0x7febb570b39f in poll (__timeout=-1, __nfds=1, __fds=0x7feba5b86b78)
at /usr/include/bits/poll2.h:46
#2  0x7febb570b39f in _xcb_conn_wait (c=c@entry=0x55de8241b520,
cond=cond@entry=0x55de8241b560, vector=vector@entry=0x0, count=count@entry=0x0)
at xcb_conn.c:479
#3  0x7febb570d01a in xcb_wait_for_event (c=0x55de8241b520) at xcb_in.c:697
#4  0x7feba5d13459 in  () at /usr/lib64/libQt5XcbQpa.so.5
#5  0x7febb649419b in  () at /usr/lib64/libQt5Core.so.5
#6  0x7febb5cc658e in start_thread () at /usr/lib64/libpthread.so.0
#7  0x7febb5fd0713 in clone () at /usr/lib64/libc.so.6

Thread 1 (Thread 0x7febb2e4e940 (LWP 14041)):
[KCrash Handler]
#6  0x7feba44088e2 in  () at /usr/lib64/qt5/plugins/okularpart.so
#7  0x7feba441bb89 in  () at /usr/lib64/qt5/plugins/okularpart.so
#8  0x7febb6ff3108 in QWidget::event(QEvent*) () at
/usr/lib64/libQt5Widgets.so.5
#9  0x7febb7097b02 in QFrame::event(QEvent*) () at
/usr/lib64/libQt5Widgets.so.5
#10 0x7feba441c769 in  () at /usr/lib64/qt5/plugins/okularpart.so
#11 0x7febb66242de in
QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () at
/usr/lib64/libQt5Core.so.5
#12 0x7febb6fb4295 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /usr/lib64/libQt5Widgets.so.5
#13 0x7febb6fbba48 in QApplication::notify(QObject*, QEvent*) () at
/usr/lib64/libQt5Widgets.so.5
#14 0x7febb6624496 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() at /usr/lib64/libQt5Core.so.5
#15 0x7febb6fbad7d in QApplicationPrivate::sendMouseEvent(QWidget*,
QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer&, bool) () at
/usr/lib64/libQt5Widgets.so.5
#16 0x7febb700df68 in  () at /usr/lib64/libQt5Widgets.so.5
#17 0x7febb7010b0e in  () at /usr/lib64/libQt5Widgets.so.5
#18 0x7febb6fb42a5 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /usr/lib64/libQt5Widgets.so.5
#19 0x7febb6fbb800 in QApplication::notify(QObject*, QEvent*) () at
/usr/lib64/libQt5Widgets.so.5
#20 0x7febb6624496 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() at /usr/lib64/libQt5Core.so.5
#21 0x7febb6a60853 in
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
() at /usr/lib64/libQt5Gui.so.5
#22 0x7febb6a62725 in
QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*)
() at /usr/lib64/libQt5Gui.so.5
#23 0x7febb6a3dadb in
QWindowSystemInterface::sendWindowSystemEvents(QFlags)
() at /usr/lib64/libQt5Gui.so.5
#24 0x7feba5daa3ff in  () at /usr/lib64/libQt5XcbQpa.so.5
#25 0x7febb66233db in
QEventLoop::exec(QFlags) () at
/usr/lib64/libQt5Core.so.5
#26 0x7febb662b386 in QCoreApplication::exec() () at
/usr/lib64/libQt5Core.so.5
#27 0x55de813c2b75 in  ()
#28 0x000

[okular] [Bug 409455] New: Request: Make signature notification more unobtrusive

[Angelos Skembris]

https://bugs.kde.org/show_bug.cgi?id=409455

Bug ID: 409455
   Summary: Request: Make signature notification more unobtrusive
   Product: okular
   Version: 1.7.2
  Platform: openSUSE RPMs
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: a.skemb...@gmail.com
  Target Milestone: ---

SUMMARY

Every time I open a digitally signed document the "This document is digitally
signed" notification appears. There are a couple of problems with this
notification. 

First, it takes up too much space and obscures the viewable area. 

Second, I need an extra click to close it, which is a bit annoying if your
workflow involves opening signed documents frequently. 

Some suggestions to resolve this would be:

1) Make the notification more discreet. Currently, it takes up two lines, one
for the notification text and another for the "show signatures panel" and close
button. If possible, these should be on the same line so that the notification
does not take up so much screen space. 

2) Perhaps it could also be configured so that it only takes as much screen
space as necessary. Currently, you have the text on one side and the buttons on
the other, and everything in-between is just empty space that is lost, as it
covers the main view panel. Perhaps both elements (text and buttons) could be
aligned (left or right) so that the rest of the space is not covered?

3) The notification could be automatically dismissed after a few seconds by
fading out.

4) The notification panel could be replaced by a lock icon presented, for
example, on the page bar. Hovering over the icon could present the "This
document is digitally signed text" and clicking could toggle (activate and
dismiss) the signatures panel. 

STEPS TO REPRODUCE
1. Open a digitally signed document

OBSERVED RESULT
The signature notification appears and stays there until dismissed, obscuring
the main view port.

EXPECTED RESULT
The signature notification should be more unobtrusive and easily dismissed. 



SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)

KDE Frameworks 5.59.0
Qt 5.12.3 (built against 5.12.3)
The xcb windowing system

-- 
You are receiving this mail because:
You are the assignee for the bug.