[okular] [Bug 422050] Scrolling issues with PageDown/PageUp navigation

2020-08-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=422050

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #8 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/okular/-/merge_requests/238

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421780] Most ways of scrolling a document not working (Qt 5.15)

2020-08-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421780

Nate Graham  changed:

   What|Removed |Added

Summary|Most ways of navigating a   |Most ways of scrolling a
   |document not working (Qt|document not working (Qt
   |5.15)   |5.15)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421780] Most ways of navigating a document not working (Qt 5.15)

2020-08-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=421780

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #8 from Nate Graham  ---
As much as I like the smooth animated scrolling in principle, I think we need
to revert those commits and focus on another approach. They just caused too
many regressions. :/

Albert, I'd be in favor of doing this for the 20.12 release. What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425148] New: okular import of old embedded annotations does not import the original create/modify time stamp

2020-08-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=425148

Bug ID: 425148
   Summary: okular import of old embedded annotations does not
import the original create/modify time stamp
   Product: okular
   Version: unspecified
  Platform: Ubuntu Packages
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: jpror...@gmail.com
  Target Milestone: ---

SUMMARY

Observed with okular versions since 1.3.3 on Ubuntu 18.04.  When opening a PDF
with annotations using the old "internal format" storage the user is prompted
to save the annotations to the PDF file.


"This document contains annotations or form data that were saved internally by
a previous Okular version. Internal storage is no longer supported.
Please save to a file in order to move them if you want to continue to edit the
document."

When saving the annotations, the original create and modify time stamps are
lost and replaced with the current datetime.

STEPS TO REPRODUCE
1. use current version of okular to open a PDF with annotations stored in the
original internal storage (eg. okular xml file for pdf in 
~/.kde/share/apps/okular/docdata/)
2. the need to migrate is detected
3. saving the file to a new PDF preserves the original annotation.
4. the create and modify time stamps of from the original annotation are lost
and replaced with the current date.

OBSERVED RESULT

The original time stamps for create and modify of an annotation are lost on
import to the PDF and replaced with the current date.

EXPECTED RESULT

The original time stamps for create and modify of an annotation are should be
preserved and imported to the PDF.


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Ubuntu 18.04 is test system but any version of okular seems
to behave this way.
(available in About System)
KDE Plasma Version:  
KDE Frameworks Version:  5.44.0 and above
Qt Version: 5.9.5 (built against 5.9.5) and above

ADDITIONAL INFORMATION

This appears to be part of how the annotations are imported.  The annotation is
properly reconstructed from the original annotation but the metadata on the
annotation is not migrated to the new annotation format.

The migration logic seems to begin here: 

https://github.com/KDE/okular/blob/master/core/document.cpp#L1192

This appears to reach the code where the local data is converted to new
annotation format.

https://github.com/KDE/okular/blob/master/core/page.cpp#L811

The newly instantiated annotations don't appear to have their time stamps
explicitly set from the original so the new instance timestamps are the ones
that get saved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424779] Embedded links not recognised in PDF file

2020-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=424779

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #3 from Albert Astals Cid  ---
It's a poppler bug
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/606

Will be fixed with poppler 20.09.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424817] Ugly rendering of images containing text in PDF files

2020-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=424817

--- Comment #20 from Albert Astals Cid  ---
(In reply to Jan Rathmann from comment #17)
> (In reply to Albert Astals Cid from comment #16)
> > (In reply to Jan Rathmann from comment #14)
> > > would it be possible that this is somehow a bug in Qt and not in poppler?
> > 
> > No, please stop pretending you understand how things work better than me,
> > the poppler maintainer
> 
> I didn't know that you are the poppler maintainer...
> 
> My intention was to do as much testing myself and to provide as much
> information as possible to help to narrow the circumstances where the bug
> appears -  I thought this would be helpful and "good practice".ç

It is, apologies for my rudeness.

> I honestly
> didn't want to pretend that I know something better than anyone else -
> especially since actually I don't have much clue I think.
> 
> I'm a bit unsure, should I still report the bug to poppler? I don't want to
> make any further mistake...

Yes please, do a report.

> 
> @Christoph
> Yeah, I saw that in qdfview and I also tried "Arthur", but the rendering was
> even worse with it...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424817] Ugly rendering of images containing text in PDF files

2020-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=424817

--- Comment #19 from Albert Astals Cid  ---
(In reply to David Hurka from comment #18)
> I don’t think there is any bug, but just that Poppler uses the available
> algorithms in e. g. the Qt painting framework, instead of complicated
> cutting-edge alternatives which *might* perform *slightly* better.

Poppler is not using any Qt painting framework in this case.

Anyway agreed, it's not a bug, but it's something that may need improving.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424817] Ugly rendering of images containing text in PDF files

2020-08-08 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=424817

--- Comment #18 from David Hurka  ---
I don’t think there is any bug, but just that Poppler uses the available
algorithms in e. g. the Qt painting framework, instead of complicated
cutting-edge alternatives which *might* perform *slightly* better.

https://bugs.kde.org/show_bug.cgi?id=408222#c20 and the following comments
contain some explanations and evaluations of some possible “fixes”.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425075] Internal annotations (i. e. not in PDF) are painted in multiply mode, so they look transparent even when “100% opacity” is configured.

2020-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=425075

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/okular/commit/389c7b02 |hics/okular/commit/3a331b78
   |35fe762cda799ad4ce8bfbe710b |2e14ffe0c24ffd324899312e273
   |ef210   |06790

--- Comment #9 from Albert Astals Cid  ---
Git commit 3a331b782e14ffe0c24ffd324899312e27306790 by Albert Astals Cid.
Committed on 07/08/2020 at 22:32.
Pushed by aacid into branch 'master'.

PagePainter: Don't draw Arrow/Line annotations with multipyl

Otherwise they will be transparent when they shouldn't

M  +9-9ui/pagepainter.cpp
M  +1-1ui/pagepainter.h

https://invent.kde.org/graphics/okular/commit/3a331b782e14ffe0c24ffd324899312e27306790

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424340] PDF bookmarks not found when opening document by symbolic link

2020-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=424340

Albert Astals Cid  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/caa351c7
   ||23c906cb2f675e298a17427928b
   ||7abd3
 Resolution|--- |FIXED

--- Comment #2 from Albert Astals Cid  ---
Git commit caa351c723c906cb2f675e298a17427928b7abd3 by Albert Astals Cid.
Committed on 07/08/2020 at 22:34.
Pushed by aacid into branch 'master'.

Bookmarks: Resolve symlinks before using an url

If a symlink points to another file, we should use that file as
canonical source for bookmarks, it doesn't make sense to have two
different sets of bookmarks for two paths that are essentially the same
file

M  +34   -14   core/bookmarkmanager.cpp
M  +14   -14   core/bookmarkmanager.h

https://invent.kde.org/graphics/okular/commit/caa351c723c906cb2f675e298a17427928b7abd3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424817] Ugly rendering of images containing text in PDF files

2020-08-08 Thread Jan Rathmann
https://bugs.kde.org/show_bug.cgi?id=424817

--- Comment #17 from Jan Rathmann  ---
(In reply to Albert Astals Cid from comment #16)
> (In reply to Jan Rathmann from comment #14)
> > would it be possible that this is somehow a bug in Qt and not in poppler?
> 
> No, please stop pretending you understand how things work better than me,
> the poppler maintainer

I didn't know that you are the poppler maintainer...

My intention was to do as much testing myself and to provide as much
information as possible to help to narrow the circumstances where the bug
appears -  I thought this would be helpful and "good practice". I honestly
didn't want to pretend that I know something better than anyone else -
especially since actually I don't have much clue I think.

I'm a bit unsure, should I still report the bug to poppler? I don't want to
make any further mistake...

@Christoph
Yeah, I saw that in qdfview and I also tried "Arthur", but the rendering was
even worse with it...

-- 
You are receiving this mail because:
You are the assignee for the bug.