[okular] [Bug 398553] Upper/lower dark border of search result highlight not drawn sometimes

2020-11-26 Thread Simone Gaiarin
https://bugs.kde.org/show_bug.cgi?id=398553

Simone Gaiarin  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #4 from Simone Gaiarin  ---
Still happening.

To reproduce it more easily, zoom in the page.

Relevant discussion:
https://phabricator.kde.org/D7662

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398553] Upper/lower dark border of search result highlight not drawn sometimes

2020-11-26 Thread Simone Gaiarin
https://bugs.kde.org/show_bug.cgi?id=398553

--- Comment #3 from Simone Gaiarin  ---
Created attachment 133680
  --> https://bugs.kde.org/attachment.cgi?id=133680&action=edit
invisible search highlight border

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

2020-11-26 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #11 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 339807] Save in FTP Folder reports existing File although there isn't

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=339807

Justin Zobel  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||justin.zo...@gmail.com
Version|0.20.0  |20.11.80

--- Comment #4 from Justin Zobel  ---
(In reply to Albert Astals Cid from comment #1)
> I'm pretty sure that this is a KIO problem, i've talked with David before
> about this and he said that it happens because the ftp ioslave defaults to
> "yes a file exists" when asked if it does because some servers are just
> plain stupid.
> 
> I'm CC'ing him in case we do something wrong.
> 
> David, what we do is just
> KUrl saveUrl = KFileDialog::getSaveUrl( KUrl("kfiledialog:///okular/" +
> url().fileName()),
> QString(), widget(), QString(),
> KFileDialog::ConfirmOverwrite )
> 
> and then
> 
> KIO::file_copy( srcUrl, saveUrl, -1, KIO::Overwrite );

This is still occurring in git master of okular, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 398553] Upper/lower dark border of search result highlight not drawn sometimes

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=398553

Justin Zobel  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Justin Zobel  ---
Thanks for the report Simone, I've just tested this and I'm unable to reproduce
this issue.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Applications » okular » kf5-qt5 FreeBSDQt5.15 - Build # 147 - Fixed!

2020-11-26 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20FreeBSDQt5.15/147/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 26 Nov 2020 23:28:52 +
 Build duration:
4 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)Name: projectroot.generators Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

[okular] [Bug 426976] Okular mangles url fragment if the it contains a '.'

2020-11-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=426976

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/239827ba
   ||ad0301d578a861be55d5711d82c
   ||c2048
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Albert Astals Cid  ---
Git commit 239827baad0301d578a861be55d5711d82cc2048 by Albert Astals Cid.
Committed on 26/11/2020 at 10:07.
Pushed by aacid into branch 'release/20.12'.

Rework how we open urls that have a #

Previously if it was a remote url that had # and a . after the # we
assumed the url had no fragment and everything was filename.

We don't do that anymore, what we do now is try to open the url as
parsed, i.e. before the # is the filename after is the fragment, and if
that fails we try to open everything as filename and nothing as
fragment.

Unfortunately given how kpart internals handle opening local vs remote
urls we need to do this in two places.

Also we have to remove the test that checked that the url was mangled at
the shell level because we don't do that anymore. Unfortunately can't
add a test for the new codepage since it would involve starting an http
server ^_^

Filenames:
  source2e.pdf
  foo#bar.pdf

What works:
 * okular http://localhost/source2e.pdf#subsection.68.3
 * okular file:///srv/http/source2e.pdf#subsection.68.3
 * okular source2e.pdf#subsection.68.3 (in the /srv/http folder)
 * okular source2e.pdf#2
 * okular http://localhost/foo#bar.pdf
 * okular file:///srv/http/foo#bar.pdf
 * okular foo#bar.pdf (in the /srv/http folder)

What doesn't work:
 * okular http://localhost/foo#bar.pdf#2

I think it's a fair limitation that if you want to open a file that contains #
in the name and also use a # page marker you need to use the encoded url like
okular http://localhost/foo%23bar.pdf#2
after all things like firefox will totally fail opening
http://localhost/foo#bar.pdf and will just work if you give the encoded url

M  +0-6autotests/shelltest.cpp
M  +22   -5part/part.cpp
M  +6-0part/part.h
M  +0-7shell/shellutils.cpp

https://invent.kde.org/graphics/okular/commit/239827baad0301d578a861be55d5711d82cc2048

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426782] annotation tooltips don't appear if the "keep annotation tool active after use" action is checked

2020-11-26 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=426782

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/023976cc
   ||fdd79812180c85dad8ee7e3b6ac
   ||7aef9
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Albert Astals Cid  ---
Git commit 023976ccfdd79812180c85dad8ee7e3b6ac7aef9 by Albert Astals Cid.
Committed on 26/11/2020 at 09:12.
Pushed by aacid into branch 'release/20.12'.

Show annotation tip when selecting the tool in continuous mode

M  +1-1part/annotationactionhandler.cpp
M  +45   -43   part/pageviewannotator.cpp
M  +2-1part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/023976ccfdd79812180c85dad8ee7e3b6ac7aef9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 305915] Submit button not displayed in PDF form opened in Okular

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=305915

Justin Zobel  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #18 from Justin Zobel  ---
The Submit Form button is showing for me in Okular 21.03.70.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377625] Moving annotations causes their border color, shape and features to change

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=377625

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
Version|1.0.0   |unspecified

--- Comment #2 from Justin Zobel  ---
Issue 1 with border changing colour appears resolved since. I can move and it
stays red.

Issue 2 is still present, after moving the annotation it is no longer visible
in Firefox.

Tested with 21.03.70 (git master).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2020-11-26 Thread Evert Heylen
https://bugs.kde.org/show_bug.cgi?id=205496

--- Comment #29 from Evert Heylen  ---
I sadly no longer have access to a machine running KDE and/or Okular. As this
is a bit of non-response, I'm not sure what to mark this as. Maybe someone else
still has it running?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 360046] Okular crashes when opening PDF

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=360046

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Justin Zobel  ---
Thanks for the report Uzair. I've tested this and am unable to reproduce the
issue.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 320723] No way to go back when following an embedded link in a pdf file.

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=320723

Justin Zobel  changed:

   What|Removed |Added

Version|0.16.2  |unspecified
 CC||justin.zo...@gmail.com

--- Comment #8 from Justin Zobel  ---
Confirmed still an issue in 21.03.70.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 359722] Page size "Custom" is set to zero and can not be adjusted

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=359722

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Justin Zobel  ---
I've just tested this and am able to set custom sizes and the preview adjusts
accordingly.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 205496] Okular's "Advance to the next page" jumps to middle of next page

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=205496

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #28 from Justin Zobel  ---
I've just tested to see if I can reproduce this with okular but I am unable to.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 355172] Crash if I quit Okular when the properties dialog is being displayed

2020-11-26 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=355172

Justin Zobel  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #3 from Justin Zobel  ---
I've just tested this and I can't quit okular while print or properties dialogs
are open.

Can you please test and confirm if this issue is still occurring or if this bug
report can be marked as resolved. I've set the bug status to "needsinfo"
pending your response, please change back to "reported" or "resolved" when you
respond, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.