[okular] [Bug 451113] New: Add Shortcut CRTL-W for closing tabs

2022-03-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=451113

Bug ID: 451113
   Summary: Add Shortcut CRTL-W for closing tabs
   Product: okular
   Version: 21.12.2
  Platform: Neon Packages
OS: Linux
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: m.w...@web.de
  Target Milestone: ---

In browsers and Dolphin there is CRTL-W for closing the current tab. In Okular
this short cut does not exist. I think it makes sense to make it work here too.
There may be other tab handling short cuts which I do not know, but make sense
to implement here too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Do we want to force braces even for 1 line if/for/etc?

2022-03-03 Thread Albert Astals Cid
El divendres, 6 de novembre de 2020, a les 0:27:05 (CET), Albert Astals Cid va 
escriure:
> El divendres, 11 de setembre de 2020, a les 22:00:30 CET, Albert Astals Cid 
> va escriure:
> > El divendres, 21 d’agost de 2020, a les 1:19:19 CEST, Albert Astals Cid va 
> > escriure:
> > > Most of the guidelines suggest it so that you don't forget to add them 
> > > when adding a new line in the "block".
> > > 
> > > What do you think?
> > > 
> > > https://invent.kde.org/graphics/okular/-/merge_requests/248
> > > 
> > > We're going to need quite some changes to make it pass, so asking before 
> > > starting to do the work :D
> > 
> > We agreed on the Akademy Okular meeting that we will do this, *but* I'm 
> > going to postpone doing it after the 20.08.3 release.
> > 
> > Rationale:
> >  * Making this change even if mechanical (clang-tidy does it) can cause 
> > potential regressions if something goes wrong, hence is something that 
> > needs to be applied in master only
> >  * If we apply it to master now, merging up from release/20.08 to master 
> > can cause master CI to stop compiling since it'd be requiring more things 
> > than release/20.08 CI
> 
> Going to postpone this because it seems not clang-tidy 10 nor 11 nor 12 are 
> able to format Okular codebase correctly with 
> readability-braces-around-statements

clang-tidy-13 seems to have succeeded.

What do you say, should we give it a go?

https://invent.kde.org/graphics/okular/-/merge_requests/578

Cheers,
  Albert

> 
> Cheers,
>   Albert
> 
> > 
> > Cheers,
> >   Albert
> > 
> > > 
> > > Cheers,
> > >   Albert
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 
> 






[okular] [Bug 451101] New: annotation tool resets to pin location while typing from a different location

2022-03-03 Thread johnathan
https://bugs.kde.org/show_bug.cgi?id=451101

Bug ID: 451101
   Summary: annotation tool resets to pin location while typing
from a different location
   Product: okular
   Version: 21.12.2
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: testing1237...@yahoo.com
  Target Milestone: ---

Created attachment 147265
  --> https://bugs.kde.org/attachment.cgi?id=147265=edit
screen recording showing the bug

SUMMARY
***
when i initiate a popup note, i can start writing but if i move the screen from
that position to anywhere else, as soon as i type anything, the position is
reset to point of pin


STEPS TO REPRODUCE
1.  open pdf, any
2. open popup note
3.  write something
4. move cursor to second page or anywhere else
5. start writing again

OBSERVED RESULT
 when i move the screen to anywhere other than where i dropped the pin and
start writing, the page view resets to that place always

EXPECTED RESULT
the page should stay as is and allow user to type whatever from anywhere
without forcing user to stay on the point of pin.

SOFTWARE/OS VERSIONS
Operating System: KDE neon 5.24
KDE Plasma Version: 5.24.1
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.3
Kernel Version: 5.13.0-30-generic (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i7-4600U CPU @ 2.10GHz
Memory: 7.7 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4400

-- 
You are receiving this mail because:
You are the assignee for the bug.