[okular] [Bug 468332] New: Change the highlight shape from oval with rounded edges to rectangular with straight edges

2023-04-09 Thread I-G-1-1
https://bugs.kde.org/show_bug.cgi?id=468332

Bug ID: 468332
   Summary: Change the highlight shape from oval with rounded
edges to rectangular with straight edges
Classification: Applications
   Product: okular
   Version: 22.12.1
  Platform: Microsoft Windows
OS: Microsoft Windows
Status: REPORTED
  Severity: wishlist
  Priority: NOR
 Component: PDF backend
  Assignee: okular-devel@kde.org
  Reporter: k6948732...@outlook.com
  Target Milestone: ---

Created attachment 157977
  --> https://bugs.kde.org/attachment.cgi?id=157977=edit
Observed and Expected Result

STEPS TO REPRODUCE
1. Open a PDF with annotations and highlights

OBSERVED RESULT
The highlights are rendered as oval shape with rounded edges. 
It's very confusing when studying if there are highlights of different color
side by side.

EXPECTED RESULT
The highlights are rendered as rectangular with straight edges. See attachment

SOFTWARE/OS VERSIONS
Windows: Windows10

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468317] Duplicated 'show sidebar' action

2023-04-09 Thread popov895
https://bugs.kde.org/show_bug.cgi?id=468317

popov895  changed:

   What|Removed |Added

 CC||popov...@ukr.net
   Assignee|okular-devel@kde.org|popov...@ukr.net

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468037] Form: 2 of the tick boxes don't work (UK IHT 400)

2023-04-09 Thread Dave Gilbert
https://bugs.kde.org/show_bug.cgi?id=468037

--- Comment #3 from Dave Gilbert  ---
Yeh, not too sure what's going on here.  44 and 45 look like all the others to
me in the raw PDF - although I can't say I fully understand the syntax yet; 
they both have an '/Off' and '/Yes' in the /N and /D sections.
48a and 48b (objects 2416/2417) both do it differently with the buttons in
children, and have 4 children, two 'No/Off' pairs and two 'Off/Yes' pairs -
which doesn't make any sense to me since they only seem to have tow buttons
each.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468037] Form: 2 of the tick boxes don't work (UK IHT 400)

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468037

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #2 from Albert Astals Cid  ---
Given that this is what Adobe Reader does too, it's either a form bug or how it
has to behave.

Closing the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468198] Missing XOR symbol in pdf document

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468198

Albert Astals Cid  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468192] Inserted text does not appear.

2023-04-09 Thread PILIER
https://bugs.kde.org/show_bug.cgi?id=468192

--- Comment #2 from PILIER  ---
Created attachment 157973
  --> https://bugs.kde.org/attachment.cgi?id=157973=edit
The asked PDF-file...

In attach a PDF with the amount of 180,00 € which does not appear.
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468036] Form: NaN in form total (UK IHT 411)

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468036

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/okular/commit/24a9d097 |hics/okular/commit/a747625c
   |d7be00128d4d65903f5c013730b |79dbebb3e0fbf6cc44143f4f26b
   |e1c2c   |82371

--- Comment #6 from Albert Astals Cid  ---
Git commit a747625c79dbebb3e0fbf6cc44143f4f26b82371 by Albert Astals Cid, on
behalf of Dr. David Alan Gilbert.
Committed on 09/04/2023 at 09:38.
Pushed by aacid into branch 'release/23.04'.

JS: Implement field.valueAsString

Adobe's docs say:
  For example, for a field with a value of “020”, value returns the integer 20,
   while valueAsString returns the string “020”.

Share most of the fieldGetValue code by splitting it out into a 'Core'
variant and then using it in both GetValue and GetValueAsString.
(cherry picked from commit 24a9d097d7be00128d4d65903f5c013730be1c2c)

M  +16   -4core/script/kjs_field.cpp

https://invent.kde.org/graphics/okular/commit/a747625c79dbebb3e0fbf6cc44143f4f26b82371

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468036] Form: NaN in form total (UK IHT 411)

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468036

Albert Astals Cid  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/24a9d097
   ||d7be00128d4d65903f5c013730b
   ||e1c2c

--- Comment #5 from Albert Astals Cid  ---
Git commit 24a9d097d7be00128d4d65903f5c013730be1c2c by Albert Astals Cid, on
behalf of Dr. David Alan Gilbert.
Committed on 09/04/2023 at 09:21.
Pushed by aacid into branch 'master'.

JS: Implement field.valueAsString

Adobe's docs say:
  For example, for a field with a value of “020”, value returns the integer 20,
   while valueAsString returns the string “020”.

Share most of the fieldGetValue code by splitting it out into a 'Core'
variant and then using it in both GetValue and GetValueAsString.

M  +16   -4core/script/kjs_field.cpp

https://invent.kde.org/graphics/okular/commit/24a9d097d7be00128d4d65903f5c013730be1c2c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468317] Duplicated 'show sidebar' action

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468317

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 460759] PDF form crash (PDF was created on Windows)

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=460759

--- Comment #6 from Albert Astals Cid  ---
(In reply to kde from comment #5)
> Created attachment 157956 [details]
> New crash information added by DrKonqi
> 
> okular (22.12.3) using Qt 5.15.8
> 
> Activating "Show forms". The starting to type in a form.
> 
> -- Backtrace (Reduced):
> #4  0x7fb72655a760 in GfxResources::doLookupFont(char const*) const ()
> from /usr/lib/libpoppler.so.126
> #5  0x7fb72655a832 in GfxResources::lookupFont(char const*) () from
> /usr/lib/libpoppler.so.126
> #6  0x7fb726555b9e in Form::ensureFontsForAllCharacters(GooString
> const*, std::__cxx11::basic_string,
> std::allocator > const&, GfxResources*) () from
> /usr/lib/libpoppler.so.126
> [...]
> #8  0x7fb72c2f357d in Poppler::FormFieldText::setText(QString const&) ()
> from /usr/lib/libpoppler-qt5.so.1
> [...]
> #10 0x7fb73d3034fa in QUndoStack::push(QUndoCommand*) () from
> /usr/lib/libQt5Widgets.so.5

Which PDF file does that happen with?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468192] Inserted text does not appear.

2023-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=468192

Albert Astals Cid  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Please attach the PDF file you think we're not rendering correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468317] New: Duplicated 'show sidebar' action

2023-04-09 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=468317

Bug ID: 468317
   Summary: Duplicated 'show sidebar' action
Classification: Applications
   Product: okular
   Version: 23.03.90
  Platform: Other
OS: Other
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: kishor...@gmail.com
  Target Milestone: ---

Created attachment 157971
  --> https://bugs.kde.org/attachment.cgi?id=157971=edit
Screenshot of the duplicated entries in the keyboard shortcuts dialog

SUMMARY
In 'Settings > Configure Keyboard Shortcuts', I see two items called 'show
sidebar', but only one of them works (the other one does not affect the sidebar
even when a keyboard shortcut is assigned to it).

Similarly, there are two 'show sidebar' actions in the list of available
toolbar buttons, only one of which works.

STEPS TO REPRODUCE
Part A (duplicated keyboard shortcut)
1. Settings > Configure Keyboard shortcuts
2. Search for 'sidebar'

Part B (duplicated toolbar entry)
1. Right-click on Okular toolbar > Configure toolbars
2. In 'main toolbar ', search for 'show sidebar'
3. In 'main toolbar ', search for 'show sidebar'
4. Place the 'show sidebar item in  onto the toolbar and save
changes
5. Try to find the new 'show sidebar' button on the toolbar

OBSERVED RESULT
Part A: Two items called 'show sidebar' (see attached screenshot), one of which
does nothing when a keyboard shortcut is assigned to it
Part B: Only the show sidebar item in okular_shell works, while the other one
shows no button even if placed on the toolbar.

EXPECTED RESULT
Only one 'show sidebar' item

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.10-arch1-1 (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
This is reproducible even in a fresh user account, so it does not seem to be an
issue of stale config files

Bug is reproducible on Arch Linux with Okular versions 23.08.80 and 23.08.90

Git bisect points to
2fbab13e1f439f0dd2c6758d51c80e86ee49392a is the first bad commit
commit 2fbab13e1f439f0dd2c6758d51c80e86ee49392a
Author: Eugene Popov 
Date:   Thu Dec 22 22:50:55 2022 +

Port sidebar to QDockWidget

With this MR, the sidebar can now be (if not locked):
* docked to the left or right side
* undocked and floated as an independent window
* closed with the close button in the header

BUG: 455013

 interfaces/viewerinterface.h |   7 ++
 part/part.cpp|   5 ++
 part/part.h  |   1 +
 part/sidebar.cpp |   5 ++
 part/sidebar.h   |   2 +
 shell/shell.cpp  | 162 ++-
 shell/shell.h|   6 +-
 shell/shell.rc   |   7 +-
 8 files changed, 192 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.