[Okular-devel] Review Request 122536: [okular] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122536/ --- Review request for Okular. Repository: okular Description --- [okular] Make tests optional Qt5Test dependency should not be mandatory, this patch makes it optional following the example set by kwin. Diffs - CMakeLists.txt b9bc1f4d557344a293907b3c02e4b0a5c1f01cb7 Diff: https://git.reviewboard.kde.org/r/122536/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 122536: [okular] Make tests optional
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122536/ --- (Updated mar. 16, 2015, 10:22 p.m.) Status -- This change has been discarded. Review request for Okular. Repository: okular Description --- [okular] Make tests optional Qt5Test dependency should not be mandatory, this patch makes it optional following the example set by kwin. Diffs - CMakeLists.txt b9bc1f4d557344a293907b3c02e4b0a5c1f01cb7 Diff: https://git.reviewboard.kde.org/r/122536/diff/ Testing --- Thanks, Andreas Sturmlechner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 127049: Port to FindPoppler from extra-cmake-modules
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127049/#review93236 --- Works for me, fwiw, tested with poppler-0.32.0 as well as poppler-0.41.0. - Andreas Sturmlechner On Feb. 14, 2016, 3:43 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127049/ > --- > > (Updated Feb. 14, 2016, 3:43 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > --- > > This changes cmake machinery to support FindPoppler which was recently added > to extra-cmake-modules. > > FindPoppler was added in extra-cmake-modules-5.19, so the dep needed to be > raised. > > > Diffs > - > > CMakeLists.txt b93c5f9 > cmake/modules/FindPoppler-Qt5.cmake 80a7862 > generators/CMakeLists.txt e2bd28e > generators/poppler/CMakeLists.txt 248825e > > Diff: https://git.reviewboard.kde.org/r/127049/diff/ > > > Testing > --- > > It builds. > > > Thanks, > > Armin K. > > ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Review Request 130099: Drop unused DBusAddons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130099/ --- Review request for Okular. Repository: okular Description --- Couldn't find use of it, builds fine without. Minor: Fix typo in generators/CMakeLists.txt Diffs - CMakeLists.txt e52b69be6b27c6113cfe95a7b47f151081cd1782 generators/CMakeLists.txt 56fc9bd63f9489e29066d2220c4ecbce1141f5fe Diff: https://git.reviewboard.kde.org/r/130099/diff/ Testing --- Thanks, Andreas Sturmlechner
Re: Review Request 130099: Drop unused DBusAddons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130099/ --- (Updated April 23, 2017, 12:10 a.m.) Status -- This change has been marked as submitted. Review request for Okular. Changes --- Submitted with commit decb01292e4b5579a53741d5412a797daa53c1d6 by Andreas Sturmlechner to branch Applications/17.04. Repository: okular Description --- Couldn't find use of it, builds fine without. Minor: Fix typo in generators/CMakeLists.txt Diffs - CMakeLists.txt e52b69be6b27c6113cfe95a7b47f151081cd1782 generators/CMakeLists.txt 56fc9bd63f9489e29066d2220c4ecbce1141f5fe Diff: https://git.reviewboard.kde.org/r/130099/diff/ Testing --- Thanks, Andreas Sturmlechner
D7212: Don't build kimgiotest unless BUILD_TESTING=ON
asturmlechner created this revision. Restricted Application added a project: Okular. REVISION SUMMARY In >=KF-5.37 target kimgiotest is only built if BUILD_TESTING=ON, so subsequent target_compile_definitions will fail if OFF. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D7212 AFFECTED FILES generators/kimgio/CMakeLists.txt To: asturmlechner, #okular Cc: kfunk, aacid
D7212: Don't build kimgiotest unless BUILD_TESTING=ON
asturmlechner added a comment. actually ECM git master/KF-5.38 that is, sorry. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7212 To: asturmlechner, #okular Cc: kfunk, aacid
D7212: Don't build kimgiotest unless BUILD_TESTING=ON
This revision was automatically updated to reflect the committed changes. Closed by commit R223:862fd4f3e1d0: Don't build kimgiotest unless BUILD_TESTING=ON (authored by asturmlechner). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7212?vs=17905&id=17910 REVISION DETAIL https://phabricator.kde.org/D7212 AFFECTED FILES generators/kimgio/CMakeLists.txt To: asturmlechner, #okular, kfunk Cc: kfunk, aacid
T11542: Remove KHTML
asturmlechner added a subtask: T13967: Port Kopete away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: asturmlechner Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, dfaure
T11542: Remove KHTML
asturmlechner added a subtask: T13968: Port KTechlab away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: asturmlechner Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, usta, asturmlechner, jucato, cfeck, cgiboudeaux, cullmann, vkrause, dfaure
[okular] [Bug 482443] okular - add build options for wayland (non X11) build options
https://bugs.kde.org/show_bug.cgi?id=482443 Andreas Sturmlechner changed: What|Removed |Added CC||ast...@gentoo.org --- Comment #2 from Andreas Sturmlechner --- Thanks for your report. Indeed invent.kde.org is the way to go and get proper review. I have submitted quite a few MRs upstream like yours, you can have a look in https://bugs.gentoo.org/813450 for inspiration. -- You are receiving this mail because: You are the assignee for the bug.
